July 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.4] Ignore mach_approximate_time when targeting macOS 10.9 and earlier
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 022b8f15da2b349aaffc5aab311bdd3e0a7fa199 Author: teor <teor(a)torproject.org> Date: Fri Jul 20 12:26:33 2018 +1000 Ignore mach_approximate_time when targeting macOS 10.9 and earlier Work around two different bugs in the OS X 10.10 and later SDKs that would prevent us from successfully targeting earlier versions of OS X. Fixes bug 26876; bugfix on 0.3.3.1-alpha. --- changes/bug26876 | 4 ++++ configure.ac | 32 +++++++++++++++++++++++++++++--- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/changes/bug26876 b/changes/bug26876 new file mode 100644 index 000000000..b66110423 --- /dev/null +++ b/changes/bug26876 @@ -0,0 +1,4 @@ + o Minor bugfixes (portability): + - Work around two different bugs in the OS X 10.10 and later SDKs that + would prevent us from successfully targeting earlier versions of OS X. + Fixes bug 26876; bugfix on 0.3.3.1-alpha. diff --git a/configure.ac b/configure.ac index 2fda2ef6f..ba58f9d74 100644 --- a/configure.ac +++ b/configure.ac @@ -548,7 +548,6 @@ AC_CHECK_FUNCS( llround \ localtime_r \ lround \ - mach_approximate_time \ memmem \ memset_s \ pipe \ @@ -574,9 +573,36 @@ AC_CHECK_FUNCS( _vscprintf ) -# Apple messed up when they added two functions functions in Sierra: they +# Apple messed up when they added some functions: they # forgot to decorate them with appropriate AVAILABLE_MAC_OS_VERSION -# checks. So we should only probe for those functions if we are sure that we +# checks. + +# We should only probe for these functions if we are sure that we +# are not targeting OS X 10.9 or earlier. +AC_MSG_CHECKING([for a pre-Yosemite OS X build target]) +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ +#ifdef __APPLE__ +# include <AvailabilityMacros.h> +# ifndef MAC_OS_X_VERSION_10_10 +# define MAC_OS_X_VERSION_10_10 101000 +# endif +# if defined(MAC_OS_X_VERSION_MIN_REQUIRED) +# if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_10 +# error "Running on Mac OS X 10.9 or earlier" +# endif +# endif +#endif +]], [[]])], + [on_macos_pre_10_10=no ; AC_MSG_RESULT([no])], + [on_macos_pre_10_10=yes; AC_MSG_RESULT([yes])]) + +if test "$on_macos_pre_10_10" = "no"; then + AC_CHECK_FUNCS( + mach_approximate_time \ + ) +fi + +# We should only probe for these functions if we are sure that we # are not targeting OSX 10.11 or earlier. AC_MSG_CHECKING([for a pre-Sierra OSX build target]) AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[

1 0

[tor/maint-0.3.3] Ignore mach_approximate_time when targeting macOS 10.9 and earlier
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 022b8f15da2b349aaffc5aab311bdd3e0a7fa199 Author: teor <teor(a)torproject.org> Date: Fri Jul 20 12:26:33 2018 +1000 Ignore mach_approximate_time when targeting macOS 10.9 and earlier Work around two different bugs in the OS X 10.10 and later SDKs that would prevent us from successfully targeting earlier versions of OS X. Fixes bug 26876; bugfix on 0.3.3.1-alpha. --- changes/bug26876 | 4 ++++ configure.ac | 32 +++++++++++++++++++++++++++++--- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/changes/bug26876 b/changes/bug26876 new file mode 100644 index 000000000..b66110423 --- /dev/null +++ b/changes/bug26876 @@ -0,0 +1,4 @@ + o Minor bugfixes (portability): + - Work around two different bugs in the OS X 10.10 and later SDKs that + would prevent us from successfully targeting earlier versions of OS X. + Fixes bug 26876; bugfix on 0.3.3.1-alpha. diff --git a/configure.ac b/configure.ac index 2fda2ef6f..ba58f9d74 100644 --- a/configure.ac +++ b/configure.ac @@ -548,7 +548,6 @@ AC_CHECK_FUNCS( llround \ localtime_r \ lround \ - mach_approximate_time \ memmem \ memset_s \ pipe \ @@ -574,9 +573,36 @@ AC_CHECK_FUNCS( _vscprintf ) -# Apple messed up when they added two functions functions in Sierra: they +# Apple messed up when they added some functions: they # forgot to decorate them with appropriate AVAILABLE_MAC_OS_VERSION -# checks. So we should only probe for those functions if we are sure that we +# checks. + +# We should only probe for these functions if we are sure that we +# are not targeting OS X 10.9 or earlier. +AC_MSG_CHECKING([for a pre-Yosemite OS X build target]) +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ +#ifdef __APPLE__ +# include <AvailabilityMacros.h> +# ifndef MAC_OS_X_VERSION_10_10 +# define MAC_OS_X_VERSION_10_10 101000 +# endif +# if defined(MAC_OS_X_VERSION_MIN_REQUIRED) +# if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_10 +# error "Running on Mac OS X 10.9 or earlier" +# endif +# endif +#endif +]], [[]])], + [on_macos_pre_10_10=no ; AC_MSG_RESULT([no])], + [on_macos_pre_10_10=yes; AC_MSG_RESULT([yes])]) + +if test "$on_macos_pre_10_10" = "no"; then + AC_CHECK_FUNCS( + mach_approximate_time \ + ) +fi + +# We should only probe for these functions if we are sure that we # are not targeting OSX 10.11 or earlier. AC_MSG_CHECKING([for a pre-Sierra OSX build target]) AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[

1 0

[tor/maint-0.3.3] Merge remote-tracking branch 'teor/bug26876_033' into maint-0.3.3
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 373b23a9ee80eb81a0d4db9fb6b742a602c8e82d Merge: 4f854dbdc 022b8f15d Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 31 08:29:54 2018 -0400 Merge remote-tracking branch 'teor/bug26876_033' into maint-0.3.3 changes/bug26876 | 4 ++++ configure.ac | 32 +++++++++++++++++++++++++++++--- 2 files changed, 33 insertions(+), 3 deletions(-)

1 0

[tor/master] Appveyor CI: Fix GitHub provider detection
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit fc9f8c28fbdc89501ebdca4792d5ff86490f9295 Author: teor <teor(a)torproject.org> Date: Tue Jul 31 11:09:54 2018 +1000 Appveyor CI: Fix GitHub provider detection Part of 26979. --- scripts/test/appveyor-irc-notify.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/test/appveyor-irc-notify.py b/scripts/test/appveyor-irc-notify.py index 4ffea5268..297b02b15 100644 --- a/scripts/test/appveyor-irc-notify.py +++ b/scripts/test/appveyor-irc-notify.py @@ -22,6 +22,9 @@ # - Accept UTF-8 # - only guess github URLs # - stop using ANSI colors +# +# Modified by teor in 2018: +# - fix github provider detection ('gitHub' or 'gitHubEnterprise', apparently) # This program is free software; you can redistribute it and/or modify it under the # terms of the GNU General Public License as published by the Free Software Foundation; @@ -110,7 +113,7 @@ def appveyor_vars(): BUILD_FMT = u'{url}/project/{account_name}/{project_name}/build/{build_version}' - if vars["repo_provider"] == 'github': + if vars["repo_provider"].lower().startswith('github'): COMMIT_FMT = u'https://{repo_provider}.com/{repo_name}/commit/{repo_commit}' vars.update(commit_url=COMMIT_FMT.format(**vars))

1 0

[tor/master] Appveyor CI: Generate correct branches and URLs for pull requests
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 9b41eb2bc3294f9bf0cf85d75fe2680efcebcc0e Author: teor <teor(a)torproject.org> Date: Tue Jul 31 11:12:21 2018 +1000 Appveyor CI: Generate correct branches and URLs for pull requests Part of 26979. --- scripts/test/appveyor-irc-notify.py | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/scripts/test/appveyor-irc-notify.py b/scripts/test/appveyor-irc-notify.py index fc2ead164..f830db4e4 100644 --- a/scripts/test/appveyor-irc-notify.py +++ b/scripts/test/appveyor-irc-notify.py @@ -26,6 +26,7 @@ # Modified by teor in 2018: # - fix github provider detection ('gitHub' or 'gitHubEnterprise', apparently) # - make short commits 10 hexdigits long (that's what git does for tor) +# - generate correct branches and URLs for pull requests # This program is free software; you can redistribute it and/or modify it under the # terms of the GNU General Public License as published by the Free Software Foundation; @@ -102,6 +103,9 @@ def appveyor_vars(): 'APPVEYOR_REPO_COMMIT_TIMESTAMP', 'APPVEYOR_REPO_PROVIDER', 'APPVEYOR_PROJECT_NAME', + 'APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME', + 'APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH', + 'APPVEYOR_PULL_REQUEST_HEAD_COMMIT', 'APPVEYOR_PULL_REQUEST_TITLE', 'APPVEYOR_BUILD_VERSION', 'APPVEYOR_REPO_COMMIT', @@ -112,15 +116,25 @@ def appveyor_vars(): ] ]) + vars.update( + short_commit=vars["repo_commit"][:10], + ) + BUILD_FMT = u'{url}/project/{account_name}/{project_name}/build/{build_version}' + BRANCH_FMT = u'{repo_name} {repo_branch} {short_commit}' if vars["repo_provider"].lower().startswith('github'): - COMMIT_FMT = u'https://{repo_provider}.com/{repo_name}/commit/{repo_commit}' + COMMIT_FMT = u'https://github.com/{repo_name}/commit/{repo_commit}' + if vars["pull_request_number"]: + BRANCH_FMT = u'{repo_name} {repo_branch} pull {pull_request_head_repo_name} {pull_request_head_repo_branch} {short_commit}' + COMMIT_FMT = u'https://github.com/{pull_request_head_repo_name}/commit/{pull_request_head_…' + PULL_FMT = u'https://github.com/{repo_name}/pull/{pull_request_number}' + vars.update(pull_url=PULL_FMT.format(**vars)) vars.update(commit_url=COMMIT_FMT.format(**vars)) vars.update( build_url=BUILD_FMT.format(**vars), - short_commit=vars["repo_commit"][:10], + branch_detail=BRANCH_FMT.format(**vars), ) return vars @@ -138,7 +152,7 @@ def notify(): if success or failure: messages = [] - messages.append(u"{repo_name} {repo_branch} {short_commit} - {repo_commit_author}: {repo_commit_message}") + messages.append(u"{branch_detail} - {repo_commit_author}: {repo_commit_message}") if success: m = u"Build #{build_version} passed. Details: {build_url}" @@ -147,7 +161,10 @@ def notify(): if "commit_url" in apvy_vars: m += " Commit: {commit_url}" - + + if "pull_url" in apvy_vars: + m += " Pull: {pull_url}" + messages.append(m) else: messages = sys.argv[3:]

1 0

[tor/master] Appveyor CI: Generate correct tag names
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 019c31bbf8a7aff9e99c8e373daa4d0f4102d1a4 Author: teor <teor(a)torproject.org> Date: Tue Jul 31 11:47:33 2018 +1000 Appveyor CI: Generate correct tag names Part of 26979. --- scripts/test/appveyor-irc-notify.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/scripts/test/appveyor-irc-notify.py b/scripts/test/appveyor-irc-notify.py index eb4d26ba3..b06534c3f 100644 --- a/scripts/test/appveyor-irc-notify.py +++ b/scripts/test/appveyor-irc-notify.py @@ -26,7 +26,7 @@ # Modified by teor in 2018: # - fix github provider detection ('gitHub' or 'gitHubEnterprise', apparently) # - make short commits 10 hexdigits long (that's what git does for tor) -# - generate correct branches and URLs for pull requests +# - generate correct branches and URLs for pull requests and tags # - switch to one URL per line # This program is free software; you can redistribute it and/or modify it under the @@ -113,7 +113,8 @@ def appveyor_vars(): 'APPVEYOR_REPO_COMMIT_MESSAGE', 'APPVEYOR_ACCOUNT_NAME', 'APPVEYOR_PULL_REQUEST_NUMBER', - 'APPVEYOR_REPO_NAME' + 'APPVEYOR_REPO_NAME', + 'APPVEYOR_REPO_TAG_NAME', ] ]) @@ -122,7 +123,11 @@ def appveyor_vars(): ) BUILD_FMT = u'{url}/project/{account_name}/{project_name}/build/{build_version}' - BRANCH_FMT = u'{repo_name} {repo_branch} {short_commit}' + + if vars["repo_tag_name"]: + BRANCH_FMT = u'{repo_name} {repo_tag_name} {short_commit}' + else: + BRANCH_FMT = u'{repo_name} {repo_branch} {short_commit}' if vars["repo_provider"].lower().startswith('github'): COMMIT_FMT = u'https://github.com/{repo_name}/commit/{repo_commit}'

1 0

[tor/master] Appveyor CI: Make short commits 10 hexdigits long
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 861db8c4aef4b71648a6ec9acad35bff042d00f2 Author: teor <teor(a)torproject.org> Date: Tue Jul 31 11:10:55 2018 +1000 Appveyor CI: Make short commits 10 hexdigits long That's what git does for tor. Part of 26979. --- scripts/test/appveyor-irc-notify.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/test/appveyor-irc-notify.py b/scripts/test/appveyor-irc-notify.py index 297b02b15..fc2ead164 100644 --- a/scripts/test/appveyor-irc-notify.py +++ b/scripts/test/appveyor-irc-notify.py @@ -25,6 +25,7 @@ # # Modified by teor in 2018: # - fix github provider detection ('gitHub' or 'gitHubEnterprise', apparently) +# - make short commits 10 hexdigits long (that's what git does for tor) # This program is free software; you can redistribute it and/or modify it under the # terms of the GNU General Public License as published by the Free Software Foundation; @@ -119,7 +120,7 @@ def appveyor_vars(): vars.update( build_url=BUILD_FMT.format(**vars), - short_commit=vars["repo_commit"][:7], + short_commit=vars["repo_commit"][:10], ) return vars

1 0

[tor/master] Appveyor CI: Switch to one URL per line
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit 3d3e62d1474a386f6a46fe6a8c5d6c7c5bed4f85 Author: teor <teor(a)torproject.org> Date: Tue Jul 31 11:37:11 2018 +1000 Appveyor CI: Switch to one URL per line Part of 26979. --- scripts/test/appveyor-irc-notify.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/test/appveyor-irc-notify.py b/scripts/test/appveyor-irc-notify.py index f830db4e4..eb4d26ba3 100644 --- a/scripts/test/appveyor-irc-notify.py +++ b/scripts/test/appveyor-irc-notify.py @@ -27,6 +27,7 @@ # - fix github provider detection ('gitHub' or 'gitHubEnterprise', apparently) # - make short commits 10 hexdigits long (that's what git does for tor) # - generate correct branches and URLs for pull requests +# - switch to one URL per line # This program is free software; you can redistribute it and/or modify it under the # terms of the GNU General Public License as published by the Free Software Foundation; @@ -155,17 +156,16 @@ def notify(): messages.append(u"{branch_detail} - {repo_commit_author}: {repo_commit_message}") if success: - m = u"Build #{build_version} passed. Details: {build_url}" + messages.append(u"Build #{build_version} passed. Details: {build_url}") if failure: - m = u"Build #{build_version} failed. Details: {build_url}" + messages.append(u"Build #{build_version} failed. Details: {build_url}") if "commit_url" in apvy_vars: - m += " Commit: {commit_url}" + messages.append(u"Commit: {commit_url}") if "pull_url" in apvy_vars: - m += " Pull: {pull_url}" + messages.append(u"Pull: {pull_url}") - messages.append(m) else: messages = sys.argv[3:] messages = ' '.join(messages)

1 0

[tor/master] Appveyor CI: Changes file for 26979
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit fcc848009311717dc23a739273501637ec7826fc Author: teor <teor(a)torproject.org> Date: Tue Jul 31 11:58:04 2018 +1000 Appveyor CI: Changes file for 26979 Closes 26979. --- changes/bug26979 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changes/bug26979 b/changes/bug26979 new file mode 100644 index 000000000..e615207b7 --- /dev/null +++ b/changes/bug26979 @@ -0,0 +1,4 @@ + o Minor bugfixes (appveyor ci): + - Improve Appveyor CI IRC logging. Generate correct branches and URLs for + pull requests and tags. Use unambiguous short commits. + Fixes bug 26979; bugfix on master.

1 0

[tor/master] Appveyor CI: always use HEAD for the short commit
by nickm＠torproject.org 31 Jul '18

31 Jul '18

commit c3fca338a2c63241497b64a9f997c28f17ef1b6a Author: teor <teor(a)torproject.org> Date: Tue Jul 31 12:14:40 2018 +1000 Appveyor CI: always use HEAD for the short commit Part of 26979. --- scripts/test/appveyor-irc-notify.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/test/appveyor-irc-notify.py b/scripts/test/appveyor-irc-notify.py index 639acc6ce..cfe0afe7a 100644 --- a/scripts/test/appveyor-irc-notify.py +++ b/scripts/test/appveyor-irc-notify.py @@ -118,10 +118,6 @@ def appveyor_vars(): ] ]) - vars.update( - short_commit=vars["repo_commit"][:10], - ) - BUILD_FMT = u'{url}/project/{account_name}/{project_name}/build/{build_version}' if vars["repo_tag_name"]: @@ -129,15 +125,20 @@ def appveyor_vars(): else: BRANCH_FMT = u'{repo_name} {repo_branch} {short_commit}' + vars.update(head_commit=vars["repo_commit"]) + if vars["repo_provider"].lower().startswith('github'): COMMIT_FMT = u'https://github.com/{repo_name}/commit/{repo_commit}' if vars["pull_request_number"]: + vars.update(head_commit=vars["pull_request_head_commit"]) BRANCH_FMT = u'{repo_name} {repo_branch} pull {pull_request_head_repo_name} {pull_request_head_repo_branch} {short_commit}' COMMIT_FMT = u'https://github.com/{pull_request_head_repo_name}/commit/{pull_request_head_…' PULL_FMT = u'https://github.com/{repo_name}/pull/{pull_request_number}' vars.update(pull_url=PULL_FMT.format(**vars)) vars.update(commit_url=COMMIT_FMT.format(**vars)) + vars.update(short_commit=vars["head_commit"][:10]) + vars.update( build_url=BUILD_FMT.format(**vars), branch_detail=BRANCH_FMT.format(**vars),

1 0