tor-commits June 2018

tor-commits@lists.torproject.org

16 participants
2190 discussions

[tor/release-0.3.4] Merge branch 'maint-0.2.9' into maint-0.3.1
by nickm＠torproject.org 30 Jun '18

30 Jun '18

commit 2968c716d7689eafcf32a1f5327af7b1ad1582ce Merge: a3ec89a4f 1953a7e61 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 23:11:47 2018 -0400 Merge branch 'maint-0.2.9' into maint-0.3.1 scripts/maint/checkSpace.pl | 5 ----- 1 file changed, 5 deletions(-) diff --cc scripts/maint/checkSpace.pl index 6d19d6ccd,5af95a27e..3043eb1aa --- a/scripts/maint/checkSpace.pl +++ b/scripts/maint/checkSpace.pl @@@ -168,32 -157,25 +168,27 @@@ for my $fn (@ARGV) } } - ## Check for forbidden functions except when they are - # explicitly permitted - if (/\bassert\(/ && not /assert OK/) { - print "assert :$fn:$. (use tor_assert)\n"; - } - if (/\bmemcmp\(/ && not /memcmp OK/) { - print "memcmp :$fn:$. (use {tor,fast}_mem{eq,neq,cmp}\n"; - } - # always forbidden. - if (not / OVERRIDE /) { - if (/\bstrcat\(/ or /\bstrcpy\(/ or /\bsprintf\(/) { - print "$& :$fn:$.\n"; - } - if (/\bmalloc\(/ or /\bfree\(/ or /\brealloc\(/ or - /\bstrdup\(/ or /\bstrndup\(/ or /\bcalloc\(/) { - print "$& :$fn:$. (use tor_malloc, tor_free, etc)\n"; - } - } + ## Check for forbidden functions except when they are + # explicitly permitted + if (/\bassert\(/ && not /assert OK/) { + msg "assert :$fn:$. (use tor_assert)\n"; + } + if (/\bmemcmp\(/ && not /memcmp OK/) { + msg "memcmp :$fn:$. (use {tor,fast}_mem{eq,neq,cmp}\n"; + } + # always forbidden. + if (not /\ OVERRIDE\ /) { + if (/\bstrcat\(/ or /\bstrcpy\(/ or /\bsprintf\(/) { + msg "$& :$fn:$.\n"; + } + if (/\bmalloc\(/ or /\bfree\(/ or /\brealloc\(/ or + /\bstrdup\(/ or /\bstrndup\(/ or /\bcalloc\(/) { + msg "$& :$fn:$. (use tor_malloc, tor_free, etc)\n"; + } + } } } - ## Warn if the file doesn't end with a blank line. - # (End each file with a single blank line.) - if (! $lastnil) { - msg " EOL\@EOF:$fn:$.\n"; - } close(F); } + +exit $found;

1 0

[tor/release-0.3.4] Finally remove our EOL@EOF check.
by nickm＠torproject.org 30 Jun '18

30 Jun '18

commit 1953a7e61d7dede47f90016cea13b38bc33554ef Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 18 16:10:47 2018 -0400 Finally remove our EOL@EOF check. This check was added by mistake long ago. It will be nice to see these EOLs disappear from our code over time. (backport from master) --- scripts/maint/checkSpace.pl | 6 ------ 1 file changed, 6 deletions(-) diff --git a/scripts/maint/checkSpace.pl b/scripts/maint/checkSpace.pl index e90f5b330..5af95a27e 100755 --- a/scripts/maint/checkSpace.pl +++ b/scripts/maint/checkSpace.pl @@ -177,11 +177,5 @@ for $fn (@ARGV) { } } } - ## Warn if the file doesn't end with a blank line. - # (End each file with a single blank line.) - if (! $lastnil) { - print " EOL\@EOF:$fn:$.\n"; - } close(F); } -

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.1' into maint-0.3.2
by nickm＠torproject.org 30 Jun '18

30 Jun '18

commit 3c97b148a42f6863ccf4b950967ce345d2fc8cbe Merge: ed84dab8b 2968c716d Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 23:12:03 2018 -0400 Merge branch 'maint-0.3.1' into maint-0.3.2 scripts/maint/checkSpace.pl | 5 ----- 1 file changed, 5 deletions(-)

1 0

[tor/master] Add another winsock2 include, for timeval in procmon.
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit ce940c8c09b1a03ab9b4baa82ecff118d5835a8c Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 19:17:24 2018 -0400 Add another winsock2 include, for timeval in procmon. --- src/common/procmon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/procmon.c b/src/common/procmon.c index c1bee041f..9799594d3 100644 --- a/src/common/procmon.c +++ b/src/common/procmon.c @@ -22,6 +22,7 @@ #endif #ifdef _WIN32 +#include <winsock2.h> #include <windows.h> #endif

1 0

[tor/master] add an include to fix macos, and probably bsd too
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 5921b23e1596ef05ac58e1c450949936a2a41bed Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 14:03:13 2018 -0400 add an include to fix macos, and probably bsd too --- src/lib/osinfo/uname.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/osinfo/uname.c b/src/lib/osinfo/uname.c index fb5cc7c20..a0fa26d1d 100644 --- a/src/lib/osinfo/uname.c +++ b/src/lib/osinfo/uname.c @@ -15,6 +15,7 @@ #ifdef _WIN32 #include <windows.h> #endif +#include <string.h> /** Hold the result of our call to <b>uname</b>. */ static char uname_result[256];

1 0

[tor/release-0.3.4] Fix a memory error in test_shared_random
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 3c0a63c40f8f41742bf6a4ab58165e8f25aab34a Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:49:02 2018 -0400 Fix a memory error in test_shared_random Bug not in any released Tor. --- src/test/test_shared_random.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 5f86d783a..6a8c1abaf 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -780,6 +780,7 @@ test_sr_setup_commits(void) /* Now during REVEAL phase save commit D by restoring its reveal. */ set_sr_phase(SR_PHASE_REVEAL); save_commit_to_state(place_holder); + place_holder = NULL; tt_str_op(commit_d->encoded_reveal, OP_EQ, "DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD"); /* Go back to an empty encoded reveal value. */

1 0

[tor/release-0.3.4] Fix some memory errors in the recent coverity fixes.
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit d583459d5845378a2b9ac0174ebe67a7473932fb Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:48:36 2018 -0400 Fix some memory errors in the recent coverity fixes. Found by asan on travis :/ --- src/test/test_channelpadding.c | 1 + src/test/test_hs_descriptor.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/test/test_channelpadding.c b/src/test/test_channelpadding.c index 0bc9699fe..d399738ce 100644 --- a/src/test/test_channelpadding.c +++ b/src/test/test_channelpadding.c @@ -677,6 +677,7 @@ test_channelpadding_consensus(void *arg) memcpy(relay->identity_digest, ((channel_tls_t *)chan)->conn->identity_digest, DIGEST_LEN); smartlist_add(current_md_consensus->routerstatus_list, relay); + relay = NULL; /* Prevent double-free */ tried_to_write_cell = 0; decision = channelpadding_decide_to_pad_channel(chan); diff --git a/src/test/test_hs_descriptor.c b/src/test/test_hs_descriptor.c index 45850ada4..a40616c61 100644 --- a/src/test/test_hs_descriptor.c +++ b/src/test/test_hs_descriptor.c @@ -207,6 +207,7 @@ test_link_specifier(void *arg) tt_int_op(link_specifier_get_un_ipv4_port(ls), ==, spec.u.ap.port); link_specifier_free(ls); + ls = NULL; tor_free(b64); } @@ -236,6 +237,7 @@ test_link_specifier(void *arg) tt_int_op(link_specifier_get_un_ipv6_port(ls), ==, spec.u.ap.port); link_specifier_free(ls); + ls = NULL; tor_free(b64); } @@ -263,6 +265,7 @@ test_link_specifier(void *arg) tt_mem_op(spec.u.legacy_id, OP_EQ, id, DIGEST_LEN); link_specifier_free(ls); + ls = NULL; tor_free(b64); }

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.4' into release-0.3.4
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 29269e6ee20023bd3de7227de637dc186f6c9ec1 Merge: 2f4ed3e57 75a6e7e25 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:49:43 2018 -0400 Merge branch 'maint-0.3.4' into release-0.3.4 src/test/test_channelpadding.c | 1 + src/test/test_hs_descriptor.c | 3 +++ src/test/test_shared_random.c | 1 + 3 files changed, 5 insertions(+)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.2' into maint-0.3.3
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 36c372581f8d7651c336f69b9b1b051d3d31d548 Merge: 92b4996b2 ed84dab8b Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:49:43 2018 -0400 Merge branch 'maint-0.3.2' into maint-0.3.3 src/test/test_channelpadding.c | 1 + src/test/test_hs_descriptor.c | 3 +++ src/test/test_shared_random.c | 1 + 3 files changed, 5 insertions(+)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.1' into maint-0.3.2
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit ed84dab8b4cd691dcdc0fecfb9c451bb0ffd930a Merge: 6e9d5fc4e a3ec89a4f Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:49:43 2018 -0400 Merge branch 'maint-0.3.1' into maint-0.3.2 src/test/test_channelpadding.c | 1 + src/test/test_hs_descriptor.c | 3 +++ src/test/test_shared_random.c | 1 + 3 files changed, 5 insertions(+) diff --cc src/test/test_hs_descriptor.c index a5e9b9667,a40616c61..897b44188 --- a/src/test/test_hs_descriptor.c +++ b/src/test/test_hs_descriptor.c @@@ -196,18 -195,19 +196,19 @@@ test_link_specifier(void *arg /* Decode it and validate the format. */ ret = base64_decode(buf, sizeof(buf), b64, strlen(b64)); - tt_int_op(ret, >, 0); + tt_int_op(ret, OP_GT, 0); /* First byte is the number of link specifier. */ - tt_int_op(get_uint8(buf), ==, 1); + tt_int_op(get_uint8(buf), OP_EQ, 1); ret = link_specifier_parse(&ls, (uint8_t *) buf + 1, ret - 1); - tt_int_op(ret, ==, 8); + tt_int_op(ret, OP_EQ, 8); /* Should be 2 bytes for port and 4 bytes for IPv4. */ - tt_int_op(link_specifier_get_ls_len(ls), ==, 6); + tt_int_op(link_specifier_get_ls_len(ls), OP_EQ, 6); ipv4 = link_specifier_get_un_ipv4_addr(ls); - tt_int_op(tor_addr_to_ipv4h(&spec.u.ap.addr), ==, ipv4); - tt_int_op(link_specifier_get_un_ipv4_port(ls), ==, spec.u.ap.port); + tt_int_op(tor_addr_to_ipv4h(&spec.u.ap.addr), OP_EQ, ipv4); + tt_int_op(link_specifier_get_un_ipv4_port(ls), OP_EQ, spec.u.ap.port); link_specifier_free(ls); + ls = NULL; tor_free(b64); } @@@ -233,11 -233,11 +234,12 @@@ for (unsigned int i = 0; i < sizeof(ipv6); i++) { ipv6[i] = link_specifier_get_un_ipv6_addr(ls, i); } - tt_mem_op(tor_addr_to_in6_addr8(&spec.u.ap.addr), ==, ipv6, sizeof(ipv6)); - tt_int_op(link_specifier_get_un_ipv6_port(ls), ==, spec.u.ap.port); + tt_mem_op(tor_addr_to_in6_addr8(&spec.u.ap.addr), OP_EQ, ipv6, + sizeof(ipv6)); + tt_int_op(link_specifier_get_un_ipv6_port(ls), OP_EQ, spec.u.ap.port); link_specifier_free(ls); + ls = NULL; tor_free(b64); }

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
219
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits June 2018