June 2018 - tor-commits - lists.torproject.org

[tor/maint-0.3.4] Merge remote-tracking branch 'ahf-github/maint-0.3.0' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit b89a66e9975dec4531c5443744f19b8105b4086a Merge: 419077c26 c997d49ad Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:11 2018 -0400 Merge remote-tracking branch 'ahf-github/maint-0.3.0' into maint-0.3.1 src/or/hs_descriptor.c | 1 + src/test/test_hs_descriptor.c | 11 +++++------ 2 files changed, 6 insertions(+), 6 deletions(-)

1 0

[tor/maint-0.3.4] Merge remote-tracking branch 'ahf-github/maint-0.3.1' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 419077c26da1e50ed5671c69ec446a3eb60a8303 Merge: 1385a5118 8550016e6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:08 2018 -0400 Merge remote-tracking branch 'ahf-github/maint-0.3.1' into maint-0.3.1 src/or/directory.c | 1 + src/test/hs_test_helpers.c | 6 ++++++ src/test/test_channelpadding.c | 2 ++ 3 files changed, 9 insertions(+)

1 0

[tor/maint-0.3.4] Merge branch 'maint-0.3.2' into maint-0.3.3
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit f82f8179e65c5e0021da46fd24e4bd7d8126d8f7 Merge: df896ed63 68dfbd5ef Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:15 2018 -0400 Merge branch 'maint-0.3.2' into maint-0.3.3 changes/ticket26467 | 3 +++ src/or/directory.c | 1 + src/or/hs_descriptor.c | 1 + src/test/hs_test_helpers.c | 6 ++++++ src/test/test_channelpadding.c | 2 ++ src/test/test_hs_descriptor.c | 11 +++++------ 6 files changed, 18 insertions(+), 6 deletions(-)

1 0

[tor/maint-0.3.4] Merge branch 'maint-0.2.9' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit ea14d3408df7c846722b54484cf5b8d61de5384f Merge: b89a66e99 890bc15ab Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:15 2018 -0400 Merge branch 'maint-0.2.9' into maint-0.3.1 changes/ticket26467 | 3 +++ 1 file changed, 3 insertions(+)

1 0

[tor/master] Fix potential memory leak in test_hs_auth_cookies().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 1724f995c71502977c79343922ab50fc2403284f Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 03:17:09 2018 +0200 Fix potential memory leak in test_hs_auth_cookies(). This patch fixes a potential memory leak in test_hs_auth_cookies() if a test-case fails and we goto the done label where no memory clean up is done. See: Coverity CID 1437453 --- src/test/test_hs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/test/test_hs.c b/src/test/test_hs.c index 8237bbc50..d572dd8d2 100644 --- a/src/test/test_hs.c +++ b/src/test/test_hs.c @@ -446,10 +446,10 @@ test_hs_auth_cookies(void *arg) #define TEST_COOKIE_ENCODED_STEALTH "YWJjZGVmZ2hpamtsbW5vcB" #define TEST_COOKIE_ENCODED_INVALID "YWJjZGVmZ2hpamtsbW5vcD" - char *encoded_cookie; + char *encoded_cookie = NULL; uint8_t raw_cookie[REND_DESC_COOKIE_LEN]; rend_auth_type_t auth_type; - char *err_msg; + char *err_msg = NULL; int re; (void)arg; @@ -495,6 +495,9 @@ test_hs_auth_cookies(void *arg) tor_free(err_msg); done: + tor_free(encoded_cookie); + tor_free(err_msg); + return; }

1 0

[tor/master] Fix memory leak in disk_state_parse_commits().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 3395de51a01aa5519c52404ed2bb9c8cda3571c9 Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 11:28:00 2018 +0200 Fix memory leak in disk_state_parse_commits(). This patch fixes a memory leak in disk_state_parse_commits() where if commit is NULL, we continue the internal loop, but without ever freeing the args variable. See: Coverity CID 1437441. --- src/or/shared_random_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/or/shared_random_state.c b/src/or/shared_random_state.c index 87db9031e..8438d4640 100644 --- a/src/or/shared_random_state.c +++ b/src/or/shared_random_state.c @@ -409,6 +409,7 @@ disk_state_parse_commits(sr_state_t *state, if (commit == NULL) { /* Ignore badly formed commit. It could also be a authority * fingerprint that we don't know about so it shouldn't be used. */ + smartlist_free(args); continue; } /* We consider parseable commit from our disk state to be valid because

1 0

[tor/master] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 5ab23e03fa0a8bce11798cbf025139e9653b9be4 Merge: c08102ea7 df896ed63 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:02:56 2018 -0400 Merge branch 'maint-0.3.3' into maint-0.3.4 src/or/dirauth/shared_random_state.c | 1 + src/or/routerlist.c | 2 +- src/test/test_hs.c | 7 +++++-- src/test/test_shared_random.c | 1 + 4 files changed, 8 insertions(+), 3 deletions(-) diff --cc src/or/routerlist.c index 8788dc019,203895c86..97d83213a --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@@ -2764,7 -2761,9 +2764,8 @@@ frac_nodes_with_descriptors(const smart if (node_has_any_descriptor(node)) n_with_descs++; }); - + tor_free(bandwidths); - return ((double)n_with_descs) / (double)smartlist_len(sl); + return ((double)n_with_descs) / smartlist_len(sl); } present = 0.0; @@@ -5819,4 -5818,4 +5820,3 @@@ refresh_all_country_info(void nodelist_refresh_countries(); } --

1 0

[tor/master] Merge remote-tracking branch 'ahf-github/maint-0.3.1' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 419077c26da1e50ed5671c69ec446a3eb60a8303 Merge: 1385a5118 8550016e6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:08 2018 -0400 Merge remote-tracking branch 'ahf-github/maint-0.3.1' into maint-0.3.1 src/or/directory.c | 1 + src/test/hs_test_helpers.c | 6 ++++++ src/test/test_channelpadding.c | 2 ++ 3 files changed, 9 insertions(+)

1 0

[tor/master] Fix memory leak in decode_link_specifiers().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 3d80c086bea3b0d93327c30ac620740b629cb294 Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 11:54:36 2018 +0200 Fix memory leak in decode_link_specifiers(). This patch fixes a memory leak in decode_link_specifiers() where the hs_spec variable might leak if the default label is taken in the switch/case expression. See: Coverity CID 1437437. --- src/or/hs_descriptor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/or/hs_descriptor.c b/src/or/hs_descriptor.c index 938b7a77d..15bdd14d5 100644 --- a/src/or/hs_descriptor.c +++ b/src/or/hs_descriptor.c @@ -864,6 +864,7 @@ decode_link_specifiers(const char *encoded) sizeof(hs_spec->u.legacy_id)); break; default: + tor_free(hs_spec); goto err; }

1 0

[tor/master] Fix memory leak in test_sr_setup_commits().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 8ec6b36dca928057c571af39fd3a9ed599ad5181 Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 11:31:59 2018 +0200 Fix memory leak in test_sr_setup_commits(). This patch fixes a memory leak in test_sr_setup_commits() where the place_holder is allocated, but never freed again. See: Coverity CID 1437440. --- src/test/test_shared_random.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 056f199b9..5f86d783a 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -788,6 +788,7 @@ test_sr_setup_commits(void) tt_assert(!commit_has_reveal_value(commit_d)); done: + tor_free(place_holder); authority_cert_free(auth_cert); }

1 0