June 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.2] Fix memory leak in client_likes_consensus().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit d86c45bf5cc75a526b884a754d72ef4d11aa0693 Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 10:33:40 2018 +0200 Fix memory leak in client_likes_consensus(). This patches fixes a memory leak in client_likes_consensus() where if consensus_cache_entry_get_voter_id_digests() would fail we would return without having free'd the voters list. See: Coverity CID 1437447 --- src/or/directory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/or/directory.c b/src/or/directory.c index 5ceea2fb3..f52354356 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -3499,6 +3499,7 @@ client_likes_consensus(const struct consensus_cache_entry_t *ent, int have = 0; if (consensus_cache_entry_get_voter_id_digests(ent, voters) != 0) { + smartlist_free(voters); return 1; // We don't know the voters; assume the client won't mind. */ }

1 0

[tor/release-0.3.2] Fix memory leak in test_sr_setup_commits().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 8ec6b36dca928057c571af39fd3a9ed599ad5181 Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 11:31:59 2018 +0200 Fix memory leak in test_sr_setup_commits(). This patch fixes a memory leak in test_sr_setup_commits() where the place_holder is allocated, but never freed again. See: Coverity CID 1437440. --- src/test/test_shared_random.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 056f199b9..5f86d783a 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -788,6 +788,7 @@ test_sr_setup_commits(void) tt_assert(!commit_has_reveal_value(commit_d)); done: + tor_free(place_holder); authority_cert_free(auth_cert); }

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.2' into release-0.3.2
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit b2bb41e029f16e7d8c67415d60e21826bd9959eb Merge: aec522661 fe2588a5a Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:00:56 2018 -0400 Merge branch 'maint-0.3.2' into release-0.3.2 src/or/routerlist.c | 2 ++ src/or/shared_random_state.c | 1 + src/test/test_hs.c | 7 +++++-- src/test/test_shared_random.c | 1 + 4 files changed, 9 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.2] Changes file for 26467
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 890bc15ab641f1c22a39b9a86de656a4e3a2d225 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:04:29 2018 -0400 Changes file for 26467 --- changes/ticket26467 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changes/ticket26467 b/changes/ticket26467 new file mode 100644 index 000000000..45883786c --- /dev/null +++ b/changes/ticket26467 @@ -0,0 +1,3 @@ + o Minor bugfixes (memory, correctness): + - Fix a number of small memory leaks identified by coverity. Fixes + bug 26467; bugfix on numerous Tor versions.

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.1' into maint-0.3.2
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit fe2588a5a8560c8cb03345b3caaaf906655c34a1 Merge: 25226fb26 1385a5118 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:00:56 2018 -0400 Merge branch 'maint-0.3.1' into maint-0.3.2 src/or/routerlist.c | 2 ++ src/or/shared_random_state.c | 1 + src/test/test_hs.c | 7 +++++-- src/test/test_shared_random.c | 1 + 4 files changed, 9 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.2] Merge remote-tracking branch 'ahf-github/maint-0.3.1' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 419077c26da1e50ed5671c69ec446a3eb60a8303 Merge: 1385a5118 8550016e6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:08 2018 -0400 Merge remote-tracking branch 'ahf-github/maint-0.3.1' into maint-0.3.1 src/or/directory.c | 1 + src/test/hs_test_helpers.c | 6 ++++++ src/test/test_channelpadding.c | 2 ++ 3 files changed, 9 insertions(+)

1 0

[tor/release-0.3.2] Merge remote-tracking branch 'ahf-github/maint-0.3.0' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit b89a66e9975dec4531c5443744f19b8105b4086a Merge: 419077c26 c997d49ad Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:11 2018 -0400 Merge remote-tracking branch 'ahf-github/maint-0.3.0' into maint-0.3.1 src/or/hs_descriptor.c | 1 + src/test/test_hs_descriptor.c | 11 +++++------ 2 files changed, 6 insertions(+), 6 deletions(-)

1 0

[tor/release-0.3.2] Merge branch 'maint-0.2.9' into maint-0.3.1
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit ea14d3408df7c846722b54484cf5b8d61de5384f Merge: b89a66e99 890bc15ab Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:15 2018 -0400 Merge branch 'maint-0.2.9' into maint-0.3.1 changes/ticket26467 | 3 +++ 1 file changed, 3 insertions(+)

1 0

[tor/release-0.3.3] Fix potential memory leak in test_hs_auth_cookies().
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit 1724f995c71502977c79343922ab50fc2403284f Author: Alexander Færøy <ahf(a)torproject.org> Date: Sat Jun 23 03:17:09 2018 +0200 Fix potential memory leak in test_hs_auth_cookies(). This patch fixes a potential memory leak in test_hs_auth_cookies() if a test-case fails and we goto the done label where no memory clean up is done. See: Coverity CID 1437453 --- src/test/test_hs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/test/test_hs.c b/src/test/test_hs.c index 8237bbc50..d572dd8d2 100644 --- a/src/test/test_hs.c +++ b/src/test/test_hs.c @@ -446,10 +446,10 @@ test_hs_auth_cookies(void *arg) #define TEST_COOKIE_ENCODED_STEALTH "YWJjZGVmZ2hpamtsbW5vcB" #define TEST_COOKIE_ENCODED_INVALID "YWJjZGVmZ2hpamtsbW5vcD" - char *encoded_cookie; + char *encoded_cookie = NULL; uint8_t raw_cookie[REND_DESC_COOKIE_LEN]; rend_auth_type_t auth_type; - char *err_msg; + char *err_msg = NULL; int re; (void)arg; @@ -495,6 +495,9 @@ test_hs_auth_cookies(void *arg) tor_free(err_msg); done: + tor_free(encoded_cookie); + tor_free(err_msg); + return; }

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.2' into release-0.3.2
by nickm＠torproject.org 29 Jun '18

29 Jun '18

commit cf61d437da0230aff3a0f1c04b95d17a37a78c88 Merge: b2bb41e02 68dfbd5ef Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 29 13:06:15 2018 -0400 Merge branch 'maint-0.3.2' into release-0.3.2 changes/ticket26467 | 3 +++ src/or/directory.c | 1 + src/or/hs_descriptor.c | 1 + src/test/hs_test_helpers.c | 6 ++++++ src/test/test_channelpadding.c | 2 ++ src/test/test_hs_descriptor.c | 11 +++++------ 6 files changed, 18 insertions(+), 6 deletions(-)

1 0