tor-commits June 2018

tor-commits@lists.torproject.org

16 participants
2190 discussions

[tor/maint-0.3.4] Merge remote-tracking branch 'isis/bug26245' into maint-0.3.4
by nickm＠torproject.org 16 Jun '18

16 Jun '18

commit 530d67410fab43e8a76544d05e4a50bdd526bca6 Merge: 9dd45456f 748a0c7d0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Jun 16 10:19:26 2018 -0400 Merge remote-tracking branch 'isis/bug26245' into maint-0.3.4 configure.ac | 6 ++++++ src/rust/.cargo/config.in | 3 +++ src/rust/external/crypto_digest.rs | 10 +++------- 3 files changed, 12 insertions(+), 7 deletions(-)

1 0

[tor/maint-0.3.4] Changes file for rust fatal warnings
by nickm＠torproject.org 16 Jun '18

16 Jun '18

commit 3dd94a7ea7e85307822885306cbd7096b56442df Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Jun 16 10:20:21 2018 -0400 Changes file for rust fatal warnings --- changes/bug26245 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changes/bug26245 b/changes/bug26245 new file mode 100644 index 000000000..7a14cea0b --- /dev/null +++ b/changes/bug26245 @@ -0,0 +1,3 @@ + o Minor features (compilation): + o The --enable-fatal-warnings flag now affects Rust code as well. + Closes ticket 26245.

1 0

[tor/maint-0.3.4] rust: Add comment and pragma on "unused" smartlist_t type.
by nickm＠torproject.org 16 Jun '18

16 Jun '18

commit d5a9b77a2892f195d391376f98287714d455ce5b Author: Isis Lovecruft <isis(a)torproject.org> Date: Fri Jun 15 22:49:05 2018 +0000 rust: Add comment and pragma on "unused" smartlist_t type. * FIXES part of #26245: https://bugs.torproject.org/26245 --- src/rust/external/crypto_digest.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/rust/external/crypto_digest.rs b/src/rust/external/crypto_digest.rs index bc49e6124..b55389ac5 100644 --- a/src/rust/external/crypto_digest.rs +++ b/src/rust/external/crypto_digest.rs @@ -117,6 +117,9 @@ struct common_digests_t { /// A `smartlist_t` is just an alias for the `#[repr(C)]` type `Stringlist`, to /// make it more clear that we're working with a smartlist which is owned by C. #[allow(non_camel_case_types)] +// BINDGEN_GENERATED: This type isn't actually bindgen generated, but the code +// below it which uses it is. As such, this comes up as "dead code" as well. +#[allow(dead_code)] type smartlist_t = Stringlist; /// All of the external functions from `src/common/crypto_digest.h`.

1 0

[tor/maint-0.3.4] rust: Remove unused N_DIGEST_ALGORITHMS constant from crypto_digest.rs.
by nickm＠torproject.org 16 Jun '18

16 Jun '18

commit 748a0c7d0b7ed4657703371428aa2392d1383fe9 Author: Isis Lovecruft <isis(a)torproject.org> Date: Fri Jun 15 23:22:43 2018 +0000 rust: Remove unused N_DIGEST_ALGORITHMS constant from crypto_digest.rs. In the C code, this constant is only ever used in src/test/bench.c. * FIXES part of #26245: https://bugs.torproject.org/26245 --- src/rust/external/crypto_digest.rs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/rust/external/crypto_digest.rs b/src/rust/external/crypto_digest.rs index b55389ac5..4eae1550a 100644 --- a/src/rust/external/crypto_digest.rs +++ b/src/rust/external/crypto_digest.rs @@ -66,13 +66,6 @@ const DIGEST_SHA512: digest_algorithm_t = 2; const DIGEST_SHA3_256: digest_algorithm_t = 3; const DIGEST_SHA3_512: digest_algorithm_t = 4; -/// The total number of digest algorithms we currently support. -/// -/// We can't access these from Rust, because their definitions in C require -/// introspecting the `digest_algorithm_t` typedef, which is an enum, so we have -/// to redefine them here. -const N_DIGEST_ALGORITHMS: usize = DIGEST_SHA3_512 as usize + 1; - /// The number of hash digests we produce for a `common_digests_t`. /// /// We can't access these from Rust, because their definitions in C require

1 0

[tor/master] Make Rust warnings conditionally fatal
by nickm＠torproject.org 16 Jun '18

16 Jun '18

commit 468bf58fa24d78bef8d0d017dcacb7da4c031c12 Author: Taylor Yu <catalyst(a)torproject.org> Date: Fri Jun 15 17:27:19 2018 -0500 Make Rust warnings conditionally fatal Set rustc flags to treat warnings as fatal if configured with --enable-warnings. --- configure.ac | 6 ++++++ src/rust/.cargo/config.in | 3 +++ 2 files changed, 9 insertions(+) diff --git a/configure.ac b/configure.ac index d554ba8e5..5269d9c42 100644 --- a/configure.ac +++ b/configure.ac @@ -462,6 +462,11 @@ if test "x$enable_rust" = "xyes"; then fi AC_DEFINE([HAVE_RUST], 1, [have Rust]) + if test "x$enable_fatal_warnings" = "xyes"; then + RUST_WARN= + else + RUST_WARN=# + fi if test "x$enable_cargo_online_mode" = "xyes"; then CARGO_ONLINE= RUST_DL=# @@ -515,6 +520,7 @@ if test "x$enable_rust" = "xyes"; then AC_SUBST(TOR_RUST_STATIC_NAME) AC_SUBST(CARGO_ONLINE) + AC_SUBST(RUST_WARN) AC_SUBST(RUST_DL) dnl Let's check the rustc version, too diff --git a/src/rust/.cargo/config.in b/src/rust/.cargo/config.in index 301e7fdbe..70481bbcb 100644 --- a/src/rust/.cargo/config.in +++ b/src/rust/.cargo/config.in @@ -6,3 +6,6 @@ @RUST_DL@ [source.vendored-sources] @RUST_DL@ directory = '@TOR_RUST_DEPENDENCIES@' + +@RUST_WARN@ [build] +@RUST_WARN@ rustflags = [ "-D", "warnings" ] \ No newline at end of file

1 0

[tor/master] rust: Add comment and pragma on "unused" smartlist_t type.
by nickm＠torproject.org 16 Jun '18

16 Jun '18

1 0

[tor/master] rust: Remove unused N_DIGEST_ALGORITHMS constant from crypto_digest.rs.
by nickm＠torproject.org 16 Jun '18

16 Jun '18

1 0

[tor/master] Changes file for rust fatal warnings
by nickm＠torproject.org 16 Jun '18

16 Jun '18

1 0

[tor/release-0.3.4] rust: Add comment and pragma on "unused" smartlist_t type.
by nickm＠torproject.org 16 Jun '18

16 Jun '18

1 0

[tor/release-0.3.4] rust: Remove unused N_DIGEST_ALGORITHMS constant from crypto_digest.rs.
by nickm＠torproject.org 16 Jun '18

16 Jun '18

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits June 2018