May 2018 - tor-commits - lists.torproject.org

[metrics-web/release] Document Onionoo's new protocol version 5.2.
by karsten＠torproject.org 30 May '18

30 May '18

commit c2e0babcf84bbf0a84bbb890d2e39a39da4582d2 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Apr 6 11:02:02 2018 +0200 Document Onionoo's new protocol version 5.2. --- src/main/resources/web/jsps/onionoo.jsp | 49 +++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/src/main/resources/web/jsps/onionoo.jsp b/src/main/resources/web/jsps/onionoo.jsp index 28b16c6..540ca23 100644 --- a/src/main/resources/web/jsps/onionoo.jsp +++ b/src/main/resources/web/jsps/onionoo.jsp @@ -300,6 +300,9 @@ Always added a relay's own fingerprint to its "effective_family" and made nickname fields "n" in summary documents and "nickname" in details documents required fields on March 14, 2018. <a href="#versions_5_1" class="anchor">#</a></li> +<li><a id="versions_5_2"></a>5.2 +Added "version_status" field to details documents on April 6, 2018. +<a href="#versions_5_2" class="anchor">#</a></li> <li><a id="versions_6_0"></a>6.0 (scheduled, but not deployed yet!): Include all exit addresses in "exit_addresses", regardless of whether they're used as OR addresses or not, to @@ -1490,6 +1493,29 @@ the relay did not report which version it runs. </li> <li> +<a id="details_relay_version_status"></a> +version_status new +<code class="typeof">string</code> +optional +<a href="#details_relay_version_status" class="anchor">#</a> + +Status of the Tor software version of this relay based on the versions +recommended by the directory authorities. +Possible version statuses are: +"recommended" if a version is listed as recommended; +"experimental" if a version is newer than every recommended version; +"obsolete" if a version is older than every recommended version; +"new in series" if a version has other recommended versions with the same first +three components, and the version is newer than all such recommended versions, +but it is not newer than every recommended version; +"unrecommended" if none of the above conditions hold. +Omitted if either the directory authorities did not recommend versions, or the +relay did not report which version it runs. +Added on April 6, 2018. + +</li> + +<li> <a id="details_relay_effective_family"></a> effective_family updated <code class="typeof">array of strings</code> @@ -1829,6 +1855,29 @@ the bridge did not report which version it runs. </li> <li> +<a id="details_bridge_version_status"></a> +version_status new +<code class="typeof">string</code> +optional +<a href="#details_bridge_version_status" class="anchor">#</a> + +Status of the Tor software version of this bridge based on the versions +recommended by the directory authorities. +Possible version statuses are: +"recommended" if a version is listed as recommended; +"experimental" if a version is newer than every recommended version; +"obsolete" if a version is older than every recommended version; +"new in series" if a version has other recommended versions with the same first +three components, and the version is newer than all such recommended versions, +but it is not newer than every recommended version; +"unrecommended" if none of the above conditions hold. +Omitted if either the directory authorities did not recommend versions, or the +bridge did not report which version it runs. +Added on April 6, 2018. + +</li> + +<li> <a id="details_bridge_transports"></a> transports <code class="typeof">array of strings</code>

1 0

[metrics-web/release] Make war-task depend on jar-task.
by karsten＠torproject.org 30 May '18

30 May '18

commit b1e05125fa3442e17cf78994e0818ba540b38571 Author: iwakeh <iwakeh(a)torproject.org> Date: Fri Apr 6 09:02:03 2018 +0000 Make war-task depend on jar-task. This makes the git-revision available. --- build.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.xml b/build.xml index 17160ee..9b29452 100644 --- a/build.xml +++ b/build.xml @@ -137,7 +137,7 @@  <target name="war" - depends="submoduleupdate,compile"> + depends="submoduleupdate,jar"> <echo message="Removing problematic service definitions from"/> <echo message="${libs}/jetty9-apache-jsp${jetty.version}.jar and using "/> <echo message="${libs}/jetty9-apache-jsp${jetty.version}-tweaked.jar below." />

1 0

[metrics-web/release] Update to latest metrics-lib.
by karsten＠torproject.org 30 May '18

30 May '18

commit d85e4368a4d91846a1541aa1a72242bb001a5e3c Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Mar 28 16:43:16 2018 +0200 Update to latest metrics-lib. --- src/submods/metrics-lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/submods/metrics-lib b/src/submods/metrics-lib index 2e235ef..f826234 160000 --- a/src/submods/metrics-lib +++ b/src/submods/metrics-lib @@ -1 +1 @@ -Subproject commit 2e235ef8f38aac679817fa8e8b9171aadb3d5b9d +Subproject commit f826234e8064014487d871838e8074e83a142e42

1 0

[metrics-web/release] Update Onionoo specification for version 6.0.
by karsten＠torproject.org 30 May '18

30 May '18

commit 1ec5da2243334c27b95cf7011ae428c78c1010e0 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Tue Apr 17 15:04:58 2018 +0200 Update Onionoo specification for version 6.0. --- src/main/resources/web/jsps/onionoo.jsp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/main/resources/web/jsps/onionoo.jsp b/src/main/resources/web/jsps/onionoo.jsp index 540ca23..b225732 100644 --- a/src/main/resources/web/jsps/onionoo.jsp +++ b/src/main/resources/web/jsps/onionoo.jsp @@ -304,9 +304,8 @@ required fields on March 14, 2018. Added "version_status" field to details documents on April 6, 2018. <a href="#versions_5_2" class="anchor">#</a></li> <li><a id="versions_6_0"></a>6.0 -(scheduled, but not deployed yet!): Include all exit addresses in -"exit_addresses", regardless of whether they're used as OR addresses or not, to -be deployed after April 14, 2018. +Included all exit addresses in "exit_addresses", regardless of whether they are +used as onion-routing addresses or not on April 17, 2018. <a href="#versions_6_0" class="anchor">#</a></li> </ul> @@ -1053,7 +1052,7 @@ IPv6 hex characters are all lower-case. <li> <a id="details_relay_exit_addresses"></a> -exit_addresses +exit_addresses updated <code class="typeof">array of strings</code> optional <a href="#details_relay_exit_addresses" class="anchor">#</a> @@ -1061,9 +1060,9 @@ IPv6 hex characters are all lower-case. Array of IPv4 or IPv6 addresses that the relay used to exit to the Internet in the past 24 hours. IPv6 hex characters are all lower-case. -Only those addresses are listed that are different from onion-routing -addresses. Omitted if array is empty. +Changed on April 17, 2018 to include all exit addresses, regardless of whether +they are used as onion-routing addresses or not. </li>

1 0

[metrics-web/release] Link directly to CollecTor subdirectories.
by karsten＠torproject.org 30 May '18

30 May '18

commit 0af3488050be3a7877d34814e39eb42465afe7ec Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Apr 4 16:15:40 2018 +0200 Link directly to CollecTor subdirectories. --- src/main/resources/web/jsps/collector.jsp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/resources/web/jsps/collector.jsp b/src/main/resources/web/jsps/collector.jsp index 13865ba..3e98785 100644 --- a/src/main/resources/web/jsps/collector.jsp +++ b/src/main/resources/web/jsps/collector.jsp @@ -382,7 +382,7 @@ The sanitizing steps are specified in detail on a separate <h3 id="type-bridge-network-status" class="hover">Bridge Network Statuses <code>@type bridge-network-status 1.2</code> <a href="/collector/recent/bridge-descriptors/statuses/" class="btn btn-primary btn-xs"> recent</a> -<a href="/collector/archive/bridge-descriptors/" class="btn btn-primary btn-xs"> archive</a> +<a href="/collector/archive/bridge-descriptors/statuses/" class="btn btn-primary btn-xs"> archive</a> <a href="#type-bridge-network-status" class="anchor">#</a> </h3> @@ -407,7 +407,7 @@ authority which produced the document, to the header.</li> <h3 id="type-bridge-server-descriptor" class="hover">Bridge Server descriptors <code>@type bridge-server-descriptor 1.2</code> <a href="/collector/recent/bridge-descriptors/server-descriptors/" class="btn btn-primary btn-xs"> recent</a> -<a href="/collector/archive/bridge-descriptors/" class="btn btn-primary btn-xs"> archive</a> +<a href="/collector/archive/bridge-descriptors/server-descriptors/" class="btn btn-primary btn-xs"> archive</a> <a href="#type-bridge-server-descriptor" class="anchor">#</a> </h3> @@ -441,7 +441,7 @@ ports.</li> <h3 id="type-bridge-extra-info" class="hover">Bridge Extra-info Descriptors <code>@type bridge-extra-info 1.3</code> <a href="/collector/recent/bridge-descriptors/extra-infos/" class="btn btn-primary btn-xs"> recent</a> -<a href="/collector/archive/bridge-descriptors/" class="btn btn-primary btn-xs"> archive</a> +<a href="/collector/archive/bridge-descriptors/extra-infos/" class="btn btn-primary btn-xs"> archive</a> <a href="#type-bridge-extra-info" class="anchor">#</a> </h3>

1 0

[metrics-web/release] Update news.json to version 255 of doc/MetricsTimeline.
by karsten＠torproject.org 30 May '18

30 May '18

commit d425de8f8a22e256398977e812fa69550506eb57 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Sun Apr 15 22:41:42 2018 +0200 Update news.json to version 255 of doc/MetricsTimeline. --- src/main/resources/web/json/news.json | 89 +++++++++++++++++++++++++++++++++-- 1 file changed, 86 insertions(+), 3 deletions(-) diff --git a/src/main/resources/web/json/news.json b/src/main/resources/web/json/news.json index c503aa1..8385b6e 100644 --- a/src/main/resources/web/json/news.json +++ b/src/main/resources/web/json/news.json @@ -429,7 +429,7 @@ }, { "start": "2012-02-08", - "ongoing": true, + "end": "2012-02-11", "places": [ "ir" ], @@ -442,6 +442,14 @@ { "label": "blog post", "target": "https://blog.torproject.org/iran-partially-blocks-encrypted-network-traffic" + }, + { + "label": "relay graph", + "target": "https://metrics.torproject.org/userstats-relay-country.html?start=2012-01-0…" + }, + { + "label": "bridge graph", + "target": "https://metrics.torproject.org/userstats-bridge-country.html?start=2012-01-…" } ] }, @@ -4489,6 +4497,10 @@ { "label": "comment", "target": "https://bugs.torproject.org/21312#comment:63" + }, + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" } ] }, @@ -4497,8 +4509,14 @@ "protocols": [ "snowflake" ], - "shortDescription": "Provisonally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited.", - "description": "Provisonally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited." + "shortDescription": "Provisionally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited.", + "description": "Provisionally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited.", + "links": [ + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" + } + ] }, { "start": "2018-03-23", @@ -4511,6 +4529,10 @@ { "label": "comment", "target": "https://bugs.torproject.org/21312#comment:64" + }, + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" } ] }, @@ -4533,6 +4555,48 @@ ] }, { + "start": "2018-03-27", + "protocols": [ + "snowflake" + ], + "shortDescription": "Restarted the fallback snowflake proxies with no limit on memory.", + "description": "Restarted the fallback snowflake proxies with no limit on memory.", + "links": [ + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" + } + ] + }, + { + "start": "2018-04-02", + "protocols": [ + "snowflake" + ], + "shortDescription": "Reinstated periodic restarts of the fallback snowflake proxies.", + "description": "Reinstated periodic restarts of the fallback snowflake proxies.", + "links": [ + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" + } + ] + }, + { + "start": "2018-04-13", + "protocols": [ + "snowflake" + ], + "shortDescription": "Snowflake client registrations", + "description": "Snowflake client registrations (based on domain fronting) stop working, because of a Google infrastructure change that stops domain fronting from working. The time of the change is between 2018-04-13 14:00:00 and 2018-04-13 18:00:00, based on when the bandwidth graph of the Snowflake bridge <a href=\"https://metrics.torproject.org/rs.html#details/5481936581E23D2D178105D44DB6…">5481936581E23D2D178105D44DB6915AB06BFB7F</a> went to zero.", + "links": [ + { + "label": "ticket", + "target": "https://bugs.torproject.org/25804" + } + ] + }, + { "start": "2016-02-24", "places": [ "tm" @@ -5452,6 +5516,25 @@ "unknown": true }, { + "start": "2018-02-01", + "end": "2018-02-05", + "places": [ + "ir" + ], + "protocols": [ + "meek" + ], + "shortDescription": "Drop of meek users in Iran; other transports not affected.", + "description": "Drop of meek users in Iran; other transports not affected.", + "links": [ + { + "label": "graph", + "target": "https://metrics.torproject.org/userstats-bridge-combined.html?start=2018-01…" + } + ], + "unknown": true + }, + { "start": "2018-03-05", "end": "2018-03-08", "places": [

1 0

[metrics-web/release] Provide no-data pictures, pdfs, and csv files instead of server error.
by karsten＠torproject.org 30 May '18

30 May '18

commit 533225c4250490857b0ed3e31232914da725cc13 Author: iwakeh <iwakeh(a)torproject.org> Date: Sat Mar 24 09:31:08 2018 +0000 Provide no-data pictures, pdfs, and csv files instead of server error. Implements task-25264. --- build.xml | 1 + src/main/R/rserver/graphs.R | 20 ++++++++++++++++++++ .../torproject/metrics/web/RObjectGenerator.java | 7 ++++--- src/main/resources/web/images/no-data-available.pdf | Bin 0 -> 33824 bytes src/main/resources/web/images/no-data-available.png | Bin 0 -> 26209 bytes src/main/resources/web/images/no-data-available.xcf | Bin 0 -> 104450 bytes 6 files changed, 25 insertions(+), 3 deletions(-) diff --git a/build.xml b/build.xml index 3b4222e..17160ee 100644 --- a/build.xml +++ b/build.xml @@ -504,6 +504,7 @@ <copy todir="${rdatadir}" > <fileset dir="${modulebase}/clients/RData" includes="*.RData" /> <fileset dir="${modulebase}/webstats/RData" includes="*.RData" /> + <fileset dir="${resources}/web/images/" includes="no-data-available.*" /> </copy> </target> diff --git a/src/main/R/rserver/graphs.R b/src/main/R/rserver/graphs.R index 57d2be2..332204b 100644 --- a/src/main/R/rserver/graphs.R +++ b/src/main/R/rserver/graphs.R @@ -328,6 +328,26 @@ stats_dir <- "/srv/metrics.torproject.org/metrics/shared/stats/" rdata_dir <- "/srv/metrics.torproject.org/metrics/shared/RData/" +# Helper function that copies the appropriate no data object to filename. +copy_no_data <- function(filename) { + len <- nchar(filename) + extension <- substr(filename, len - 3, len) + if (".csv" == extension) { + write("# No data available for the given parameters.", file=filename) + } else { + file.copy(paste(rdata_dir, "no-data-available", extension, sep = ""), + filename) + } +} + +# Helper function wrapping calls into error handling. +robust_call <- function(wrappee, filename) { + tryCatch(eval(wrappee), error = function(e) copy_no_data(filename), + finally = if (!file.exists(filename) || file.size(filename) == 0) { + copy_no_data(filename) + }) +} + prepare_networksize <- function(start, end) { read.csv(paste(stats_dir, "servers.csv", sep = ""), colClasses = c("date" = "Date")) %>% diff --git a/src/main/java/org/torproject/metrics/web/RObjectGenerator.java b/src/main/java/org/torproject/metrics/web/RObjectGenerator.java index 04bda0c..e3a2419 100644 --- a/src/main/java/org/torproject/metrics/web/RObjectGenerator.java +++ b/src/main/java/org/torproject/metrics/web/RObjectGenerator.java @@ -117,19 +117,20 @@ public class RObjectGenerator implements ServletContextListener { == null) { return null; } - String function = this.availableGraphs.get(requestedGraph) - .getFunction(); Map<String, String[]> checkedParameters = GraphParameterChecker .getInstance().checkParameters(requestedGraph, parameterMap); if (checkedParameters == null) { return null; } StringBuilder queryBuilder = new StringBuilder(); + queryBuilder.append("robust_call(as.call(list("); if ("csv".equalsIgnoreCase(fileType)) { queryBuilder.append("write_"); } else { queryBuilder.append("plot_"); } + String function = this.availableGraphs.get(requestedGraph) + .getFunction(); queryBuilder.append(function).append("("); StringBuilder imageFilenameBuilder = new StringBuilder(requestedGraph); @@ -154,7 +155,7 @@ public class RObjectGenerator implements ServletContextListener { } imageFilenameBuilder.append(".").append(fileType); String imageFilename = imageFilenameBuilder.toString(); - queryBuilder.append("path = '%s')"); + queryBuilder.append("path = '%1$s'))), '%1$s')"); String query = queryBuilder.toString(); File imageFile = new File(this.cachedGraphsDirectory + "/" + imageFilename); diff --git a/src/main/resources/web/images/no-data-available.pdf b/src/main/resources/web/images/no-data-available.pdf new file mode 100644 index 0000000..8c9ca25 Binary files /dev/null and b/src/main/resources/web/images/no-data-available.pdf differ diff --git a/src/main/resources/web/images/no-data-available.png b/src/main/resources/web/images/no-data-available.png new file mode 100644 index 0000000..36310ad Binary files /dev/null and b/src/main/resources/web/images/no-data-available.png differ diff --git a/src/main/resources/web/images/no-data-available.xcf b/src/main/resources/web/images/no-data-available.xcf new file mode 100644 index 0000000..42a7170 Binary files /dev/null and b/src/main/resources/web/images/no-data-available.xcf differ

1 0

[metrics-web/release] Convert shell script into Ant task.
by karsten＠torproject.org 30 May '18

30 May '18

commit 3be34c3be42a9fda3258c152efa5f56a2693519d Author: iwakeh <iwakeh(a)torproject.org> Date: Wed Jan 31 19:29:57 2018 +0000 Convert shell script into Ant task. --- build.xml | 49 ++++++++++++++++++++++++++++++++++++++ src/main/resources/spec/convert.sh | 6 ----- 2 files changed, 49 insertions(+), 6 deletions(-) diff --git a/build.xml b/build.xml index 57eab68..0e05d12 100644 --- a/build.xml +++ b/build.xml @@ -24,6 +24,8 @@ <property name="Rsources" value="${basedir}/src/main/R" /> <property name="pysources" value="${basedir}/src/main/python" /> + <property name="specdir" value="${basedir}/generated/spec" /> +  <property name="metrics-web.deployment.base" @@ -149,6 +151,7 @@ </jar> <antcall target="generate-ml-javadoc" /> + <antcall target="generate-specs" /> <war destfile="${dist}/${warfile}" duplicate="fail" @@ -183,6 +186,9 @@ <zipfileset dir="${resources}/web/jsps" prefix="WEB-INF" includes="*.jsp"/> + <zipfileset dir="${specdir}" + prefix="WEB-INF" + includes="*.jsp"/> <zipfileset dir="${resources}" includes="*.properties" /> <fileset dir="${resources}" includes="jetty.xml" /> @@ -249,6 +255,49 @@ <echo message="Java module UpdateNews finished. " /> </target> + <target name="generate-specs" depends="init" > + <mkdir dir="${specdir}" /> + <antcall target="xml2jsp"> + <param name="specfile" value="bridge-descriptors"/> + </antcall> + <antcall target="xml2jsp"> + <param name="specfile" value="web-server-logs"/> + </antcall> + </target> + + <target name="xml2jsp" > + <echo message="Generating ${specfile} specification jsp ... " /> + <exec executable="saxon-xslt" + dir="${specdir}" + logError="true" + output="${specdir}/${specfile}.tmp" + failonerror="true" > + <arg value="${basedir}/${resources}/spec/${specfile}.xml" /> + <arg value="${basedir}/${resources}/spec/rfc2629.xslt" /> + <arg value="xml2rfc-topblock=no" /> + </exec> + <exec executable="tidy" + dir="${specdir}" + logError="true" + output="${specdir}/${specfile}.tmp2" + failonerror="true" > + <arg value="-quiet" /> + <arg value="${specdir}/${specfile}.tmp" /> + </exec> + <exec executable="awk" + dir="${specdir}" + logError="true" + output="${specdir}/${specfile}.jsp" + failonerror="true" > + <arg value="-f" /> + <arg value="${basedir}/${resources}/spec/convert.awk" /> + <arg value="${specdir}/${specfile}.tmp2" /> + </exec> + <echo message="Done." /> + <delete file="${specdir}/${specfile}.tmp" quiet="true" /> + <delete file="${specdir}/${specfile}.tmp2" quiet="true" /> + </target> +  <property name="prepare.deployment" value="/srv/metrics.torproject.org/metrics/work" /> diff --git a/src/main/resources/spec/convert.sh b/src/main/resources/spec/convert.sh deleted file mode 100755 index 95287e2..0000000 --- a/src/main/resources/spec/convert.sh +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/bash -for specfile in "bridge-descriptors" "web-server-logs"; do - saxon-xslt $specfile.xml rfc2629.xslt xml2rfc-topblock=no | \ - tidy -q | awk -f convert.awk > ../web/jsps/$specfile.jsp -done -

1 0

[metrics-web/release] Use proper call list syntax.
by karsten＠torproject.org 30 May '18

30 May '18

commit 41907268f1b86337961b7035984ee084a3bd6bab Author: iwakeh <iwakeh(a)torproject.org> Date: Tue Apr 3 07:32:38 2018 +0000 Use proper call list syntax. --- src/main/java/org/torproject/metrics/web/RObjectGenerator.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/torproject/metrics/web/RObjectGenerator.java b/src/main/java/org/torproject/metrics/web/RObjectGenerator.java index e3a2419..aea6db7 100644 --- a/src/main/java/org/torproject/metrics/web/RObjectGenerator.java +++ b/src/main/java/org/torproject/metrics/web/RObjectGenerator.java @@ -131,7 +131,7 @@ public class RObjectGenerator implements ServletContextListener { } String function = this.availableGraphs.get(requestedGraph) .getFunction(); - queryBuilder.append(function).append("("); + queryBuilder.append(function).append(", "); StringBuilder imageFilenameBuilder = new StringBuilder(requestedGraph); for (Map.Entry<String, String[]> parameter @@ -155,7 +155,7 @@ public class RObjectGenerator implements ServletContextListener { } imageFilenameBuilder.append(".").append(fileType); String imageFilename = imageFilenameBuilder.toString(); - queryBuilder.append("path = '%1$s'))), '%1$s')"); + queryBuilder.append("path = '%1$s')), '%1$s')"); String query = queryBuilder.toString(); File imageFile = new File(this.cachedGraphsDirectory + "/" + imageFilename);

1 0

[metrics-web/release] Fix typo on Statistics page.
by karsten＠torproject.org 30 May '18

30 May '18

commit 215f3639c245a4ed200158526bf03b3d07f25677 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Mon Apr 23 12:41:29 2018 +0200 Fix typo on Statistics page. --- src/main/resources/web/jsps/stats.jsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/web/jsps/stats.jsp b/src/main/resources/web/jsps/stats.jsp index c224a06..2674ba0 100644 --- a/src/main/resources/web/jsps/stats.jsp +++ b/src/main/resources/web/jsps/stats.jsp @@ -452,7 +452,7 @@ uni-/bidirectional connection usage were reported.</li> <li>direction: Direction of reported fraction, which can be "read", "write", or "both" for connections classified as -"mostly reading", "mostly writing", or "both reading as writing". Connections +"mostly reading", "mostly writing", or "both reading and writing". Connections below the threshold have been removed from this statistics file entirely.</li> <li>quantile: Quantile of the reported fraction when considering all

1 0