May 2018 - tor-commits - lists.torproject.org

[tor/master] Update cov-diff to handle new gcov, and remove timestamps
by nickm＠torproject.org 22 May '18

22 May '18

commit db94d7fed246e617fe953751a8f506f9b57c2fda Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon May 14 18:04:10 2018 -0400 Update cov-diff to handle new gcov, and remove timestamps The new gcov sometimes emits *s if there is a line containing multiple basic blocks, and some are not executed. (The gcov documentation says something weird about this point, so I'm trying to interpret it into the compilerese that I'm familiar with.) That's bug 26101. Also, when we're looking for unique variations in our coverage, we would like cov-diff to suppress timestamps on the diffs. That's bug 26102. Both of these are bugfixes on 0.2.5.1-alpha when the cov-diff script was introduced. My apologies for the perl. --- changes/bug26101_26102 | 5 +++++ scripts/test/cov-diff | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/changes/bug26101_26102 b/changes/bug26101_26102 new file mode 100644 index 000000000..bc3bc84b2 --- /dev/null +++ b/changes/bug26101_26102 @@ -0,0 +1,5 @@ + o Minor bugfixes (test coverage tools): + - Update our "cov-diff" script to handle output from the latest + version of gcov, and to remove extraneous timestamp information + from its output. Fixes bugs 26101 and 26102; bugfix on + 0.2.5.1-alpha. \ No newline at end of file diff --git a/scripts/test/cov-diff b/scripts/test/cov-diff index ed8874d2d..6179dff63 100755 --- a/scripts/test/cov-diff +++ b/scripts/test/cov-diff @@ -10,12 +10,12 @@ DIRB="$2" for B in $DIRB/*; do A=$DIRA/`basename $B` if [ -f $A ]; then - perl -pe 's/^\s*\!*\d+:/ 1:/; s/^([^:]+:)[\d\s]+:/$1/; s/^ *-:(Runs|Programs):.*//;' "$A" > "$A.tmp" + perl -pe 's/^\s*\!*\d+(\*?):/ 1$1:/; s/^([^:]+:)[\d\s]+:/$1/; s/^ *-:(Runs|Programs):.*//;' "$A" > "$A.tmp" else cat /dev/null > "$A.tmp" fi - perl -pe 's/^\s*\!*\d+:/ 1:/; s/^([^:]+:)[\d\s]+:/$1/; s/^ *-:(Runs|Programs):.*//;' "$B" > "$B.tmp" - diff -u "$A.tmp" "$B.tmp" + perl -pe 's/^\s*\!*\d+(\*?):/ 1$1:/; s/^([^:]+:)[\d\s]+:/$1/; s/^ *-:(Runs|Programs):.*//;' "$B" > "$B.tmp" + diff -u "$A.tmp" "$B.tmp" |perl -pe 's/^((?:\+\+\+|---)(?:.*tmp))\s+.*/$1/;' rm "$A.tmp" "$B.tmp" done

1 0

[tor/master] Merge branch 'maint-0.3.3'
by nickm＠torproject.org 22 May '18

22 May '18

commit d2aefffe2f528c26ce6a6594c4ce0fc6d0ac3895 Merge: 943291d7a 3d1266324 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 08:35:41 2018 -0400 Merge branch 'maint-0.3.3' changes/bug25415 | 4 ++++ 1 file changed, 4 insertions(+)

1 0

[tor/master] Fix a crash bug when testing reachability
by nickm＠torproject.org 22 May '18

22 May '18

commit 3d126632430fe60e7ced72bf82cd2c16f297297e Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Mar 4 10:31:17 2018 -0500 Fix a crash bug when testing reachability Fixes bug 25415; bugfix on 0.3.3.2-alpha. --- changes/bug25415 | 4 ++++ src/or/dirserv.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/changes/bug25415 b/changes/bug25415 new file mode 100644 index 000000000..ec851aee8 --- /dev/null +++ b/changes/bug25415 @@ -0,0 +1,4 @@ + o Major bugfixes (directory authority): + - Avoid a crash when testing router reachability on a router that could + have an ed25519 ID, but which does not. Fixes bug 25415; bugfix on + 0.3.3.2-alpha. diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 981efc67f..1c1610ff9 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -3402,7 +3402,8 @@ dirserv_single_reachability_test(time_t now, routerinfo_t *router) tor_assert(node); if (options->AuthDirTestEd25519LinkKeys && - node_supports_ed25519_link_authentication(node, 1)) { + node_supports_ed25519_link_authentication(node, 1) && + router->cache_info.signing_key_cert) { ed_id_key = &router->cache_info.signing_key_cert->signing_key; } else { ed_id_key = NULL;

1 0

[tor/release-0.3.3] Fix a crash bug when testing reachability
by nickm＠torproject.org 22 May '18

22 May '18

commit 3d126632430fe60e7ced72bf82cd2c16f297297e Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Mar 4 10:31:17 2018 -0500 Fix a crash bug when testing reachability Fixes bug 25415; bugfix on 0.3.3.2-alpha. --- changes/bug25415 | 4 ++++ src/or/dirserv.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/changes/bug25415 b/changes/bug25415 new file mode 100644 index 000000000..ec851aee8 --- /dev/null +++ b/changes/bug25415 @@ -0,0 +1,4 @@ + o Major bugfixes (directory authority): + - Avoid a crash when testing router reachability on a router that could + have an ed25519 ID, but which does not. Fixes bug 25415; bugfix on + 0.3.3.2-alpha. diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 981efc67f..1c1610ff9 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -3402,7 +3402,8 @@ dirserv_single_reachability_test(time_t now, routerinfo_t *router) tor_assert(node); if (options->AuthDirTestEd25519LinkKeys && - node_supports_ed25519_link_authentication(node, 1)) { + node_supports_ed25519_link_authentication(node, 1) && + router->cache_info.signing_key_cert) { ed_id_key = &router->cache_info.signing_key_cert->signing_key; } else { ed_id_key = NULL;

1 0

[tor/maint-0.3.3] Fix a crash bug when testing reachability
by nickm＠torproject.org 22 May '18

22 May '18

commit 3d126632430fe60e7ced72bf82cd2c16f297297e Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Mar 4 10:31:17 2018 -0500 Fix a crash bug when testing reachability Fixes bug 25415; bugfix on 0.3.3.2-alpha. --- changes/bug25415 | 4 ++++ src/or/dirserv.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/changes/bug25415 b/changes/bug25415 new file mode 100644 index 000000000..ec851aee8 --- /dev/null +++ b/changes/bug25415 @@ -0,0 +1,4 @@ + o Major bugfixes (directory authority): + - Avoid a crash when testing router reachability on a router that could + have an ed25519 ID, but which does not. Fixes bug 25415; bugfix on + 0.3.3.2-alpha. diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 981efc67f..1c1610ff9 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -3402,7 +3402,8 @@ dirserv_single_reachability_test(time_t now, routerinfo_t *router) tor_assert(node); if (options->AuthDirTestEd25519LinkKeys && - node_supports_ed25519_link_authentication(node, 1)) { + node_supports_ed25519_link_authentication(node, 1) && + router->cache_info.signing_key_cert) { ed_id_key = &router->cache_info.signing_key_cert->signing_key; } else { ed_id_key = NULL;

1 0

[tor/master] remove already-merged changes file
by nickm＠torproject.org 22 May '18

22 May '18

commit 87a7748a8489160ffce966e663dc1e25de1c734e Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 08:36:03 2018 -0400 remove already-merged changes file --- changes/bug25415 | 4 ---- 1 file changed, 4 deletions(-) diff --git a/changes/bug25415 b/changes/bug25415 deleted file mode 100644 index ec851aee8..000000000 --- a/changes/bug25415 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (directory authority): - - Avoid a crash when testing router reachability on a router that could - have an ed25519 ID, but which does not. Fixes bug 25415; bugfix on - 0.3.3.2-alpha.

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 22 May '18

22 May '18

commit c91c4e9bb69113feee91f0056ca9aea7adc538fd Merge: f15e1e65c 3d1266324 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 08:35:41 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug25415 | 4 ++++ src/or/dirserv.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[translation/support-topics_completed] Update translations for support-topics_completed
by translation＠torproject.org 22 May '18

22 May '18

commit df0dd48a5f966a475dde0f2210ae0b7333aa9d07 Author: Translation commit bot <translation(a)torproject.org> Date: Tue May 22 12:19:44 2018 +0000 Update translations for support-topics_completed --- it.json | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/it.json b/it.json index 51b8e3d58..ce4b13b14 100644 --- a/it.json +++ b/it.json @@ -5,18 +5,18 @@ "label": "Domande più frequenti" }, "tbb": { - "path": "#tor-browser", - "control": "tor-browser", + "path": "#tbb", + "control": "tbb", "label": "Tor Browser" }, "tormessenger": { - "path": "#tor-messenger", - "control": "tor-messenger", + "path": "#tormessenger", + "control": "tormessenger", "label": "Tor Messenger" }, "tormobile": { - "path": "#tor-mobile", - "control": "tor-mobile", + "path": "#tormobile", + "control": "tormobile", "label": "Tor Mobile" }, "gettor": { @@ -25,8 +25,8 @@ "label": "OttieniTor" }, "connecting": { - "path": "#connessione-a-tor", - "control": "connessione-a-tor", + "path": "#connessioneator", + "control": "connessioneator", "label": "Connessione a Tor" }, "censorship": { @@ -45,8 +45,8 @@ "label": "Operatori" }, "onionservices": { - "path": "#servizi-onion", - "control": "servizi-onion", + "path": "#servizionion", + "control": "servizionion", "label": "Servizi Onion" }, "misc": {

1 0

[translation/support-topics] Update translations for support-topics
by translation＠torproject.org 22 May '18

22 May '18

commit 1e8a4bc90715fbe59ff4f5685d3a65c1fe89490c Author: Translation commit bot <translation(a)torproject.org> Date: Tue May 22 12:19:40 2018 +0000 Update translations for support-topics --- it.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/it.json b/it.json index 7f29e7105..ce4b13b14 100644 --- a/it.json +++ b/it.json @@ -25,8 +25,8 @@ "label": "OttieniTor" }, "connecting": { - "path": "#connectingtotor", - "control": "connectingtotor", + "path": "#connessioneator", + "control": "connessioneator", "label": "Connessione a Tor" }, "censorship": { @@ -45,8 +45,8 @@ "label": "Operatori" }, "onionservices": { - "path": "#onionservices", - "control": "onionservices", + "path": "#servizionion", + "control": "servizionion", "label": "Servizi Onion" }, "misc": {

1 0

[translation/torbirdy] Update translations for torbirdy
by translation＠torproject.org 22 May '18

22 May '18

commit 7253c1e9c843531a72935469bd1b84bfc8711bf5 Author: Translation commit bot <translation(a)torproject.org> Date: Tue May 22 12:15:59 2018 +0000 Update translations for torbirdy --- gl/torbirdy.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gl/torbirdy.dtd b/gl/torbirdy.dtd index 28728be17..b95c2556b 100644 --- a/gl/torbirdy.dtd +++ b/gl/torbirdy.dtd @@ -17,7 +17,7 @@ <!ENTITY torbirdy.prefs.testproxy.button "Test Proxy Settings"> <!ENTITY torbirdy.prefs.testproxy.key "n"> <!ENTITY torbirdy.prefs.proxy.label "Proxy"> -<!ENTITY torbirdy.prefs.privacy.label "Privacy"> +<!ENTITY torbirdy.prefs.privacy.label "Privacidade"> <!ENTITY torbirdy.prefs.enigmail.label "Enigmail"> <!ENTITY torbirdy.prefs.recommended.text "Use the recommended proxy settings for TorBirdy (Tor)"> <!ENTITY torbirdy.prefs.recommended.key "r">

1 0