May 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.2] backport changelog entries for #24972 correctly
by arma＠torproject.org 22 May '18

22 May '18

commit f3b53391e8ff61eda6c2cdfa744e603565922cdb Author: Roger Dingledine <arma(a)torproject.org> Date: Tue May 22 14:26:34 2018 -0400 backport changelog entries for #24972 correctly --- ChangeLog | 4 ++-- ReleaseNotes | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8980ec9ef..870f8ebd5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -96,8 +96,8 @@ Changes in version 0.3.2.10 - 2018-03-03 Country database. o Minor features (logging, diagnostic, backport from 0.3.3.2-alpha): - - When logging a failure to check a hidden service's certificate, - also log what the problem with the certificate was. Diagnostic + - When logging a failure to create an onion service's descriptor, + also log what the problem with the descriptor was. Diagnostic for ticket 24972. o Minor bugfix (channel connection, backport from 0.3.3.2-alpha): diff --git a/ReleaseNotes b/ReleaseNotes index 671f2ff48..1ce162c8b 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -100,8 +100,8 @@ Changes in version 0.3.2.10 - 2018-03-03 Country database. o Minor features (logging, diagnostic, backport from 0.3.3.2-alpha): - - When logging a failure to check a hidden service's certificate, - also log what the problem with the certificate was. Diagnostic + - When logging a failure to create an onion service's descriptor, + also log what the problem with the descriptor was. Diagnostic for ticket 24972. o Minor bugfix (channel connection, backport from 0.3.3.2-alpha):

1 0

[tor/release-0.3.3] remove items from 0.3.3.6 that are already in 0.3.2.10
by arma＠torproject.org 22 May '18

22 May '18

commit 00e7e324d1d38aa66d61d90ee20c2a5577815653 Author: Roger Dingledine <arma(a)torproject.org> Date: Tue May 22 14:22:51 2018 -0400 remove items from 0.3.3.6 that are already in 0.3.2.10 --- ReleaseNotes | 123 +---------------------------------------------------------- 1 file changed, 1 insertion(+), 122 deletions(-) diff --git a/ReleaseNotes b/ReleaseNotes index d63f87ccb..46240d183 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -7,7 +7,7 @@ Changes in version 0.3.3.6 - 2018-05-22 backports several important fixes from the 0.3.4.1-alpha. The Tor 0.3.3 series includes several important features, including - improved denial-of-service resistance, controller support and other + controller support and other improvements for v3 onion services, and official support for embedding Tor within other applications. It also include our first non-trivial module written in the Rust programming language. (Rust is still not @@ -28,20 +28,6 @@ Changes in version 0.3.3.6 - 2018-05-22 bugfix on 0.2.9.4-alpha. This issue is also tracked as TROVE-2018-005. - o Major features (denial-of-service mitigation): - - Give relays some defenses against the recent network overload. We - start with three defenses (default parameters in parentheses). - First: if a single client address makes too many concurrent - connections (>100), hang up on further connections. Second: if a - single client address makes circuits too quickly (more than 3 per - second, with an allowed burst of 90) while also having too many - connections open (3), refuse new create cells for the next while - (1-2 hours). Third: if a client asks to establish a rendezvous - point to you directly, ignore the request. These defenses can be - manually controlled by new torrc options, but relays will also - take guidance from consensus parameters, so there's no need to - configure anything manually. Implements ticket 24902. - o Major features (embedding): - There is now a documented stable API for programs that need to embed Tor. See tor_api.h for full documentation and known bugs. @@ -114,12 +100,6 @@ Changes in version 0.3.3.6 - 2018-05-22 if we fail to allow any circuits to actually complete. Fixes bug 25733; bugfix on 0.2.2.2-alpha. - o Major bugfixes (denial-of-service, directory authority): - - Fix a protocol-list handling bug that could be used to remotely crash - directory authorities with a null-pointer exception. Fixes bug 25074; - bugfix on 0.2.9.4-alpha. Also tracked as TROVE-2018-001 and - CVE-2018-0490. - o Major bugfixes (netflow padding): - Stop adding unneeded channel padding right after we finish flushing to a connection that has been trying to flush for many @@ -133,18 +113,6 @@ Changes in version 0.3.3.6 - 2018-05-22 - Correctly detect when onion services get disabled after HUP. Fixes bug 25761; bugfix on 0.3.2.1. - o Major bugfixes (onion services, retry behavior): - - Fix an "off by 2" error in counting rendezvous failures on the - onion service side. While we thought we would stop the rendezvous - attempt after one failed circuit, we were actually making three - circuit attempts before giving up. Now switch to a default of 2, - and allow the consensus parameter "hs_service_max_rdv_failures" to - override. Fixes bug 24895; bugfix on 0.0.6. - - New-style (v3) onion services now obey the "max rendezvous circuit - attempts" logic. Previously they would make as many rendezvous - circuit attempts as they could fit in the MAX_REND_TIMEOUT second - window before giving up. Fixes bug 24894; bugfix on 0.3.2.1-alpha. - o Major bugfixes (performance, load balancing): - Directory authorities no longer vote in favor of the Guard flag for relays without directory support. Starting in Tor @@ -153,31 +121,16 @@ Changes in version 0.3.3.6 - 2018-05-22 the 5%-or-so of Guards that don't advertise directory support. Fixes bug 22310; bugfix on 0.3.0.6. - o Major bugfixes (protocol versions): - - Add Link protocol version 5 to the supported protocols list. Fixes - bug 25070; bugfix on 0.3.1.1-alpha. - o Major bugfixes (relay): - If we have failed to connect to a relay and received a connection refused, timeout, or similar error (at the TCP level), do not try that same address/port again for 60 seconds after the failure has occurred. Fixes bug 24767; bugfix on 0.0.6. - - Fix a set of false positives where relays would consider - connections to other relays as being client-only connections (and - thus e.g. deserving different link padding schemes) if those - relays fell out of the consensus briefly. Now we look only at the - initial handshake and whether the connection authenticated as a - relay. Fixes bug 24898; bugfix on 0.3.1.1-alpha. o Major bugfixes (relay, denial of service, backport from 0.3.4.1-alpha): - Impose a limit on circuit cell queue size. The limit can be controlled by a consensus parameter. Fixes bug 25226; bugfix on 0.2.4.14-alpha. - o Major bugfixes (scheduler, consensus): - - The scheduler subsystem was failing to promptly notice changes in - consensus parameters, making it harder to switch schedulers - network-wide. Fixes bug 24975; bugfix on 0.3.2.1-alpha. - o Minor features (cleanup): - Tor now deletes the CookieAuthFile and ExtORPortCookieAuthFile when it stops. Closes ticket 23271. @@ -186,13 +139,6 @@ Changes in version 0.3.3.6 - 2018-05-22 - Avoid some compilation warnings with recent versions of LibreSSL. Closes ticket 26006. - o Minor features (compatibility, OpenSSL): - - Tor will now support TLS1.3 once OpenSSL 1.1.1 is released. - Previous versions of Tor would not have worked with OpenSSL 1.1.1, - since they neither disabled TLS 1.3 nor enabled any of the - ciphersuites it requires. Now we enable the TLS 1.3 ciphersuites. - Closes ticket 24978. - o Minor features (config options): - Change the way the default value for MaxMemInQueues is calculated. We now use 40% of the hardware RAM if the system has 8 GB RAM or @@ -221,11 +167,6 @@ Changes in version 0.3.3.6 - 2018-05-22 node_get_ed25519_id() before returning them. Implements 24001, patch by "aruna1234". - o Minor features (denial-of-service avoidance): - - Make our OOM handler aware of the geoip client history cache so it - doesn't fill up the memory. This check is important for IPv6 and - our DoS mitigation subsystem. Closes ticket 25122. - o Minor features (directory authority): - When directory authorities are unable to add signatures to a pending consensus, log the reason why. Closes ticket 24849. @@ -334,9 +275,6 @@ Changes in version 0.3.3.6 - 2018-05-22 entropy-generation mechanism gives an error. Closes ticket 25120. - Added support for the Android logging subsystem. Closes ticket 24362. - - When logging a failure to create an onion service's descriptor, - also log what the problem with the descriptor was. Diagnostic for - ticket 24972. o Minor features (performance): - Support predictive circuit building for onion service circuits @@ -394,9 +332,6 @@ Changes in version 0.3.3.6 - 2018-05-22 - Fix output of autoconf checks to display success messages for Rust dependencies and a suitable rustc compiler version. Fixes bug 24612; bugfix on 0.3.1.3-alpha. - - When building with Rust on OSX, link against libresolv, to work - around the issue at https://github.com/rust-lang/rust/issues/46797. - Fixes bug 24652; bugfix on 0.3.1.1-alpha. - Don't pass the --quiet option to cargo: it seems to suppress some errors, which is not what we want to do when building. Fixes bug 24518; bugfix on 0.3.1.7. @@ -409,12 +344,6 @@ Changes in version 0.3.3.6 - 2018-05-22 dereference. Fixes bug 25629; bugfix on 0.2.9.15. Found by Coverity; this is CID 1430932. - o Minor bugfixes (channel connection): - - Use the actual observed address of an incoming relay connection, - not the canonical address of the relay from its descriptor, when - making decisions about how to handle the incoming connection. - Fixes bug 24952; bugfix on 0.2.4.11-alpha. Patch by "ffmancera". - o Minor bugfixes (channel, client): - Better identify client connection when reporting to the geoip client cache. Fixes bug 24904; bugfix on 0.3.1.7. @@ -454,26 +383,12 @@ Changes in version 0.3.3.6 - 2018-05-22 continue processing the cell as if the connection were open. Fixes bug 26072; bugfix on 0.2.4.7-alpha. - o Minor bugfixes (denial-of-service): - - Fix a possible crash on malformed consensus. If a consensus had - contained an unparseable protocol line, it could have made clients - and relays crash with a null-pointer exception. To exploit this - issue, however, an attacker would need to be able to subvert the - directory authority system. Fixes bug 25251; bugfix on - 0.2.9.4-alpha. Also tracked as TROVE-2018-004. - o Minor bugfixes (directory authorities, IPv6): - When creating a routerstatus (vote) from a routerinfo (descriptor), set the IPv6 address to the unspecified IPv6 address, and explicitly initialize the port to zero. Fixes bug 24488; bugfix on 0.2.4.1-alpha. - o Minor bugfixes (directory authority): - - Directory authorities, when refusing a descriptor from a rejected - relay, now explicitly tell the relay (in its logs) to set a valid - ContactInfo address and contact the bad-relays@ mailing list. - Fixes bug 25170; bugfix on 0.2.9.1. - o Minor bugfixes (documentation): - Document that the PerConnBW{Rate,Burst} options will fall back to their corresponding consensus parameters only if those parameters @@ -530,9 +445,6 @@ Changes in version 0.3.3.6 - 2018-05-22 sleep() and usleep(). Fixes bug 24969; bugfix on 0.2.5.1-alpha. o Minor bugfixes (logging): - - Don't treat inability to store a cached consensus object as a bug: - it can happen normally when we are out of disk space. Fixes bug - 24859; bugfix on 0.3.1.1-alpha. - Fix a (mostly harmless) race condition when invoking LOG_PROTOCOL_WARN message from a subthread while the torrc options are changing. Fixes bug 23954; bugfix on 0.1.1.9-alpha. @@ -578,19 +490,10 @@ Changes in version 0.3.3.6 - 2018-05-22 Fixes bug 26069; bugfix on 0.3.0.1-alpha. o Minor bugfixes (onion services): - - Remove a BUG() statement when a client fetches an onion descriptor - that has a lower revision counter than the one in its cache. This - can happen in normal circumstances due to HSDir desync. Fixes bug - 24976; bugfix on 0.3.2.1-alpha. - If we are configured to offer a single onion service, don't log long-term established one hop rendezvous points in the heartbeat. Fixes bug 25116; bugfix on 0.2.9.6-rc. - o Minor bugfixes (OSX): - - Don't exit the Tor process if setrlimit() fails to change the file - limit (which can happen sometimes on some versions of OSX). Fixes - bug 21074; bugfix on 0.0.9pre5. - o Minor bugfixes (performance): - Reduce the number of circuits that will be opened at once during the circuit build timeout phase. This is done by increasing the @@ -604,11 +507,6 @@ Changes in version 0.3.3.6 - 2018-05-22 a little, and saves a large amount of short-term memory allocation operations. Fixes bug 25008; bugfix on 0.2.9.4-alpha. - o Minor bugfixes (performance, fragile-hardening): - - Improve the performance of our consensus-diff application code - when Tor is built with the --enable-fragile-hardening option set. - Fixes bug 24826; bugfix on 0.3.1.1-alpha. - o Minor bugfixes (performance, timeouts): - Consider circuits for timeout as soon as they complete a hop. This is more accurate than applying the timeout in @@ -640,12 +538,6 @@ Changes in version 0.3.3.6 - 2018-05-22 list, which would waste CPU cycles. Fixes bug 24700; bugfix on 0.3.2.1-alpha. - o Minor bugfixes (spec conformance): - - Forbid "-0" as a protocol version. Fixes part of bug 25249; bugfix on - 0.2.9.4-alpha. - - Forbid UINT32_MAX as a protocol version. Fixes part of bug 25249; - bugfix on 0.2.9.4-alpha. - o Minor bugfixes (spelling): - Use the "misspell" tool to detect and fix typos throughout the source code. Fixes bug 23650; bugfix on various versions of Tor. @@ -658,8 +550,6 @@ Changes in version 0.3.3.6 - 2018-05-22 on 0.3.1.3-alpha. - Give out Exit flags in bootstrapping networks. Fixes bug 24137; bugfix on 0.2.3.1-alpha. - - Fix a memory leak in the scheduler/loop_kist unit test. Fixes bug - 25005; bugfix on 0.3.2.7-rc. o Minor bugfixes (unit test, monotonic time): - Increase a constant (1msec to 10msec) in the monotonic time test @@ -668,20 +558,12 @@ Changes in version 0.3.3.6 - 2018-05-22 when the clock_gettime() is not a VDSO on the running kernel. Fixes bug 25113; bugfix on 0.2.9.1. - o Minor bugfixes (v3 onion services): - - Look at the "HSRend" protocol version, not the "HSDir" protocol - version, when deciding whether a consensus entry can support the - v3 onion service protocol as a rendezvous point. Fixes bug 25105; - bugfix on 0.3.2.1-alpha. - o Code simplification and refactoring: - Move the list of default directory authorities to its own file. Closes ticket 24854. Patch by "beastr0". - Remove the old (deterministic) directory retry logic entirely: We've used exponential backoff exclusively for some time. Closes ticket 23814. - - Update the "rust dependencies" submodule to be a project-level - repository, rather than a user repository. Closes ticket 25323. - Remove the unused nodelist_recompute_all_hsdir_indices(). Closes ticket 25108. - Remove a series of counters used to track circuit extend attempts @@ -725,9 +607,6 @@ Changes in version 0.3.3.6 - 2018-05-22 traffic. Closes ticket 24318. - Document that OutboundBindAddress doesn't apply to DNS requests. Closes ticket 22145. Patch from Aruna Maurya. - - Document that operators who run more than one relay or bridge are - expected to set MyFamily and ContactInfo correctly. Closes - ticket 24526. o Code simplification and refactoring (channels): - Remove the incoming and outgoing channel queues. These were never

1 0

[tor/master] avoid a signed/unsigned comparison.
by nickm＠torproject.org 22 May '18

22 May '18

commit 7483aef896654a02ae1fa7ae616fbd1f2c27f3c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:12:44 2018 -0400 avoid a signed/unsigned comparison. --- src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/protover.c b/src/or/protover.c index ae6cda092..13dd6549e 100644 --- a/src/or/protover.c +++ b/src/or/protover.c @@ -201,7 +201,7 @@ parse_single_entry(const char *s, const char *end_of_entry) goto error; /* The name must not be longer than MAX_PROTOCOL_NAME_LENGTH. */ - if (equals - s > MAX_PROTOCOL_NAME_LENGTH) { + if (equals - s > (int)MAX_PROTOCOL_NAME_LENGTH) { log_warn(LD_NET, "When parsing a protocol entry, I got a very large " "protocol name. This is possibly an attack or a bug, unless " "the Tor network truly supports protocol names larger than "

1 0

[tor/master] Merge branch 'trove-2018-005_032' into maint-0.3.3
by nickm＠torproject.org 22 May '18

22 May '18

commit 80d673ccea4d6f784052dc5bc55cec04647556e7 Merge: a5d4ce2b3 7483aef89 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:13:23 2018 -0400 Merge branch 'trove-2018-005_032' into maint-0.3.3 src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/master] Merge branch 'maint-0.3.3'
by nickm＠torproject.org 22 May '18

22 May '18

commit 38f8b3c63deb5b4e9daaef1035574afbbb2f35d9 Merge: cde5c9d0c 80d673cce Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:13:28 2018 -0400 Merge branch 'maint-0.3.3' src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/release-0.3.3] Merge branch 'trove-2018-005_032' into maint-0.3.3
by nickm＠torproject.org 22 May '18

22 May '18

commit 80d673ccea4d6f784052dc5bc55cec04647556e7 Merge: a5d4ce2b3 7483aef89 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:13:23 2018 -0400 Merge branch 'trove-2018-005_032' into maint-0.3.3 src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/release-0.3.3] avoid a signed/unsigned comparison.
by nickm＠torproject.org 22 May '18

22 May '18

commit 7483aef896654a02ae1fa7ae616fbd1f2c27f3c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:12:44 2018 -0400 avoid a signed/unsigned comparison. --- src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/protover.c b/src/or/protover.c index ae6cda092..13dd6549e 100644 --- a/src/or/protover.c +++ b/src/or/protover.c @@ -201,7 +201,7 @@ parse_single_entry(const char *s, const char *end_of_entry) goto error; /* The name must not be longer than MAX_PROTOCOL_NAME_LENGTH. */ - if (equals - s > MAX_PROTOCOL_NAME_LENGTH) { + if (equals - s > (int)MAX_PROTOCOL_NAME_LENGTH) { log_warn(LD_NET, "When parsing a protocol entry, I got a very large " "protocol name. This is possibly an attack or a bug, unless " "the Tor network truly supports protocol names larger than "

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 22 May '18

22 May '18

commit 67da2d94119aaf7c843f88ff63302f7ff52218bf Merge: 025670236 80d673cce Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:13:28 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/maint-0.3.3] avoid a signed/unsigned comparison.
by nickm＠torproject.org 22 May '18

22 May '18

commit 7483aef896654a02ae1fa7ae616fbd1f2c27f3c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:12:44 2018 -0400 avoid a signed/unsigned comparison. --- src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/protover.c b/src/or/protover.c index ae6cda092..13dd6549e 100644 --- a/src/or/protover.c +++ b/src/or/protover.c @@ -201,7 +201,7 @@ parse_single_entry(const char *s, const char *end_of_entry) goto error; /* The name must not be longer than MAX_PROTOCOL_NAME_LENGTH. */ - if (equals - s > MAX_PROTOCOL_NAME_LENGTH) { + if (equals - s > (int)MAX_PROTOCOL_NAME_LENGTH) { log_warn(LD_NET, "When parsing a protocol entry, I got a very large " "protocol name. This is possibly an attack or a bug, unless " "the Tor network truly supports protocol names larger than "

1 0

[tor/maint-0.3.3] Merge branch 'trove-2018-005_032' into maint-0.3.3
by nickm＠torproject.org 22 May '18

22 May '18

commit 80d673ccea4d6f784052dc5bc55cec04647556e7 Merge: a5d4ce2b3 7483aef89 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 22 14:13:23 2018 -0400 Merge branch 'trove-2018-005_032' into maint-0.3.3 src/or/protover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0