May 2018 - tor-commits - lists.torproject.org

[tor/master] Mark the 1-per-sec update_current_time() call as redundant.
by nickm＠torproject.org 09 May '18

09 May '18

commit c9f07f36bf986f274ac9fc56b5c61bbcc669b22e Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 3 12:23:55 2018 -0400 Mark the 1-per-sec update_current_time() call as redundant. We still do this time update here, since we do it from all callbacks, but it is no longer a reason to keep the once-per-second callback enabled. Closes ticket 26009. --- changes/ticket26009 | 9 +++++++++ src/or/main.c | 6 +++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/changes/ticket26009 b/changes/ticket26009 new file mode 100644 index 000000000..51ada1572 --- /dev/null +++ b/changes/ticket26009 @@ -0,0 +1,9 @@ + o Minor features (mainloop): + - Move responsibility for + keeping track of Tor's uptime + from a nce-per-second callback to a callback that is only scheduled as + needed. Once enough items are removed from our once-per-second + callback, we can eliminate it entirely to conserve CPU when idle. + Closes ticket + 26009. + diff --git a/src/or/main.c b/src/or/main.c index e82162c39..b6035fa76 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -2576,8 +2576,12 @@ second_elapsed_callback(periodic_timer_t *timer, void *arg) n_libevent_errors = 0; - /* log_notice(LD_GENERAL, "Tick."); */ now = time(NULL); + + /* We don't need to do this once-per-second any more: time-updating is + * only in this callback _because it is a callback_. It should be fine + * to disable this callback, and the time will still get updated. + */ update_current_time(now); /* the second has rolled over. check more stuff. */

1 0

[webwml/master] Add new Tor Browser version: 7.5.4
by boklm＠torproject.org 09 May '18

09 May '18

commit cd2fb4c68242ba92d2cd9e169a22b5daa7a321e0 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Wed May 9 19:34:31 2018 +0200 Add new Tor Browser version: 7.5.4 --- include/versions.wmi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/versions.wmi b/include/versions.wmi index 4acd207b..cb255f72 100644 --- a/include/versions.wmi +++ b/include/versions.wmi @@ -4,8 +4,8 @@ <define-tag version-torbrowserdevelopbranch whitespace=delete>maint-7.5</define-tag> # *** tor browser stable *** -<define-tag version-torbrowserbundle-all whitespace=delete>7.5.3</define-tag> -<define-tag releasedate-torbrowserbundle-all whitespace=delete>2018-03-26</define-tag> +<define-tag version-torbrowserbundle-all whitespace=delete>7.5.4</define-tag> +<define-tag releasedate-torbrowserbundle-all whitespace=delete>2018-05-09</define-tag> <define-tag version-win32-stable whitespace=delete>0.3.2.10</define-tag> # If all platforms are on the same version, you only need to update

1 0

[tor/maint-0.3.2] Detect when v2 services get disabled after HUP.
by nickm＠torproject.org 09 May '18

09 May '18

commit 5dc00c06615ef1e99e1d82dfdf41823c0d4bf7f6 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue May 8 18:07:08 2018 +0300 Detect when v2 services get disabled after HUP. During service configuration, rend_service_prune_list_impl_() sets rend_service_staging_list to NULL, which blocked pruning after a HUP. This patch initializes rend_service_staging_list when needed, so that HUP can detect disabled onion services. Fixes bug #25761. --- src/or/rendservice.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/or/rendservice.c b/src/or/rendservice.c index 2c5c5840a..fed8c97eb 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -618,10 +618,11 @@ void rend_service_prune_list(void) { smartlist_t *old_service_list = rend_service_list; - /* Don't try to prune anything if we have no staging list. */ + if (!rend_service_staging_list) { - return; + rend_service_staging_list = smartlist_new(); } + rend_service_prune_list_impl_(); if (old_service_list) { /* Every remaining service in the old list have been removed from the

1 0

[tor/maint-0.3.3] Detect when v3 services get disabled after HUP.
by nickm＠torproject.org 09 May '18

09 May '18

commit 7e8c5e36622d4581840bb0a037a66d9504c433a5 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue May 8 18:14:02 2018 +0300 Detect when v3 services get disabled after HUP. Remove v3 optimization which made Tor not detect disabling services. This optimization is not so needed because we only call that function after HUP anyway. Fixes bug #25761. --- changes/bug25761 | 3 +++ src/or/hs_service.c | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/changes/bug25761 b/changes/bug25761 new file mode 100644 index 000000000..096fadcf0 --- /dev/null +++ b/changes/bug25761 @@ -0,0 +1,3 @@ + o Major bugfixes (onion service): + - Correctly detect when onion services get disabled after HUP. + Fixes bug 25761; bugfix on 0.3.2.1. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 8ddd68c69..b9a1dfc36 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -859,11 +859,6 @@ register_all_services(void) tor_assert(hs_service_staging_list); - /* We'll save us some allocation and computing time. */ - if (smartlist_len(hs_service_staging_list) == 0) { - return; - } - /* Allocate a new map that will replace the current one. */ new_service_map = tor_malloc_zero(sizeof(*new_service_map)); HT_INIT(hs_service_ht, new_service_map);

1 0

[tor/maint-0.3.2] Detect when v3 services get disabled after HUP.
by nickm＠torproject.org 09 May '18

09 May '18

commit 7e8c5e36622d4581840bb0a037a66d9504c433a5 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue May 8 18:14:02 2018 +0300 Detect when v3 services get disabled after HUP. Remove v3 optimization which made Tor not detect disabling services. This optimization is not so needed because we only call that function after HUP anyway. Fixes bug #25761. --- changes/bug25761 | 3 +++ src/or/hs_service.c | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/changes/bug25761 b/changes/bug25761 new file mode 100644 index 000000000..096fadcf0 --- /dev/null +++ b/changes/bug25761 @@ -0,0 +1,3 @@ + o Major bugfixes (onion service): + - Correctly detect when onion services get disabled after HUP. + Fixes bug 25761; bugfix on 0.3.2.1. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 8ddd68c69..b9a1dfc36 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -859,11 +859,6 @@ register_all_services(void) tor_assert(hs_service_staging_list); - /* We'll save us some allocation and computing time. */ - if (smartlist_len(hs_service_staging_list) == 0) { - return; - } - /* Allocate a new map that will replace the current one. */ new_service_map = tor_malloc_zero(sizeof(*new_service_map)); HT_INIT(hs_service_ht, new_service_map);

1 0

[tor/maint-0.3.2] Merge remote-tracking branch 'asn-github/bug25761_032' into maint-0.3.2
by nickm＠torproject.org 09 May '18

09 May '18

commit 394f102ea6b0494cde97769a99d75e91b5743616 Merge: be5b4415c 7e8c5e366 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed May 9 11:53:15 2018 -0400 Merge remote-tracking branch 'asn-github/bug25761_032' into maint-0.3.2 changes/bug25761 | 3 +++ src/or/hs_service.c | 5 ----- src/or/rendservice.c | 5 +++-- 3 files changed, 6 insertions(+), 7 deletions(-)

1 0

[tor/maint-0.3.3] Merge remote-tracking branch 'asn-github/bug25761_032' into maint-0.3.2
by nickm＠torproject.org 09 May '18

09 May '18

commit 394f102ea6b0494cde97769a99d75e91b5743616 Merge: be5b4415c 7e8c5e366 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed May 9 11:53:15 2018 -0400 Merge remote-tracking branch 'asn-github/bug25761_032' into maint-0.3.2 changes/bug25761 | 3 +++ src/or/hs_service.c | 5 ----- src/or/rendservice.c | 5 +++-- 3 files changed, 6 insertions(+), 7 deletions(-)

1 0

[tor/maint-0.3.3] Detect when v2 services get disabled after HUP.
by nickm＠torproject.org 09 May '18

09 May '18

commit 5dc00c06615ef1e99e1d82dfdf41823c0d4bf7f6 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue May 8 18:07:08 2018 +0300 Detect when v2 services get disabled after HUP. During service configuration, rend_service_prune_list_impl_() sets rend_service_staging_list to NULL, which blocked pruning after a HUP. This patch initializes rend_service_staging_list when needed, so that HUP can detect disabled onion services. Fixes bug #25761. --- src/or/rendservice.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/or/rendservice.c b/src/or/rendservice.c index 2c5c5840a..fed8c97eb 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -618,10 +618,11 @@ void rend_service_prune_list(void) { smartlist_t *old_service_list = rend_service_list; - /* Don't try to prune anything if we have no staging list. */ + if (!rend_service_staging_list) { - return; + rend_service_staging_list = smartlist_new(); } + rend_service_prune_list_impl_(); if (old_service_list) { /* Every remaining service in the old list have been removed from the

1 0

[tor/master] Detect when v3 services get disabled after HUP.
by nickm＠torproject.org 09 May '18

09 May '18

commit 7e8c5e36622d4581840bb0a037a66d9504c433a5 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue May 8 18:14:02 2018 +0300 Detect when v3 services get disabled after HUP. Remove v3 optimization which made Tor not detect disabling services. This optimization is not so needed because we only call that function after HUP anyway. Fixes bug #25761. --- changes/bug25761 | 3 +++ src/or/hs_service.c | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/changes/bug25761 b/changes/bug25761 new file mode 100644 index 000000000..096fadcf0 --- /dev/null +++ b/changes/bug25761 @@ -0,0 +1,3 @@ + o Major bugfixes (onion service): + - Correctly detect when onion services get disabled after HUP. + Fixes bug 25761; bugfix on 0.3.2.1. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 8ddd68c69..b9a1dfc36 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -859,11 +859,6 @@ register_all_services(void) tor_assert(hs_service_staging_list); - /* We'll save us some allocation and computing time. */ - if (smartlist_len(hs_service_staging_list) == 0) { - return; - } - /* Allocate a new map that will replace the current one. */ new_service_map = tor_malloc_zero(sizeof(*new_service_map)); HT_INIT(hs_service_ht, new_service_map);

1 0

[tor/release-0.3.2] Detect when v2 services get disabled after HUP.
by nickm＠torproject.org 09 May '18

09 May '18

commit 5dc00c06615ef1e99e1d82dfdf41823c0d4bf7f6 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue May 8 18:07:08 2018 +0300 Detect when v2 services get disabled after HUP. During service configuration, rend_service_prune_list_impl_() sets rend_service_staging_list to NULL, which blocked pruning after a HUP. This patch initializes rend_service_staging_list when needed, so that HUP can detect disabled onion services. Fixes bug #25761. --- src/or/rendservice.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/or/rendservice.c b/src/or/rendservice.c index 2c5c5840a..fed8c97eb 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -618,10 +618,11 @@ void rend_service_prune_list(void) { smartlist_t *old_service_list = rend_service_list; - /* Don't try to prune anything if we have no staging list. */ + if (!rend_service_staging_list) { - return; + rend_service_staging_list = smartlist_new(); } + rend_service_prune_list_impl_(); if (old_service_list) { /* Every remaining service in the old list have been removed from the

1 0