April 2018 - tor-commits - lists.torproject.org

[snowflake/master] Add the `cake build` hint to proxy/README.md.
by dcf＠torproject.org 16 Apr '18

16 Apr '18

commit 01d1f951e59560e367f6da6a2ef56c75e79eb954 Author: David Fifield <david(a)bamsoftware.com> Date: Sun Apr 15 17:12:55 2018 -0700 Add the `cake build` hint to proxy/README.md. It was already in the root README.md, but proxy/README.md is where I always look for it. --- proxy/README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/proxy/README.md b/proxy/README.md index ca08b21..5f63cce 100644 --- a/proxy/README.md +++ b/proxy/README.md @@ -7,6 +7,13 @@ See [keroserene.net/snowflake](https://keroserene.net/snowflake) for more info: <iframe src="https://keroserene.net/snowflake/embed.html" width="88" height="16" frameborder="0" scrolling="no"></iframe> ``` +### Building + +``` +cake build +``` +(Type `cake` by itself to see possible commands) + ### Testing Unit testing with Jasmine are available with:

1 0

[snowflake/master] Documentation fix: current default relay.
by dcf＠torproject.org 16 Apr '18

16 Apr '18

commit 2e59838faf3acad9bd481b665896b32fe078d23c Author: David Fifield <david(a)bamsoftware.com> Date: Sun Apr 15 17:05:07 2018 -0700 Documentation fix: current default relay. Was missed in 3fe10f3e7c39991193f4322fee55c7067d21831d. --- proxy/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxy/README.md b/proxy/README.md index 2a0f7ea..ca08b21 100644 --- a/proxy/README.md +++ b/proxy/README.md @@ -23,7 +23,7 @@ To run locally, either: ### Parameters With no parameters, -snowflake uses the default relay `192.81.135.242:9902` and +snowflake uses the default relay `snowflake.bamsoftware.com:443` and uses automatic signaling with the default broker at `https://snowflake-reg.appspot.com/`.

1 0

[metrics-web/master] Update news.json to version 255 of doc/MetricsTimeline.
by karsten＠torproject.org 15 Apr '18

15 Apr '18

commit d425de8f8a22e256398977e812fa69550506eb57 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Sun Apr 15 22:41:42 2018 +0200 Update news.json to version 255 of doc/MetricsTimeline. --- src/main/resources/web/json/news.json | 89 +++++++++++++++++++++++++++++++++-- 1 file changed, 86 insertions(+), 3 deletions(-) diff --git a/src/main/resources/web/json/news.json b/src/main/resources/web/json/news.json index c503aa1..8385b6e 100644 --- a/src/main/resources/web/json/news.json +++ b/src/main/resources/web/json/news.json @@ -429,7 +429,7 @@ }, { "start": "2012-02-08", - "ongoing": true, + "end": "2012-02-11", "places": [ "ir" ], @@ -442,6 +442,14 @@ { "label": "blog post", "target": "https://blog.torproject.org/iran-partially-blocks-encrypted-network-traffic" + }, + { + "label": "relay graph", + "target": "https://metrics.torproject.org/userstats-relay-country.html?start=2012-01-0…" + }, + { + "label": "bridge graph", + "target": "https://metrics.torproject.org/userstats-bridge-country.html?start=2012-01-…" } ] }, @@ -4489,6 +4497,10 @@ { "label": "comment", "target": "https://bugs.torproject.org/21312#comment:63" + }, + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" } ] }, @@ -4497,8 +4509,14 @@ "protocols": [ "snowflake" ], - "shortDescription": "Provisonally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited.", - "description": "Provisonally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited." + "shortDescription": "Provisionally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited.", + "description": "Provisionally increased memory limits of the fallback snowflake proxies to 400 MB, 800 MB, or unlimited.", + "links": [ + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" + } + ] }, { "start": "2018-03-23", @@ -4511,6 +4529,10 @@ { "label": "comment", "target": "https://bugs.torproject.org/21312#comment:64" + }, + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" } ] }, @@ -4533,6 +4555,48 @@ ] }, { + "start": "2018-03-27", + "protocols": [ + "snowflake" + ], + "shortDescription": "Restarted the fallback snowflake proxies with no limit on memory.", + "description": "Restarted the fallback snowflake proxies with no limit on memory.", + "links": [ + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" + } + ] + }, + { + "start": "2018-04-02", + "protocols": [ + "snowflake" + ], + "shortDescription": "Reinstated periodic restarts of the fallback snowflake proxies.", + "description": "Reinstated periodic restarts of the fallback snowflake proxies.", + "links": [ + { + "label": "comment", + "target": "https://bugs.torproject.org/25688#comment:1" + } + ] + }, + { + "start": "2018-04-13", + "protocols": [ + "snowflake" + ], + "shortDescription": "Snowflake client registrations", + "description": "Snowflake client registrations (based on domain fronting) stop working, because of a Google infrastructure change that stops domain fronting from working. The time of the change is between 2018-04-13 14:00:00 and 2018-04-13 18:00:00, based on when the bandwidth graph of the Snowflake bridge <a href=\"https://metrics.torproject.org/rs.html#details/5481936581E23D2D178105D44DB6…">5481936581E23D2D178105D44DB6915AB06BFB7F</a> went to zero.", + "links": [ + { + "label": "ticket", + "target": "https://bugs.torproject.org/25804" + } + ] + }, + { "start": "2016-02-24", "places": [ "tm" @@ -5452,6 +5516,25 @@ "unknown": true }, { + "start": "2018-02-01", + "end": "2018-02-05", + "places": [ + "ir" + ], + "protocols": [ + "meek" + ], + "shortDescription": "Drop of meek users in Iran; other transports not affected.", + "description": "Drop of meek users in Iran; other transports not affected.", + "links": [ + { + "label": "graph", + "target": "https://metrics.torproject.org/userstats-bridge-combined.html?start=2018-01…" + } + ], + "unknown": true + }, + { "start": "2018-03-05", "end": "2018-03-08", "places": [

1 0

[nyx/master] Exit stats dialog crashed if no data was available
by atagar＠torproject.org 15 Apr '18

15 Apr '18

commit 1d2683e08b181e1a929748faeaab7bbab13f128b Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Apr 15 13:28:08 2018 -0700 Exit stats dialog crashed if no data was available Showing the exit stats dialog (pressing 'e' on the connection page) stacktraced if no exit stats were available... https://trac.torproject.org/projects/tor/ticket/25801 --- nyx/panel/connection.py | 2 +- web/changelog/index.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/nyx/panel/connection.py b/nyx/panel/connection.py index 98b0baf..ac4a234 100644 --- a/nyx/panel/connection.py +++ b/nyx/panel/connection.py @@ -391,7 +391,7 @@ class ConnectionPanel(nyx.panel.DaemonPanel): def _show_exiting_port_usage(): counts = {} - key_width = max(map(len, self._exit_port_usage.keys())) + key_width = max(map(len, self._exit_port_usage.keys())) if self._exit_port_usage else 0 for k, v in self._exit_port_usage.items(): usage = connection.port_usage(k) diff --git a/web/changelog/index.html b/web/changelog/index.html index 196d82b..bf8e1a3 100644 --- a/web/changelog/index.html +++ b/web/changelog/index.html @@ -83,6 +83,7 @@ <li><span class="component">Connections</span> <ul> <li>Geoip information unavailable for inbound connections</li> + <li>Dialog showing exit statistics crashed when no data was available (:trac:`25801`)</li> </ul> </li>

1 0

[stem/master] Fix exit policy tests
by atagar＠torproject.org 15 Apr '18

15 Apr '18

commit 6f7c54782d865eabbbce49223bf2b2619fbf5d47 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Apr 15 12:45:09 2018 -0700 Fix exit policy tests Oops, earlier change broke one of our unit test mocks. --- test/integ/control/controller.py | 43 +++++----------------------------------- test/unit/control/controller.py | 16 ++------------- 2 files changed, 7 insertions(+), 52 deletions(-) diff --git a/test/integ/control/controller.py b/test/integ/control/controller.py index b59f5d63..cde8e140 100644 --- a/test/integ/control/controller.py +++ b/test/integ/control/controller.py @@ -270,45 +270,12 @@ class TestController(unittest.TestCase): @test.require.controller def test_get_exit_policy(self): """ - Sanity test for get_exit_policy(). We have the default policy (no - ExitPolicy set) which is a little... long due to the boilerplate. - """ - - expected = ExitPolicy( - 'reject 0.0.0.0/8:*', - 'reject 169.254.0.0/16:*', - 'reject 127.0.0.0/8:*', - 'reject 192.168.0.0/16:*', - 'reject 10.0.0.0/8:*', - 'reject 172.16.0.0/12:*', - # this is where 'reject [public_addr]:*' may or may not be - 'reject *:25', - 'reject *:119', - 'reject *:135-139', - 'reject *:445', - 'reject *:563', - 'reject *:1214', - 'reject *:4661-4666', - 'reject *:6346-6429', - 'reject *:6699', - 'reject *:6881-6999', - 'accept *:*', - ) - - runner = test.runner.get_runner() - - with runner.get_tor_controller() as controller: - # We can't simply compare the policies because the tor policy may or may - # not have a reject entry for our public address. Hence, stripping it - # from the policy's string, then comparing those. - - policy_str = str(controller.get_exit_policy()) - - public_addr_start = policy_str.find('reject 172.16.0.0/12:*') + 22 - public_addr_end = policy_str.find(', reject *:25') + Sanity test for get_exit_policy(). Our 'ExitRelay 0' torrc entry causes us + to have a simple reject-all policy. + """ - policy_str = policy_str[:public_addr_start] + policy_str[public_addr_end:] - self.assertEqual(str(expected), policy_str) + with test.runner.get_runner().get_tor_controller() as controller: + self.assertEqual(ExitPolicy('reject *:*'), controller.get_exit_policy()) @test.require.controller def test_authenticate(self): diff --git a/test/unit/control/controller.py b/test/unit/control/controller.py index 929adcfc..92abfb67 100644 --- a/test/unit/control/controller.py +++ b/test/unit/control/controller.py @@ -164,23 +164,11 @@ class TestControl(unittest.TestCase): }[param] get_info_mock.side_effect = lambda param, default = None: { - 'address': '123.45.67.89', - 'exit-policy/default': 'reject *:25,reject *:119,reject *:135-139,reject *:445,reject *:563,reject *:1214,reject *:4661-4666,reject *:6346-6429,reject *:6699,reject *:6881-6999,accept *:*', + 'exit-policy/full': 'reject *:25,reject *:119,reject *:135-139,reject *:445,reject *:563,reject *:1214,reject *:4661-4666,reject *:6346-6429,reject *:6699,reject *:6881-6999,accept *:*', }[param] expected = ExitPolicy( - 'reject 0.0.0.0/8:*', # private entries - 'reject 169.254.0.0/16:*', - 'reject 127.0.0.0/8:*', - 'reject 192.168.0.0/16:*', - 'reject 10.0.0.0/8:*', - 'reject 172.16.0.0/12:*', - 'reject 123.45.67.89:*', # relay's public address - 'accept *:80', # finally we get to our ExitPolicy - 'accept *:443', - 'accept 43.5.5.5:*', - 'reject *:22', - 'reject *:25', # default policy + 'reject *:25', 'reject *:119', 'reject *:135-139', 'reject *:445',

1 0

[tor/master] copy 0.3.3.5-rc changelog to master.
by nickm＠torproject.org 15 Apr '18

15 Apr '18

commit a8482d127f2833798754d389cbc63e9055a8c9b5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Apr 15 15:40:01 2018 -0400 copy 0.3.3.5-rc changelog to master. --- ChangeLog | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) diff --git a/ChangeLog b/ChangeLog index 98da35a07..26707cc05 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,92 @@ +Changes in version 0.3.3.5-rc - 2018-04-15 + Tor 0.3.3.5-rc fixes various bugs in earlier versions of Tor, + including some that could affect reliability or correctness. + + This is the first release candidate in the 0.3.3 series. If we find no + new bugs or regression here, then the first stable 0.3.3 release will + be nearly identical to this one. + + o Major bugfixes (security, protover, voting): + - Revise Rust implementation of protover to use a more memory- + efficient voting algorithm and corresponding data structures, thus + avoiding a potential memory-based DoS attack where specially + crafted protocol strings would expand to fill available memory. + Fixes bug 24031; bugfix on 0.3.3.1-alpha. + + o Major bugfixes (performance, load balancing): + - Directory authorities no longer vote in favor of the Guard flag + for relays without directory support. Starting in Tor + 0.3.0.1-alpha, clients have been avoiding using such relays in the + Guard position, leading to increasingly broken load balancing for + the 5%-or-so of Guards that don't advertise directory support. + Fixes bug 22310; bugfix on 0.3.0.6. + + o Minor feature (continuous integration): + - Update the Travis CI configuration to use the stable Rust channel, + now that we have decided to require that. Closes ticket 25714. + + o Minor features (config options): + - Change the way the default value for MaxMemInQueues is calculated. + We now use 40% of the hardware RAM if the system has 8 GB RAM or + more. Otherwise we use the former value of 75%. Closes + ticket 24782. + + o Minor features (geoip): + - Update geoip and geoip6 to the April 3 2018 Maxmind GeoLite2 + Country database. Closes ticket 25718. + + o Minor bugfixes (client): + - When using a listed relay as a bridge, and also using + microdescriptors, and considering that relay as a non-bridge in a + circuit, treat its microdescriptor as a valid source of + information about that relay. This change should prevent a non- + fatal assertion error. Fixes bug 25691; bugfix on 0.3.3.4-alpha. + + o Minor bugfixes (controller): + - Restore the correct operation of the RESOLVE command, which had + been broken since we added the ability to enable/disable DNS on + specific listener ports. Fixes bug 25617; bugfix on 0.2.9.3-alpha. + + o Minor bugfixes (distribution, compilation, rust): + - Build correctly when the rust dependencies submodule is loaded, + but the TOR_RUST_DEPENDENCIES environment variable is not set. + Fixes bug 25679; bugfix on 0.3.3.1-alpha. + - Actually include all of our Rust source in our source + distributions. (Previously, a few of the files were accidentally + omitted.) Fixes bug 25732; bugfix on 0.3.3.2-alpha. + + o Minor bugfixes (documentation): + - Document that the PerConnBW{Rate,Burst} options will fall back to + their corresponding consensus parameters only if those parameters + are set. Previously we had claimed that these values would always + be set in the consensus. Fixes bug 25296; bugfix on 0.2.2.7-alpha. + - Revert a misformatting issue in the ExitPolicy documentation. + Fixes bug 25582; bugfix on 0.3.3.1-alpha. + + o Minor bugfixes (exit node DNS retries): + - Re-attempt timed-out DNS queries 3 times before failure, since our + timeout is 5 seconds for them, but clients wait 10-15. Also allow + slightly more timeouts per resolver when an exit has multiple + resolvers configured. Fixes bug 21394; bugfix on 0.3.1.9. + + o Minor bugfixes (onion services): + - Re-instate counting the client HSDir fetch circuits against the + MaxClientCircuitsPending rate limit. Fixes bug 24989; bugfix + on 0.3.3.1-alpha. + - Remove underscores from the _HSLayer{2,3}Nodes options. This + expert-user configuration can now be enabled as HSLayer{2,3}Nodes. + Fixes bug 25581; bugfix on 0.3.3.1-alpha + + o Code simplification and refactoring: + - Move the list of default directory authorities to its own file. + Closes ticket 24854. Patch by "beastr0". + + o Documentation (manpage, denial of service): + - Provide more detail about the denial-of-service options, by + listing each mitigation and explaining how they relate. Closes + ticket 25248. + + Changes in version 0.3.3.4-alpha - 2018-03-29 Tor 0.3.3.4-alpha includes various bugfixes for issues found during the alpha testing of earlier releases in its series. We are

1 0

[tor/maint-0.3.3] bump to 0.3.3.5-rc-dev
by nickm＠torproject.org 15 Apr '18

15 Apr '18

commit 3ee4c9b1fae9d53556b3e3be852f12e9abe51e14 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Apr 15 15:41:03 2018 -0400 bump to 0.3.3.5-rc-dev --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 070054112..44235024c 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2017, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.3.5-rc]) +AC_INIT([tor],[0.3.3.5-rc-dev]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 0cea26bde..c27e244b5 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.3.5-rc" +!define VERSION "0.3.3.5-rc-dev" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 3fcf68524..de1bc8c85 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.3.5-rc" +#define VERSION "0.3.3.5-rc-dev"

1 0

[tor/master] Merge branch 'maint-0.3.3'
by nickm＠torproject.org 15 Apr '18

15 Apr '18

commit 8da7fcccd67f5dc37acc904f628d94fb2827059d Merge: a8482d127 3ee4c9b1f Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Apr 15 15:41:10 2018 -0400 Merge branch 'maint-0.3.3' "ours" to avoid version bump.

1 0

[tor/release-0.3.3] bump to 0.3.3.5-rc-dev
by nickm＠torproject.org 15 Apr '18

15 Apr '18

commit 3ee4c9b1fae9d53556b3e3be852f12e9abe51e14 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Apr 15 15:41:03 2018 -0400 bump to 0.3.3.5-rc-dev --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 070054112..44235024c 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2017, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.3.5-rc]) +AC_INIT([tor],[0.3.3.5-rc-dev]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 0cea26bde..c27e244b5 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.3.5-rc" +!define VERSION "0.3.3.5-rc-dev" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 3fcf68524..de1bc8c85 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.3.5-rc" +#define VERSION "0.3.3.5-rc-dev"

1 0

[tor/master] bump to 0.3.3.5-rc-dev
by nickm＠torproject.org 15 Apr '18

15 Apr '18

commit 3ee4c9b1fae9d53556b3e3be852f12e9abe51e14 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Apr 15 15:41:03 2018 -0400 bump to 0.3.3.5-rc-dev --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 070054112..44235024c 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2017, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.3.5-rc]) +AC_INIT([tor],[0.3.3.5-rc-dev]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 0cea26bde..c27e244b5 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.3.5-rc" +!define VERSION "0.3.3.5-rc-dev" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 3fcf68524..de1bc8c85 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.3.5-rc" +#define VERSION "0.3.3.5-rc-dev"

1 0