April 2018 - tor-commits - lists.torproject.org

[tor/master] Use node_has_preferred_descriptor() in another case
by nickm＠torproject.org 22 Apr '18

22 Apr '18

commit 388d217c40fea4dfd9c2782ae6036126258fc292 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Apr 16 11:40:14 2018 -0400 Use node_has_preferred_descriptor() in another case In router_add_running_nodes_to_smartlist(), we had an inline implementation of the logic from node_has_descriptor(), which should be changed to node_has_preferred_descriptor(). --- src/or/routerlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/routerlist.c b/src/or/routerlist.c index bc3abb236..2ab5017b7 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -2335,7 +2335,7 @@ router_add_running_nodes_to_smartlist(smartlist_t *sl, int need_uptime, SMARTLIST_FOREACH_BEGIN(nodelist_get_list(), const node_t *, node) { if (!node->is_running || !node->is_valid) continue; - if (need_desc && !(node->ri || (node->rs && node->md))) + if (need_desc && !node_has_preferred_descriptor(node, direct_conn)) continue; if (node->ri && node->ri->purpose != ROUTER_PURPOSE_GENERAL) continue;

1 0

[tor/master] Use router_crn_flags in more places, to pass direct-connect flag
by nickm＠torproject.org 22 Apr '18

22 Apr '18

commit 7915efd1b83e45c53eb06cfb384eed024df440c0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Apr 16 11:41:45 2018 -0400 Use router_crn_flags in more places, to pass direct-connect flag In order to fix 25691 and 25692, we need to pass the "direct_conn" flag to more places -- particularly when choosing single-hop tunnels. The right way to do this involves having a couple more functions accept router_crn_flags_t, rather than a big list of boolean arguments. This commit also makes sure that choose_good_exit_server_general() honors the direct_conn flag, to fix 25691 and 25692. --- src/or/circuitbuild.c | 39 ++++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 019b9c51f..96cc8369d 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1827,7 +1827,7 @@ ap_stream_wants_exit_attention(connection_t *conn) * Return NULL if we can't find any suitable routers. */ static const node_t * -choose_good_exit_server_general(int need_uptime, int need_capacity) +choose_good_exit_server_general(router_crn_flags_t flags) { int *n_supported; int n_pending_connections = 0; @@ -1837,6 +1837,9 @@ choose_good_exit_server_general(int need_uptime, int need_capacity) const or_options_t *options = get_options(); const smartlist_t *the_nodes; const node_t *selected_node=NULL; + const int need_uptime = (flags & CRN_NEED_UPTIME) != 0; + const int need_capacity = (flags & CRN_NEED_CAPACITY) != 0; + const int direct_conn = (flags & CRN_DIRECT_CONN) != 0; connections = get_connection_array(); @@ -1869,7 +1872,7 @@ choose_good_exit_server_general(int need_uptime, int need_capacity) */ continue; } - if (!node_has_preferred_descriptor(node, 0)) { + if (!node_has_preferred_descriptor(node, direct_conn)) { n_supported[i] = -1; continue; } @@ -1982,7 +1985,8 @@ choose_good_exit_server_general(int need_uptime, int need_capacity) need_capacity?", fast":"", need_uptime?", stable":""); tor_free(n_supported); - return choose_good_exit_server_general(0, 0); + flags &= ~(CRN_NEED_UPTIME|CRN_NEED_CAPACITY); + return choose_good_exit_server_general(flags); } log_notice(LD_CIRC, "All routers are down or won't exit%s -- " "choosing a doomed exit at random.", @@ -2229,17 +2233,11 @@ pick_restricted_middle_node(router_crn_flags_t flags, * toward the preferences in 'options'. */ static const node_t * -choose_good_exit_server(origin_circuit_t *circ, int need_uptime, - int need_capacity, int is_internal, int need_hs_v3) +choose_good_exit_server(origin_circuit_t *circ, + router_crn_flags_t flags, int is_internal) { const or_options_t *options = get_options(); - router_crn_flags_t flags = CRN_NEED_DESC; - if (need_uptime) - flags |= CRN_NEED_UPTIME; - if (need_capacity) - flags |= CRN_NEED_CAPACITY; - if (need_hs_v3) - flags |= CRN_RENDEZVOUS_V3; + flags |= CRN_NEED_DESC; switch (TO_CIRCUIT(circ)->purpose) { case CIRCUIT_PURPOSE_C_HSDIR_GET: @@ -2253,7 +2251,7 @@ choose_good_exit_server(origin_circuit_t *circ, int need_uptime, if (is_internal) /* pick it like a middle hop */ return router_choose_random_node(NULL, options->ExcludeNodes, flags); else - return choose_good_exit_server_general(need_uptime,need_capacity); + return choose_good_exit_server_general(flags); case CIRCUIT_PURPOSE_C_ESTABLISH_REND: { /* Pick a new RP */ @@ -2378,15 +2376,22 @@ onion_pick_cpath_exit(origin_circuit_t *circ, extend_info_t *exit_ei, extend_info_describe(exit_ei)); exit_ei = extend_info_dup(exit_ei); } else { /* we have to decide one */ + router_crn_flags_t flags = CRN_NEED_DESC; + if (state->need_uptime) + flags |= CRN_NEED_UPTIME; + if (state->need_capacity) + flags |= CRN_NEED_CAPACITY; + if (is_hs_v3_rp_circuit) + flags |= CRN_RENDEZVOUS_V3; + if (state->onehop_tunnel) + flags |= CRN_DIRECT_CONN; const node_t *node = - choose_good_exit_server(circ, state->need_uptime, - state->need_capacity, state->is_internal, - is_hs_v3_rp_circuit); + choose_good_exit_server(circ, flags, state->is_internal); if (!node) { log_warn(LD_CIRC,"Failed to choose an exit server"); return -1; } - exit_ei = extend_info_from_node(node, 0); + exit_ei = extend_info_from_node(node, state->onehop_tunnel); if (BUG(exit_ei == NULL)) return -1; }

1 0

[doctor/master] Errors are getting incorrectly suppressed
by atagar＠torproject.org 22 Apr '18

22 Apr '18

commit 023cbeeff9798b8600f5191ed3084e57624fee10 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Apr 22 12:02:31 2018 -0700 Errors are getting incorrectly suppressed Interesting! Roger reported an issue where he isn't getting notified about moria1's bwauth scanner being down. In taking a look at the logs I'm indeed seeing something funky... 04/21/2018 21:05:46 [DEBUG] NOTICE: The following directory authorities are not reporting bandwidth scanner results: gabelmoo 04/21/2018 21:05:47 [INFO] Suppressing The_following_directory_authorities_are_not_reporting_bandwidth_scanner_results:_gabelmoo, time remaining is 1 3 hours 04/21/2018 21:05:47 [INFO] All 1 issues were suppressed. Not sending a notification. 04/21/2018 21:05:47 [DEBUG] Checks finished, runtime was 46.84 seconds 04/21/2018 22:05:45 [DEBUG] ERROR: The following directory authorities are not reporting bandwidth scanner results: gabelmoo, moria1 04/21/2018 22:05:46 [INFO] All 1 issues were suppressed. Not sending a notification. 04/21/2018 22:05:46 [DEBUG] Checks finished, runtime was 45.56 seconds I suspect what's happening is this... * When only gabelmoo is down this is a NOTICE runlevel notification, which works. * When moria1 is down as well it's an ERROR runlevel notice which should generate an email every hour, but isn't. I think this is due to a bug where ERROR notices in specific are getting incorrectly suppressed. Lets give this a try... --- consensus_health_checker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consensus_health_checker.py b/consensus_health_checker.py index beb8c70..9710b5e 100755 --- a/consensus_health_checker.py +++ b/consensus_health_checker.py @@ -193,7 +193,7 @@ def is_rate_limited(issue): hours = issue.get_suppression_duration() if hours == 0: - return True + return False current_time = int(time.time()) last_seen = stem.util.conf.get_config('last_notified').get(key, 0)

1 0

[translation/support-miscellaneous_completed] Update translations for support-miscellaneous_completed
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit ffe5fc4906a1846a367311340ff62139b854628f Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:20:32 2018 +0000 Update translations for support-miscellaneous_completed --- es.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/es.json b/es.json index 6bec37c61..482202264 100644 --- a/es.json +++ b/es.json @@ -8,7 +8,7 @@ "misc-2": { "id": "#misc-2", "control": "misc-2", - "title": "¿Por qué no evitáis que indeseables haga maldades cuando usan Tor?", + "title": "¿Por qué no evitan que gente indeseable haga maldades cuando usa Tor?", "description": "Tor está diseñado para defender los derechos humanos y la privacidad evitando que cualquiera censure cosas, incluso nosotros. Odiamos que haya personas que usen Tor para hacer cosas terribles, pero no podemos hacer nada para librarnos de ellos sin socavar también los activistas pro derechos humanos, periodistas, supervivientes de abusos, y otras personas que usan Tor para cosas buenas. Si queremos evitar que ciertas personas usen Tor, básicamente estaríamos añadiendo una puerta trasera al software, lo que dejaría vulnerables a nuestros usuarios a ataques de regímenes opresivos y otros adversarios." }, "misc-3": { @@ -50,8 +50,8 @@ "misc-9": { "id": "#misc-9", "control": "misc-9", - "title": "Estoy teniendo un problema actualizando o usando Vidalia.", - "description": "Vidalia ya no es mantenido ni está soportado. Una gran porción de las características que ofrecía Vidalia ahora están integradas en el propio Navegador Tor." + "title": "Tengo un problema actualizando o usando Vidalia.", + "description": "Vidalia ya no se mantiene ni está soportado. Una gran parte de las características que ofrecía Vidalia ahora están integradas en el propio Navegador Tor." }, "misc-10": { "id": "#misc-10", @@ -75,12 +75,12 @@ "id": "#misc-13", "control": "misc-13", "title": "¿Puedo usar una VPN con Tor?", - "description": "En términos generales, no recomendamos usar una VPN con Tor a menos que seas un usuario avanzado que sabe cómo configurar ambos de forma que no comprometa su privacidad. Puedes encontrar más información detallada sobre Tor + VPN en <a href=\"https://trac.torproject.org/projects/tor/wiki/doc/TorPlusVPN\">nuestro wiki</a>." + "description": "En términos generales, no recomendamos usar una VPN con Tor a menos que seas un usuario avanzado que sabe cómo configurar ambos de forma que no comprometa tu privacidad. Puedes encontrar más información detallada sobre Tor + VPN en <a href=\"https://trac.torproject.org/projects/tor/wiki/doc/TorPlusVPN\">nuestro wiki</a>." }, "misc-14": { "id": "#misc-14", "control": "misc-14", - "title": "¿Cómo puedo ofrecerme voluntario para Tor Project?", + "title": "¿Cómo puedo hacer voluntariado con Tor Project?", "description": "Por favor, ¡mira nuestra <a href=\"https://www.torproject.org/getinvolved/volunteer.html.en\">página de voluntariado</a> para ver cómo involucrarte!" }, "misc-15": {

1 0

[translation/support-miscellaneous] Update translations for support-miscellaneous
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit d40762aa0040e64da9004cbeac33bec3c5265887 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:20:28 2018 +0000 Update translations for support-miscellaneous --- es.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/es.json b/es.json index 6bec37c61..482202264 100644 --- a/es.json +++ b/es.json @@ -8,7 +8,7 @@ "misc-2": { "id": "#misc-2", "control": "misc-2", - "title": "¿Por qué no evitáis que indeseables haga maldades cuando usan Tor?", + "title": "¿Por qué no evitan que gente indeseable haga maldades cuando usa Tor?", "description": "Tor está diseñado para defender los derechos humanos y la privacidad evitando que cualquiera censure cosas, incluso nosotros. Odiamos que haya personas que usen Tor para hacer cosas terribles, pero no podemos hacer nada para librarnos de ellos sin socavar también los activistas pro derechos humanos, periodistas, supervivientes de abusos, y otras personas que usan Tor para cosas buenas. Si queremos evitar que ciertas personas usen Tor, básicamente estaríamos añadiendo una puerta trasera al software, lo que dejaría vulnerables a nuestros usuarios a ataques de regímenes opresivos y otros adversarios." }, "misc-3": { @@ -50,8 +50,8 @@ "misc-9": { "id": "#misc-9", "control": "misc-9", - "title": "Estoy teniendo un problema actualizando o usando Vidalia.", - "description": "Vidalia ya no es mantenido ni está soportado. Una gran porción de las características que ofrecía Vidalia ahora están integradas en el propio Navegador Tor." + "title": "Tengo un problema actualizando o usando Vidalia.", + "description": "Vidalia ya no se mantiene ni está soportado. Una gran parte de las características que ofrecía Vidalia ahora están integradas en el propio Navegador Tor." }, "misc-10": { "id": "#misc-10", @@ -75,12 +75,12 @@ "id": "#misc-13", "control": "misc-13", "title": "¿Puedo usar una VPN con Tor?", - "description": "En términos generales, no recomendamos usar una VPN con Tor a menos que seas un usuario avanzado que sabe cómo configurar ambos de forma que no comprometa su privacidad. Puedes encontrar más información detallada sobre Tor + VPN en <a href=\"https://trac.torproject.org/projects/tor/wiki/doc/TorPlusVPN\">nuestro wiki</a>." + "description": "En términos generales, no recomendamos usar una VPN con Tor a menos que seas un usuario avanzado que sabe cómo configurar ambos de forma que no comprometa tu privacidad. Puedes encontrar más información detallada sobre Tor + VPN en <a href=\"https://trac.torproject.org/projects/tor/wiki/doc/TorPlusVPN\">nuestro wiki</a>." }, "misc-14": { "id": "#misc-14", "control": "misc-14", - "title": "¿Cómo puedo ofrecerme voluntario para Tor Project?", + "title": "¿Cómo puedo hacer voluntariado con Tor Project?", "description": "Por favor, ¡mira nuestra <a href=\"https://www.torproject.org/getinvolved/volunteer.html.en\">página de voluntariado</a> para ver cómo involucrarte!" }, "misc-15": {

1 0

[translation/tails-greeter-2] Update translations for tails-greeter-2
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit 217cb0285ac85c4ae2688b3d585545f0603a9e03 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:19:32 2018 +0000 Update translations for tails-greeter-2 --- te/te.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/te/te.po b/te/te.po index df6721593..56860e37e 100644 --- a/te/te.po +++ b/te/te.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2018-01-22 14:15+0100\n" +"POT-Creation-Date: 2018-03-01 20:26+0100\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: Tor Project <support-team-private(a)lists.torproject.org>, 2016\n" "Language-Team: Telugu (https://www.transifex.com/otf/teams/1519/te/)\n"

1 0

[translation/tor-messenger-privdtd] Update translations for tor-messenger-privdtd
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit 0c69ac20e42551792839abb95ba031d84b1a9d25 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:19:09 2018 +0000 Update translations for tor-messenger-privdtd --- te/priv.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/te/priv.dtd b/te/priv.dtd index 70079796c..4060bca4d 100644 --- a/te/priv.dtd +++ b/te/priv.dtd @@ -1,2 +1,2 @@ <!ENTITY privDialog.title "Generating private key"> -<!ENTITY privDialog.done "Done"> \ No newline at end of file +<!ENTITY privDialog.done "పూర్తి"> \ No newline at end of file

1 0

[translation/tails-perl5lib] Update translations for tails-perl5lib
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit d4f5893e2a417c3aa36706f47b5cf930cc9bbbfd Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:17:36 2018 +0000 Update translations for tails-perl5lib --- te.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/te.po b/te.po index f4be7eb51..9fb9bcaf8 100644 --- a/te.po +++ b/te.po @@ -8,8 +8,8 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" "POT-Creation-Date: 2018-03-15 12:15+0000\n" -"PO-Revision-Date: 2018-03-31 13:21+0000\n" -"Last-Translator: carolyn <carolyn(a)anhalt.org>\n" +"PO-Revision-Date: 2018-04-22 07:12+0000\n" +"Last-Translator: sonusandeep <kapalawai.sandeep.sandeep(a)gmail.com>\n" "Language-Team: Telugu (http://www.transifex.com/otf/torproject/language/te/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -19,7 +19,7 @@ msgstr "" #: ../lib/Tails/RunningSystem.pm:159 msgid "Error" -msgstr "" +msgstr "లోపం" #: ../lib/Tails/RunningSystem.pm:161 msgid ""

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit 457f9624779921e9d2b1f34523803c09f46547ba Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:16:44 2018 +0000 Update translations for tails-misc --- te.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/te.po b/te.po index 62a2525cc..52e800ffe 100644 --- a/te.po +++ b/te.po @@ -8,8 +8,8 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-03-12 19:03+0100\n" -"PO-Revision-Date: 2018-03-13 02:48+0000\n" -"Last-Translator: carolyn <carolyn(a)anhalt.org>\n" +"PO-Revision-Date: 2018-04-22 07:12+0000\n" +"Last-Translator: sonusandeep <kapalawai.sandeep.sandeep(a)gmail.com>\n" "Language-Team: Telugu (http://www.transifex.com/otf/torproject/language/te/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -240,7 +240,7 @@ msgstr "" #: config/chroot_local-includes/usr/local/bin/tails-upgrade-frontend-wrapper:73 #: config/chroot_local-includes/usr/local/sbin/unsafe-browser:28 msgid "Error" -msgstr "" +msgstr "లోపం" #: config/chroot_local-includes/usr/local/lib/tails-virt-notify-user:71 msgid "Warning: virtual machine detected!"

1 0

[translation/tor-launcher-properties] Update translations for tor-launcher-properties
by translation＠torproject.org 22 Apr '18

22 Apr '18

commit 2d3b04620accadc69a215ce9ff6f5e47ccdef483 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Apr 22 07:16:20 2018 +0000 Update translations for tor-launcher-properties --- te/torlauncher.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/te/torlauncher.properties b/te/torlauncher.properties index a4d097a76..209ac60ae 100644 --- a/te/torlauncher.properties +++ b/te/torlauncher.properties @@ -45,7 +45,7 @@ torlauncher.connect=Connect torlauncher.restart_tor=Restart Tor torlauncher.quit=Quit torlauncher.quit_win=Exit -torlauncher.done=Done +torlauncher.done=పూర్తి torlauncher.forAssistance=For assistance, contact %S torlauncher.forAssistance2=For assistance, visit %S

1 0