April 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.3] hs: Fix memleak in v3 on SIGHUP
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit b259008c56c44c32dfeea3ed8d4b06cd61751a88 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Apr 23 11:09:57 2018 -0400 hs: Fix memleak in v3 on SIGHUP Fixes #25901 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/changes/bug25901 b/changes/bug25901 new file mode 100644 index 000000000..3ad30c767 --- /dev/null +++ b/changes/bug25901 @@ -0,0 +1,3 @@ + o Minor bugfixes (hidden service v3): + - Fix a memory leak when an hidden service v3 is configured and gets a + SIGHUP signal. Fixes bug 25901; bugfix on 0.3.2.1-alpha. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 45810c5c5..8ddd68c69 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -840,6 +840,10 @@ move_hs_state(hs_service_t *src_service, hs_service_t *dst_service) /* Let's do a shallow copy */ dst->intro_circ_retry_started_time = src->intro_circ_retry_started_time; dst->num_intro_circ_launched = src->num_intro_circ_launched; + /* Freeing a NULL replaycache triggers an info LD_BUG. */ + if (dst->replay_cache_rend_cookie != NULL) { + replaycache_free(dst->replay_cache_rend_cookie); + } dst->replay_cache_rend_cookie = src->replay_cache_rend_cookie; src->replay_cache_rend_cookie = NULL; /* steal pointer reference */

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit d8114a1f572f01559b149dff53d380bdad6f29c0 Merge: 08fca9414 7e7b052b2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Apr 24 10:37:36 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+)

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.2' into maint-0.3.3
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit 7e7b052b2a114900b5e6575fd5375dc00c09d5db Merge: 6182f60f7 9187cdb1c Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Apr 24 10:37:36 2018 -0400 Merge branch 'maint-0.3.2' into maint-0.3.3 changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+)

1 0

[tor/maint-0.3.3] Merge remote-tracking branch 'dgoulet/bug25901_032_01' into maint-0.3.2
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit 9187cdb1cd17dd988c6e444705c6153a65948f1e Merge: d2951b381 b259008c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Apr 24 10:36:17 2018 -0400 Merge remote-tracking branch 'dgoulet/bug25901_032_01' into maint-0.3.2 changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+)

1 0

[tor/maint-0.3.3] Merge branch 'maint-0.3.2' into maint-0.3.3
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit 7e7b052b2a114900b5e6575fd5375dc00c09d5db Merge: 6182f60f7 9187cdb1c Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Apr 24 10:37:36 2018 -0400 Merge branch 'maint-0.3.2' into maint-0.3.3 changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+)

1 0

[tor/maint-0.3.2] hs: Fix memleak in v3 on SIGHUP
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit b259008c56c44c32dfeea3ed8d4b06cd61751a88 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Apr 23 11:09:57 2018 -0400 hs: Fix memleak in v3 on SIGHUP Fixes #25901 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/changes/bug25901 b/changes/bug25901 new file mode 100644 index 000000000..3ad30c767 --- /dev/null +++ b/changes/bug25901 @@ -0,0 +1,3 @@ + o Minor bugfixes (hidden service v3): + - Fix a memory leak when an hidden service v3 is configured and gets a + SIGHUP signal. Fixes bug 25901; bugfix on 0.3.2.1-alpha. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 45810c5c5..8ddd68c69 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -840,6 +840,10 @@ move_hs_state(hs_service_t *src_service, hs_service_t *dst_service) /* Let's do a shallow copy */ dst->intro_circ_retry_started_time = src->intro_circ_retry_started_time; dst->num_intro_circ_launched = src->num_intro_circ_launched; + /* Freeing a NULL replaycache triggers an info LD_BUG. */ + if (dst->replay_cache_rend_cookie != NULL) { + replaycache_free(dst->replay_cache_rend_cookie); + } dst->replay_cache_rend_cookie = src->replay_cache_rend_cookie; src->replay_cache_rend_cookie = NULL; /* steal pointer reference */

1 0

[tor/maint-0.3.3] hs: Fix memleak in v3 on SIGHUP
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit b259008c56c44c32dfeea3ed8d4b06cd61751a88 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Apr 23 11:09:57 2018 -0400 hs: Fix memleak in v3 on SIGHUP Fixes #25901 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/changes/bug25901 b/changes/bug25901 new file mode 100644 index 000000000..3ad30c767 --- /dev/null +++ b/changes/bug25901 @@ -0,0 +1,3 @@ + o Minor bugfixes (hidden service v3): + - Fix a memory leak when an hidden service v3 is configured and gets a + SIGHUP signal. Fixes bug 25901; bugfix on 0.3.2.1-alpha. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 45810c5c5..8ddd68c69 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -840,6 +840,10 @@ move_hs_state(hs_service_t *src_service, hs_service_t *dst_service) /* Let's do a shallow copy */ dst->intro_circ_retry_started_time = src->intro_circ_retry_started_time; dst->num_intro_circ_launched = src->num_intro_circ_launched; + /* Freeing a NULL replaycache triggers an info LD_BUG. */ + if (dst->replay_cache_rend_cookie != NULL) { + replaycache_free(dst->replay_cache_rend_cookie); + } dst->replay_cache_rend_cookie = src->replay_cache_rend_cookie; src->replay_cache_rend_cookie = NULL; /* steal pointer reference */

1 0

[tor/maint-0.3.2] Merge remote-tracking branch 'dgoulet/bug25901_032_01' into maint-0.3.2
by nickm＠torproject.org 24 Apr '18

24 Apr '18

commit 9187cdb1cd17dd988c6e444705c6153a65948f1e Merge: d2951b381 b259008c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Apr 24 10:36:17 2018 -0400 Merge remote-tracking branch 'dgoulet/bug25901_032_01' into maint-0.3.2 changes/bug25901 | 3 +++ src/or/hs_service.c | 4 ++++ 2 files changed, 7 insertions(+)

1 0

[translation/tor-and-https_completed] Update translations for tor-and-https_completed
by translation＠torproject.org 24 Apr '18

24 Apr '18

commit 16e319a9425521bfd2400cf3e1637e13d73f3931 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Apr 24 13:18:01 2018 +0000 Update translations for tor-and-https_completed --- ru.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ru.po b/ru.po index 725db43ea..14baf5088 100644 --- a/ru.po +++ b/ru.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2014-07-17 14:23+0000\n" -"PO-Revision-Date: 2018-04-23 16:31+0000\n" +"PO-Revision-Date: 2018-04-24 12:53+0000\n" "Last-Translator: e Translators <jobayer.1612191(a)gmail.com>\n" "Language-Team: Russian (http://www.transifex.com/otf/torproject/language/ru/)\n" "MIME-Version: 1.0\n"

1 0

[translation/tor-and-https] Update translations for tor-and-https
by translation＠torproject.org 24 Apr '18

24 Apr '18

commit 77b02f27b36a665cedaf20e6fa8e369b5dd5d11d Author: Translation commit bot <translation(a)torproject.org> Date: Tue Apr 24 13:17:55 2018 +0000 Update translations for tor-and-https --- ru.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ru.po b/ru.po index 725db43ea..14baf5088 100644 --- a/ru.po +++ b/ru.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2014-07-17 14:23+0000\n" -"PO-Revision-Date: 2018-04-23 16:31+0000\n" +"PO-Revision-Date: 2018-04-24 12:53+0000\n" "Last-Translator: e Translators <jobayer.1612191(a)gmail.com>\n" "Language-Team: Russian (http://www.transifex.com/otf/torproject/language/ru/)\n" "MIME-Version: 1.0\n"

1 0