April 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.3] Fix a copy-paste error in the fix for #23693.
by nickm＠torproject.org 25 Apr '18

25 Apr '18

commit bb35405d2ad01dbc8cf59ed275c41bd7d6098ae8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 25 08:00:55 2018 -0400 Fix a copy-paste error in the fix for #23693. Found by coverity; CID 25912; bug not in any released Tor. --- src/or/router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/router.c b/src/or/router.c index f29ebbdf8..5405d3126 100644 --- a/src/or/router.c +++ b/src/or/router.c @@ -143,7 +143,7 @@ dup_onion_keys(crypto_pk_t **key, crypto_pk_t **last) if (onionkey) *key = crypto_pk_copy_full(onionkey); else - *last = NULL; + *key = NULL; if (lastonionkey) *last = crypto_pk_copy_full(lastonionkey); else

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.1' into maint-0.3.2
by nickm＠torproject.org 25 Apr '18

25 Apr '18

commit 7c3f87eb4b2c3c4ce3422b3561bee36f3c9956c1 Merge: 89a3fafd4 bb35405d2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 25 08:01:53 2018 -0400 Merge branch 'maint-0.3.1' into maint-0.3.2 src/or/router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.2' into maint-0.3.3
by nickm＠torproject.org 25 Apr '18

25 Apr '18

commit 58f54a3588cf722a31b10fa0450225f7685c8629 Merge: 85cd8386f 7c3f87eb4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 25 08:01:54 2018 -0400 Merge branch 'maint-0.3.2' into maint-0.3.3 src/or/router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 25 Apr '18

25 Apr '18

commit 19bed6f936350dc024c82bd11d624c34063d9172 Merge: 148540c50 58f54a358 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 25 08:01:54 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 src/or/router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor-browser/tor-browser-52.7.3esr-8.0-1] Bug 25458: UI customization half-broken in Tor Browser 8.0a3
by gk＠torproject.org 25 Apr '18

25 Apr '18

commit 12847934f5c7baf4e94945ec433f1b2fdcf33625 Author: Richard Pospesel <richard(a)torproject.org> Date: Fri Apr 20 16:03:41 2018 -0700 Bug 25458: UI customization half-broken in Tor Browser 8.0a3 Fixed fallout from #25147. Some of the functionality of the UI Customize screen is dependent on setting innerHTML on divs. Since the code runs in the System context, the HTML was being sanitized and broke page functionality. The offending statements have been switched to the unsafeSetInnerHTML() method which bypasses sanitization in System context. --- browser/components/customizableui/CustomizeMode.jsm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/browser/components/customizableui/CustomizeMode.jsm b/browser/components/customizableui/CustomizeMode.jsm index 49868cdbd4a0..4c32fd867c09 100644 --- a/browser/components/customizableui/CustomizeMode.jsm +++ b/browser/components/customizableui/CustomizeMode.jsm @@ -690,13 +690,13 @@ CustomizeMode.prototype = { // Put the tip contents in the popup. let bundle = this.document.getElementById("bundle_browser"); const kLabelClass = "customization-tipPanel-link"; - messageNode.innerHTML = bundle.getFormattedString("customizeTips.tip0", [ + messageNode.unsafeSetInnerHTML(bundle.getFormattedString("customizeTips.tip0", [ "<label class=\"customization-tipPanel-em\" value=\"" + bundle.getString("customizeTips.tip0.hint") + "\"/>", this.document.getElementById("bundle_brand").getString("brandShortName"), "<label class=\"" + kLabelClass + " text-link\" value=\"" + bundle.getString("customizeTips.tip0.learnMore") + "\"/>" - ]); + ])); messageNode.querySelector("." + kLabelClass).addEventListener("click", () => { let url = Services.urlFormatter.formatURLPref("browser.customizemode.tip0.learnMoreUrl");

1 0

[webwml/master] Update tor logo and isabela pic
by hiro＠torproject.org 25 Apr '18

25 Apr '18

commit e0201c520bfbc6ada17c82d747714d52683b5847 Author: hiro <hiro(a)torproject.org> Date: Wed Apr 25 11:00:53 2018 +0200 Update tor logo and isabela pic --- images/people/isabela.png | Bin 14705 -> 26123 bytes images/tor-logo.png | Bin 4830 -> 29871 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/images/people/isabela.png b/images/people/isabela.png index 64814518..b6dc84d3 100644 Binary files a/images/people/isabela.png and b/images/people/isabela.png differ diff --git a/images/tor-logo.png b/images/tor-logo.png index 8ebcda66..3f0ebd6a 100644 Binary files a/images/tor-logo.png and b/images/tor-logo.png differ

1 0

[tor-browser/tor-browser-52.7.3esr-8.0-1] fixup! fix #17 from https://github.com/amoghbl1/tor-browser/issues don't restore tabs by default
by gk＠torproject.org 25 Apr '18

25 Apr '18

commit 7814f97385daa7b5056bfaabe6ca56206acd6b58 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Apr 25 08:04:39 2018 +0000 fixup! fix #17 from https://github.com/amoghbl1/tor-browser/issues don't restore tabs by default This fixes #25898 on our side --- modules/libpref/init/all.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/libpref/init/all.js b/modules/libpref/init/all.js index 766e665c074a..198028eeb96c 100644 --- a/modules/libpref/init/all.js +++ b/modules/libpref/init/all.js @@ -591,7 +591,7 @@ pref("media.encoder.webm.enabled", true); #endif // Whether to autostart a media element with an |autoplay| attribute -pref("media.autoplay.enabled", false); +pref("media.autoplay.enabled", true); // The default number of decoded video frames that are enqueued in // MediaDecoderReader's mVideoQueue.

1 0

[translation/support-tbb] Update translations for support-tbb
by translation＠torproject.org 24 Apr '18

24 Apr '18

commit 89dbe40be55680bf834e58cae12d48e70d41c3cd Author: Translation commit bot <translation(a)torproject.org> Date: Tue Apr 24 22:20:24 2018 +0000 Update translations for support-tbb --- sk_SK.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sk_SK.json b/sk_SK.json index 673937e56..b3ce18d84 100644 --- a/sk_SK.json +++ b/sk_SK.json @@ -122,7 +122,7 @@ "tbb-20": { "id": "#tbb-20", "control": "tbb-20", - "title": "Tor Browser won't connect, but it doesn’t seem to be an issue with censorship.", + "title": "Tor Browser sa nevie pripojiť ale nezdá sa, že by to bol problém s cenzúrou.", "description": "<p class=\"mb-3\">One of the most common issues that causes connection errors in Tor Browser is an incorrect system clock. Please make sure your system clock and timezone are set accurately. If this doesn't fix the problem, see the Troubleshooting page on the <mark><a href=\"https://tb-manual.torproject.org/en-US/bridges.html\">Tor Browser manual</a></mark>.</p>" }, "tbb-21": {

1 0

[translation/support-censorship] Update translations for support-censorship
by translation＠torproject.org 24 Apr '18

24 Apr '18

commit a9a48273b4bdced9799b2ffa49ffa8575e900568 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Apr 24 22:19:42 2018 +0000 Update translations for support-censorship --- sk_SK.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sk_SK.json b/sk_SK.json index 121cc9918..fd2cf1518 100644 --- a/sk_SK.json +++ b/sk_SK.json @@ -26,7 +26,7 @@ "censorship-5": { "id": "#censorship-5", "control": "censorship-5", - "title": "I am having trouble connecting to Tor, and I can’t figure out what’s wrong.", + "title": "Mám problém pripojiť sa k Tor a neviem prísť na to v čom je problém.", "description": "<p class=\"mb-3\">If you’re having trouble connecting, please select the option to \"copy Tor log to clipboard.\" Then paste the Tor log into a text file or other document. You should see one of these common log errors (look for the following lines in your Tor log):</p><h5>Common log error #1: Proxy connection failure</h5><p class=\"mb-3\"><pre><code> 2017-10-29 09:23:40.800 [NOTICE] Opening Socks listener on 127.0.0.1:9150 \n 2017-10-29 09:23:47.900 [NOTICE] Bootstrapped 5%: Connecting to directory server \n 2017-10-29 09:23:47.900 [NOTICE] Bootstrapped 10%: Finishing handshake with directory server \n 2017-10-29 09:24:08.900 [WARN] Proxy Client: unable to connect to xx..xxx..xxx.xx:xxxxx (\"general SOCKS server failure\") \n 2017-10-29 09:24:08.900 [WARN] Proxy Client: unable to connect to xx..xxx..xxx.xx:xxxxx (\"general SOCKS server failure\") \n 2017-10-29 09:24:08.900 [WARN] Proxy Client: unable to connect toxx..xxx..xxx.xx:xxxxx (\"general SOCKS server fa ilure\")</code></pre></p><p class=\"mb-3\">If you see lines like these in your Tor log, it means you are failing to connect to a SOCKS proxy. If a SOCKS proxy is required for your network setup, then please make sure you’ve entered your proxy details correctly. If a SOCKS proxy is not required, or you’re not sure, please try connecting to the Tor network without a SOCKS proxy.<p><h5>Common log error #2: Can’t reach guard relays</h5><p class=\"mb-3\"><pre><code> 11/1/2017 21:11:43 PM.500 [NOTICE] Opening Socks listener on 127.0.0.1:9150 \n 11/1/2017 21:11:44 PM.300 [NOTICE] Bootstrapped 80%: Connecting to the Tor network \n 11/1/2017 21:11:44 PM.300 [WARN] Failed to find node for hop 0 of our path. Discarding this circuit. \n 11/1/2017 21:11:44 PM.500 [NOTICE] Bootstrapped 85%: Finishing handshake with first hop \n 11/1/2017 21:11:45 PM.300 [WARN] Failed to find node for hop 0 of our path. Discarding this circuit.</code></pre></p><p class=\"mb-3\">If you see lines like these in your Tor log, it means your Tor failed to connect to the first node in the Tor circuit. This could mean that you’re on a network that’s censored. Please try connecting with bridges, and that should fix the problem.</p><h5>Common log error #3: Failed to complete TLS handshake</h5><p class=\"mb-3\"><pre><code> 13-11-17 19:52:24.300 [NOTICE] Bootstrapped 10%: Finishing handshake with directory server \n 13-11-17 19:53:49.300 [WARN] Problem bootstrapping. Stuck at 10%: Finishing handshake with directory server. (DONE; DONE; count 10; recommendation warn; host [host] at xxx.xxx.xxx.xx:xxx) \n 13-11-17 19:53:49.300 [WARN] 10 connections have failed: \n 13-11-17 19:53:49.300 [WARN] 9 connections died in state handshaking (TLS) with SSL state SSLv2/v3 read server hello A in HANDSHAKE \n 13-11-17 19:53:49.300 [WARN] 1 connections died in state connect()ing with SSL state (No SSL object)</code></pre></p><p class=\"mb-3\">If you see lines like this in your Tor log, it means that Tor failed to complete a TLS handshake with the directory authorities. Using bridges will likely fix this.</p><h5>Common log error #4: Clock skew</h5><p class=\"mb-3\"><pre><code> 19.11.2017 00:04:47.400 [NOTICE] Opening Socks listener on 127.0.0.1:9150 \n 19.11.2017 00:04:48.000 [NOTICE] Bootstrapped 5%: Connecting to directory server \n 19.11.2017 00:04:48.200 [NOTICE] Bootstrapped 10%: Finishing handshake with directory server \n 19.11.2017 00:04:48.800 [WARN] Received NETINFO cell with skewed time (OR:xxx.xx.x.xx:xxxx): It seems that our clock is behind by 1 days, 0 hours, 1 minutes, or that theirs is ahead. \n Tor requires an accurate clock to work: please check your time, timezone, and date settings.</code></pre></p><p class=\"mb-3\">If you see lines like this in your Tor log, it means your system clock is incorrect. Please make sure your clock is set accurately, including the correct timezone. Then restart Tor. </p>" }, "censorship-6": {

1 0

[translation/support-connecting] Update translations for support-connecting
by translation＠torproject.org 24 Apr '18

24 Apr '18

commit c3b220a2a451688e4f79dd47834db0b3407d587d Author: Translation commit bot <translation(a)torproject.org> Date: Tue Apr 24 20:20:07 2018 +0000 Update translations for support-connecting --- sk_SK.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sk_SK.json b/sk_SK.json index 4d3e7f911..9584483d7 100644 --- a/sk_SK.json +++ b/sk_SK.json @@ -2,13 +2,13 @@ "connecting-1": { "id": "#connecting-1", "control": "connecting-1", - "title": "Tor Browser won't connect, but it doesn’t seem to be an issue with censorship.", + "title": "Tor Browser sa nevie pripojiť ale nezdá sa, že by to bol problém s cenzúrou.", "description": "<p class=\"mb-3\">One of the most common issues that causes connection errors in Tor Browser is an incorrect system clock. Please make sure your system clock and timezone are set accurately. If this doesn't fix the problem, see the Troubleshooting page on the <mark><a href=\"https://tb-manual.torproject.org/en-US/bridges.html\">Tor Browser manual</a></mark>.</p>" }, "connecting-2": { "id": "#connecting-2", "control": "connecting-2", - "title": "I am having trouble connecting to Tor, and I can’t figure out what’s wrong.", + "title": "Mám problém pripojiť sa k Tor a neviem prísť na to v čom je problém.", "description": "<p class=\"mb-3\">If you’re having trouble connecting, please select the option to \"copy Tor log to clipboard.\" Then paste the Tor log into a text file or other document. You should see one of these common log errors (look for the following lines in your Tor log):</p><h5>Common log error #1: Proxy connection failure</h5><p class=\"mb-3\"><pre><code> 2017-10-29 09:23:40.800 [NOTICE] Opening Socks listener on 127.0.0.1:9150 \n 2017-10-29 09:23:47.900 [NOTICE] Bootstrapped 5%: Connecting to directory server \n 2017-10-29 09:23:47.900 [NOTICE] Bootstrapped 10%: Finishing handshake with directory server \n 2017-10-29 09:24:08.900 [WARN] Proxy Client: unable to connect to xx..xxx..xxx.xx:xxxxx (\"general SOCKS server failure\") \n 2017-10-29 09:24:08.900 [WARN] Proxy Client: unable to connect to xx..xxx..xxx.xx:xxxxx (\"general SOCKS server failure\") \n 2017-10-29 09:24:08.900 [WARN] Proxy Client: unable to connect toxx..xxx..xxx.xx:xxxxx (\"general SOCKS server fa ilure\")</code></pre></p><p class=\"mb-3\">If you see lines like these in your Tor log, it means you are failing to connect to a SOCKS proxy. If a SOCKS proxy is required for your network setup, then please make sure you’ve entered your proxy details correctly. If a SOCKS proxy is not required, or you’re not sure, please try connecting to the Tor network without a SOCKS proxy.<p><h5>Common log error #2: Can’t reach guard relays</h5><p class=\"mb-3\"><pre><code> 11/1/2017 21:11:43 PM.500 [NOTICE] Opening Socks listener on 127.0.0.1:9150 \n 11/1/2017 21:11:44 PM.300 [NOTICE] Bootstrapped 80%: Connecting to the Tor network \n 11/1/2017 21:11:44 PM.300 [WARN] Failed to find node for hop 0 of our path. Discarding this circuit. \n 11/1/2017 21:11:44 PM.500 [NOTICE] Bootstrapped 85%: Finishing handshake with first hop \n 11/1/2017 21:11:45 PM.300 [WARN] Failed to find node for hop 0 of our path. Discarding this circuit.</code></pre></p><p class=\"mb-3\">If you see lines like these in your Tor log, it means your Tor failed to connect to the first node in the Tor circuit. This could mean that you’re on a network that’s censored. Please try connecting with bridges, and that should fix the problem.</p><h5>Common log error #3: Failed to complete TLS handshake</h5><p class=\"mb-3\"><pre><code> 13-11-17 19:52:24.300 [NOTICE] Bootstrapped 10%: Finishing handshake with directory server \n 13-11-17 19:53:49.300 [WARN] Problem bootstrapping. Stuck at 10%: Finishing handshake with directory server. (DONE; DONE; count 10; recommendation warn; host [host] at xxx.xxx.xxx.xx:xxx) \n 13-11-17 19:53:49.300 [WARN] 10 connections have failed: \n 13-11-17 19:53:49.300 [WARN] 9 connections died in state handshaking (TLS) with SSL state SSLv2/v3 read server hello A in HANDSHAKE \n 13-11-17 19:53:49.300 [WARN] 1 connections died in state connect()ing with SSL state (No SSL object)</code></pre></p><p class=\"mb-3\">If you see lines like this in your Tor log, it means that Tor failed to complete a TLS handshake with the directory authorities. Using bridges will likely fix this.</p><h5>Common log error #4: Clock skew</h5><p class=\"mb-3\"><pre><code> 19.11.2017 00:04:47.400 [NOTICE] Opening Socks listener on 127.0.0.1:9150 \n 19.11.2017 00:04:48.000 [NOTICE] Bootstrapped 5%: Connecting to directory server \n 19.11.2017 00:04:48.200 [NOTICE] Bootstrapped 10%: Finishing handshake with directory server \n 19.11.2017 00:04:48.800 [WARN] Received NETINFO cell with skewed time (OR:xxx.xx.x.xx:xxxx): It seems that our clock is behind by 1 days, 0 hours, 1 minutes, or that theirs is ahead. \n Tor requires an accurate clock to work: please check your time, timezone, and date settings.</code></pre></p><p class=\"mb-3\">If you see lines like this in your Tor log, it means your system clock is incorrect. Please make sure your clock is set accurately, including the correct timezone. Then restart Tor. </p>" }, "connecting-3": {

1 0