January 2018 - tor-commits - lists.torproject.org

[tor/release-0.2.9] Fix the clz32 and clz64 settings on MSVC.
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit accd0ea65bb817ad8f2361c5ca06c40ac9a9a11f Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Dec 20 09:34:25 2017 -0500 Fix the clz32 and clz64 settings on MSVC. Fixes bug 24633; bugfix on 0.2.9.1-alpha. --- changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changes/bug24633 b/changes/bug24633 new file mode 100644 index 000000000..028c7cc14 --- /dev/null +++ b/changes/bug24633 @@ -0,0 +1,5 @@ + o Minor bugfixes (portability, msvc): + - Fix a bug in the bit-counting parts of our timing-wheel code on + MSVC. (Note that MSVC is still not a supported build platform, + due to cyptographic timing channel risks.) Fixes bug 24633; + bugfix on 0.2.9.1-alpha. diff --git a/src/ext/timeouts/timeout-bitops.c b/src/ext/timeouts/timeout-bitops.c index a018f33b9..45466f6cb 100644 --- a/src/ext/timeouts/timeout-bitops.c +++ b/src/ext/timeouts/timeout-bitops.c @@ -40,7 +40,7 @@ static __inline int clz32(unsigned long val) { DWORD zeros = 0; _BitScanReverse(&zeros, val); - return zeros; + return 31 - zeros; } #ifdef _WIN64 /* According to the documentation, these only exist on Win64. */ @@ -54,7 +54,7 @@ static __inline int clz64(uint64_t val) { DWORD zeros = 0; _BitScanReverse64(&zeros, val); - return zeros; + return 63 - zeros; } #else static __inline int ctz64(uint64_t val)

1 0

[tor/release-0.3.1] Merge branch 'maint-0.3.1' into release-0.3.1
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit ed304a052f0d6575495999e516e464d34ea5f0e2 Merge: a8a060cdb c1d98c75e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 09:00:00 2018 -0500 Merge branch 'maint-0.3.1' into release-0.3.1 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.2.9' into maint-0.3.0
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit bbc9ff160e7071b7a2fa9ab200b6496580975b06 Merge: 8a7767603 c9b3f6352 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 08:59:59 2018 -0500 Merge branch 'maint-0.2.9' into maint-0.3.0 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.0] Merge branch 'maint-0.3.0' into release-0.3.0
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit 72c2292efc916a9da007108d8d019765238bb225 Merge: 698e4a478 bbc9ff160 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 08:59:59 2018 -0500 Merge branch 'maint-0.3.0' into release-0.3.0 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0

[tor/release-0.2.9] Merge branch 'bug24633_029' into maint-0.2.9
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit c9b3f6352f68a03b5380db0e459a8cd6407c5603 Merge: 6e5e4f92a accd0ea65 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 08:59:52 2018 -0500 Merge branch 'bug24633_029' into maint-0.2.9 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.3.1' into maint-0.3.2
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit 451c852a0f75fe9ac6935851e763a948c1c5b197 Merge: 2aa1767b2 c1d98c75e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 09:00:00 2018 -0500 Merge branch 'maint-0.3.1' into maint-0.3.2 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.0] Fix the clz32 and clz64 settings on MSVC.
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit accd0ea65bb817ad8f2361c5ca06c40ac9a9a11f Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Dec 20 09:34:25 2017 -0500 Fix the clz32 and clz64 settings on MSVC. Fixes bug 24633; bugfix on 0.2.9.1-alpha. --- changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changes/bug24633 b/changes/bug24633 new file mode 100644 index 000000000..028c7cc14 --- /dev/null +++ b/changes/bug24633 @@ -0,0 +1,5 @@ + o Minor bugfixes (portability, msvc): + - Fix a bug in the bit-counting parts of our timing-wheel code on + MSVC. (Note that MSVC is still not a supported build platform, + due to cyptographic timing channel risks.) Fixes bug 24633; + bugfix on 0.2.9.1-alpha. diff --git a/src/ext/timeouts/timeout-bitops.c b/src/ext/timeouts/timeout-bitops.c index a018f33b9..45466f6cb 100644 --- a/src/ext/timeouts/timeout-bitops.c +++ b/src/ext/timeouts/timeout-bitops.c @@ -40,7 +40,7 @@ static __inline int clz32(unsigned long val) { DWORD zeros = 0; _BitScanReverse(&zeros, val); - return zeros; + return 31 - zeros; } #ifdef _WIN64 /* According to the documentation, these only exist on Win64. */ @@ -54,7 +54,7 @@ static __inline int clz64(uint64_t val) { DWORD zeros = 0; _BitScanReverse64(&zeros, val); - return zeros; + return 63 - zeros; } #else static __inline int ctz64(uint64_t val)

1 0

[tor/release-0.3.2] Fix the clz32 and clz64 settings on MSVC.
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit accd0ea65bb817ad8f2361c5ca06c40ac9a9a11f Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Dec 20 09:34:25 2017 -0500 Fix the clz32 and clz64 settings on MSVC. Fixes bug 24633; bugfix on 0.2.9.1-alpha. --- changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changes/bug24633 b/changes/bug24633 new file mode 100644 index 000000000..028c7cc14 --- /dev/null +++ b/changes/bug24633 @@ -0,0 +1,5 @@ + o Minor bugfixes (portability, msvc): + - Fix a bug in the bit-counting parts of our timing-wheel code on + MSVC. (Note that MSVC is still not a supported build platform, + due to cyptographic timing channel risks.) Fixes bug 24633; + bugfix on 0.2.9.1-alpha. diff --git a/src/ext/timeouts/timeout-bitops.c b/src/ext/timeouts/timeout-bitops.c index a018f33b9..45466f6cb 100644 --- a/src/ext/timeouts/timeout-bitops.c +++ b/src/ext/timeouts/timeout-bitops.c @@ -40,7 +40,7 @@ static __inline int clz32(unsigned long val) { DWORD zeros = 0; _BitScanReverse(&zeros, val); - return zeros; + return 31 - zeros; } #ifdef _WIN64 /* According to the documentation, these only exist on Win64. */ @@ -54,7 +54,7 @@ static __inline int clz64(uint64_t val) { DWORD zeros = 0; _BitScanReverse64(&zeros, val); - return zeros; + return 63 - zeros; } #else static __inline int ctz64(uint64_t val)

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.1' into maint-0.3.2
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit 451c852a0f75fe9ac6935851e763a948c1c5b197 Merge: 2aa1767b2 c1d98c75e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 09:00:00 2018 -0500 Merge branch 'maint-0.3.1' into maint-0.3.2 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.0' into maint-0.3.1
by nickm＠torproject.org 03 Jan '18

03 Jan '18

commit c1d98c75e305eaf63e81903ca5a4eb68dcae515b Merge: fb5877b97 bbc9ff160 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 3 08:59:59 2018 -0500 Merge branch 'maint-0.3.0' into maint-0.3.1 changes/bug24633 | 5 +++++ src/ext/timeouts/timeout-bitops.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)

1 0