tor-commits September 2017

tor-commits@lists.torproject.org

16 participants
2950 discussions

[tor/master] Make hs_ntor_ref.py work with python3
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit 63ae9ea316f77346ed2e1941958916fd3a5207a1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 10:48:28 2017 -0400 Make hs_ntor_ref.py work with python3 --- src/test/hs_ntor_ref.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/test/hs_ntor_ref.py b/src/test/hs_ntor_ref.py index 3dd2d6d6e..2ed9324e1 100644 --- a/src/test/hs_ntor_ref.py +++ b/src/test/hs_ntor_ref.py @@ -83,11 +83,11 @@ from ntor_ref import hash_nil from ntor_ref import PrivateKey # String constants used in this protocol -PROTOID = "tor-hs-ntor-curve25519-sha3-256-1" -T_HSENC = PROTOID + ":hs_key_extract" -T_HSVERIFY = PROTOID + ":hs_verify" -T_HSMAC = PROTOID + ":hs_mac" -M_HSEXPAND = PROTOID + ":hs_key_expand" +PROTOID = b"tor-hs-ntor-curve25519-sha3-256-1" +T_HSENC = PROTOID + b":hs_key_extract" +T_HSVERIFY = PROTOID + b":hs_verify" +T_HSMAC = PROTOID + b":hs_mac" +M_HSEXPAND = PROTOID + b":hs_key_expand" INTRO_SECRET_LEN = 161 REND_SECRET_LEN = 225 @@ -191,7 +191,7 @@ def service_part1(intro_auth_pubkey_str, client_enc_pubkey, intro_enc_privkey, i ntor_key_seed = mac(rend_secret_hs_input, T_HSENC) verify = mac(rend_secret_hs_input, T_HSVERIFY) - auth_input = verify + intro_auth_pubkey_str + intro_enc_pubkey.serialize() + service_ephemeral_pubkey.serialize() + client_enc_pubkey.serialize() + PROTOID + "Server" + auth_input = verify + intro_auth_pubkey_str + intro_enc_pubkey.serialize() + service_ephemeral_pubkey.serialize() + client_enc_pubkey.serialize() + PROTOID + b"Server" assert(len(auth_input) == AUTH_INPUT_LEN) auth_input_mac = mac(auth_input, T_HSMAC) @@ -218,7 +218,7 @@ def client_part2(intro_auth_pubkey_str, client_ephemeral_enc_pubkey, client_ephe ntor_key_seed = mac(rend_secret_hs_input, T_HSENC) verify = mac(rend_secret_hs_input, T_HSVERIFY) - auth_input = verify + intro_auth_pubkey_str + intro_enc_pubkey.serialize() + service_ephemeral_rend_pubkey.serialize() + client_ephemeral_enc_pubkey.serialize() + PROTOID + "Server" + auth_input = verify + intro_auth_pubkey_str + intro_enc_pubkey.serialize() + service_ephemeral_rend_pubkey.serialize() + client_ephemeral_enc_pubkey.serialize() + PROTOID + b"Server" assert(len(auth_input) == AUTH_INPUT_LEN) auth_input_mac = mac(auth_input, T_HSMAC) @@ -294,7 +294,7 @@ def do_pure_python_ntor_test(): assert(client_ntor_key_seed == service_ntor_key_seed) assert(client_auth_input_mac == service_auth_input_mac) - print "DONE: python dance [%s]" % repr(client_auth_input_mac) + print("DONE: python dance [%s]" % repr(client_auth_input_mac)) # Perform a pure little-t-tor integration test. def do_little_t_tor_ntor_test(): @@ -334,7 +334,7 @@ def do_little_t_tor_ntor_test(): assert(client_ntor_key_seed == service_ntor_key_seed) assert(client_ntor_auth_mac == service_ntor_auth_mac) - print "DONE: tor dance [%s]" % repr(client_ntor_auth_mac) + print("DONE: tor dance [%s]" % repr(client_ntor_auth_mac)) """ Do mixed test as follows: @@ -379,7 +379,7 @@ def do_first_mixed_test(): assert(client_auth_input_mac == service_ntor_auth_mac) assert(client_ntor_key_seed == service_ntor_key_seed) - print "DONE: 1st mixed dance [%s]" % repr(client_auth_input_mac) + print("DONE: 1st mixed dance [%s]" % repr(client_auth_input_mac)) """ Do mixed test as follows: @@ -413,7 +413,7 @@ def do_second_mixed_test(): assert(client_ntor_key_seed == service_ntor_key_seed) assert(client_ntor_auth_mac == service_ntor_auth_mac) - print "DONE: 2nd mixed dance [%s]" % repr(client_ntor_auth_mac) + print("DONE: 2nd mixed dance [%s]" % repr(client_ntor_auth_mac)) def do_mixed_tests(): do_first_mixed_test()

1 0

[tor/maint-0.3.1] Make hs_ntor_ref.py work with python3
by nickm＠torproject.org 18 Sep '17

18 Sep '17

1 0

[tor/release-0.3.1] Make hs_ntor_ref.py work with python3
by nickm＠torproject.org 18 Sep '17

18 Sep '17

1 0

[tor/release-0.3.1] Merge branch 'maint-0.3.1' into release-0.3.1
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit 6babd3d9ba9318b38b5af7278875efe84055a1b0 Merge: 9d35ddf11 63ae9ea31 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 10:48:31 2017 -0400 Merge branch 'maint-0.3.1' into release-0.3.1 src/test/hs_ntor_ref.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 18 Sep '17

18 Sep '17

commit 6737b4fe2be789c8c236f1248284d8d378742ae7 Author: Translation commit bot <translation(a)torproject.org> Date: Mon Sep 18 14:45:33 2017 +0000 Update translations for https_everywhere --- uk/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uk/https-everywhere.dtd b/uk/https-everywhere.dtd index 044decaba..1947819bd 100644 --- a/uk/https-everywhere.dtd +++ b/uk/https-everywhere.dtd @@ -25,7 +25,7 @@ <!ENTITY https-everywhere.menu.viewAllRules "Переглянути всі правила"> <!ENTITY https-everywhere.options.importSettings "Import Settings"> -<!ENTITY https-everywhere.options.import "Import"> +<!ENTITY https-everywhere.options.import "Імпортувати"> <!ENTITY https-everywhere.options.imported "Your settings have been imported."> <!ENTITY https-everywhere.prefs.title "Налаштування HTTPS Everywhere">

1 0

[tor/release-0.2.8] Finish changelog for 0.2.8.15
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit e25e980285a80231956dba6d3c89a25c27fdf94f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 09:57:45 2017 -0400 Finish changelog for 0.2.8.15 --- ChangeLog | 13 ++++++++++++- ReleaseNotes | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ changes/trove-2017-008 | 5 ----- 3 files changed, 62 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 602069f5f..28303c082 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,16 @@ Changes in version 0.2.8.15 - 2017-09-18 - BLURB + Tor 0.2.8.15 backports a collection of bugfixes from later + Tor series. + + Most significantly, it includes a fix for TROVE-2017-008, a + security bug that affects hidden services running with the + SafeLogging option disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 + + Note that Tor 0.2.8.x will no longer be supported after 1 Jan + 2018. We suggest that you upgrade to the latest stable release if + possible. If you can't, we recommend that you upgrade at least to + 0.2.9, which will be supported until 2020. o Major bugfixes (openbsd, denial-of-service, backport from 0.3.1.5-alpha): - Avoid an assertion failure bug affecting our implementation of diff --git a/ReleaseNotes b/ReleaseNotes index 9353cd086..2d67f5b89 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -2,6 +2,56 @@ This document summarizes new features and bugfixes in each stable release of Tor. If you want to see more detailed descriptions of the changes in each development snapshot, see the ChangeLog file. +Changes in version 0.2.8.15 - 2017-09-18 + Tor 0.2.8.15 backports a collection of bugfixes from later + Tor series. + + Most significantly, it includes a fix for TROVE-2017-008, a + security bug that affects hidden services running with the + SafeLogging option disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 + + Note that Tor 0.2.8.x will no longer be supported after 1 Jan + 2018. We suggest that you upgrade to the latest stable release if + possible. If you can't, we recommend that you upgrade at least to + 0.2.9, which will be supported until 2020. + + o Major bugfixes (openbsd, denial-of-service, backport from 0.3.1.5-alpha): + - Avoid an assertion failure bug affecting our implementation of + inet_pton(AF_INET6) on certain OpenBSD systems whose strtol() + handling of "0xx" differs from what we had expected. Fixes bug + 22789; bugfix on 0.2.3.8-alpha. Also tracked as TROVE-2017-007. + + o Minor features: + - Update geoip and geoip6 to the September 6 2017 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (compilation, mingw, backport from 0.3.1.1-alpha): + - Backport a fix for an "unused variable" warning that appeared + in some versions of mingw. Fixes bug 22838; bugfix on + 0.2.8.1-alpha. + + o Minor bugfixes (defensive programming, undefined behavior, backport from 0.3.1.4-alpha): + - Fix a memset() off the end of an array when packing cells. This + bug should be harmless in practice, since the corrupted bytes are + still in the same structure, and are always padding bytes, + ignored, or immediately overwritten, depending on compiler + behavior. Nevertheless, because the memset()'s purpose is to make + sure that any other cell-handling bugs can't expose bytes to the + network, we need to fix it. Fixes bug 22737; bugfix on + 0.2.4.11-alpha. Fixes CID 1401591. + + o Build features (backport from 0.3.1.5-alpha): + - Tor's repository now includes a Travis Continuous Integration (CI) + configuration file (.travis.yml). This is meant to help new + developers and contributors who fork Tor to a Github repository be + better able to test their changes, and understand what we expect + to pass. To use this new build feature, you must fork Tor to your + Github account, then go into the "Integrations" menu in the + repository settings for your fork and enable Travis, then push + your changes. Closes ticket 22636. + + Changes in version 0.2.8.14 - 2017-06-08 Tor 0.2.7.8 backports a fix for a bug that would allow an attacker to remotely crash a hidden service with an assertion failure. Anyone diff --git a/changes/trove-2017-008 b/changes/trove-2017-008 deleted file mode 100644 index 4b9c5b0a1..000000000 --- a/changes/trove-2017-008 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (security, hidden services, loggging): - - Fix a bug where we could log uninitialized stack when a certain - hidden service error occurred while SafeLogging was disabled. - Fixes bug #23490; bugfix on 0.2.7.2-alpha. - This is also tracked as TROVE-2017-008 and CVE-2017-0380.

1 0

[tor/release-0.3.0] finish changelog for 0.3.0.11
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit 5cb83c942584f86830ef1d13a9cd2501eea367c4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 09:56:54 2017 -0400 finish changelog for 0.3.0.11 --- ChangeLog | 9 ++++++--- ReleaseNotes | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ changes/trove-2017-008 | 5 ----- 3 files changed, 54 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4a7795113..93adb09ed 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,11 @@ Changes in version 0.3.0.11 - 2017-09-18 - Tor 0.3.0.11 backports a collection of bugfixes from Tor the 0.3.1 - series. + Tor 0.3.0.11 backports a collection of bugfixes from Tor the 0.3.1 + series. - MORE HERE. + Most significantly, it includes a fix for TROVE-2017-008, a + security bug that affects hidden services running with the + SafeLogging option disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 o Minor features (code style, backport from 0.3.1.7): - Add "Falls through" comments to our codebase, in order to silence diff --git a/ReleaseNotes b/ReleaseNotes index 1dd3d9530..aaa7a5c46 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -2,6 +2,54 @@ This document summarizes new features and bugfixes in each stable release of Tor. If you want to see more detailed descriptions of the changes in each development snapshot, see the ChangeLog file. +Changes in version 0.3.0.11 - 2017-09-18 + Tor 0.3.0.11 backports a collection of bugfixes from Tor the 0.3.1 + series. + + Most significantly, it includes a fix for TROVE-2017-008, a + security bug that affects hidden services running with the + SafeLogging option disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 + + Note: now that Tor 0.3.1.x is stable and released, support for the + 0.3.0.x series will end on 26 Jan 2018. For longer term support, + either upgrade to the most recent 0.3.1.x release, or downgrade to + 0.2.9.x for long-term support. + + o Minor features (code style, backport from 0.3.1.7): + - Add "Falls through" comments to our codebase, in order to silence + GCC 7's -Wimplicit-fallthrough warnings. Patch from Andreas + Stieger. Closes ticket 22446. + + o Minor features: + - Update geoip and geoip6 to the September 6 2017 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (compilation, backport from 0.3.1.7): + - Avoid compiler warnings in the unit tests for calling tor_sscanf() + with wide string outputs. Fixes bug 15582; bugfix on 0.2.6.2-alpha. + + o Minor bugfixes (controller, backport from 0.3.1.7): + - Do not crash when receiving a HSPOST command with an empty body. + Fixes part of bug 22644; bugfix on 0.2.7.1-alpha. + - Do not crash when receiving a POSTDESCRIPTOR command with an empty + body. Fixes part of bug 22644; bugfix on 0.2.0.1-alpha. + + o Minor bugfixes (file limits, osx, backport from 0.3.1.5-alpha): + - When setting the maximum number of connections allowed by the OS, + always allow some extra file descriptors for other files. Fixes + bug 22797; bugfix on 0.2.0.10-alpha. + + o Minor bugfixes (logging, relay, backport from 0.3.1.6-rc): + - Remove a forgotten debugging message when an introduction point + successfully establishes a hidden service prop224 circuit with + a client. + - Change three other log_warn() for an introduction point to + protocol warnings, because they can be failure from the network + and are not relevant to the operator. Fixes bug 23078; bugfix on + 0.3.0.1-alpha and 0.3.0.2-alpha. + + Changes in version 0.3.0.10 - 2017-08-02 Tor 0.3.0.10 backports a collection of small-to-medium bugfixes from the current Tor alpha series. OpenBSD users and TPROXY users diff --git a/changes/trove-2017-008 b/changes/trove-2017-008 deleted file mode 100644 index 4b9c5b0a1..000000000 --- a/changes/trove-2017-008 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (security, hidden services, loggging): - - Fix a bug where we could log uninitialized stack when a certain - hidden service error occurred while SafeLogging was disabled. - Fixes bug #23490; bugfix on 0.2.7.2-alpha. - This is also tracked as TROVE-2017-008 and CVE-2017-0380.

1 0

[tor/release-0.3.1] Finish changelog and release notes for 0.3.1.7
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit 9d35ddf110dc1737af4f12c4135a03cb7ac3c85d Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 09:50:05 2017 -0400 Finish changelog and release notes for 0.3.1.7 --- ChangeLog | 20 +++++++++++++++----- ReleaseNotes | 20 +++++++++++++++----- changes/bug23533 | 4 ---- changes/trove-2017-008 | 5 ----- 4 files changed, 30 insertions(+), 19 deletions(-) diff --git a/ChangeLog b/ChangeLog index 282cb3e8d..0c8c0d310 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,11 +9,10 @@ Changes in version 0.3.1.7 - 2017-09-18 small features, bugfixes on earlier release series, and groundwork for the hidden services revamp of 0.3.2. - Per our stable release policy, we plan to support the Tor 0.3.0 - release series for at least the next nine months, or for three months - after the first stable release of the 0.3.1 series: whichever is - longer. If you need a release with long-term support, we recommend - that you stay with the 0.2.9 series. + This release also includes a fix for TROVE-2017-008, a security bug + that affects hidden services running with the SafeLogging option + disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 Per our stable release policy, we plan to support each stable release series for at least the next nine months, or for three months after @@ -24,6 +23,12 @@ Changes in version 0.3.1.7 - 2017-09-18 Below is a list of the changes since 0.3.1.6-rc. For a list of all changes since 0.3.0, see the ReleaseNotes file. + o Major bugfixes (security, hidden services, loggging): + - Fix a bug where we could log uninitialized stack when a certain + hidden service error occurred while SafeLogging was disabled. + Fixes bug #23490; bugfix on 0.2.7.2-alpha. This is also tracked as + TROVE-2017-008 and CVE-2017-0380. + o Minor features (defensive programming): - Create a pair of consensus parameters, nf_pad_tor2web and nf_pad_single_onion, to disable netflow padding in the consensus @@ -49,6 +54,11 @@ Changes in version 0.3.1.7 - 2017-09-18 - Do not crash when receiving a POSTDESCRIPTOR command with an empty body. Fixes part of bug 22644; bugfix on 0.2.0.1-alpha. + o Minor bugfixes (relay): + - Inform the geoip and rephist modules about all requests, even on + relays that are only fetching microdescriptors. Fixes a bug + related to 21585; bugfix on 0.3.0.1-alpha. + o Minor bugfixes (unit tests): - Fix a channelpadding unit test failure on slow systems by using mocked time instead of actual time. Fixes bug 23077; bugfix diff --git a/ReleaseNotes b/ReleaseNotes index 8328b63c1..e8a9f3b41 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -13,11 +13,10 @@ Changes in version 0.3.1.7 - 2017-09-18 small features, bugfixes on earlier release series, and groundwork for the hidden services revamp of 0.3.2. - Per our stable release policy, we plan to support the Tor 0.3.0 - release series for at least the next nine months, or for three months - after the first stable release of the 0.3.1 series: whichever is - longer. If you need a release with long-term support, we recommend - that you stay with the 0.2.9 series. + This release also includes a fix for TROVE-2017-008, a security bug + that affects hidden services running with the SafeLogging option + disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 Per our stable release policy, we plan to support each stable release series for at least the next nine months, or for three months after @@ -32,6 +31,12 @@ Changes in version 0.3.1.7 - 2017-09-18 - To build with zstd and lzma support, Tor now requires the pkg-config tool at build time. + o Major bugfixes (security, hidden services, loggging): + - Fix a bug where we could log uninitialized stack when a certain + hidden service error occurred while SafeLogging was disabled. + Fixes bug #23490; bugfix on 0.2.7.2-alpha. + This is also tracked as TROVE-2017-008 and CVE-2017-0380. + o Major features (build system, continuous integration): - Tor's repository now includes a Travis Continuous Integration (CI) configuration file (.travis.yml). This is meant to help new @@ -515,6 +520,11 @@ Changes in version 0.3.1.7 - 2017-09-18 and are not relevant to the operator. Fixes bug 23078; bugfix on 0.3.0.1-alpha and 0.3.0.2-alpha. + o Minor bugfixes (relay): + - Inform the geoip and rephist modules about all requests, even on + relays that are only fetching microdescriptors. Fixes a bug + related to 21585; bugfix on 0.3.0.1-alpha. + o Minor bugfixes (memory leaks): - Fix a small memory leak at exit from the backtrace handler code. Fixes bug 21788; bugfix on 0.2.5.2-alpha. Patch from Daniel Pinto. diff --git a/changes/bug23533 b/changes/bug23533 deleted file mode 100644 index b5bfdc0ce..000000000 --- a/changes/bug23533 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (relay): - - Inform the geoip and rephist modules about all requests, even - on relays that are only fetching microdescriptors. Fixes a bug related - to 21585; bugfix on 0.3.0.1-alpha. diff --git a/changes/trove-2017-008 b/changes/trove-2017-008 deleted file mode 100644 index 4b9c5b0a1..000000000 --- a/changes/trove-2017-008 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (security, hidden services, loggging): - - Fix a bug where we could log uninitialized stack when a certain - hidden service error occurred while SafeLogging was disabled. - Fixes bug #23490; bugfix on 0.2.7.2-alpha. - This is also tracked as TROVE-2017-008 and CVE-2017-0380.

1 0

[tor/release-0.2.9] finish changelog for 0.2.9.12
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit 2e47bfad4f596dc39ab31bc66056a07d05715270 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 09:57:26 2017 -0400 finish changelog for 0.2.9.12 --- ChangeLog | 8 ++- ReleaseNotes | 129 +++++++++++++++++++++++++++++++++++++++++++++++++ changes/trove-2017-008 | 5 -- 3 files changed, 136 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index c4ba66832..2fc7eb5e9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ Changes in version 0.2.9.12 - 2017-09-18 - BLURB + Tor 0.2.9.12 backports a collection of bugfixes from later + Tor series. + + Most significantly, it includes a fix for TROVE-2017-008, a + security bug that affects hidden services running with the + SafeLogging option disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 o Major features (security, backport from 0.3.0.2-alpha): - Change the algorithm used to decide DNS TTLs on client and server diff --git a/ReleaseNotes b/ReleaseNotes index 0057fbd44..8621cefa9 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -2,6 +2,135 @@ This document summarizes new features and bugfixes in each stable release of Tor. If you want to see more detailed descriptions of the changes in each development snapshot, see the ChangeLog file. +Changes in version 0.2.9.12 - 2017-09-18 + Tor 0.2.9.12 backports a collection of bugfixes from later + Tor series. + + Most significantly, it includes a fix for TROVE-2017-008, a + security bug that affects hidden services running with the + SafeLogging option disabled. For more information, see + https://trac.torproject.org/projects/tor/ticket/23490 + + o Major features (security, backport from 0.3.0.2-alpha): + - Change the algorithm used to decide DNS TTLs on client and server + side, to better resist DNS-based correlation attacks like the + DefecTor attack of Greschbach, Pulls, Roberts, Winter, and + Feamster. Now relays only return one of two possible DNS TTL + values, and clients are willing to believe DNS TTL values up to 3 + hours long. Closes ticket 19769. + + o Major bugfixes (crash, directory connections, backport from 0.3.0.5-rc): + - Fix a rare crash when sending a begin cell on a circuit whose + linked directory connection had already been closed. Fixes bug + 21576; bugfix on 0.2.9.3-alpha. Reported by Alec Muffett. + + o Major bugfixes (DNS, backport from 0.3.0.2-alpha): + - Fix a bug that prevented exit nodes from caching DNS records for + more than 60 seconds. Fixes bug 19025; bugfix on 0.2.4.7-alpha. + + o Major bugfixes (linux TPROXY support, backport from 0.3.1.1-alpha): + - Fix a typo that had prevented TPROXY-based transparent proxying + from working under Linux. Fixes bug 18100; bugfix on 0.2.6.3-alpha. + Patch from "d4fq0fQAgoJ". + + o Major bugfixes (openbsd, denial-of-service, backport from 0.3.1.5-alpha): + - Avoid an assertion failure bug affecting our implementation of + inet_pton(AF_INET6) on certain OpenBSD systems whose strtol() + handling of "0xx" differs from what we had expected. Fixes bug + 22789; bugfix on 0.2.3.8-alpha. Also tracked as TROVE-2017-007. + + o Minor features (code style, backport from 0.3.1.3-alpha): + - Add "Falls through" comments to our codebase, in order to silence + GCC 7's -Wimplicit-fallthrough warnings. Patch from Andreas + Stieger. Closes ticket 22446. + + o Minor features (geoip): + - Update geoip and geoip6 to the September 6 2017 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (bandwidth accounting, backport from 0.3.1.1-alpha): + - Roll over monthly accounting at the configured hour and minute, + rather than always at 00:00. Fixes bug 22245; bugfix on 0.0.9rc1. + Found by Andrey Karpov with PVS-Studio. + + o Minor bugfixes (compilation, backport from 0.3.1.5-alpha): + - Suppress -Wdouble-promotion warnings with clang 4.0. Fixes bug 22915; + bugfix on 0.2.8.1-alpha. + - Fix warnings when building with libscrypt and openssl scrypt support + on Clang. Fixes bug 22916; bugfix on 0.2.7.2-alpha. + - When building with certain versions the mingw C header files, avoid + float-conversion warnings when calling the C functions isfinite(), + isnan(), and signbit(). Fixes bug 22801; bugfix on 0.2.8.1-alpha. + + o Minor bugfixes (compilation, backport from 0.3.1.7): + - Avoid compiler warnings in the unit tests for running tor_sscanf() + with wide string outputs. Fixes bug 15582; bugfix on 0.2.6.2-alpha. + + o Minor bugfixes (compilation, mingw, backport from 0.3.1.1-alpha): + - Backport a fix for an "unused variable" warning that appeared + in some versions of mingw. Fixes bug 22838; bugfix on + 0.2.8.1-alpha. + + o Minor bugfixes (controller, backport from 0.3.1.7): + - Do not crash when receiving a HSPOST command with an empty body. + Fixes part of bug 22644; bugfix on 0.2.7.1-alpha. + - Do not crash when receiving a POSTDESCRIPTOR command with an + empty body. Fixes part of bug 22644; bugfix on 0.2.0.1-alpha. + + o Minor bugfixes (coverity build support, backport from 0.3.1.5-alpha): + - Avoid Coverity build warnings related to our BUG() macro. By + default, Coverity treats BUG() as the Linux kernel does: an + instant abort(). We need to override that so our BUG() macro + doesn't prevent Coverity from analyzing functions that use it. + Fixes bug 23030; bugfix on 0.2.9.1-alpha. + + o Minor bugfixes (defensive programming, undefined behavior, backport from 0.3.1.4-alpha): + - Fix a memset() off the end of an array when packing cells. This + bug should be harmless in practice, since the corrupted bytes are + still in the same structure, and are always padding bytes, + ignored, or immediately overwritten, depending on compiler + behavior. Nevertheless, because the memset()'s purpose is to make + sure that any other cell-handling bugs can't expose bytes to the + network, we need to fix it. Fixes bug 22737; bugfix on + 0.2.4.11-alpha. Fixes CID 1401591. + + o Minor bugfixes (file limits, osx, backport from 0.3.1.5-alpha): + - When setting the maximum number of connections allowed by the OS, + always allow some extra file descriptors for other files. Fixes + bug 22797; bugfix on 0.2.0.10-alpha. + + o Minor bugfixes (linux seccomp2 sandbox, backport from 0.3.1.5-alpha): + - Avoid a sandbox failure when trying to re-bind to a socket and + mark it as IPv6-only. Fixes bug 20247; bugfix on 0.2.5.1-alpha. + + o Minor bugfixes (linux seccomp2 sandbox, backport from 0.3.1.4-alpha): + - Permit the fchmod system call, to avoid crashing on startup when + starting with the seccomp2 sandbox and an unexpected set of + permissions on the data directory or its contents. Fixes bug + 22516; bugfix on 0.2.5.4-alpha. + + o Minor bugfixes (relay, backport from 0.3.0.5-rc): + - Avoid a double-marked-circuit warning that could happen when we + receive DESTROY cells under heavy load. Fixes bug 20059; bugfix + on 0.1.0.1-rc. + + o Minor bugfixes (voting consistency, backport from 0.3.1.1-alpha): + - Reject version numbers with non-numeric prefixes (such as +, -, or + whitespace). Disallowing whitespace prevents differential version + parsing between POSIX-based and Windows platforms. Fixes bug 21507 + and part of 21508; bugfix on 0.0.8pre1. + + o Build features (backport from 0.3.1.5-alpha): + - Tor's repository now includes a Travis Continuous Integration (CI) + configuration file (.travis.yml). This is meant to help new + developers and contributors who fork Tor to a Github repository be + better able to test their changes, and understand what we expect + to pass. To use this new build feature, you must fork Tor to your + Github account, then go into the "Integrations" menu in the + repository settings for your fork and enable Travis, then push + your changes. Closes ticket 22636. + + Changes in version 0.2.9.11 - 2017-06-08 Tor 0.2.9.11 backports a fix for a bug that would allow an attacker to remotely crash a hidden service with an assertion failure. Anyone diff --git a/changes/trove-2017-008 b/changes/trove-2017-008 deleted file mode 100644 index 4b9c5b0a1..000000000 --- a/changes/trove-2017-008 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (security, hidden services, loggging): - - Fix a bug where we could log uninitialized stack when a certain - hidden service error occurred while SafeLogging was disabled. - Fixes bug #23490; bugfix on 0.2.7.2-alpha. - This is also tracked as TROVE-2017-008 and CVE-2017-0380.

1 0

[tor/master] Fix log-uninitialized-stack bug in rend_service_intro_established.
by nickm＠torproject.org 18 Sep '17

18 Sep '17

commit 4a2cbea6ce585fcdaf86a80ccf39bceb4137e86a Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 18 09:25:21 2017 -0400 Fix log-uninitialized-stack bug in rend_service_intro_established. Fixes bug 23490; bugfix on 0.2.7.2-alpha. TROVE-2017-008 CVE-2017-0380 --- changes/trove-2017-008 | 5 +++++ src/or/rendservice.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changes/trove-2017-008 b/changes/trove-2017-008 new file mode 100644 index 000000000..4b9c5b0a1 --- /dev/null +++ b/changes/trove-2017-008 @@ -0,0 +1,5 @@ + o Major bugfixes (security, hidden services, loggging): + - Fix a bug where we could log uninitialized stack when a certain + hidden service error occurred while SafeLogging was disabled. + Fixes bug #23490; bugfix on 0.2.7.2-alpha. + This is also tracked as TROVE-2017-008 and CVE-2017-0380. diff --git a/src/or/rendservice.c b/src/or/rendservice.c index b81a01c56..0a5b5efd5 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -2859,6 +2859,8 @@ rend_service_intro_established(origin_circuit_t *circuit, (unsigned)circuit->base_.n_circ_id); goto err; } + base32_encode(serviceid, REND_SERVICE_ID_LEN_BASE32 + 1, + circuit->rend_data->rend_pk_digest, REND_SERVICE_ID_LEN); /* We've just successfully established a intro circuit to one of our * introduction point, account for it. */ intro = find_intro_point(circuit); @@ -2875,8 +2877,6 @@ rend_service_intro_established(origin_circuit_t *circuit, service->desc_is_dirty = time(NULL); circuit_change_purpose(TO_CIRCUIT(circuit), CIRCUIT_PURPOSE_S_INTRO); - base32_encode(serviceid, REND_SERVICE_ID_LEN_BASE32 + 1, - circuit->rend_data->rend_pk_digest, REND_SERVICE_ID_LEN); log_info(LD_REND, "Received INTRO_ESTABLISHED cell on circuit %u for service %s", (unsigned)circuit->base_.n_circ_id, serviceid);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits September 2017