September 2017 - tor-commits - lists.torproject.org

[torspec/master] Document exact contents of RELAY_RESOLVED cells
by nickm＠torproject.org 19 Sep '17

19 Sep '17

commit 9f390c36febd23e9d3fda4203fd261ee03056e3c Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 19 09:42:49 2017 -0400 Document exact contents of RELAY_RESOLVED cells We had been vague about what the Value fields here were. Also, document that addresses in NETINFO don't have TTLs. Closes ticket 22937. --- tor-spec.txt | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tor-spec.txt b/tor-spec.txt index 4d572ec..16dc74b 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -706,9 +706,9 @@ see tor-design.pdf. Number of addresses [1 byte] This OR's addresses [variable] - The address format is a type/length/value sequence as given in section - 6.4 below. The timestamp is a big-endian unsigned integer number of - seconds since the Unix epoch. + The address format is a type/length/value sequence as given in + section 6.4 below, without the final TTL. The timestamp is a + big-endian unsigned integer number of seconds since the Unix epoch. Implementations MAY use the timestamp value to help decide if their clocks are skewed. Initiators MAY use "other OR's address" to help @@ -1522,7 +1522,16 @@ see tor-design.pdf. 0xF0 -- Error, transient 0xF1 -- Error, nontransient - If any answer has a type of 'Error', then no other answer may be given. + If any answer has a type of 'Error', then no other answer may be + given. + + The 'Value' field encodes the answer: + IP addresses are given in network order. + Hostnames are given in standard DNS order ("www.example.com") + and not NUL-terminated. + The content of Errors is currently ignored. Relays currently + set it to the string "Error resolving hostname" with no + terminating NUL. Implementations MUST ignore this value. For backward compatibility, if there are any IPv4 answers, one of those must be given as the first answer.

1 0

[tor-browser-build/master] Bug 23039: fix detection of runc version
by gk＠torproject.org 19 Sep '17

19 Sep '17

commit 1f054c59ddc349cf5719447bc51eaccde554312a Author: Nicolas Vigier <boklm(a)torproject.org> Date: Tue Sep 19 13:28:34 2017 +0200 Bug 23039: fix detection of runc version In the previous patch, we wrongly assumed that all runc 0.1.1 versions exited with 0 when given an unknown command, and used that to detect the version. It seems it is not true on all systems. We are now using the 'runc --version' command to find the version of runc. We don't support versions older than 0.1.1. --- rbm.conf | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/rbm.conf b/rbm.conf index ef37575..a93fa1a 100644 --- a/rbm.conf +++ b/rbm.conf @@ -375,11 +375,10 @@ ENV: ( var_p => { # runc100 is true if we are using runc >= 1.0.0 + # we assume that any version that is not 0.1.1 is >= 1.0.0 runc100 => sub { - # runc >= 1.0.0 exits with an error when trying to use an unknown - # command while older versions exit with 0 - my (undef, undef, $success) = capture_exec('sudo', 'runc', 'xyzxyzxyz'); - return !$success; + my ($out) = capture_exec('sudo', 'runc', '--version'); + return !($out =~ m/^runc version 0.1.1/); }, }, )

1 0

[torspec/master] Correct our description of circID MSB logic
by nickm＠torproject.org 19 Sep '17

19 Sep '17

commit 3540da456b70c46d7601101b73c57439c455ff73 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 19 09:35:22 2017 -0400 Correct our description of circID MSB logic In protocol <= 3 we allowed OPs to set the circID msb however they wanted. We don't do that any more in >= 4. Closes ticket 22882. --- tor-spec.txt | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tor-spec.txt b/tor-spec.txt index f7bd546..4d572ec 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -792,18 +792,19 @@ see tor-design.pdf. To prevent CircID collisions, when one node sends a CREATE cell to another, it chooses from only one half of the possible values based - on the ORs' public identity keys. In link protocol version 3 or - lower, if the sending node has a lower key, it chooses a CircID with - an MSB of 0; otherwise, it chooses a CircID with an MSB of 1. (Public - keys are compared numerically by modulus.) + on the ORs' public identity keys. + + In link protocol version 3 or lower, if the sending node has a lower + key, it chooses a CircID with an MSB of 0; otherwise, it chooses a + CircID with an MSB of 1. (Public keys are compared numerically by + modulus.) With protocol version 3 or lower, a client with no public key + MAY choose any CircID it wishes, since clients never need to process a + CREATE cell. In link protocol version 4 or higher, whichever node initiated the connection sets its MSB to 1, and whichever node didn't initiate the connection sets its MSB to 0. - (An OP with no public key MAY choose any CircID it wishes, since an OP - never needs to process a CREATE cell.) - The CircID value 0 is specifically reserved for cells that do not belong to any circuit: CircID 0 must not be used for circuits. No other CircID value, including 0x8000 or 0x80000000, is reserved.

1 0

[translation/torcheck_completed] Update translations for torcheck_completed
by translation＠torproject.org 19 Sep '17

19 Sep '17

commit d78134cf1b54532ef5e4e2adb9b0332bd4b99ee6 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Sep 19 13:15:17 2017 +0000 Update translations for torcheck_completed --- pa/torcheck.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pa/torcheck.po b/pa/torcheck.po index 26e74329b..2213e8648 100644 --- a/pa/torcheck.po +++ b/pa/torcheck.po @@ -9,7 +9,7 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2016-07-26 23:43+0000\n" +"PO-Revision-Date: 2017-09-19 12:56+0000\n" "Last-Translator: Punjabi Fied <towtruckerwiki(a)gmail.com>\n" "Language-Team: Panjabi (Punjabi) (http://www.transifex.com/otf/torproject/language/pa/)\n" "MIME-Version: 1.0\n"

1 0

[translation/torcheck] Update translations for torcheck
by translation＠torproject.org 19 Sep '17

19 Sep '17

commit bb73258b33b53222f404582ddf7ba832f9cc97da Author: Translation commit bot <translation(a)torproject.org> Date: Tue Sep 19 13:15:13 2017 +0000 Update translations for torcheck --- ms_MY/torcheck.po | 4 ++-- pa/torcheck.po | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ms_MY/torcheck.po b/ms_MY/torcheck.po index c56054db0..15c435ced 100644 --- a/ms_MY/torcheck.po +++ b/ms_MY/torcheck.po @@ -9,8 +9,8 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2016-03-21 16:27+0000\n" -"Last-Translator: runasand <runa.sandvik(a)gmail.com>\n" +"PO-Revision-Date: 2017-09-19 12:58+0000\n" +"Last-Translator: runasand <inactive+runasand(a)transifex.com>\n" "Language-Team: Malay (Malaysia) (http://www.transifex.com/otf/torproject/language/ms_MY/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/pa/torcheck.po b/pa/torcheck.po index 26e74329b..2213e8648 100644 --- a/pa/torcheck.po +++ b/pa/torcheck.po @@ -9,7 +9,7 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2016-07-26 23:43+0000\n" +"PO-Revision-Date: 2017-09-19 12:56+0000\n" "Last-Translator: Punjabi Fied <towtruckerwiki(a)gmail.com>\n" "Language-Team: Panjabi (Punjabi) (http://www.transifex.com/otf/torproject/language/pa/)\n" "MIME-Version: 1.0\n"

1 0

[tor/master] doc: Add version 3 to HiddenServiceVersion man page entry
by nickm＠torproject.org 19 Sep '17

19 Sep '17

commit 6f313edc8a92ac9279ba18f4bbe257093226df03 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Sep 19 08:38:53 2017 -0400 doc: Add version 3 to HiddenServiceVersion man page entry Fixes #23580 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug23580 | 3 +++ doc/tor.1.txt | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/bug23580 b/changes/bug23580 new file mode 100644 index 000000000..45c825fb6 --- /dev/null +++ b/changes/bug23580 @@ -0,0 +1,3 @@ + o Documentation (hidden service, man page): + - HiddenServiceVersion man page entry wasn't mentionning the now supported + version 3. Fixes ticket 23580.; bugfix on 0.3.2.1-alpha. diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 5e0b76d4a..ef70d36b3 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2382,7 +2382,7 @@ The following options are used to configure a hidden service. [[HiddenServiceVersion]] **HiddenServiceVersion** __version__,__version__,__...__:: A list of rendezvous service descriptor versions to publish for the hidden - service. Currently, only version 2 is supported. (Default: 2) + service. Currently, version 2 and 3 are supported. (Default: 2) [[HiddenServiceAuthorizeClient]] **HiddenServiceAuthorizeClient** __auth-type__ __client-name__,__client-name__,__...__:: If configured, the hidden service is accessible for authorized clients

1 0

[tor/master] plural in manpage
by nickm＠torproject.org 19 Sep '17

19 Sep '17

commit 1f602e86433cc132981e8f9727266353ea2c3b0e Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 19 08:48:39 2017 -0400 plural in manpage --- doc/tor.1.txt | 2 +- scripts/test/scan-build.sh | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index ef70d36b3..f669a055c 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2382,7 +2382,7 @@ The following options are used to configure a hidden service. [[HiddenServiceVersion]] **HiddenServiceVersion** __version__,__version__,__...__:: A list of rendezvous service descriptor versions to publish for the hidden - service. Currently, version 2 and 3 are supported. (Default: 2) + service. Currently, versions 2 and 3 are supported. (Default: 2) [[HiddenServiceAuthorizeClient]] **HiddenServiceAuthorizeClient** __auth-type__ __client-name__,__client-name__,__...__:: If configured, the hidden service is accessible for authorized clients diff --git a/scripts/test/scan-build.sh b/scripts/test/scan-build.sh index bc602e61a..793adf87e 100755 --- a/scripts/test/scan-build.sh +++ b/scripts/test/scan-build.sh @@ -56,7 +56,15 @@ scan-build \ $CHECKERS \ ./configure -make clean +scan-build \ + make clean + +# Make this not get scanned for dead assignments, since it has lots of +# dead assignments we don't care about. +scan-build \ + $CHECKERS \ + -disable-checker deadcode.DeadStores \ + make -j5 -k ./src/ext/ed25519/ref10/libed25519_ref10.a scan-build \ $CHECKERS $OUTPUTARG \

1 0

[collector/master] Tweak the change log a bit.
by karsten＠torproject.org 19 Sep '17

19 Sep '17

commit 74e683ab4aa08234f409df6b0f77bbc776f5b2d5 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Tue Sep 19 14:34:03 2017 +0200 Tweak the change log a bit. --- CHANGELOG.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f687a50..4f9064e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,8 @@ # Changes in version 1.?.? - 2017-??-?? * Minor changes - - Un-prettify directory listings. + - Remove all styling resources (fonts, CSS, etc.) from directory + listings. # Changes in version 1.3.0 - 2017-09-15 @@ -18,7 +19,8 @@ # Changes in version 1.2.1 - 2017-08-17 * Medium changes - - Fix a bug while sanitizing bridge network statuses without entries. + - Fix a bug while sanitizing bridge network statuses without + entries. # Changes in version 1.2.0 - 2017-07-12

1 0

[metrics-web/master] Prepare for 1.0.0 release.
by karsten＠torproject.org 19 Sep '17

19 Sep '17

commit 471cf98c2ddfb904cd37a1ca0d157e9333d78950 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Tue Sep 19 14:30:54 2017 +0200 Prepare for 1.0.0 release. --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md new file mode 100644 index 0000000..f83665d --- /dev/null +++ b/CHANGELOG.md @@ -0,0 +1,6 @@ +# Changes in version 1.0.0 - 2017-09-19 + + * Major changes + - This is the initial release after almost eight years of + development. +

1 0

[tor/master] Improve comments formatting in connection.c
by nickm＠torproject.org 19 Sep '17

19 Sep '17

commit 228d782229dea07e225cd2d00cc108790866cb26 Author: teor <teor2345(a)gmail.com> Date: Tue Sep 19 14:19:20 2017 +1000 Improve comments formatting in connection.c --- src/or/connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/connection.c b/src/or/connection.c index b831d231b..2d3623c93 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -812,7 +812,7 @@ connection_mark_for_close_(connection_t *conn, int line, const char *file) * CONN_TYPE_OR checks; this should be called when you either are sure that * if this is an or_connection_t the controlling channel has been notified * (e.g. with connection_or_notify_error()), or you actually are the - * connection_or_close_for_error() or connection_or_close_normally function. + * connection_or_close_for_error() or connection_or_close_normally() function. * For all other cases, use connection_mark_and_flush() instead, which * checks for or_connection_t properly, instead. See below. */

1 0