September 2017 - tor-commits - lists.torproject.org

[sandboxed-tor-browser/master] Bug 22814: Revert the upstream fix by default.
by yawning＠torproject.org 20 Sep '17

20 Sep '17

commit 04868bf86dfc4ce7cbf428a162308c685b95d17a Author: Yawning Angel <yawning(a)schwanenlied.me> Date: Wed Sep 20 16:50:15 2017 +0000 Bug 22814: Revert the upstream fix by default. I don't care what the people whining on trac or bugzilla say, I like the existing behavior, so I'll flip the pref now to keep it. --- ChangeLog | 1 + data/installer/mozilla.cfg | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/ChangeLog b/ChangeLog index 54e4ea1..936f9fc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,6 @@ Changes in version 0.0.14 - UNRELEASED: * Bug 8706: Fully disable the .recently-used.xbel. + * Bug 22814: Revert the upstream fix by default. Changes in version 0.0.13 - 2017-09-13: * Bug 13170: Disable the rest of the Firefox experiments botnet prefs. diff --git a/data/installer/mozilla.cfg b/data/installer/mozilla.cfg index 5170c02..0def436 100644 --- a/data/installer/mozilla.cfg +++ b/data/installer/mozilla.cfg @@ -51,3 +51,8 @@ defaultPref("dom.securecontext.whitelist_onions", false); // Disable the "Open with" dialog, which will never work. lockPref("browser.download.forbid_open_with", true); + +// Revert https://bugzilla.mozilla.org/show_bug.cgi?id=366945 aka #22814 +// by default, because I'm writing this for me, and my workflow is what +// matters. +defaultPref("middlemouse.contentLoadURL", true);

1 0

[tor/master] Warn on ExtORPort USERADDR that is missing or 0.
by nickm＠torproject.org 20 Sep '17

20 Sep '17

commit c4e8548c59c1eb423fe6a39f2712dbc1eff3951a Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 20 08:50:49 2017 -0400 Warn on ExtORPort USERADDR that is missing or 0. Diagnoses violations on #23080. --- changes/bug23080 | 5 +++++ src/or/ext_orport.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/changes/bug23080 b/changes/bug23080 new file mode 100644 index 000000000..c80d323d3 --- /dev/null +++ b/changes/bug23080 @@ -0,0 +1,5 @@ + o Minor features (spec conformance, bridge, diagnostic): + - When handling the USERADDR command on an ExtOrPort, warn when the + transports provides a USERADDR with no port. In a future version, + USERADDR commands of this format may be rejected. Detects problems + related to ticket 23080. diff --git a/src/or/ext_orport.c b/src/or/ext_orport.c index c22a2f13d..28377a3f3 100644 --- a/src/or/ext_orport.c +++ b/src/or/ext_orport.c @@ -460,6 +460,11 @@ connection_ext_or_handle_cmd_useraddr(connection_t *conn, tor_free(addr_str); if (res<0) return -1; + if (port == 0) { + log_warn(LD_GENERAL, "Server transport proxy gave us an empty port " + "in ExtORPort UserAddr command."); + // return -1; // enable this if nothing breaks after a while. + } res = tor_addr_parse(&addr, address_part); tor_free(address_part);

1 0

[tor/master] Merge branch 'bug23080'
by nickm＠torproject.org 20 Sep '17

20 Sep '17

commit 2998350122884f57c3fe5248fc819b829434f2dd Merge: ff0aabc35 c4e8548c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 20 12:12:02 2017 -0400 Merge branch 'bug23080' changes/bug23080 | 5 +++++ src/or/ext_orport.c | 5 +++++ 2 files changed, 10 insertions(+)

1 0

[torspec/master] Close proposal 162 as "as implemented as it will get.
by nickm＠torproject.org 20 Sep '17

20 Sep '17

commit 6f9b3e058fdaa904bf71d703dd10e0c85017bfb0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 20 10:23:42 2017 -0400 Close proposal 162 as "as implemented as it will get. --- dir-spec.txt | 2 +- proposals/000-index.txt | 4 ++-- proposals/162-consensus-flavors.txt | 4 +++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dir-spec.txt b/dir-spec.txt index 14770f7..bb34292 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2961,7 +2961,7 @@ The following methods have incorrect implementations; authorities SHOULD Every consensus flavor has a name consisting of a sequence of one or more alphanumeric characters and dashes. For compatibility, - current descriptor flavor is called "ns". + the original (unflavored) consensus type is called "ns". The supported consensus flavors are defined as part of the authorities' consensus method. diff --git a/proposals/000-index.txt b/proposals/000-index.txt index ba6e1a9..6693bbc 100644 --- a/proposals/000-index.txt +++ b/proposals/000-index.txt @@ -82,7 +82,7 @@ Proposals by number: 159 Exit Scanning [INFORMATIONAL] 160 Authorities vote for bandwidth offsets in consensus [FINISHED] 161 Computing Bandwidth Adjustments [CLOSED] -162 Publish the consensus in multiple flavors [FINISHED] +162 Publish the consensus in multiple flavors [CLOSED] 163 Detecting whether a connection comes from a client [SUPERSEDED] 164 Reporting the status of server votes [OPEN] 165 Easy migration for voting authority sets [OPEN] @@ -273,7 +273,6 @@ Proposals by status: 257 Refactoring authorities and making them more isolated from the net FINISHED: 160 Authorities vote for bandwidth offsets in consensus [for 0.2.1.x] - 162 Publish the consensus in multiple flavors [in 0.2.3.1-alpha] 196 Extended ORPort and TransportControlPort [in 0.2.5.2-alpha] 217 Tor Extended ORPort Authentication [for 0.2.5.x] 220 Migrate server identity keys to Ed25519 [in 0.3.0.1-alpha] @@ -317,6 +316,7 @@ Proposals by status: 157 Make certificate downloads specific [for 0.2.4.x] 158 Clients download consensus + microdescriptors [in 0.2.3.1-alpha] 161 Computing Bandwidth Adjustments [for 0.2.1.x] + 162 Publish the consensus in multiple flavors [in 0.2.3.1-alpha] 166 Including Network Statistics in Extra-Info Documents [for 0.2.2] 167 Vote on network parameters in consensus [in 0.2.2] 171 Separate streams across circuits by connection metadata [in 0.2.3.3-alpha] diff --git a/proposals/162-consensus-flavors.txt b/proposals/162-consensus-flavors.txt index f97143b..2a227a0 100644 --- a/proposals/162-consensus-flavors.txt +++ b/proposals/162-consensus-flavors.txt @@ -3,7 +3,9 @@ Title: Publish the consensus in multiple flavors Author: Nick Mathewson Created: 14-May-2009 Implemented-In: 0.2.3.1-alpha -Status: Finished +Status: Closed + +[Implementation notes: the 'consensus index' feature never got implemented.] Overview:

1 0

[torspec/master] Mark prop158 closed. It has been merged into the spec ages ago.
by nickm＠torproject.org 20 Sep '17

20 Sep '17

commit e360873db5c7d09c67ed58e13acce55a6c7eff7a Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 20 10:19:12 2017 -0400 Mark prop158 closed. It has been merged into the spec ages ago. --- proposals/000-index.txt | 4 ++-- proposals/158-microdescriptors.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proposals/000-index.txt b/proposals/000-index.txt index 6f6fca0..ba6e1a9 100644 --- a/proposals/000-index.txt +++ b/proposals/000-index.txt @@ -78,7 +78,7 @@ Proposals by number: 155 Four Improvements of Hidden Service Performance [CLOSED] 156 Tracking blocked ports on the client side [SUPERSEDED] 157 Make certificate downloads specific [CLOSED] -158 Clients download consensus + microdescriptors [FINISHED] +158 Clients download consensus + microdescriptors [CLOSED] 159 Exit Scanning [INFORMATIONAL] 160 Authorities vote for bandwidth offsets in consensus [FINISHED] 161 Computing Bandwidth Adjustments [CLOSED] @@ -272,7 +272,6 @@ Proposals by status: 099 Miscellaneous proposals 257 Refactoring authorities and making them more isolated from the net FINISHED: - 158 Clients download consensus + microdescriptors [in 0.2.3.1-alpha] 160 Authorities vote for bandwidth offsets in consensus [for 0.2.1.x] 162 Publish the consensus in multiple flavors [in 0.2.3.1-alpha] 196 Extended ORPort and TransportControlPort [in 0.2.5.2-alpha] @@ -316,6 +315,7 @@ Proposals by status: 152 Optionally allow exit from single-hop circuits [in 0.2.1.6-alpha] 155 Four Improvements of Hidden Service Performance [in 0.2.1.x] 157 Make certificate downloads specific [for 0.2.4.x] + 158 Clients download consensus + microdescriptors [in 0.2.3.1-alpha] 161 Computing Bandwidth Adjustments [for 0.2.1.x] 166 Including Network Statistics in Extra-Info Documents [for 0.2.2] 167 Vote on network parameters in consensus [in 0.2.2] diff --git a/proposals/158-microdescriptors.txt b/proposals/158-microdescriptors.txt index 39a0ed7..442d705 100644 --- a/proposals/158-microdescriptors.txt +++ b/proposals/158-microdescriptors.txt @@ -2,7 +2,7 @@ Filename: 158-microdescriptors.txt Title: Clients download consensus + microdescriptors Author: Roger Dingledine Created: 17-Jan-2009 -Status: Finished +Status: Closed Implemented-In: 0.2.3.1-alpha 0. History

1 0

[torspec/master] Replace MAY with SHOULD for SHA256-signatures on microdesc consensuses.
by nickm＠torproject.org 20 Sep '17

20 Sep '17

commit 6e4ae942db6701d04cddee00d355add53b5fec0d Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 20 10:18:11 2017 -0400 Replace MAY with SHOULD for SHA256-signatures on microdesc consensuses. --- dir-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dir-spec.txt b/dir-spec.txt index 212a2e8..14770f7 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -3034,7 +3034,7 @@ The following methods have incorrect implementations; authorities SHOULD [*Before consensus method 13, this field was sometimes erroneously omitted.] - Additionally, a microdescriptor consensus MAY use the sha256 digest + Additionally, a microdescriptor consensus SHOULD use the sha256 digest algorithm for its signatures. 3.10. Exchanging detached signatures

1 0

[tor-browser-bundle/maint-7.0] There is the torbutton key as well...
by gk＠torproject.org 20 Sep '17

20 Sep '17

commit 4bd6009419433fcb758cb79b6e9c5a3086da89ba Author: Georg Koppen <gk(a)torproject.org> Date: Wed Sep 20 13:58:47 2017 +0000 There is the torbutton key as well... --- gitian/gpg/torbutton.gpg | Bin 135369 -> 182747 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/gitian/gpg/torbutton.gpg b/gitian/gpg/torbutton.gpg index 17b6c70..8a087c0 100644 Binary files a/gitian/gpg/torbutton.gpg and b/gitian/gpg/torbutton.gpg differ

1 0

[tor-browser-bundle/maint-7.0] Updating gk's subkeys
by gk＠torproject.org 20 Sep '17

20 Sep '17

commit 787fb6cd2b7fd50bbe8a8089ba24d6827aa5697e Author: Georg Koppen <gk(a)torproject.org> Date: Wed Sep 20 13:47:43 2017 +0000 Updating gk's subkeys --- gitian/gpg/gk.gpg | Bin 41255 -> 88633 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/gitian/gpg/gk.gpg b/gitian/gpg/gk.gpg index 9037e43..2eb314e 100644 Binary files a/gitian/gpg/gk.gpg and b/gitian/gpg/gk.gpg differ

1 0

[translation/whisperback] Update translations for whisperback
by translation＠torproject.org 20 Sep '17

20 Sep '17

commit 4b27b1da4dcce65e717e9e7bcac1fc8f80e82e86 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Sep 20 13:45:22 2017 +0000 Update translations for whisperback --- sl_SI/sl_SI.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sl_SI/sl_SI.po b/sl_SI/sl_SI.po index 678a2a025..3e6222bf3 100644 --- a/sl_SI/sl_SI.po +++ b/sl_SI/sl_SI.po @@ -9,7 +9,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-03-20 12:09+0000\n" -"PO-Revision-Date: 2017-03-21 08:24+0000\n" +"PO-Revision-Date: 2017-09-20 13:38+0000\n" "Last-Translator: carolyn <carolyn(a)anhalt.org>\n" "Language-Team: Slovenian (Slovenia) (http://www.transifex.com/otf/torproject/language/sl_SI/)\n" "MIME-Version: 1.0\n"

1 0

[tor/master] in zstd compression, fix 32 bit build
by nickm＠torproject.org 20 Sep '17

20 Sep '17

commit 427c2cc9e8f640769a7f8771c42b89948e78028e Author: Andreas Stieger <astieger(a)suse.com> Date: Mon Sep 18 21:15:52 2017 +0200 in zstd compression, fix 32 bit build format '%lu' expects argument of type 'long unsigned int', but argument ... has type 'size_t' Closes ticket 23568. --- src/common/compress_zstd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/compress_zstd.c b/src/common/compress_zstd.c index 0808bcd9a..63e92ed22 100644 --- a/src/common/compress_zstd.c +++ b/src/common/compress_zstd.c @@ -62,10 +62,10 @@ tor_zstd_get_version_str(void) version_number = ZSTD_versionNumber(); tor_snprintf(version_str, sizeof(version_str), - "%lu.%lu.%lu", - version_number / 10000 % 100, - version_number / 100 % 100, - version_number % 100); + "%d.%d.%d", + (int) version_number / 10000 % 100, + (int) version_number / 100 % 100, + (int) version_number % 100); return version_str; #else

1 0