August 2017 - tor-commits - lists.torproject.org

[metrics-web/master] Take out old Onionoo news, fix typo.
by karsten＠torproject.org 12 Aug '17

12 Aug '17

commit 423304724061feb4a01c3dea8ce8ed25e8c7048f Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Sat Aug 12 21:44:11 2017 +0200 Take out old Onionoo news, fix typo. --- website/src/main/resources/web/WEB-INF/onionoo.jsp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/website/src/main/resources/web/WEB-INF/onionoo.jsp b/website/src/main/resources/web/WEB-INF/onionoo.jsp index 3fa4c5e..19ad886 100644 --- a/website/src/main/resources/web/WEB-INF/onionoo.jsp +++ b/website/src/main/resources/web/WEB-INF/onionoo.jsp @@ -600,14 +600,13 @@ Indicates how recent the relay objects in this document are. </li> <li> -relays_skipped new +relays_skipped <code class="typeof">number</code> optional Number of skipped relays as requested by a positive "offset" parameter value. Omitted if zero. -Added on January 27, 2017. </li> @@ -621,14 +620,13 @@ Array of relay objects as specified below. </li> <li> -relays_truncated new +relays_truncated <code class="typeof">number</code> optional Number of truncated relays as requested by a positive "limit" parameter value. Omitted if zero. -Added on January 27, 2017. </li> @@ -644,14 +642,13 @@ Indicates how recent the bridge objects in this document are. </li> <li> -bridge_skipped new +bridges_skipped <code class="typeof">number</code> optional Number of skipped bridges as requested by a positive "offset" parameter value. Omitted if zero. -Added on January 27, 2017. </li> @@ -665,14 +662,13 @@ Array of bridge objects as specified below. </li> <li> -bridges_truncated new +bridges_truncated <code class="typeof">number</code> optional Number of truncated bridges as requested by a positive "limit" parameter value. Omitted if zero. -Added on January 27, 2017. </li>

1 0

[metrics-web/master] Update news.json to version 109 of doc/MetricsTimeline.
by karsten＠torproject.org 12 Aug '17

12 Aug '17

commit f31c9a17470968e0a5d66c78ae4f04eaeee62fd7 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Sat Aug 12 21:40:30 2017 +0200 Update news.json to version 109 of doc/MetricsTimeline. --- website/src/main/resources/etc/news.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/website/src/main/resources/etc/news.json b/website/src/main/resources/etc/news.json index 0645b14..841495a 100644 --- a/website/src/main/resources/etc/news.json +++ b/website/src/main/resources/etc/news.json @@ -874,5 +874,17 @@ "<a href=\"https://metrics.torproject.org/userstats-bridge-country.html?start=2017-01-…">bridge graph</a>" ], "unknown": true + }, + { + "start": "2017-08-02", + "place": "lt", + "protocols": [ + "<OR>" + ], + "description": "Increase of direct users in Lithuania, from 2k to 70k. Bridge users not affected.", + "links": [ + "<a href=\"https://metrics.torproject.org/userstats-relay-country.html?start=2017-06-0…">graph</a>" + ], + "unknown": true } ]

1 0

[metrics-web/master] Document Onionoo's qualified search terms a bit better.
by karsten＠torproject.org 12 Aug '17

12 Aug '17

commit 4925203d868bd590cac340bdfc9c427368099258 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Sat Aug 12 21:46:53 2017 +0200 Document Onionoo's qualified search terms a bit better. Also document 4 hex character blocks better. Fixes #22063. --- website/src/main/resources/web/WEB-INF/onionoo.jsp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/website/src/main/resources/web/WEB-INF/onionoo.jsp b/website/src/main/resources/web/WEB-INF/onionoo.jsp index 19ad886..1239198 100644 --- a/website/src/main/resources/web/WEB-INF/onionoo.jsp +++ b/website/src/main/resources/web/WEB-INF/onionoo.jsp @@ -331,7 +331,7 @@ Parameter values are case-insensitive. Return only (1) relays with the parameter value matching (part of a) nickname, (possibly $-prefixed) beginning of a hex-encoded fingerprint, -any 4 hex characters of a space-separated fingerprint, beginning of a +any 4 hex character block of a space-separated fingerprint, beginning of a base64-encoded fingerprint without trailing equal signs, or beginning of an IP address (possibly enclosed in square brackets in case of IPv6), (2) bridges with (part of a) nickname or (possibly @@ -352,6 +352,8 @@ Qualified search terms have the form "key:value" (without double quotes) with "key" being one of the parameters listed here except for "search", "fingerprint", "order", "limit", "offset", and "fields", and "value" being the string that will internally be passed to that parameter. +If a qualified search term for a given "key" is specified more than once, +only the first "value" is considered. </li>

1 0

[torspec/master] add some nsf ack's in some recent proposals
by arma＠torproject.org 11 Aug '17

11 Aug '17

commit 2d9712f228606abb233b8e43e23b044565789ff5 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Aug 11 17:51:03 2017 -0400 add some nsf ack's in some recent proposals --- proposals/278-directory-compression-scheme-negotiation.txt | 6 ++++++ proposals/279-naming-layer-api.txt | 3 +++ proposals/280-privcount-in-tor.txt | 4 ++++ 3 files changed, 13 insertions(+) diff --git a/proposals/278-directory-compression-scheme-negotiation.txt b/proposals/278-directory-compression-scheme-negotiation.txt index ced710f..4630bc4 100644 --- a/proposals/278-directory-compression-scheme-negotiation.txt +++ b/proposals/278-directory-compression-scheme-negotiation.txt @@ -201,3 +201,9 @@ Implemented-In: 0.3.1.1-alpha [1]: https://docs.google.com/spreadsheets/d/1devQlUOzMPStqUl9mPawFWP99xSsRM8xWv7… [2]: https://gitlab.com/ahf/tor-sponsor4-compression [3]: https://github.com/nmathewson/consensus-diff-analysis + +8. Acknowledgements + + This research was supported in part by NSF grants CNS-1111539, + CNS-1314637, CNS-1526306, CNS-1619454, and CNS-1640548. + diff --git a/proposals/279-naming-layer-api.txt b/proposals/279-naming-layer-api.txt index 73616aa..9f8c104 100644 --- a/proposals/279-naming-layer-api.txt +++ b/proposals/279-naming-layer-api.txt @@ -468,6 +468,9 @@ Status: Draft Yawning, David and me. Thanks to Lunar and indolering for more discussion and feedback. + This research was supported in part by NSF grants CNS-1111539, + CNS-1314637, CNS-1526306, CNS-1619454, and CNS-1640548. + Appendix A.1: Example communication Tor <-> name plugin [PROTOEXAMPLE] Environemnt variables: diff --git a/proposals/280-privcount-in-tor.txt b/proposals/280-privcount-in-tor.txt index c51eb33..2dcf85a 100644 --- a/proposals/280-privcount-in-tor.txt +++ b/proposals/280-privcount-in-tor.txt @@ -20,6 +20,9 @@ Status: Draft https://github.com/privcount/privcount/blob/master/CONTRIBUTORS.markdown + This research was supported in part by NSF grants CNS-1111539, + CNS-1314637, CNS-1526306, CNS-1619454, and CNS-1640548. + 1. Introduction and scope PrivCount is a privacy-preserving way to collect aggregate statistics @@ -330,3 +333,4 @@ Status: Draft above. Like the rest of this design, it would need rethinking if we want to expand this scheme to work with anonymous data collectors, such as Tor clients. +

1 0

[torspec/master] give it a better title
by arma＠torproject.org 11 Aug '17

11 Aug '17

commit 45a8e04154e3bd9925cb9d96dceb04c1f621d454 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Aug 11 17:58:30 2017 -0400 give it a better title --- proposals/280-privcount-in-tor.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proposals/280-privcount-in-tor.txt b/proposals/280-privcount-in-tor.txt index 2dcf85a..f0e4bd3 100644 --- a/proposals/280-privcount-in-tor.txt +++ b/proposals/280-privcount-in-tor.txt @@ -1,5 +1,5 @@ Filename: 280-privcount-in-tor.txt -Title: Privacy-Preseving Statistics with Privcount in Tor +Title: Privacy-Preserving Statistics with Privcount in Tor Author: Nick Mathewson, Tim Wilson-Brown Created: 02-Aug-2017 Status: Draft

1 0

[snowflake/master] Re-remove ipHandler function.
by dcf＠torproject.org 11 Aug '17

11 Aug '17

commit 8dcd337ce45555401ae75028356c8ea3d65fdc56 Author: David Fifield <david(a)bamsoftware.com> Date: Fri Aug 11 13:08:36 2017 -0700 Re-remove ipHandler function. Had been removed in 2a46db2c01985d144e25f537b5019b195af32782 and was erroneously restored in the merge 36debdfdd24e978fc323ec352852fc4af0bc4ae5. --- broker/broker.go | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/broker/broker.go b/broker/broker.go index 6cb08d9..b544e64 100644 --- a/broker/broker.go +++ b/broker/broker.go @@ -12,7 +12,6 @@ import ( "fmt" "io/ioutil" "log" - "net" "net/http" "strings" "time" @@ -222,15 +221,6 @@ func robotsTxtHandler(w http.ResponseWriter, r *http.Request) { w.Write([]byte("User-agent: *\nDisallow:\n")) } -func ipHandler(w http.ResponseWriter, r *http.Request) { - remoteAddr := r.RemoteAddr - if net.ParseIP(remoteAddr).To4() == nil { - remoteAddr = "[" + remoteAddr + "]" - } - w.Header().Set("Content-Type", "text/plain; charset=utf-8") - w.Write([]byte(remoteAddr)) -} - func main() { var acmeEmail string var acmeHostnamesCommas string

1 0

[tor/master] test: Fix typing issues found by clang
by nickm＠torproject.org 11 Aug '17

11 Aug '17

commit 598bf986b60cbbb447aa288eb8c05dcaca282d0f Author: David Goulet <dgoulet(a)torproject.org> Date: Fri Aug 11 14:59:28 2017 -0400 test: Fix typing issues found by clang Partially fix #23224. Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_hs_service.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c index 60efca15f..c0dd9fe25 100644 --- a/src/test/test_hs_service.c +++ b/src/test/test_hs_service.c @@ -1030,8 +1030,8 @@ test_build_update_descriptors(void *arg) { int ret; time_t now = time(NULL); - time_t period_num = hs_get_time_period_num(now); - time_t next_period_num = hs_get_next_time_period_num(now); + uint64_t period_num = hs_get_time_period_num(now); + uint64_t next_period_num = hs_get_next_time_period_num(now); node_t *node; hs_service_t *service; hs_service_intro_point_t *ip_cur, *ip_next; @@ -1287,13 +1287,13 @@ test_revision_counter_state(void *arg) &desc_one->blinded_kp.pubkey, &service_found); tt_int_op(service_found, OP_EQ, 1); - tt_int_op(cached_rev_counter, OP_EQ, 42); + tt_u64_op(cached_rev_counter, OP_EQ, 42); cached_rev_counter =check_state_line_for_service_rev_counter(state_line_two, &desc_two->blinded_kp.pubkey, &service_found); tt_int_op(service_found, OP_EQ, 1); - tt_int_op(cached_rev_counter, OP_EQ, 240); + tt_u64_op(cached_rev_counter, OP_EQ, 240); done: tor_free(state_line_one);

1 0

[tor/master] Make Windows happy for time_t printf format
by nickm＠torproject.org 11 Aug '17

11 Aug '17

commit 257f50b22fbaf9c9cb5859e257437b24af46c7ab Author: David Goulet <dgoulet(a)torproject.org> Date: Fri Aug 11 15:08:45 2017 -0400 Make Windows happy for time_t printf format Our Windows compiler treats "time_t" as long long int but Linux likes it long int so cast those to make Windows happy. Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/or/hs_cell.c | 2 +- src/or/hs_circuit.c | 5 +++-- src/or/hs_service.c | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/or/hs_cell.c b/src/or/hs_cell.c index a0e907460..7728b7705 100644 --- a/src/or/hs_cell.c +++ b/src/or/hs_cell.c @@ -444,7 +444,7 @@ hs_cell_parse_introduce2(hs_cell_introduce2_data_t *data, encrypted_section_len, &elapsed)) { log_warn(LD_REND, "Possible replay detected! An INTRODUCE2 cell with the" "same ENCRYPTED section was seen %ld seconds ago. " - "Dropping cell.", elapsed); + "Dropping cell.", (long int) elapsed); goto done; } diff --git a/src/or/hs_circuit.c b/src/or/hs_circuit.c index d0265dc54..6d1cdd4eb 100644 --- a/src/or/hs_circuit.c +++ b/src/or/hs_circuit.c @@ -589,7 +589,7 @@ can_relaunch_service_rendezvous_point(const origin_circuit_t *circ) safe_str_client( extend_info_describe(circ->build_state->chosen_exit)), circ->build_state->failure_count, - circ->build_state->expiry_time); + (long int) circ->build_state->expiry_time); goto disallow; } @@ -978,7 +978,8 @@ hs_circ_handle_introduce2(const hs_service_t *service, * cell), we are already trying to connect to that rend point (and may * have already succeeded); drop this cell. */ log_info(LD_REND, "We received an INTRODUCE2 cell with same REND_COOKIE " - "field %ld seconds ago. Dropping cell.", elapsed); + "field %ld seconds ago. Dropping cell.", + (long int) elapsed); goto done; } diff --git a/src/or/hs_service.c b/src/or/hs_service.c index cb3a49cb8..3f6de0ba2 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -1875,8 +1875,9 @@ can_service_launch_intro_circuit(hs_service_t *service, time_t now) safe_str_client(service->onion_address), get_max_intro_circ_per_period(service), INTRO_CIRC_RETRY_PERIOD, - service->state.num_intro_circ_launched, elapsed_time, - INTRO_CIRC_RETRY_PERIOD - elapsed_time); + service->state.num_intro_circ_launched, + (long int) elapsed_time, + (long int) INTRO_CIRC_RETRY_PERIOD - elapsed_time); tor_free(msg); } }

1 0

[tor/master] test: Fix hs common test for Windows
by nickm＠torproject.org 11 Aug '17

11 Aug '17

commit 60c7da71ab3435e2022dd4f62ac67c09da94db89 Author: David Goulet <dgoulet(a)torproject.org> Date: Fri Aug 11 14:42:20 2017 -0400 test: Fix hs common test for Windows Use the PATH_SEPARATOR for a path comparaison so it works with Windows as well. Partially fix #23223 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_hs_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_hs_common.c b/src/test/test_hs_common.c index b8b7ab00d..fce71ef2d 100644 --- a/src/test/test_hs_common.c +++ b/src/test/test_hs_common.c @@ -78,7 +78,7 @@ static int mock_write_str_to_file(const char *path, const char *str, int bin) { (void)bin; - tt_str_op(path, OP_EQ, "/double/five/squared"); + tt_str_op(path, OP_EQ, "/double/five"PATH_SEPARATOR"squared"); tt_str_op(str, OP_EQ, "ijbeeqscijbeeqscijbeeqscijbeeqscijbeeqscijbeeqscijbezhid.onion\n");

1 0

[tor/master] test: Fix memory leak in test_hs_common.c
by nickm＠torproject.org 11 Aug '17

11 Aug '17

commit 9df4261407d620d05901a5c4e93aa963f89ab185 Author: David Goulet <dgoulet(a)torproject.org> Date: Fri Aug 11 14:46:27 2017 -0400 test: Fix memory leak in test_hs_common.c Partially fixes #23223 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_hs_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_hs_common.c b/src/test/test_hs_common.c index fce71ef2d..2461e7cd6 100644 --- a/src/test/test_hs_common.c +++ b/src/test/test_hs_common.c @@ -409,7 +409,7 @@ test_responsible_hsdirs(void *arg) memset(&ri, 0 ,sizeof(routerinfo_t)); tor_addr_parse(&ipv4_addr, "127.0.0.1"); ri.addr = tor_addr_to_ipv4h(&ipv4_addr); - ri.nickname = tor_strdup("fatal"); + ri.nickname = (char *) "fatal"; ri.protocol_list = (char *) "HSDir=1-2 LinkAuth=3"; memset(ri.cache_info.identity_digest, 'A', DIGEST_LEN); tt_assert(nodelist_set_routerinfo(&ri, NULL));

1 0