June 2017 - tor-commits - lists.torproject.org

[tor/release-0.2.6] Merge branch 'maint-0.2.6' into release-0.2.6
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit 0978889563e9986368dfe6d490fd3cf7912414b3 Merge: 183a62d 9ea3d08 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:00:34 2017 -0400 Merge branch 'maint-0.2.6' into release-0.2.6 changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.6] Merge branch 'maint-0.2.5' into maint-0.2.6
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit 9ea3d0877a5be2762cfcb4d7c2015e5ec43a2055 Merge: 159ddf6 1a540b5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:00:27 2017 -0400 Merge branch 'maint-0.2.5' into maint-0.2.6 changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.6] Fix undefined behavior in geoip_parse_entry().
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit e3ebae48040b9ed3946e65dbc6a24e8f5e48ff6b Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 10:09:39 2017 -0400 Fix undefined behavior in geoip_parse_entry(). Fixes bug 22490; bugfix on 6a241ff3ffe7dc1 in 0.2.4.6-alpha. Found by teor using clang-5.0's AddressSanitizer stack-use-after-scope. --- changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/bug22490 b/changes/bug22490 new file mode 100644 index 0000000..244dd50 --- /dev/null +++ b/changes/bug22490 @@ -0,0 +1,3 @@ + o Minor bugfixes (correctness): + - Avoid undefined behavior when parsing IPv6 entries from the geoip6 + file. Fixes bug 22490; bugfix on 0.2.4.6-alpha. diff --git a/src/or/geoip.c b/src/or/geoip.c index e2e98e8..4abd519 100644 --- a/src/or/geoip.c +++ b/src/or/geoip.c @@ -145,6 +145,7 @@ geoip_parse_entry(const char *line, sa_family_t family) if (*line == '#') return 0; + char buf[512]; if (family == AF_INET) { unsigned int low, high; if (tor_sscanf(line,"%u,%u,%2s", &low, &high, c) == 3 || @@ -155,7 +156,6 @@ geoip_parse_entry(const char *line, sa_family_t family) goto fail; country = c; } else { /* AF_INET6 */ - char buf[512]; char *low_str, *high_str; struct in6_addr low, high; char *strtok_state;

1 0

[tor/release-0.2.7-redux] Merge branch 'maint-0.2.7-redux' into release-0.2.7-redux
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit d0d9afa5f99da2fb7df61974647308ce540ad417 Merge: 82ce0be 3f2d1f7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:01:11 2017 -0400 Merge branch 'maint-0.2.7-redux' into release-0.2.7-redux changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.8] Merge branch 'maint-0.2.8' into release-0.2.8
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit 33b500851c3476298f4a243374216258a4cf56e8 Merge: df842d8 33fcc0f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:01:27 2017 -0400 Merge branch 'maint-0.2.8' into release-0.2.8 changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.8] Merge branch 'maint-0.2.4' into maint-0.2.5
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit 1a540b579248c04eba79c3e18d022054b238f6f5 Merge: 68d6720 e3ebae4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:00:08 2017 -0400 Merge branch 'maint-0.2.4' into maint-0.2.5 changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.7-redux] Fix undefined behavior in geoip_parse_entry().
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit e3ebae48040b9ed3946e65dbc6a24e8f5e48ff6b Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 10:09:39 2017 -0400 Fix undefined behavior in geoip_parse_entry(). Fixes bug 22490; bugfix on 6a241ff3ffe7dc1 in 0.2.4.6-alpha. Found by teor using clang-5.0's AddressSanitizer stack-use-after-scope. --- changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/bug22490 b/changes/bug22490 new file mode 100644 index 0000000..244dd50 --- /dev/null +++ b/changes/bug22490 @@ -0,0 +1,3 @@ + o Minor bugfixes (correctness): + - Avoid undefined behavior when parsing IPv6 entries from the geoip6 + file. Fixes bug 22490; bugfix on 0.2.4.6-alpha. diff --git a/src/or/geoip.c b/src/or/geoip.c index e2e98e8..4abd519 100644 --- a/src/or/geoip.c +++ b/src/or/geoip.c @@ -145,6 +145,7 @@ geoip_parse_entry(const char *line, sa_family_t family) if (*line == '#') return 0; + char buf[512]; if (family == AF_INET) { unsigned int low, high; if (tor_sscanf(line,"%u,%u,%2s", &low, &high, c) == 3 || @@ -155,7 +156,6 @@ geoip_parse_entry(const char *line, sa_family_t family) goto fail; country = c; } else { /* AF_INET6 */ - char buf[512]; char *low_str, *high_str; struct in6_addr low, high; char *strtok_state;

1 0

[tor/release-0.2.8] Merge branch 'maint-0.2.6' into maint-0.2.7-redux
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit 3f2d1f7f0730a17b81d2fb94df9b6a5b8b277893 Merge: 71dd1d7 9ea3d08 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:00:41 2017 -0400 Merge branch 'maint-0.2.6' into maint-0.2.7-redux changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.7-redux] Merge branch 'maint-0.2.4' into maint-0.2.5
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit 1a540b579248c04eba79c3e18d022054b238f6f5 Merge: 68d6720 e3ebae4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 12:00:08 2017 -0400 Merge branch 'maint-0.2.4' into maint-0.2.5 changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.9] Fix undefined behavior in geoip_parse_entry().
by nickm＠torproject.org 05 Jun '17

05 Jun '17

commit e3ebae48040b9ed3946e65dbc6a24e8f5e48ff6b Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 5 10:09:39 2017 -0400 Fix undefined behavior in geoip_parse_entry(). Fixes bug 22490; bugfix on 6a241ff3ffe7dc1 in 0.2.4.6-alpha. Found by teor using clang-5.0's AddressSanitizer stack-use-after-scope. --- changes/bug22490 | 3 +++ src/or/geoip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/bug22490 b/changes/bug22490 new file mode 100644 index 0000000..244dd50 --- /dev/null +++ b/changes/bug22490 @@ -0,0 +1,3 @@ + o Minor bugfixes (correctness): + - Avoid undefined behavior when parsing IPv6 entries from the geoip6 + file. Fixes bug 22490; bugfix on 0.2.4.6-alpha. diff --git a/src/or/geoip.c b/src/or/geoip.c index e2e98e8..4abd519 100644 --- a/src/or/geoip.c +++ b/src/or/geoip.c @@ -145,6 +145,7 @@ geoip_parse_entry(const char *line, sa_family_t family) if (*line == '#') return 0; + char buf[512]; if (family == AF_INET) { unsigned int low, high; if (tor_sscanf(line,"%u,%u,%2s", &low, &high, c) == 3 || @@ -155,7 +156,6 @@ geoip_parse_entry(const char *line, sa_family_t family) goto fail; country = c; } else { /* AF_INET6 */ - char buf[512]; char *low_str, *high_str; struct in6_addr low, high; char *strtok_state;

1 0