tor-commits June 2017

tor-commits@lists.torproject.org

13 participants
1918 discussions

[tor/release-0.3.0] Consider the exit family when applying guard restrictions.
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit 665baf5ed5c6186d973c46cdea165c0548027350 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jun 28 11:41:50 2017 -0400 Consider the exit family when applying guard restrictions. When the new path selection logic went into place, I accidentally dropped the code that considered the _family_ of the exit node when deciding if the guard was usable, and we didn't catch that during code review. This patch makes the guard_restriction_t code consider the exit family as well, and adds some (hopefully redundant) checks for the case where we lack a node_t for a guard but we have a bridge_info_t for it. Fixes bug 22753; bugfix on 0.3.0.1-alpha. Tracked as TROVE-2016-006 and CVE-2017-0377. --- changes/bug22753 | 7 +++++++ src/or/entrynodes.c | 39 ++++++++++++++++++++++++++++++++++++++- src/or/entrynodes.h | 9 +++++---- src/or/nodelist.c | 2 +- src/or/nodelist.h | 2 ++ 5 files changed, 53 insertions(+), 6 deletions(-) diff --git a/changes/bug22753 b/changes/bug22753 new file mode 100644 index 0000000..32a6dfa --- /dev/null +++ b/changes/bug22753 @@ -0,0 +1,7 @@ + o Major bugfixes (path selection, security): + - When choosing which guard to use for a circuit, avoid the + exit's family along with the exit itself. Previously, the new + guard selection logic avoided the exit, but did not consider + its family. Fixes bug 22753; bugfix on 0.3.0.1-alpha. Tracked + as TROVE-2016-006 and CVE-2017-0377. + diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index aba35e6..ccb0808 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -1428,6 +1428,38 @@ entry_guard_passes_filter(const or_options_t *options, guard_selection_t *gs, } } +/** Return true iff <b>guard</b> is in the same family as <b>node</b>. + */ +static int +guard_in_node_family(const entry_guard_t *guard, const node_t *node) +{ + const node_t *guard_node = node_get_by_id(guard->identity); + if (guard_node) { + return nodes_in_same_family(guard_node, node); + } else { + /* If we don't have a node_t for the guard node, we might have + * a bridge_info_t for it. So let's check to see whether the bridge + * address matches has any family issues. + * + * (Strictly speaking, I believe this check is unnecessary, since we only + * use it to avoid the exit's family when building circuits, and we don't + * build multihop circuits until we have a routerinfo_t for the + * bridge... at which point, we'll also have a node_t for the + * bridge. Nonetheless, it seems wise to include it, in case our + * assumptions change down the road. -nickm.) + */ + if (get_options()->EnforceDistinctSubnets && guard->bridge_addr) { + tor_addr_t node_addr; + node_get_addr(node, &node_addr); + if (addrs_in_same_network_family(&node_addr, + &guard->bridge_addr->addr)) { + return 1; + } + } + return 0; + } +} + /** * Return true iff <b>guard</b> obeys the restrictions defined in <b>rst</b>. * (If <b>rst</b> is NULL, there are no restrictions.) @@ -1440,7 +1472,12 @@ entry_guard_obeys_restriction(const entry_guard_t *guard, if (! rst) return 1; // No restriction? No problem. - // Only one kind of restriction exists right now + // Only one kind of restriction exists right now: excluding an exit + // ID and all of its family. + const node_t *node = node_get_by_id((const char*)rst->exclude_id); + if (node && guard_in_node_family(guard, node)) + return 0; + return tor_memneq(guard->identity, rst->exclude_id, DIGEST_LEN); } diff --git a/src/or/entrynodes.h b/src/or/entrynodes.h index f02901f..6ccc48f 100644 --- a/src/or/entrynodes.h +++ b/src/or/entrynodes.h @@ -276,16 +276,17 @@ struct entry_guard_handle_t; * A restriction to remember which entry guards are off-limits for a given * circuit. * - * Right now, we only use restrictions to block a single guard from being - * selected; this mechanism is designed to be more extensible in the future, - * however. + * Right now, we only use restrictions to block a single guard and its family + * from being selected; this mechanism is designed to be more extensible in + * the future, however. * * Note: This mechanism is NOT for recording which guards are never to be * used: only which guards cannot be used on <em>one particular circuit</em>. */ struct entry_guard_restriction_t { /** - * The guard's RSA identity digest must not equal this. + * The guard's RSA identity digest must not equal this; and it must not + * be in the same family as any node with this digest. */ uint8_t exclude_id[DIGEST_LEN]; }; diff --git a/src/or/nodelist.c b/src/or/nodelist.c index 96e95ba..2ca52e7 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -1343,7 +1343,7 @@ nodelist_refresh_countries(void) /** Return true iff router1 and router2 have similar enough network addresses * that we should treat them as being in the same family */ -static inline int +int addrs_in_same_network_family(const tor_addr_t *a1, const tor_addr_t *a2) { diff --git a/src/or/nodelist.h b/src/or/nodelist.h index 8456d21..4e5301d 100644 --- a/src/or/nodelist.h +++ b/src/or/nodelist.h @@ -94,6 +94,8 @@ int node_is_unreliable(const node_t *router, int need_uptime, int router_exit_policy_all_nodes_reject(const tor_addr_t *addr, uint16_t port, int need_uptime); void router_set_status(const char *digest, int up); +int addrs_in_same_network_family(const tor_addr_t *a1, + const tor_addr_t *a2); /** router_have_minimum_dir_info tests to see if we have enough * descriptor information to create circuits.

1 0

[tor/release-0.3.1] Sort changes into changelog file for 0.3.1.4-alpha
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit ce64ab2f096a57d8f44dd3269731209b9527387d Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 29 15:54:36 2017 -0400 Sort changes into changelog file for 0.3.1.4-alpha --- ChangeLog | 121 ++++++++++++++++++++++++++++++++++++++ changes/bug16082 | 4 -- changes/bug22212 | 6 -- changes/bug22347 | 3 - changes/bug22356 | 5 -- changes/bug22400_01 | 4 -- changes/bug22502_part1 | 12 ---- changes/bug22516 | 5 -- changes/bug22669 | 4 -- changes/bug22670 | 4 -- changes/bug22670_02 | 4 -- changes/bug22670_03 | 6 -- changes/bug22672 | 5 -- changes/bug22702 | 5 -- changes/bug22719 | 7 --- changes/bug22720 | 9 --- changes/bug22737 | 12 ---- changes/bug22751 | 5 -- changes/diagnose_22752 | 4 -- changes/geoip-june2017 | 4 -- changes/more-files | 4 -- changes/new_requirement_pkgconfig | 5 -- 22 files changed, 121 insertions(+), 117 deletions(-) diff --git a/ChangeLog b/ChangeLog index b1f64c9..d67c8dd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,124 @@ +Changes in version 0.3.1.4-alpha - 2017-06-29: + blurb goes here. + + o Major bugfixes (compression): + - Fix crash in LZMA module, when the Sandbox is enabled, where + liblzma would allocate more than 16 MB of memory. We solve this + by bumping the mprotect() limit in the Sandbox module from 16 MB + to 20 MB. Fixes bug 22751; bugfix on 0.3.1.1-alpha. + + o Major bugfixes (compression, zstd): + - Correctly detect a full buffer when decompessing a large + zstd-compressed input. Fixes bug 22628; bugfix on 0.3.1.1-alpha. + + o Major bugfixes (directory protocol): + - Ensure that we sent "304 Not modified" as HTTP status code when a + client is attempting to fetch a consensus or consensus diff that + matches the latest consensus we have available. Fixes bug 22702; + bugfix on 0.3.1.1-alpha. + + o Major bugfixes (entry guards): + - When starting with an old consensus, do not add new entry guards + unless the consensus is "reasonably live" (under 1 day old). Fixes + one root cause of bug 22400; bugfix on 0.3.0.1-alpha. + + o Minor features (bug mitigation, diagnostics, logging): + - Avoid an assertion failure, and log a better error message, + when unable to remove a file from the consensus cache on + Windows. Attempts to mitigate and diagnose bug 22752. + + o Minor features (compression, defensive programming): + - Detect and break out of infinite loops in our compression code. + We don't think that any such loops exist now, but it's best to be + safe. Closes ticket 22672. + + o Minor features (geoip): + - Update geoip and geoip6 to the June 8 2017 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (compression): + - When compressing or decompressing a buffer, check for a failure to + create a compression object. Fixes bug 22626; bugfix on + 0.3.1.1-alpha. + - When decompressing a buffer, check for extra data after the end of + the compressed data. Fixes bug 22629; bugfix on 0.3.1.1-alpha. + - When decompressing an object received over an anonymous directory + connection, if we have already successfully decompressed it using an + acceptable compression method, do not reject it for looking like an + unacceptable compression method. Fixes part of bug 22670; bugfix on + 0.3.1.1-alpha. + - When serving directory votes compressed with zlib, + do not claim to have compressed them with zstd. Fixes bug 22669; + bugfix on 0.3.1.1-alpha. + - When spooling compressed data to an output buffer, don't try to + spool more data when there is no more data to spool and we are + not trying to flush the input. Previously, we would sometimes + launch compression requests with nothing to do, which interferes + with our 22672 checks. Fixes bug 22719; bugfix on 0.2.0.16-alpha. + + o Minor bugfixes (defensive programming, undefined behavior): + - Fix a memset() off the end of an array when packing cells. This + bug should be harmless in practice, since the corrupted bytes + are still in the same structure, and are always padding bytes, + ignored, or immediately overwritten, depending on compiler + behavior. Nevertheless, because the memset()'s purpose is to + make sure that any other cell-handling bugs can't expose bytes + to the network, we need to fix it. Fixes bug 22737; bugfix on + 0.2.4.11-alpha. Fixes CID 1401591. + + o Minor bugfixes (linux seccomp2 sandbox): + - Permit the fchmod system call, to avoid crashing on startup when + starting with the seccomp2 sandbox and an unexpected set of permissions + on the data directory or its contents. Fixes bug 22516; bugfix on + 0.2.5.4-alpha. + + o Minor bugfixes (logging, compression): + - When decompressing, do not warn if we fail to decompress using a + compression method that we merely guessed. Fixes part of + bug 22670; bugfix on 0.1.1.14-alpha. + - When decompressing, treat mismatch between content-encoding and + actual compression type as a protocol warning. Fixes part of bug + 22670; bugfix on 0.1.1.9-alpha. + + o Minor bugfixes (logging, relay): + - Downgrade "assigned_to_cpuworker failed" message to INFO-level + severity. In every case that can reach it, either a better warning + has already been logged, or no warning is warranted. Fixes bug 22356; + bugfix on 0.2.6.3-alpha. + + o Minor bugfixes (netflow padding logging): + - Demote a warn that was caused by libevent delays to info if + the padding is less than 4.5 seconds late, or notice if it is more + (4.5 seconds is the amount of time that a netflow record might + be emitted after, if we chose the maximum timeout). Fixes bug 22212; + bugfix on 0.3.1.1-alpha. + + o Minor bugfixes (process behavior): + - When exiting because of an error, always exit with a nonzero + exit status. Previously, we would fail to report an error in + our exit status in cases related to lockfile contention, + __OwningControllerProcess failure, and Ed25519 key + initialization. Fixes bug 22720; bugfix on versions + 0.2.1.6-alpha, 0.2.2.28-beta, and 0.2.7.2-alpha + respectively. Reported by "f55jwk4f"; patch from "huyvq". + + o Documentation: + - Add a manpage description for the key-pinning-journal file. + Closes ticket 22347. + - Correctly note that bandwidth accounting values are stored in the + state file, and the bw_accounting file is now obsolete. Closes + ticket 16082. + - Document more of the files in the Tor data directory, including + cached-extrainfo, secret_onion_key{,_ntor}.old, hidserv-stats, + approved-routers, sr-random, and diff-cache. + + o New dependencies: + - To build with zstd and lzma support, Tor now requires the + pkg-config tool at build time. (This requirement was new in + 0.3.1.1-alpha, but was not noted at the time. Noting it here to + close ticket 22623.) + + Changes in version 0.3.1.3-alpha - 2017-06-08 Tor 0.3.1.3-alpha fixes a pair of bugs that would allow an attacker to remotely crash a hidden service with an assertion failure. Anyone diff --git a/changes/bug16082 b/changes/bug16082 deleted file mode 100644 index 0f2f04f..0000000 --- a/changes/bug16082 +++ /dev/null @@ -1,4 +0,0 @@ - o Documentation: - - Correctly note that bandwidth accounting values are stored in the - state file, and the bw_accounting file is now obsolete. Closes - ticket 16082. diff --git a/changes/bug22212 b/changes/bug22212 deleted file mode 100644 index dc1604a..0000000 --- a/changes/bug22212 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (netflow padding logging): - - Demote a warn that was caused by libevent delays to info if - the padding is less than 4.5 seconds late, or notice if it is more - (4.5 seconds is the amount of time that a netflow record might - be emitted after, if we chose the maximum timeout). Fixes bug 22212; - bugfix on 0.3.1.1-alpha. diff --git a/changes/bug22347 b/changes/bug22347 deleted file mode 100644 index f98c19f..0000000 --- a/changes/bug22347 +++ /dev/null @@ -1,3 +0,0 @@ - o Documentation: - - Add a manpage description for the key-pinning-journal file. - Closes ticket 22347. diff --git a/changes/bug22356 b/changes/bug22356 deleted file mode 100644 index 0082b54..0000000 --- a/changes/bug22356 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (logging, relay): - - Downgrade "assigned_to_cpuworker failed" message to INFO-level - severity. In every case that can reach it, either a better warning - has already been logged, or no warning is warranted. Fixes bug 22356; - bugfix on 0.2.6.3-alpha. diff --git a/changes/bug22400_01 b/changes/bug22400_01 deleted file mode 100644 index 454c5f7..0000000 --- a/changes/bug22400_01 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (entry guards): - - When starting with an old consensus, do not add new entry guards - unless the consensus is "reasonably live" (under 1 day old). Fixes - one root cause of bug 22400; bugfix on 0.3.0.1-alpha. diff --git a/changes/bug22502_part1 b/changes/bug22502_part1 deleted file mode 100644 index bd95b7c..0000000 --- a/changes/bug22502_part1 +++ /dev/null @@ -1,12 +0,0 @@ - o Major bugfixes (compression, zstd): - - Correctly detect a full buffer when decompessing a large - zstd-compressed input. Fixes bug 22628; bugfix on 0.3.1.1-alpha. - - o Minor bugfixes (compression): - - When compressing or decompressing a buffer, check for a failure to - create a compression object. Fixes bug 22626; bugfix on - 0.3.1.1-alpha. - - - When decompressing a buffer, check for extra data after the end of - the compressed data. Fixes bug 22629; bugfix on 0.3.1.1-alpha. - diff --git a/changes/bug22516 b/changes/bug22516 deleted file mode 100644 index f024a3c..0000000 --- a/changes/bug22516 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (linux seccomp2 sandbox): - - Permit the fchmod system call, to avoid crashing on startup when - starting with the seccomp2 sandbox and an unexpected set of permissions - on the data directory or its contents. Fixes bug 22516; bugfix on - 0.2.5.4-alpha. diff --git a/changes/bug22669 b/changes/bug22669 deleted file mode 100644 index 804a39e..0000000 --- a/changes/bug22669 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (compression): - - When serving directory votes compressed with zlib, - do not claim to have compressed them with zstd. Fixes bug 22669; - bugfix on 0.3.1.1-alpha. diff --git a/changes/bug22670 b/changes/bug22670 deleted file mode 100644 index 4740327..0000000 --- a/changes/bug22670 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (logging, compression): - - When decompressing, do not warn if we fail to decompress using a - compression method that we merely guessed. Fixes part of - bug 22670; bugfix on 0.1.1.14-alpha. diff --git a/changes/bug22670_02 b/changes/bug22670_02 deleted file mode 100644 index 3e7a428..0000000 --- a/changes/bug22670_02 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (logging, compression): - - When decompressing, treat mismatch between content-encoding and - actual compression type as a protocol warning. Fixes part of bug - 22670; bugfix on 0.1.1.9-alpha. diff --git a/changes/bug22670_03 b/changes/bug22670_03 deleted file mode 100644 index 8a7aa49..0000000 --- a/changes/bug22670_03 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (compression): - - When decompressing an object received over an anonymous directory - connection, if we have already successfully decompressed it using an - acceptable compression method, do not reject it for looking like an - unacceptable compression method. Fixes part of bug 22670; bugfix on - 0.3.1.1-alpha. diff --git a/changes/bug22672 b/changes/bug22672 deleted file mode 100644 index ec66811..0000000 --- a/changes/bug22672 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor features (compression, defensive programming): - - Detect and break out of infinite loops in our compression code. - We don't think that any such loops exist now, but it's best to be - safe. Closes ticket 22672. - diff --git a/changes/bug22702 b/changes/bug22702 deleted file mode 100644 index a2044c7..0000000 --- a/changes/bug22702 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (directory protocol): - - Ensure that we sent "304 Not modified" as HTTP status code when a - client is attempting to fetch a consensus or consensus diff that - matches the latest consensus we have available. Fixes bug 22702; - bugfix on 0.3.1.1-alpha. diff --git a/changes/bug22719 b/changes/bug22719 deleted file mode 100644 index bfcda0a..0000000 --- a/changes/bug22719 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (compression): - - When spooling compressed data to an output buffer, don't try to - spool more data when there is no more data to spool and we are - not trying to flush the input. Previously, we would sometimes - launch compression requests with nothing to do, which interferes - with our 22672 checks. Fixes bug 22719; bugfix on 0.2.0.16-alpha. - diff --git a/changes/bug22720 b/changes/bug22720 deleted file mode 100644 index 4893b57..0000000 --- a/changes/bug22720 +++ /dev/null @@ -1,9 +0,0 @@ - o Minor bugfixes (process behavior): - - When exiting because of an error, always exit with a nonzero - exit status. Previously, we would fail to report an error in - our exit status in cases related to lockfile contention, - __OwningControllerProcess failure, and Ed25519 key - initialization. Fixes bug 22720; bugfix on versions - 0.2.1.6-alpha, 0.2.2.28-beta, and 0.2.7.2-alpha - respectively. Reported by "f55jwk4f"; patch from "huyvq". - diff --git a/changes/bug22737 b/changes/bug22737 deleted file mode 100644 index f0de8e6..0000000 --- a/changes/bug22737 +++ /dev/null @@ -1,12 +0,0 @@ - o Minor bugfixes (defensive programming, undefined behavior): - - - Fix a memset() off the end of an array when packing cells. This - bug should be harmless in practice, since the corrupted bytes - are still in the same structure, and are always padding bytes, - ignored, or immediately overwritten, depending on compiler - behavior. Nevertheless, because the memset()'s purpose is to - make sure that any other cell-handling bugs can't expose bytes - to the network, we need to fix it. Fixes bug 22737; bugfix on - 0.2.4.11-alpha. Fixes CID 1401591. - - diff --git a/changes/bug22751 b/changes/bug22751 deleted file mode 100644 index 714525c..0000000 --- a/changes/bug22751 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (compression): - - Fix crash in LZMA module, when the Sandbox is enabled, where - liblzma would allocate more than 16 MB of memory. We solve this - by bumping the mprotect() limit in the Sandbox module from 16 MB - to 20 MB. Fixes bug 22751; bugfix on 0.3.1.1-alpha. diff --git a/changes/diagnose_22752 b/changes/diagnose_22752 deleted file mode 100644 index b5bda05..0000000 --- a/changes/diagnose_22752 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (bug mitigation, diagnostics, logging): - - Avoid an assertion failure, and log a better error message, - when unable to remove a file from the consensus cache on - Windows. Attempts to mitigate and diagnose bug 22752. diff --git a/changes/geoip-june2017 b/changes/geoip-june2017 deleted file mode 100644 index 1001e8e..0000000 --- a/changes/geoip-june2017 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (geoip): - - Update geoip and geoip6 to the June 8 2017 Maxmind GeoLite2 - Country database. - diff --git a/changes/more-files b/changes/more-files deleted file mode 100644 index 861d6a3..0000000 --- a/changes/more-files +++ /dev/null @@ -1,4 +0,0 @@ - o Documentation: - - Document more of the files in the Tor data directory, including - cached-extrainfo, secret_onion_key{,_ntor}.old, hidserv-stats, - approved-routers, sr-random, and diff-cache. diff --git a/changes/new_requirement_pkgconfig b/changes/new_requirement_pkgconfig deleted file mode 100644 index 503ff58..0000000 --- a/changes/new_requirement_pkgconfig +++ /dev/null @@ -1,5 +0,0 @@ - o New dependencies: - - To build with zstd and lzma support, Tor now requires the - pkg-config tool at build time. (This requirement was new in - 0.3.1.1-alpha, but was not noted at the time. Noting it here to - close ticket 22623.)

1 0

[tor/release-0.3.1] Run format-changes script to reflow changelog.
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit 62c87f857bbafcaba33a8fc5d2a7ed192f9a1df3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 29 15:55:04 2017 -0400 Run format-changes script to reflow changelog. --- ChangeLog | 108 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/ChangeLog b/ChangeLog index d67c8dd..097482c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,15 +1,21 @@ Changes in version 0.3.1.4-alpha - 2017-06-29: blurb goes here. + o New dependencies: + - To build with zstd and lzma support, Tor now requires the pkg- + config tool at build time. (This requirement was new in + 0.3.1.1-alpha, but was not noted at the time. Noting it here to + close ticket 22623.) + o Major bugfixes (compression): - Fix crash in LZMA module, when the Sandbox is enabled, where - liblzma would allocate more than 16 MB of memory. We solve this - by bumping the mprotect() limit in the Sandbox module from 16 MB - to 20 MB. Fixes bug 22751; bugfix on 0.3.1.1-alpha. + liblzma would allocate more than 16 MB of memory. We solve this by + bumping the mprotect() limit in the Sandbox module from 16 MB to + 20 MB. Fixes bug 22751; bugfix on 0.3.1.1-alpha. o Major bugfixes (compression, zstd): - - Correctly detect a full buffer when decompessing a large - zstd-compressed input. Fixes bug 22628; bugfix on 0.3.1.1-alpha. + - Correctly detect a full buffer when decompessing a large zstd- + compressed input. Fixes bug 22628; bugfix on 0.3.1.1-alpha. o Major bugfixes (directory protocol): - Ensure that we sent "304 Not modified" as HTTP status code when a @@ -23,13 +29,13 @@ Changes in version 0.3.1.4-alpha - 2017-06-29: one root cause of bug 22400; bugfix on 0.3.0.1-alpha. o Minor features (bug mitigation, diagnostics, logging): - - Avoid an assertion failure, and log a better error message, - when unable to remove a file from the consensus cache on - Windows. Attempts to mitigate and diagnose bug 22752. + - Avoid an assertion failure, and log a better error message, when + unable to remove a file from the consensus cache on Windows. + Attempts to mitigate and diagnose bug 22752. o Minor features (compression, defensive programming): - - Detect and break out of infinite loops in our compression code. - We don't think that any such loops exist now, but it's best to be + - Detect and break out of infinite loops in our compression code. We + don't think that any such loops exist now, but it's best to be safe. Closes ticket 22672. o Minor features (geoip): @@ -38,44 +44,44 @@ Changes in version 0.3.1.4-alpha - 2017-06-29: o Minor bugfixes (compression): - When compressing or decompressing a buffer, check for a failure to - create a compression object. Fixes bug 22626; bugfix on - 0.3.1.1-alpha. + create a compression object. Fixes bug 22626; bugfix + on 0.3.1.1-alpha. - When decompressing a buffer, check for extra data after the end of the compressed data. Fixes bug 22629; bugfix on 0.3.1.1-alpha. - When decompressing an object received over an anonymous directory - connection, if we have already successfully decompressed it using an - acceptable compression method, do not reject it for looking like an - unacceptable compression method. Fixes part of bug 22670; bugfix on - 0.3.1.1-alpha. - - When serving directory votes compressed with zlib, - do not claim to have compressed them with zstd. Fixes bug 22669; + connection, if we have already successfully decompressed it using + an acceptable compression method, do not reject it for looking + like an unacceptable compression method. Fixes part of bug 22670; bugfix on 0.3.1.1-alpha. + - When serving directory votes compressed with zlib, do not claim to + have compressed them with zstd. Fixes bug 22669; bugfix + on 0.3.1.1-alpha. - When spooling compressed data to an output buffer, don't try to - spool more data when there is no more data to spool and we are - not trying to flush the input. Previously, we would sometimes - launch compression requests with nothing to do, which interferes - with our 22672 checks. Fixes bug 22719; bugfix on 0.2.0.16-alpha. + spool more data when there is no more data to spool and we are not + trying to flush the input. Previously, we would sometimes launch + compression requests with nothing to do, which interferes with our + 22672 checks. Fixes bug 22719; bugfix on 0.2.0.16-alpha. o Minor bugfixes (defensive programming, undefined behavior): - - Fix a memset() off the end of an array when packing cells. This - bug should be harmless in practice, since the corrupted bytes - are still in the same structure, and are always padding bytes, + - Fix a memset() off the end of an array when packing cells. This + bug should be harmless in practice, since the corrupted bytes are + still in the same structure, and are always padding bytes, ignored, or immediately overwritten, depending on compiler - behavior. Nevertheless, because the memset()'s purpose is to - make sure that any other cell-handling bugs can't expose bytes - to the network, we need to fix it. Fixes bug 22737; bugfix on + behavior. Nevertheless, because the memset()'s purpose is to make + sure that any other cell-handling bugs can't expose bytes to the + network, we need to fix it. Fixes bug 22737; bugfix on 0.2.4.11-alpha. Fixes CID 1401591. o Minor bugfixes (linux seccomp2 sandbox): - Permit the fchmod system call, to avoid crashing on startup when - starting with the seccomp2 sandbox and an unexpected set of permissions - on the data directory or its contents. Fixes bug 22516; bugfix on - 0.2.5.4-alpha. + starting with the seccomp2 sandbox and an unexpected set of + permissions on the data directory or its contents. Fixes bug + 22516; bugfix on 0.2.5.4-alpha. o Minor bugfixes (logging, compression): - When decompressing, do not warn if we fail to decompress using a - compression method that we merely guessed. Fixes part of - bug 22670; bugfix on 0.1.1.14-alpha. + compression method that we merely guessed. Fixes part of bug + 22670; bugfix on 0.1.1.14-alpha. - When decompressing, treat mismatch between content-encoding and actual compression type as a protocol warning. Fixes part of bug 22670; bugfix on 0.1.1.9-alpha. @@ -83,28 +89,28 @@ Changes in version 0.3.1.4-alpha - 2017-06-29: o Minor bugfixes (logging, relay): - Downgrade "assigned_to_cpuworker failed" message to INFO-level severity. In every case that can reach it, either a better warning - has already been logged, or no warning is warranted. Fixes bug 22356; - bugfix on 0.2.6.3-alpha. + has already been logged, or no warning is warranted. Fixes bug + 22356; bugfix on 0.2.6.3-alpha. o Minor bugfixes (netflow padding logging): - - Demote a warn that was caused by libevent delays to info if - the padding is less than 4.5 seconds late, or notice if it is more - (4.5 seconds is the amount of time that a netflow record might - be emitted after, if we chose the maximum timeout). Fixes bug 22212; + - Demote a warn that was caused by libevent delays to info if the + padding is less than 4.5 seconds late, or notice if it is more + (4.5 seconds is the amount of time that a netflow record might be + emitted after, if we chose the maximum timeout). Fixes bug 22212; bugfix on 0.3.1.1-alpha. o Minor bugfixes (process behavior): - - When exiting because of an error, always exit with a nonzero - exit status. Previously, we would fail to report an error in - our exit status in cases related to lockfile contention, - __OwningControllerProcess failure, and Ed25519 key - initialization. Fixes bug 22720; bugfix on versions - 0.2.1.6-alpha, 0.2.2.28-beta, and 0.2.7.2-alpha - respectively. Reported by "f55jwk4f"; patch from "huyvq". + - When exiting because of an error, always exit with a nonzero exit + status. Previously, we would fail to report an error in our exit + status in cases related to lockfile contention, + __OwningControllerProcess failure, and Ed25519 key initialization. + Fixes bug 22720; bugfix on versions 0.2.1.6-alpha, 0.2.2.28-beta, + and 0.2.7.2-alpha respectively. Reported by "f55jwk4f"; patch + from "huyvq". o Documentation: - - Add a manpage description for the key-pinning-journal file. - Closes ticket 22347. + - Add a manpage description for the key-pinning-journal file. Closes + ticket 22347. - Correctly note that bandwidth accounting values are stored in the state file, and the bw_accounting file is now obsolete. Closes ticket 16082. @@ -112,12 +118,6 @@ Changes in version 0.3.1.4-alpha - 2017-06-29: cached-extrainfo, secret_onion_key{,_ntor}.old, hidserv-stats, approved-routers, sr-random, and diff-cache. - o New dependencies: - - To build with zstd and lzma support, Tor now requires the - pkg-config tool at build time. (This requirement was new in - 0.3.1.1-alpha, but was not noted at the time. Noting it here to - close ticket 22623.) - Changes in version 0.3.1.3-alpha - 2017-06-08 Tor 0.3.1.3-alpha fixes a pair of bugs that would allow an attacker to

1 0

[tor/release-0.3.1] Lintchanges fix: bug numbers do not get #d, but they do get "fix on"
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit ac89262b1c37e86b2b57b9b1642f6db48fde0808 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 29 15:49:32 2017 -0400 Lintchanges fix: bug numbers do not get #d, but they do get "fix on" --- changes/bug22212 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/changes/bug22212 b/changes/bug22212 index f92d670..dc1604a 100644 --- a/changes/bug22212 +++ b/changes/bug22212 @@ -2,4 +2,5 @@ - Demote a warn that was caused by libevent delays to info if the padding is less than 4.5 seconds late, or notice if it is more (4.5 seconds is the amount of time that a netflow record might - be emitted after, if we chose the maximum timeout). Fixes bug #22212. + be emitted after, if we chose the maximum timeout). Fixes bug 22212; + bugfix on 0.3.1.1-alpha.

1 0

[tor/release-0.3.1] lintchanges fix: mention the ticket number.
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit 403969a3a735077c69a0b074ca45804b063284af Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 29 15:50:38 2017 -0400 lintchanges fix: mention the ticket number. --- changes/bug22347 | 1 + 1 file changed, 1 insertion(+) diff --git a/changes/bug22347 b/changes/bug22347 index f294ba0..f98c19f 100644 --- a/changes/bug22347 +++ b/changes/bug22347 @@ -1,2 +1,3 @@ o Documentation: - Add a manpage description for the key-pinning-journal file. + Closes ticket 22347.

1 0

[tor/release-0.3.1] Add "New dependencies" as a recognized lintchanges category
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit 27688994a936e8c045f0273e7295b930f4ce28ae Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 29 15:51:32 2017 -0400 Add "New dependencies" as a recognized lintchanges category --- scripts/maint/lintChanges.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/maint/lintChanges.py b/scripts/maint/lintChanges.py index bf06064..ff5ba5a 100755 --- a/scripts/maint/lintChanges.py +++ b/scripts/maint/lintChanges.py @@ -17,6 +17,7 @@ KNOWN_GROUPS = set([ "Major feature", "Major features", "New system requirements", + "New dependencies", "Testing", "Documentation", "Code simplification and refactoring",

1 0

[tor/release-0.3.1] lintchanges fix: add a category
by nickm＠torproject.org 29 Jun '17

29 Jun '17

commit 1bf3ef1c283619c5afb804db87db54db36dd6076 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 29 15:50:55 2017 -0400 lintchanges fix: add a category --- changes/geoip-june2017 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changes/geoip-june2017 b/changes/geoip-june2017 index 2ea7bf1..1001e8e 100644 --- a/changes/geoip-june2017 +++ b/changes/geoip-june2017 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the June 8 2017 Maxmind GeoLite2 Country database.

1 0

[webwml/master] Change select options
by hiro＠torproject.org 29 Jun '17

29 Jun '17

commit d48f00475e345c7d240bd2a4bbf978fd5f76e002 Author: hiromipaw <hiro(a)torproject.org> Date: Thu Jun 29 18:30:38 2017 +0200 Change select options --- docs/en/debian.wml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/en/debian.wml b/docs/en/debian.wml index 96e061b..535c449 100644 --- a/docs/en/debian.wml +++ b/docs/en/debian.wml @@ -71,9 +71,9 @@ For Ubuntu, ask <a href="https://en.wikipedia.org/wiki/List_of_Ubuntu_releases#T <blockquote> I run <select id="distrib"> -<option value="wheezy">Debian oldstable (jessie)</option> -<option value="jessie" selected="selected">Debian stable (stretch)</option> -<option value="stretch">Debian testing (buster)</option> +<option value="jessie">Debian oldstable (jessie)</option> +<option value="stretch" selected="selected">Debian stable (stretch)</option> +<option value="testing">Debian testing (buster)</option> <option value="sid">Debian unstable (sid)</option> <option value="precise">Ubuntu Precise Pangolin</option> <option value="trusty">Ubuntu Trusty Tahr</option>

1 0

[webwml/master] Change buster for testing
by hiro＠torproject.org 29 Jun '17

29 Jun '17

commit 5d0929868aba9cf63603015731f1c7b5fcf18e3d Author: hiromipaw <hiro(a)torproject.org> Date: Thu Jun 29 17:50:25 2017 +0200 Change buster for testing --- docs/debian-selector.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/debian-selector.js b/docs/debian-selector.js index d7ddbe6..71550a7 100644 --- a/docs/debian-selector.js +++ b/docs/debian-selector.js @@ -6,7 +6,7 @@ var software = { 'tor': { '_stable': { 'jessie': [ 'jessie' ], 'stretch': [ 'stretch' ], - 'buster': [ 'buster' ], + 'testing': [ 'testing' ], 'sid': [ 'sid' ], 'precise': [ 'precise'], 'trusty': [ 'trusty'], @@ -16,7 +16,7 @@ var software = { 'experimental-0.3.0.x': { 'jessie': [ 'jessie' ], 'stretch': [ 'stretch' ], - 'buster': [ 'buster' ], + 'testing': [ 'testing' ], 'sid': [ 'sid' ], 'precise': [ 'precise'], 'trusty': [ 'trusty'], @@ -28,7 +28,7 @@ var software = { '_stable': { 'jessie': [ 'jessie' ], 'stretch': [ 'stretch' ], - 'buster': [ 'buster' ], + 'testing': [ 'testing' ], 'sid': [ 'sid' ], 'precise': [ 'precise'], 'trusty': [ 'trusty'], @@ -38,7 +38,7 @@ var software = { 'experimental-0.3.0.x': { 'jessie': [ 'jessie' ], 'stretch': [ 'stretch' ], - 'buster': [ 'buster' ], + 'testing': [ 'testing' ], 'sid': [ 'sid' ], 'precise': [ 'precise'], 'trusty': [ 'trusty'],

1 0

[webwml/master] Change Debian distros also in blockquote
by hiro＠torproject.org 29 Jun '17

29 Jun '17

commit 1a2028afc99f5855748c50797b95d2efc4cf0af6 Author: hiromipaw <hiro(a)torproject.org> Date: Thu Jun 29 16:19:53 2017 +0200 Change Debian distros also in blockquote --- docs/en/debian.wml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/debian.wml b/docs/en/debian.wml index 5cbe323..96e061b 100644 --- a/docs/en/debian.wml +++ b/docs/en/debian.wml @@ -89,7 +89,7 @@ version <div id="apt-source"> <p>You need to add the following entry in <code>/etc/apt/sources.list</code> or a new file in <code>/etc/apt/sources.list.d/</code>:</p> -<blockquote><pre id="sources">deb http://deb.torproject.org/torproject.org wheezy main +<blockquote><pre id="sources">deb http://deb.torproject.org/torproject.org jessie main </pre></blockquote> </div>

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
192
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits June 2017