March 2017 - tor-commits - lists.torproject.org

[support-portal/master] Add misc operator (relay/onion/bridge) questions
by colin＠torproject.org 28 Mar '17

28 Mar '17

commit ec9065c22815cadbf098eecf40bf584051a3d86c Author: Colin Childs <colin(a)torproject.org> Date: Mon Mar 27 22:11:10 2017 -0500 Add misc operator (relay/onion/bridge) questions --- plain/operator.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/plain/operator.txt b/plain/operator.txt new file mode 100644 index 0000000..e09d63d --- /dev/null +++ b/plain/operator.txt @@ -0,0 +1,14 @@ +Q. How do I run a middle/guard relay? + +Q. How do I run an exit relay? + +Q. How do I run a vanilla bridge? + +Q. How do I run a bridge with pluggable transports? + +Q. How do I run a standard onion service? + +Q. How do I run a single onion service? + +Q. What is the difference between a single and standard onion service? +

1 0

[support-portal/master] Add initial list of mobile questions
by colin＠torproject.org 28 Mar '17

28 Mar '17

commit 636724fc46b9061caf674040dd0185f9c23efb66 Author: Colin Childs <colin(a)torproject.org> Date: Mon Mar 27 22:06:40 2017 -0500 Add initial list of mobile questions --- plain/mobile.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/plain/mobile.txt b/plain/mobile.txt new file mode 100644 index 0000000..10f27be --- /dev/null +++ b/plain/mobile.txt @@ -0,0 +1,8 @@ +Q. How do I run Tor on Android? + +Q. How do I run Tor on iOS? + +Q. How do I run Tor on Windows Phone? + +Q. Who is the Guardian Project? +

1 0

[support-portal/master] Pushing initial set of misc questions
by colin＠torproject.org 28 Mar '17

28 Mar '17

commit a7de6113cb5d6ea6f910b6d71429889867038499 Author: Colin Childs <colin(a)torproject.org> Date: Mon Mar 27 22:03:41 2017 -0500 Pushing initial set of misc questions --- plain/misc.txt | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/plain/misc.txt b/plain/misc.txt new file mode 100644 index 0000000..197e4fe --- /dev/null +++ b/plain/misc.txt @@ -0,0 +1,10 @@ +Q. How is Tor different from a VPN? + +Q. Can I use Tor with bittorrent? + +Q. Does the Tor Project have control over onion services? + +Q. Is using Tor illegal? + +Q. Why did you infect my computer with malware? (CryptoLocker) +

1 0

[tor/release-0.3.0] Fix max sampled size logic when in bridge mode.
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit ef4c10fb42e796a7a1662b5f1db27d10347e89af Author: George Kadianakis <desnacked(a)riseup.net> Date: Mon Mar 27 15:08:18 2017 +0200 Fix max sampled size logic when in bridge mode. When calculating max sampled size, Tor would only count the number of bridges in torrc, without considering that our state file might already have sampled bridges in it. This caused problems when people swap bridges, since the following error would trigger: [warn] Not expanding the guard sample any further; just hit the maximum sample threshold of 1 --- changes/bug21771 | 5 +++++ src/or/entrynodes.c | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/changes/bug21771 b/changes/bug21771 new file mode 100644 index 0000000..f814c75 --- /dev/null +++ b/changes/bug21771 @@ -0,0 +1,5 @@ + o Minor bugfixes (guard selection): + - Fix a guard selection bug where Tor would refuse to bootstrap in some + cases if the user swapped a bridge for another bridge in their + configuration file. + Fixes bug 21771; bugfix on 0.3.0.1-alpha. Reported by "torvlnt33r". diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index c3c576c..e0a3854 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -989,9 +989,11 @@ get_max_sample_size(guard_selection_t *gs, const int using_bridges = (gs->type == GS_TYPE_BRIDGE); const int min_sample = get_min_filtered_sample_size(); - /* With bridges, max_sample is "all of them" */ + /* If we are in bridge mode, expand our sample set as needed without worrying + * about max size. We should respect the user's wishes to use many bridges if + * that's what they have specified in their configuration file. */ if (using_bridges) - return n_guards; + return INT_MAX; const int max_sample_by_pct = (int)(n_guards * get_max_sample_threshold()); const int max_sample_absolute = get_max_sample_size_absolute();

1 0

[tor/release-0.3.0] Merge branch 'maint-0.3.0' into release-0.3.0
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit 0c0f8ad061812f06c8379ebdb95fd71440fd4eed Merge: e1718c2 ef4c10f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 27 15:55:32 2017 +0200 Merge branch 'maint-0.3.0' into release-0.3.0 changes/bug21771 | 5 +++++ src/or/entrynodes.c | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-)

1 0

[tor/master] Fix max sampled size logic when in bridge mode.
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit ef4c10fb42e796a7a1662b5f1db27d10347e89af Author: George Kadianakis <desnacked(a)riseup.net> Date: Mon Mar 27 15:08:18 2017 +0200 Fix max sampled size logic when in bridge mode. When calculating max sampled size, Tor would only count the number of bridges in torrc, without considering that our state file might already have sampled bridges in it. This caused problems when people swap bridges, since the following error would trigger: [warn] Not expanding the guard sample any further; just hit the maximum sample threshold of 1 --- changes/bug21771 | 5 +++++ src/or/entrynodes.c | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/changes/bug21771 b/changes/bug21771 new file mode 100644 index 0000000..f814c75 --- /dev/null +++ b/changes/bug21771 @@ -0,0 +1,5 @@ + o Minor bugfixes (guard selection): + - Fix a guard selection bug where Tor would refuse to bootstrap in some + cases if the user swapped a bridge for another bridge in their + configuration file. + Fixes bug 21771; bugfix on 0.3.0.1-alpha. Reported by "torvlnt33r". diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index c3c576c..e0a3854 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -989,9 +989,11 @@ get_max_sample_size(guard_selection_t *gs, const int using_bridges = (gs->type == GS_TYPE_BRIDGE); const int min_sample = get_min_filtered_sample_size(); - /* With bridges, max_sample is "all of them" */ + /* If we are in bridge mode, expand our sample set as needed without worrying + * about max size. We should respect the user's wishes to use many bridges if + * that's what they have specified in their configuration file. */ if (using_bridges) - return n_guards; + return INT_MAX; const int max_sample_by_pct = (int)(n_guards * get_max_sample_threshold()); const int max_sample_absolute = get_max_sample_size_absolute();

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.3.0'
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit 4d5b46aad91daeafd9c3f9d703f3b0b7b47ad472 Merge: e79f90c ef4c10f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 27 15:44:31 2017 +0200 Merge remote-tracking branch 'origin/maint-0.3.0' changes/bug21771 | 5 +++++ src/or/entrynodes.c | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.3.0] Fix max sampled size logic when in bridge mode.
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit ef4c10fb42e796a7a1662b5f1db27d10347e89af Author: George Kadianakis <desnacked(a)riseup.net> Date: Mon Mar 27 15:08:18 2017 +0200 Fix max sampled size logic when in bridge mode. When calculating max sampled size, Tor would only count the number of bridges in torrc, without considering that our state file might already have sampled bridges in it. This caused problems when people swap bridges, since the following error would trigger: [warn] Not expanding the guard sample any further; just hit the maximum sample threshold of 1 --- changes/bug21771 | 5 +++++ src/or/entrynodes.c | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/changes/bug21771 b/changes/bug21771 new file mode 100644 index 0000000..f814c75 --- /dev/null +++ b/changes/bug21771 @@ -0,0 +1,5 @@ + o Minor bugfixes (guard selection): + - Fix a guard selection bug where Tor would refuse to bootstrap in some + cases if the user swapped a bridge for another bridge in their + configuration file. + Fixes bug 21771; bugfix on 0.3.0.1-alpha. Reported by "torvlnt33r". diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index c3c576c..e0a3854 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -989,9 +989,11 @@ get_max_sample_size(guard_selection_t *gs, const int using_bridges = (gs->type == GS_TYPE_BRIDGE); const int min_sample = get_min_filtered_sample_size(); - /* With bridges, max_sample is "all of them" */ + /* If we are in bridge mode, expand our sample set as needed without worrying + * about max size. We should respect the user's wishes to use many bridges if + * that's what they have specified in their configuration file. */ if (using_bridges) - return n_guards; + return INT_MAX; const int max_sample_by_pct = (int)(n_guards * get_max_sample_threshold()); const int max_sample_absolute = get_max_sample_size_absolute();

1 0

[tor/master] Storagedir test fix: save strings in binary mode to preserve length
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit e79f90c7f031b8a7825574f865c77d7034b93a16 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 27 15:27:52 2017 +0200 Storagedir test fix: save strings in binary mode to preserve length --- src/test/test_storagedir.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/test_storagedir.c b/src/test/test_storagedir.c index 77ed5bf..6678629 100644 --- a/src/test/test_storagedir.c +++ b/src/test/test_storagedir.c @@ -172,17 +172,17 @@ test_storagedir_full(void *arg) d = storage_dir_new(dirname, 3); tt_assert(d); - r = storage_dir_save_string_to_file(d, str, 0, NULL); + r = storage_dir_save_string_to_file(d, str, 1, NULL); tt_int_op(r, OP_EQ, 0); - r = storage_dir_save_string_to_file(d, str, 0, NULL); + r = storage_dir_save_string_to_file(d, str, 1, NULL); tt_int_op(r, OP_EQ, 0); - r = storage_dir_save_string_to_file(d, str, 0, NULL); + r = storage_dir_save_string_to_file(d, str, 1, NULL); tt_int_op(r, OP_EQ, 0); // These should fail! - r = storage_dir_save_string_to_file(d, str, 0, NULL); + r = storage_dir_save_string_to_file(d, str, 1, NULL); tt_int_op(r, OP_EQ, -1); - r = storage_dir_save_string_to_file(d, str, 0, NULL); + r = storage_dir_save_string_to_file(d, str, 1, NULL); tt_int_op(r, OP_EQ, -1); tt_u64_op(strlen(str) * 3, OP_EQ, storage_dir_get_usage(d)); @@ -212,7 +212,7 @@ test_storagedir_cleaning(void *arg) tt_assert(d); for (i = 0; i < 8; ++i) { - r = storage_dir_save_string_to_file(d, str+i*2, 0, &fns[i]); + r = storage_dir_save_string_to_file(d, str+i*2, 1, &fns[i]); tt_int_op(r, OP_EQ, 0); }

1 0

[tor/master] Merge remote-tracking branch 'ahf/bugs/21757'
by nickm＠torproject.org 27 Mar '17

27 Mar '17

commit 10888dcac6cd1b32914da4d25c5dcc42e91a6239 Merge: 1bf891c a28be68 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 27 15:02:48 2017 +0200 Merge remote-tracking branch 'ahf/bugs/21757' src/common/util.c | 2 +- src/test/test_util.c | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-)

1 0