November 2017 - tor-commits - lists.torproject.org

[translation/whisperback_completed] Update translations for whisperback_completed
by translation＠torproject.org 03 Nov '17

03 Nov '17

commit dcdb960f24c1047f1c1ac9da05b01ea3ec934267 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 3 14:15:30 2017 +0000 Update translations for whisperback_completed --- ja/ja.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ja/ja.po b/ja/ja.po index 67fa2a3e3..ab429cab1 100644 --- a/ja/ja.po +++ b/ja/ja.po @@ -11,7 +11,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-03-20 12:09+0000\n" -"PO-Revision-Date: 2017-09-19 14:50+0000\n" +"PO-Revision-Date: 2017-11-03 14:03+0000\n" "Last-Translator: daisuke osada (daiskeh) <dosada(a)gmail.com>\n" "Language-Team: Japanese (http://www.transifex.com/otf/torproject/language/ja/)\n" "MIME-Version: 1.0\n"

1 0

[translation/whisperback] Update translations for whisperback
by translation＠torproject.org 03 Nov '17

03 Nov '17

commit 79d5f877c50ba66743290aed4efe820946ad1160 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 3 14:15:24 2017 +0000 Update translations for whisperback --- ja/ja.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ja/ja.po b/ja/ja.po index 67fa2a3e3..ab429cab1 100644 --- a/ja/ja.po +++ b/ja/ja.po @@ -11,7 +11,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-03-20 12:09+0000\n" -"PO-Revision-Date: 2017-09-19 14:50+0000\n" +"PO-Revision-Date: 2017-11-03 14:03+0000\n" "Last-Translator: daisuke osada (daiskeh) <dosada(a)gmail.com>\n" "Language-Team: Japanese (http://www.transifex.com/otf/torproject/language/ja/)\n" "MIME-Version: 1.0\n"

1 0

[translation/tails-misc_completed] Update translations for tails-misc_completed
by translation＠torproject.org 03 Nov '17

03 Nov '17

commit f97a990838ffdac75896525b3b331469ae52b620 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 3 13:17:16 2017 +0000 Update translations for tails-misc_completed --- vi.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vi.po b/vi.po index 7015424fa..dbb54e9d1 100644 --- a/vi.po +++ b/vi.po @@ -10,7 +10,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-09-13 20:10+0200\n" -"PO-Revision-Date: 2017-11-01 03:53+0000\n" +"PO-Revision-Date: 2017-11-03 13:02+0000\n" "Last-Translator: Khanh Nguyen <nguyenduykhanh85(a)gmail.com>\n" "Language-Team: Vietnamese (http://www.transifex.com/otf/torproject/language/vi/)\n" "MIME-Version: 1.0\n"

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 03 Nov '17

03 Nov '17

commit 71e915e40f79d5290272b3ef9d8384d509660bc3 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 3 13:17:10 2017 +0000 Update translations for tails-misc --- vi.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vi.po b/vi.po index 7015424fa..dbb54e9d1 100644 --- a/vi.po +++ b/vi.po @@ -10,7 +10,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-09-13 20:10+0200\n" -"PO-Revision-Date: 2017-11-01 03:53+0000\n" +"PO-Revision-Date: 2017-11-03 13:02+0000\n" "Last-Translator: Khanh Nguyen <nguyenduykhanh85(a)gmail.com>\n" "Language-Team: Vietnamese (http://www.transifex.com/otf/torproject/language/vi/)\n" "MIME-Version: 1.0\n"

1 0

[translation/liveusb-creator_completed] Update translations for liveusb-creator_completed
by translation＠torproject.org 03 Nov '17

03 Nov '17

commit 1e4a7a5ce884d9204546514a65b3b9d89b8f9bf5 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 3 13:16:03 2017 +0000 Update translations for liveusb-creator_completed --- da/da.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/da/da.po b/da/da.po index 3dba03de7..1e73c695c 100644 --- a/da/da.po +++ b/da/da.po @@ -20,7 +20,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-09-25 14:02+0200\n" -"PO-Revision-Date: 2017-11-01 07:16+0000\n" +"PO-Revision-Date: 2017-11-03 13:03+0000\n" "Last-Translator: scootergrisen\n" "Language-Team: Danish (http://www.transifex.com/otf/torproject/language/da/)\n" "MIME-Version: 1.0\n"

1 0

[translation/liveusb-creator] Update translations for liveusb-creator
by translation＠torproject.org 03 Nov '17

03 Nov '17

commit fbe61b6076ce8116dc297626b9eb12d553639c01 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 3 13:15:57 2017 +0000 Update translations for liveusb-creator --- da/da.po | 2 +- vi/vi.po | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/da/da.po b/da/da.po index 3dba03de7..1e73c695c 100644 --- a/da/da.po +++ b/da/da.po @@ -20,7 +20,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-09-25 14:02+0200\n" -"PO-Revision-Date: 2017-11-01 07:16+0000\n" +"PO-Revision-Date: 2017-11-03 13:03+0000\n" "Last-Translator: scootergrisen\n" "Language-Team: Danish (http://www.transifex.com/otf/torproject/language/da/)\n" "MIME-Version: 1.0\n" diff --git a/vi/vi.po b/vi/vi.po index 54cad5493..cdb61fe53 100644 --- a/vi/vi.po +++ b/vi/vi.po @@ -12,7 +12,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-09-25 14:02+0200\n" -"PO-Revision-Date: 2017-11-01 03:57+0000\n" +"PO-Revision-Date: 2017-11-03 13:02+0000\n" "Last-Translator: Khanh Nguyen <nguyenduykhanh85(a)gmail.com>\n" "Language-Team: Vietnamese (http://www.transifex.com/otf/torproject/language/vi/)\n" "MIME-Version: 1.0\n"

1 0

[doctor/master] Drop bwauth exception for gabelmoo
by atagar＠torproject.org 02 Nov '17

02 Nov '17

commit d54d5b3aa5ebb084d3eb37cc5ee0e74f30a7f673 Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Nov 2 12:03:07 2017 -0700 Drop bwauth exception for gabelmoo Earlier gabelmoo's bwauth had issues and after a while Sebastian disabled it. During it we disabled this check so he woulnd't spam for having *or* omitting bwauth measurements. Sebastian's now running a bwauth again so dropping this exception. --- consensus_health_checker.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/consensus_health_checker.py b/consensus_health_checker.py index 3b3d779..ba9c2b1 100755 --- a/consensus_health_checker.py +++ b/consensus_health_checker.py @@ -545,11 +545,6 @@ def voting_bandwidth_scanners(latest_consensus, consensuses, votes): contains_measured_bandwidth = True break - # TODO: re-enable when gabelmoo is fixed - - if authority == 'gabelmoo': - continue - if DIRECTORY_AUTHORITIES[authority].is_bandwidth_authority and not contains_measured_bandwidth: missing_authorities.append(authority) if not DIRECTORY_AUTHORITIES[authority].is_bandwidth_authority and contains_measured_bandwidth:

1 0

[stem/master] Don't check 'UseMicrodescriptors 1' when calling get_network_statuses()
by atagar＠torproject.org 02 Nov '17

02 Nov '17

commit 136537c229193f77f86a11e02d528c6123ee91ab Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Nov 2 10:07:59 2017 -0700 Don't check 'UseMicrodescriptors 1' when calling get_network_statuses() So much confusion around this... https://trac.torproject.org/projects/tor/ticket/24110 It turns out in practice these methods essentially never provided microdescriptor flavored router status entries because 'UseMicrodescriptors' defaults to 'auto' (and it's rare to set it to '1' since that's the default anyway). However, if that was done we stacktraced... >>> desc = next(controller.get_network_statuses()) Traceback (most recent call last): File "<console>", line 1, in <module> File "/home/atagar/Desktop/stem/stem/control.py", line 494, in wrapped for val in func(self, *args, **kwargs): File "/home/atagar/Desktop/stem/stem/control.py", line 1993, in get_network_statuses for desc in desc_iterator: File "/home/atagar/Desktop/stem/stem/descriptor/router_status_entry.py", line 104, in _parse_file yield entry_class(desc_content, validate, *extra_args) File "/home/atagar/Desktop/stem/stem/descriptor/router_status_entry.py", line 446, in __init__ raise ValueError("%s must have a '%s' line:\n%s" % (self._name(True), keyword, str(self))) ValueError: Router status entries (micro v3) must have a 'm' line: r networkofthesmoker AAaX5kASI9/xzl9Qp7aFdPOSnrQ aoqBoLrUWKssJAKnO8r6GpZs5p8 2017-11-02 13:51:59 128.72.180.74 443 0 s Fast Guard HSDir Running Stable V2Dir Valid w Bandwidth=4150 From what I can tell nowadays UseMicrodescriptors doesn't change the 'GETINFO ns/all' response. As such reverting... https://gitweb.torproject.org/stem.git/commit/?id=d70fa9cd --- docs/change_log.rst | 1 + stem/control.py | 38 ++++---------------------------------- 2 files changed, 5 insertions(+), 34 deletions(-) diff --git a/docs/change_log.rst b/docs/change_log.rst index 12a7dc8c..e6ff38d3 100644 --- a/docs/change_log.rst +++ b/docs/change_log.rst @@ -65,6 +65,7 @@ The following are only available within Stem's `git repository * Failed to parse torrcs without a port on ipv6 exit policy entries * Resilient to 'Tor' prefix in 'GETINFO version' result (:spec:`c5ff1b1`) * Added a **all_extra** parameter to :class:`stem.version.Version` and support for multiple parenthetical entries (:trac:`22110`, :spec:`b50917d`) + * Setting 'UseMicrodescriptors 1' in your torrc caused :func:`~stem.control.Controller.get_network_statuses` to error (:trac:`24110`) * Closing controller connection faster when under heavy event load * Better messaging when unable to connect to tor on FreeBSD * More succinct trace level logging diff --git a/stem/control.py b/stem/control.py index 7c67cd0d..412740cc 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1889,17 +1889,6 @@ class Controller(BaseController): or nickname. If the relay identifier could be either a fingerprint *or* nickname then it's queried as a fingerprint. - This provides - :class:`~stem.descriptor.router_status_entry.RouterStatusEntryMicroV3` - instances if tor is using microdescriptors... - - :: - - controller.get_conf('UseMicrodescriptors', '0') == '1' - - ... and :class:`~stem.descriptor.router_status_entry.RouterStatusEntryV3` - otherwise. - If no **relay** is provided then this defaults to ourselves. Remember that this requires that we've retrieved our own descriptor from remote authorities so this both won't be available for newly started relays and @@ -1911,7 +1900,7 @@ class Controller(BaseController): :param str relay: fingerprint or nickname of the relay to be queried :param object default: response if the query fails - :returns: :class:`~stem.descriptor.router_status_entry.RouterStatusEntry` + :returns: :class:`~stem.descriptor.router_status_entry.RouterStatusEntryV3` for the given relay :raises: @@ -1948,10 +1937,7 @@ class Controller(BaseController): if not desc_content: raise stem.DescriptorUnavailable('Descriptor information is unavailable, tor might still be downloading it') - if self.get_conf('UseMicrodescriptors', '0') == '1': - return stem.descriptor.router_status_entry.RouterStatusEntryMicroV3(desc_content) - else: - return stem.descriptor.router_status_entry.RouterStatusEntryV3(desc_content) + return stem.descriptor.router_status_entry.RouterStatusEntryV3(desc_content) @with_default(yields = True) def get_network_statuses(self, default = UNDEFINED): @@ -1961,21 +1947,10 @@ class Controller(BaseController): Provides an iterator for all of the router status entries that tor currently knows about. - This provides - :class:`~stem.descriptor.router_status_entry.RouterStatusEntryMicroV3` - instances if tor is using microdescriptors... - - :: - - controller.get_conf('UseMicrodescriptors', '0') == '1' - - ... and :class:`~stem.descriptor.router_status_entry.RouterStatusEntryV3` - otherwise. - :param list default: items to provide if the query fails :returns: iterates over - :class:`~stem.descriptor.router_status_entry.RouterStatusEntry` for + :class:`~stem.descriptor.router_status_entry.RouterStatusEntryV3` for relays in the tor network :raises: :class:`stem.ControllerError` if unable to query tor and no @@ -1987,11 +1962,6 @@ class Controller(BaseController): # # https://trac.torproject.org/8248 - if self.get_conf('UseMicrodescriptors', '0') == '1': - desc_class = stem.descriptor.router_status_entry.RouterStatusEntryMicroV3 - else: - desc_class = stem.descriptor.router_status_entry.RouterStatusEntryV3 - desc_content = self.get_info('ns/all', get_bytes = True) if not desc_content: @@ -2000,7 +1970,7 @@ class Controller(BaseController): desc_iterator = stem.descriptor.router_status_entry._parse_file( io.BytesIO(desc_content), False, - entry_class = desc_class, + entry_class = stem.descriptor.router_status_entry.RouterStatusEntryV3, ) for desc in desc_iterator:

1 0

[tor/master] nodelist: Downgrade warning to protocol warning
by nickm＠torproject.org 02 Nov '17

02 Nov '17

commit 0386280487fce78b73e060234f515b850af9c589 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Nov 1 12:15:15 2017 -0400 nodelist: Downgrade warning to protocol warning The node_get_ed25519_id() warning can actually be triggered by a relay flagged with NoEdConsensus so instead of triggering a warning on all relays of the network, downgrade it to protocol warning. Fixes #24025 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug24025 | 5 +++++ src/or/nodelist.c | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changes/bug24025 b/changes/bug24025 new file mode 100644 index 000000000..1d7841af5 --- /dev/null +++ b/changes/bug24025 @@ -0,0 +1,5 @@ + o Minor bugfixes (logging, relay): + - Downgrade a warning to a protocol warning in the case the ed25519 key is + not consistent between the descriptor and micro descriptor of a relay. + This can happen for instance if the relay has been flagged + NoEdConsensus. Fixes bug 24025; bugfix on 0.3.2.1-alpha. diff --git a/src/or/nodelist.c b/src/or/nodelist.c index f5a2cddf4..f2e979be8 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -924,7 +924,10 @@ node_get_ed25519_id(const node_t *node) if (ed25519_pubkey_eq(ri_pk, md_pk)) { return ri_pk; } else { - log_warn(LD_GENERAL, "Inconsistent ed25519 identities in the nodelist"); + /* This can happen if the relay gets flagged NoEdConsensus which will be + * triggered on all relays of the network. Thus a protocol warning. */ + log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, + "Inconsistent ed25519 identities in the nodelist"); return NULL; } } else if (ri_pk) {

1 0

[tor/maint-0.3.2] nodelist: Downgrade warning to protocol warning
by nickm＠torproject.org 02 Nov '17

02 Nov '17

commit 0386280487fce78b73e060234f515b850af9c589 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Nov 1 12:15:15 2017 -0400 nodelist: Downgrade warning to protocol warning The node_get_ed25519_id() warning can actually be triggered by a relay flagged with NoEdConsensus so instead of triggering a warning on all relays of the network, downgrade it to protocol warning. Fixes #24025 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug24025 | 5 +++++ src/or/nodelist.c | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changes/bug24025 b/changes/bug24025 new file mode 100644 index 000000000..1d7841af5 --- /dev/null +++ b/changes/bug24025 @@ -0,0 +1,5 @@ + o Minor bugfixes (logging, relay): + - Downgrade a warning to a protocol warning in the case the ed25519 key is + not consistent between the descriptor and micro descriptor of a relay. + This can happen for instance if the relay has been flagged + NoEdConsensus. Fixes bug 24025; bugfix on 0.3.2.1-alpha. diff --git a/src/or/nodelist.c b/src/or/nodelist.c index f5a2cddf4..f2e979be8 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -924,7 +924,10 @@ node_get_ed25519_id(const node_t *node) if (ed25519_pubkey_eq(ri_pk, md_pk)) { return ri_pk; } else { - log_warn(LD_GENERAL, "Inconsistent ed25519 identities in the nodelist"); + /* This can happen if the relay gets flagged NoEdConsensus which will be + * triggered on all relays of the network. Thus a protocol warning. */ + log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, + "Inconsistent ed25519 identities in the nodelist"); return NULL; } } else if (ri_pk) {

1 0