November 2017 - tor-commits - lists.torproject.org

[tor/release-0.3.2] hs-v3: Fix consensus param "hsdir-interval" name
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 7df28ce2990cc0890b05767f07756990e0d91e97 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 13 11:48:56 2017 -0500 hs-v3: Fix consensus param "hsdir-interval" name The dir-spec.txt specifies it to be "hsdir_interval" (underscore). Fixes #24262 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug24262 | 3 +++ src/or/hs_common.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/bug24262 b/changes/bug24262 new file mode 100644 index 000000000..eee69512e --- /dev/null +++ b/changes/bug24262 @@ -0,0 +1,3 @@ + o Minor bugfixes (hidden service): + - Fix the consensus parameter "hsdir-interval" to "hsdir_interval" so it + matches the dir-spec.txt. Fixes bug 24262; bugfix on 0.3.1.1-alpha. diff --git a/src/or/hs_common.c b/src/or/hs_common.c index 42508126f..7cef5a8e2 100644 --- a/src/or/hs_common.c +++ b/src/or/hs_common.c @@ -56,7 +56,7 @@ hs_check_service_private_dir(const char *username, const char *path, STATIC uint64_t get_time_period_length(void) { - int32_t time_period_length = networkstatus_get_param(NULL, "hsdir-interval", + int32_t time_period_length = networkstatus_get_param(NULL, "hsdir_interval", HS_TIME_PERIOD_LENGTH_DEFAULT, HS_TIME_PERIOD_LENGTH_MIN, HS_TIME_PERIOD_LENGTH_MAX);

1 0

[tor/master] Merge branch 'maint-0.3.2'
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 0c6d05cdd4b20ddacb913e84cc49a4d4082b28d4 Merge: 527eb563c d0b75b5ad Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 13 12:27:44 2017 -0500 Merge branch 'maint-0.3.2' changes/bug24262 | 3 +++ src/or/hs_common.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/master] Remove changes files for those items already merged in 0.3.2
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 527eb563cbf8e5be385623a608f5503110d2c445 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 13 11:45:55 2017 -0500 Remove changes files for those items already merged in 0.3.2 --- changes/bug21394 | 9 --------- changes/bug23318 | 11 ----------- changes/bug23623 | 4 ---- changes/bug23693 | 6 ------ changes/bug23751 | 6 ------ changes/bug23753 | 4 ---- changes/bug23762 | 4 ---- changes/bug23774 | 4 ---- changes/bug23816 | 6 ------ changes/bug23820 | 5 ----- changes/bug23985 | 9 --------- changes/bug24025 | 5 ----- changes/bug24082 | 3 --- changes/bug24115 | 4 ---- changes/bug24150 | 4 ---- changes/bug24170 | 3 --- changes/bug24247 | 6 ------ changes/geoip-2017-11-06 | 4 ---- changes/hsdescv3_fuzz_more | 3 --- changes/ticket21031 | 7 ------- changes/ticket24109 | 4 ---- 21 files changed, 111 deletions(-) diff --git a/changes/bug21394 b/changes/bug21394 deleted file mode 100644 index e5452e20b..000000000 --- a/changes/bug21394 +++ /dev/null @@ -1,9 +0,0 @@ - o Major bugfixes (Exit nodes): - - Fix an issue causing high-bandwidth exit nodes to fail a majority - or all of their DNS requests, making them basically unsuitable for - regular usage in Tor circuits. The problem is related to - libevent's DNS handling, but we can work around it in Tor. Fixes - bugs 21394 and 18580; bugfix on 0.1.2.2-alpha which introduced - eventdns. Credit goes to Dhalgren for identifying and finding a - workaround to this bug and to gamambel, arthuredelstein and - arma in helping to track it down and analyze it. diff --git a/changes/bug23318 b/changes/bug23318 deleted file mode 100644 index 7fcb8d448..000000000 --- a/changes/bug23318 +++ /dev/null @@ -1,11 +0,0 @@ - o Minor bugfixes (path selection): - - When selecting relays by bandwidth, avoid a rounding error that - could sometimes cause load to be imbalanced incorrectly. Previously, - we would always round upwards; now, we round towards the nearest - integer. This had the biggest effect when a relay's weight adjustments - should have given it weight 0, but it got weight 1 instead. - Fixes bug 23318; bugfix on 0.2.4.3-alpha. - - When calculating the fraction of nodes that have descriptors, and all - all nodes in the network have zero bandwidths, count the number of nodes - instead. - Fixes bug 23318; bugfix on 0.2.4.10-alpha. diff --git a/changes/bug23623 b/changes/bug23623 deleted file mode 100644 index 1e2e5c2ac..000000000 --- a/changes/bug23623 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (onion services): - - Cache some needed onion service client information instead of - continuously computing it over and over again. Fixes bug 23623; bugfix - on 0.3.2.1-alpha. diff --git a/changes/bug23693 b/changes/bug23693 deleted file mode 100644 index 796398be5..000000000 --- a/changes/bug23693 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (relay, crash): - - Avoid a crash when transitioning from client mode to bridge mode. - Previously, we would launch the worker threads whenever our "public - server" mode changed, but not when our "server" mode changed. - Fixes bug 23693; bugfix on 0.2.6.3-alpha. - diff --git a/changes/bug23751 b/changes/bug23751 deleted file mode 100644 index 2fd702166..000000000 --- a/changes/bug23751 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (scheduler, channel): - - Ignore channels that have been closed while flushing cells. This can - happen if the write on the connection fails leading to the channel being - closed while in the scheduler loop. This is not a complete fix, it is a - bandaid until we are able to refactor those interactions. Fixes bug - 23751; bugfix on 0.3.2.1-alpha. diff --git a/changes/bug23753 b/changes/bug23753 deleted file mode 100644 index 8782a8e2d..000000000 --- a/changes/bug23753 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (logging, scheduler): - - Introduce a SCHED_BUG() function to log extra information about the - scheduler state if we ever catch a bug in the scheduler. Closes ticket - 23753. diff --git a/changes/bug23762 b/changes/bug23762 deleted file mode 100644 index 741a88e21..000000000 --- a/changes/bug23762 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (hidden service v3): - - Properly retry HSv3 descriptor fetches in the case where we were initially - missing required directory information. Fixes bug 23762; bugfix on - 0.3.2.1-alpha. diff --git a/changes/bug23774 b/changes/bug23774 deleted file mode 100644 index 2ea5c0122..000000000 --- a/changes/bug23774 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (memory leak): - - Fix a minor memory-leak-at-exit in the KIST scheduler. This - bug should have no user-visible impact. Fixes bug 23774; - bugfix on 0.3.2.1-alpha. diff --git a/changes/bug23816 b/changes/bug23816 deleted file mode 100644 index 6139dec9e..000000000 --- a/changes/bug23816 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (directory client): - - On failure to download directory information, delay retry attempts - by a random amount based on the "decorrelated jitter" algorithm. - Our previous delay algorithm tended to produce extra-long delays too - easily. Fixes bug 23816; bugfix on 0.2.9.1-alpha. - diff --git a/changes/bug23820 b/changes/bug23820 deleted file mode 100644 index 4e920d049..000000000 --- a/changes/bug23820 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (IPv6, v3 single onion services): - - Remove buggy code for IPv6-only v3 single onion services, and reject - attempts to configure them. This release supports IPv4, dual-stack, and - IPv6-only v3 hidden services; and IPv4 and dual-stack v3 single onion - services. Fixes bug 23820; bugfix on 0.3.2.1-alpha. diff --git a/changes/bug23985 b/changes/bug23985 deleted file mode 100644 index 9cb593796..000000000 --- a/changes/bug23985 +++ /dev/null @@ -1,9 +0,0 @@ - o Minor bugfixes (bootstrapping): - - Fetch descriptors aggressively whenever we lack enough - to build circuits, regardless of how many descriptors we are missing. - Previously, we would delay launching the fetch when we had fewer than - 15 missing descriptors, even if some of those descriptors were - blocking circuits from building. Fixes bug 23985; bugfix on - 0.1.1.11-alpha. The effects of this bug became worse in 0.3.0.3-alpha, - when we began treating missing descriptors from our primary guards - as a reason to delay circuits. diff --git a/changes/bug24025 b/changes/bug24025 deleted file mode 100644 index 1d7841af5..000000000 --- a/changes/bug24025 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (logging, relay): - - Downgrade a warning to a protocol warning in the case the ed25519 key is - not consistent between the descriptor and micro descriptor of a relay. - This can happen for instance if the relay has been flagged - NoEdConsensus. Fixes bug 24025; bugfix on 0.3.2.1-alpha. diff --git a/changes/bug24082 b/changes/bug24082 deleted file mode 100644 index 152323935..000000000 --- a/changes/bug24082 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (testing): - - Fix a spurious fuzzing-only use of an uninitialized value. - Found by Brian Carpenter. Fixes bug 24082; bugfix on 0.3.0.3-alpha. diff --git a/changes/bug24115 b/changes/bug24115 deleted file mode 100644 index 767f13840..000000000 --- a/changes/bug24115 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (manpage, hidden service): - - Mention that the HiddenServiceNumIntroductionPoints option is 0-10 for - v2 service and 0-20 for v3 service. Fixes bug 24115; bugfix on - 0.3.2.1-alpha. diff --git a/changes/bug24150 b/changes/bug24150 deleted file mode 100644 index cfda7c40d..000000000 --- a/changes/bug24150 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (v3 onion services): - - Fix a memory leak when decrypting a badly formatted v3 onion - service descriptor. Fixes bug 24150; bugfix on 0.3.2.1-alpha. - Found by OSS-Fuzz; this is OSS-Fuzz issue 3994. diff --git a/changes/bug24170 b/changes/bug24170 deleted file mode 100644 index d3d734769..000000000 --- a/changes/bug24170 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (path selection): - - Actually log the total bandwidth in compute_weighted_bandwidths(). - Fixes bug 24170; bugfix on 0.2.4.3-alpha. diff --git a/changes/bug24247 b/changes/bug24247 deleted file mode 100644 index 1f4ddcdde..000000000 --- a/changes/bug24247 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (fuzzing): - - Fix a bug in our fuzzing mock replacement for crypto_pk_checksig(), to - correctly handle cases where a caller gives it an RSA key of under 160 - bits. (This is not actually a bug in Tor itself, but wrather in our - fuzzing code.) Fixes bug 24247; bugfix on 0.3.0.3-alpha. - Found by OSS-Fuzz as issue 4177. diff --git a/changes/geoip-2017-11-06 b/changes/geoip-2017-11-06 deleted file mode 100644 index f034be900..000000000 --- a/changes/geoip-2017-11-06 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (geoip): - - Update geoip and geoip6 to the November 6 2017 Maxmind GeoLite2 - Country database. - diff --git a/changes/hsdescv3_fuzz_more b/changes/hsdescv3_fuzz_more deleted file mode 100644 index 25626bb9a..000000000 --- a/changes/hsdescv3_fuzz_more +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (testing): - - Our fuzzing tests now test the encrypted portions of the - v3 hidden service descriptors. Implements more of 21509. diff --git a/changes/ticket21031 b/changes/ticket21031 deleted file mode 100644 index b081fb018..000000000 --- a/changes/ticket21031 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor features (removed deprecations): - - The ClientDNSRejectInternalAddresses flag can once again be set in - non-testing Tor networks, so long as they do not use the default - directory authorities. - This change also removes the deprecation of this - flag in 0.2.9.2-alpha. Closes ticket 21031. - diff --git a/changes/ticket24109 b/changes/ticket24109 deleted file mode 100644 index f66271817..000000000 --- a/changes/ticket24109 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (integration tests): - - Test that IPv6-only clients can use microdescriptors when running - "make test-network-all". Requires chutney master 61c28b9 or later. - Closes ticket 24109.

1 0

[tor/master] Allow bootstrapping networks to have Exit flags
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 4d6b679318c07ee71bd549d0a53defcf86ca82e4 Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Fri Nov 3 23:02:24 2017 +0100 Allow bootstrapping networks to have Exit flags Relevant for non-test networks --- changes/bug24137 | 3 +++ src/or/dirserv.c | 12 +++++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/changes/bug24137 b/changes/bug24137 new file mode 100644 index 000000000..588e68d19 --- /dev/null +++ b/changes/bug24137 @@ -0,0 +1,3 @@ + o Minor bugfixes (Private Networks): + - Give out Exit flags in bootstrapping networks. Fixes bug 24137; + bugfix on 0.2.3.1-alpha. diff --git a/src/or/dirserv.c b/src/or/dirserv.c index ddee92da5..e1a572ec1 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -1519,15 +1519,17 @@ dirserv_compute_performance_thresholds(digestmap_t *omit_as_sybil) node->ri && node->ri->purpose != ROUTER_PURPOSE_BRIDGE) continue; + + routerinfo_t *ri = node->ri; + /* resolve spurious clang shallow analysis null pointer errors */ + tor_assert(ri); + node->is_exit = (!router_exit_policy_rejects_all(ri) && + exit_policy_is_general_exit(ri->exit_policy)); + if (router_counts_toward_thresholds(node, now, omit_as_sybil, require_mbw)) { - routerinfo_t *ri = node->ri; const char *id = node->identity; uint32_t bw_kb; - /* resolve spurious clang shallow analysis null pointer errors */ - tor_assert(ri); - node->is_exit = (!router_exit_policy_rejects_all(ri) && - exit_policy_is_general_exit(ri->exit_policy)); uptimes[n_active] = (uint32_t)real_uptime(ri, now); mtbfs[n_active] = rep_hist_get_stability(id, now); tks [n_active] = rep_hist_get_weighted_time_known(id, now);

1 0

[tor/master] fixup! Allow bootstrapping networks to have Exit flags
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit e24df58245ff7956ecbaf3817006af6d12b807b1 Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Sat Nov 4 04:18:32 2017 +0100 fixup! Allow bootstrapping networks to have Exit flags --- src/or/dirserv.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/or/dirserv.c b/src/or/dirserv.c index e1a572ec1..eb2c75613 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -1521,15 +1521,19 @@ dirserv_compute_performance_thresholds(digestmap_t *omit_as_sybil) continue; routerinfo_t *ri = node->ri; - /* resolve spurious clang shallow analysis null pointer errors */ - tor_assert(ri); - node->is_exit = (!router_exit_policy_rejects_all(ri) && - exit_policy_is_general_exit(ri->exit_policy)); + if (ri) { + node->is_exit = (!router_exit_policy_rejects_all(ri) && + exit_policy_is_general_exit(ri->exit_policy)); + } if (router_counts_toward_thresholds(node, now, omit_as_sybil, require_mbw)) { const char *id = node->identity; uint32_t bw_kb; + + /* resolve spurious clang shallow analysis null pointer errors */ + tor_assert(ri); + uptimes[n_active] = (uint32_t)real_uptime(ri, now); mtbfs[n_active] = rep_hist_get_stability(id, now); tks [n_active] = rep_hist_get_weighted_time_known(id, now);

1 0

[tor/master] Merge remote-tracking branch 'sebastian/bug24137'
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 0b4e59b7c6d28565bdea773a9711571acd81d85d Merge: 45fb624e3 e24df5824 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 13 11:32:35 2017 -0500 Merge remote-tracking branch 'sebastian/bug24137' changes/bug24137 | 3 +++ src/or/dirserv.c | 12 +++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-)

1 0

[torspec/master] dir-spec: Document consensus param HSV3MaxDescriptorSize
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit d6ca7515e759beac5115013b5e849c749181930e Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 13 10:44:41 2017 -0500 dir-spec: Document consensus param HSV3MaxDescriptorSize Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- dir-spec.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/dir-spec.txt b/dir-spec.txt index ded23eb..1c63b21 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -1984,6 +1984,7 @@ should select to try to fetch a descriptor. "hsdir_spread_store" -- Total number of HSDirs per replica a service will upload its descriptor to. + "HSV3MaxDescriptorSize" -- Maximum descriptor size (in bytes). "shared-rand-previous-value" SP NumReveals SP Value NL

1 0

[tor/release-0.3.2] Assign Exit flag only for ports 80 and 443
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 8dff23eb34cf63278f8c78eb965c77fe215b860c Author: Roger Dingledine <arma(a)torproject.org> Date: Sun Sep 24 19:27:07 2017 -0400 Assign Exit flag only for ports 80 and 443 Make the "Exit" flag assignment only depend on whether the exit policy allows connections to ports 80 and 443. Previously relays would get the Exit flag if they allowed connections to one of these ports and also port 6667. Resolves ticket 23637. --- changes/ticket23637 | 5 +++++ src/or/policies.c | 13 ++++--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/changes/ticket23637 b/changes/ticket23637 new file mode 100644 index 000000000..8687ab1a0 --- /dev/null +++ b/changes/ticket23637 @@ -0,0 +1,5 @@ + o Minor features: + - Make the "Exit" flag assignment only depend on whether the exit + policy allows connections to ports 80 and 443. Previously relays + would get the Exit flag if they allowed connections to one of + these ports and also port 6667. Resolves ticket 23637. diff --git a/src/or/policies.c b/src/or/policies.c index 4c24bfbc3..78451db8f 100644 --- a/src/or/policies.c +++ b/src/or/policies.c @@ -2186,21 +2186,16 @@ exit_policy_is_general_exit_helper(smartlist_t *policy, int port) } /** Return true iff <b>ri</b> is "useful as an exit node", meaning - * it allows exit to at least one /8 address space for at least - * two of ports 80, 443, and 6667. */ + * it allows exit to at least one /8 address space for each of ports 80 + * and 443. */ int exit_policy_is_general_exit(smartlist_t *policy) { - static const int ports[] = { 80, 443, 6667 }; - int n_allowed = 0; - int i; if (!policy) /*XXXX disallow NULL policies? */ return 0; - for (i = 0; i < 3; ++i) { - n_allowed += exit_policy_is_general_exit_helper(policy, ports[i]); - } - return n_allowed >= 2; + return (exit_policy_is_general_exit_helper(policy, 80) && + exit_policy_is_general_exit_helper(policy, 443)); } /** Return false if <b>policy</b> might permit access to some addr:port;

1 0

[tor/master] Merge branch 'maint-0.3.2'
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 45fb624e38a3bc000be4fd7fa98378644f3d9756 Merge: e209e8e3c 3300a6e93 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 13 11:20:23 2017 -0500 Merge branch 'maint-0.3.2'

1 0

[tor/maint-0.3.2] Merge remote-tracking branch 'arma/ticket23637' into maint-0.3.2
by nickm＠torproject.org 13 Nov '17

13 Nov '17

commit 3300a6e93aa9e6adfe9c6bb7949b3774e98b94f8 Merge: cf1e6ad2d 8dff23eb3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 13 11:20:20 2017 -0500 Merge remote-tracking branch 'arma/ticket23637' into maint-0.3.2 changes/ticket23637 | 5 +++++ src/or/policies.c | 13 ++++--------- 2 files changed, 9 insertions(+), 9 deletions(-)

1 0