July 2016 - tor-commits - lists.torproject.org

[tor/master] Appease lint-changes script.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit 717eae3b8fc6c90915a1306a093c68a7024feb55 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:57:43 2016 -0400 Appease lint-changes script. --- changes/bug19499 | 2 +- changes/bug19556 | 2 +- changes/bug19557 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/changes/bug19499 b/changes/bug19499 index 5db49bb..59bdb29 100644 --- a/changes/bug19499 +++ b/changes/bug19499 @@ -1,4 +1,4 @@ o Minor features (build): - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre6-dev). + (tested against 1.1.0-pre6-dev). Closes ticket 19499. diff --git a/changes/bug19556 b/changes/bug19556 index f4ac894..31856b3 100644 --- a/changes/bug19556 +++ b/changes/bug19556 @@ -4,4 +4,4 @@ private stats directory, calls check_private_dir(), which also opens and not just stats() the directory. Therefore, we need to also allow open() for the stats dir in our sandboxing setup. - Fixes bug 19556. + Fixes bug 19556; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug19557 b/changes/bug19557 index 9036cdc..55214b0 100644 --- a/changes/bug19557 +++ b/changes/bug19557 @@ -1,4 +1,4 @@ o Major bugfixes (sandboxing): - Our sandboxing code would not allow us to write to stats/hidserv-stats, causing tor to abort while trying to write stats. This was previously - masked by bug 19556. Fixes bug 19557. + masked by bug 19556. Fixes bug 19557; bugfix on 0.2.6.1-alpha.

1 0

[tor/release-0.2.8] start a changelog for 0.2.8.5-rc.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit d3c624bfd02c23f885e51073e449262da2dcb3f4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 13:01:56 2016 -0400 start a changelog for 0.2.8.5-rc. --- ChangeLog | 62 +++++++++++++++++++++++++++++++++++++++++++++++ changes/asciidoc-UTC | 4 --- changes/bug18812 | 4 --- changes/bug18849 | 4 --- changes/bug19454 | 3 --- changes/bug19464 | 6 ----- changes/bug19499 | 4 --- changes/bug19556 | 7 ------ changes/bug19557 | 4 --- changes/ticket19071-19480 | 13 ---------- 10 files changed, 62 insertions(+), 49 deletions(-) diff --git a/ChangeLog b/ChangeLog index a1b0a51..bc03283 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,65 @@ +Changes in version 0.2.8.5-rc - 2016-07-0? + Tor 0.2.8.5-rc is the second release candidate in the Tor 0.2.8 series. + If we find no new bugs or regressions here, the first stable 0.2.8 + release will be identical to it. It has a few small bugfixes against + previous versions. + + o Major bugfixes (heartbeat): + - Fix regression that crashes Tor when disabling heartbeats. Fixes bug + 19454; bugfix on tor-0.2.8.1-alpha. Reported by "kubaku". + + o Minor features (build): + - Tor now again builds with the recent OpenSSL 1.1 development branch + (tested against 1.1.0-pre6-dev). Closes ticket 19499. + + o Fallback directory list: + - Add a comment to the generated list that explains how to comment-out + unsuitable fallbacks in a way that's compatible with the stem fallback + parser. + - Update fallback whitelist and blacklist based on relay operator + emails. Blacklist unsuitable fallbacks. Resolves ticket 19071. + Patch by teor. + - Update hard-coded fallback list to remove unsuitable fallbacks. + Resolves ticket 19071. Patch by teor. + + o Minor bugfixes (build): + - When building manual pages, set the timezone to "UTC", so that the + output is reproducible. Fixes bug 19558; bugfix on 0.2.2.9-alpha. + Patch from intrigeri. + + o Minor bugfixes (fallback directory selection): + - Avoid errors during fallback selection if there are no eligible + fallbacks. Fixes bug 19480; bugfix on ba76910 and 78ec782 in + 0.2.8.3-alpha. Patch by teor. + + o Minor bugfixes (logging): + - Reduce excessive logging when directories can't be found. + Fixes bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. + Patch by teor. + - When a fallback changes its fingerprint from the hard-coded + fingerprint, log a less severe, more explanatory log message. + Fixes bug 18812; bugfix on 0.2.8.1-alpha. Patch by teor. + + o Minor bugfixes (sandboxing): + - When sandboxing is enabled, we could not write any stats to + disk. check_or_create_data_subdir("stats"), which prepares the + private stats directory, calls check_private_dir(), which also + opens and not just stats() the directory. Therefore, we need to + also allow open() for the stats dir in our sandboxing setup. + Fixes bug 19556; bugfix on 0.2.5.1-alpha. + - Our sandboxing code would not allow us to write to stats/hidserv-stats, + causing tor to abort while trying to write stats. This was previously + masked by bug 19556. Fixes bug 19557; bugfix on 0.2.6.1-alpha. + + + o Minor bugfixes (user interface): + - Remove a warning message "Service [scrubbed] not found after + descriptor upload". This message appears when one uses HSPOST control + command to upload a service descriptor. Since there is only a descriptor + and no service, showing this message is pointless and confusing. + Fixes bug 19464; bugfix on 0.2.7.2-alpha. + + Changes in version 0.2.8.4-rc - 2016-06-15 Tor 0.2.8.4-rc is the first release candidate in the Tor 0.2.8 series. If we find no new bugs or regressions here, the first stable 0.2.8 diff --git a/changes/asciidoc-UTC b/changes/asciidoc-UTC deleted file mode 100644 index 21fbfc1..0000000 --- a/changes/asciidoc-UTC +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (build): - - When building manual pages, set the timezone to "UTC", so that the - output is reproducible. Fixes bug 19558; bugfix on 0.2.2.9-alpha. - Patch from intrigeri. diff --git a/changes/bug18812 b/changes/bug18812 deleted file mode 100644 index 793e110..0000000 --- a/changes/bug18812 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (bootstrap): - - When a fallback changes its fingerprint from the hard-coded - fingerprint, log a less severe, more explanatory log message. - Fixes bug 18812; bugfix on 0.2.8.1-alpha. Patch by teor. diff --git a/changes/bug18849 b/changes/bug18849 deleted file mode 100644 index b12a8da..0000000 --- a/changes/bug18849 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfix (logging): - - Reduce excessive logging when directories can't be found. - Fixes bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. - Patch by teor. diff --git a/changes/bug19454 b/changes/bug19454 deleted file mode 100644 index 05650b5..0000000 --- a/changes/bug19454 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (heartbeat): - - Fix regression that crashes Tor when disabling heartbeats. Fixes bug - 19454; bugfix on tor-0.2.8.1-alpha. Reported by "kubaku". diff --git a/changes/bug19464 b/changes/bug19464 deleted file mode 100644 index 22c9e73..0000000 --- a/changes/bug19464 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (user interface): - - Remove a warning message "Service [scrubbed] not found after - descriptor upload". This message appears when one uses HSPOST control - command to upload a service descriptor. Since there is only a descriptor - and no service, showing this message is pointless and confusing. - Fixes bug 19464; bugfix on 0.2.7.2-alpha. diff --git a/changes/bug19499 b/changes/bug19499 deleted file mode 100644 index 59bdb29..0000000 --- a/changes/bug19499 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (build): - - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre6-dev). Closes ticket 19499. - diff --git a/changes/bug19556 b/changes/bug19556 deleted file mode 100644 index 31856b3..0000000 --- a/changes/bug19556 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (sandboxing): - - When sandboxing is enabled, we could not write any stats to - disk. check_or_create_data_subdir("stats"), which prepares the - private stats directory, calls check_private_dir(), which also - opens and not just stats() the directory. Therefore, we need to - also allow open() for the stats dir in our sandboxing setup. - Fixes bug 19556; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug19557 b/changes/bug19557 deleted file mode 100644 index 55214b0..0000000 --- a/changes/bug19557 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (sandboxing): - - Our sandboxing code would not allow us to write to stats/hidserv-stats, - causing tor to abort while trying to write stats. This was previously - masked by bug 19556. Fixes bug 19557; bugfix on 0.2.6.1-alpha. diff --git a/changes/ticket19071-19480 b/changes/ticket19071-19480 deleted file mode 100644 index ab5c72a..0000000 --- a/changes/ticket19071-19480 +++ /dev/null @@ -1,13 +0,0 @@ - o Minor bugfixes (fallback directory selection): - - Avoid errors during fallback selection if there are no eligible - fallbacks. Fixes bug 19480; bugfix on ba76910 and 78ec782 in - 0.2.8.3-alpha. Patch by teor. - o Minor features (fallback directory list): - - Update hard-coded fallback list to remove unsuitable fallbacks. - Resolves ticket 19071. Patch by teor. - - Add a comment to the generated list that explains how to comment-out - unsuitable fallbacks in a way that's compatible with the stem fallback - parser. - - Update fallback whitelist and blacklist based on relay operator - emails. Blacklist unsuitable fallbacks. Resolves ticket 19071. - Patch by teor.

1 0

[tor/maint-0.2.8] Appease lint-changes script.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit 717eae3b8fc6c90915a1306a093c68a7024feb55 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:57:43 2016 -0400 Appease lint-changes script. --- changes/bug19499 | 2 +- changes/bug19556 | 2 +- changes/bug19557 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/changes/bug19499 b/changes/bug19499 index 5db49bb..59bdb29 100644 --- a/changes/bug19499 +++ b/changes/bug19499 @@ -1,4 +1,4 @@ o Minor features (build): - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre6-dev). + (tested against 1.1.0-pre6-dev). Closes ticket 19499. diff --git a/changes/bug19556 b/changes/bug19556 index f4ac894..31856b3 100644 --- a/changes/bug19556 +++ b/changes/bug19556 @@ -4,4 +4,4 @@ private stats directory, calls check_private_dir(), which also opens and not just stats() the directory. Therefore, we need to also allow open() for the stats dir in our sandboxing setup. - Fixes bug 19556. + Fixes bug 19556; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug19557 b/changes/bug19557 index 9036cdc..55214b0 100644 --- a/changes/bug19557 +++ b/changes/bug19557 @@ -1,4 +1,4 @@ o Major bugfixes (sandboxing): - Our sandboxing code would not allow us to write to stats/hidserv-stats, causing tor to abort while trying to write stats. This was previously - masked by bug 19556. Fixes bug 19557. + masked by bug 19556. Fixes bug 19557; bugfix on 0.2.6.1-alpha.

1 0

[tor/master] Merge branch 'maint-0.2.8'
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit 6ea9d3fd42d6fa38f1a43fb0c5016c03d1eabd8b Merge: 5c97b42 717eae3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:58:28 2016 -0400 Merge branch 'maint-0.2.8' changes/bug19499 | 2 +- changes/bug19556 | 2 +- changes/bug19557 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

1 0

[tor/release-0.2.8] Reflow changelog.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit c174f060fa252c816461552bb0de2bf758dcd61f Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 13:02:47 2016 -0400 Reflow changelog. --- ChangeLog | 70 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/ChangeLog b/ChangeLog index bc03283..06577e5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,26 +1,16 @@ Changes in version 0.2.8.5-rc - 2016-07-0? - Tor 0.2.8.5-rc is the second release candidate in the Tor 0.2.8 series. - If we find no new bugs or regressions here, the first stable 0.2.8 - release will be identical to it. It has a few small bugfixes against - previous versions. + Tor 0.2.8.5-rc is the second release candidate in the Tor 0.2.8 + series. If we find no new bugs or regressions here, the first stable + 0.2.8 release will be identical to it. It has a few small bugfixes + against previous versions. o Major bugfixes (heartbeat): - - Fix regression that crashes Tor when disabling heartbeats. Fixes bug - 19454; bugfix on tor-0.2.8.1-alpha. Reported by "kubaku". + - Fix regression that crashes Tor when disabling heartbeats. Fixes + bug 19454; bugfix on tor-0.2.8.1-alpha. Reported by "kubaku". o Minor features (build): - - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre6-dev). Closes ticket 19499. - - o Fallback directory list: - - Add a comment to the generated list that explains how to comment-out - unsuitable fallbacks in a way that's compatible with the stem fallback - parser. - - Update fallback whitelist and blacklist based on relay operator - emails. Blacklist unsuitable fallbacks. Resolves ticket 19071. - Patch by teor. - - Update hard-coded fallback list to remove unsuitable fallbacks. - Resolves ticket 19071. Patch by teor. + - Tor now again builds with the recent OpenSSL 1.1 development + branch (tested against 1.1.0-pre6-dev). Closes ticket 19499. o Minor bugfixes (build): - When building manual pages, set the timezone to "UTC", so that the @@ -33,31 +23,41 @@ Changes in version 0.2.8.5-rc - 2016-07-0? 0.2.8.3-alpha. Patch by teor. o Minor bugfixes (logging): - - Reduce excessive logging when directories can't be found. - Fixes bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. - Patch by teor. + - Reduce excessive logging when directories can't be found. Fixes + bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. Patch + by teor. - When a fallback changes its fingerprint from the hard-coded fingerprint, log a less severe, more explanatory log message. Fixes bug 18812; bugfix on 0.2.8.1-alpha. Patch by teor. o Minor bugfixes (sandboxing): - - When sandboxing is enabled, we could not write any stats to - disk. check_or_create_data_subdir("stats"), which prepares the - private stats directory, calls check_private_dir(), which also - opens and not just stats() the directory. Therefore, we need to - also allow open() for the stats dir in our sandboxing setup. - Fixes bug 19556; bugfix on 0.2.5.1-alpha. - - Our sandboxing code would not allow us to write to stats/hidserv-stats, - causing tor to abort while trying to write stats. This was previously - masked by bug 19556. Fixes bug 19557; bugfix on 0.2.6.1-alpha. - + - When sandboxing is enabled, we could not write any stats to disk. + check_or_create_data_subdir("stats"), which prepares the private + stats directory, calls check_private_dir(), which also opens and + not just stats() the directory. Therefore, we need to also allow + open() for the stats dir in our sandboxing setup. Fixes bug 19556; + bugfix on 0.2.5.1-alpha. + - Our sandboxing code would not allow us to write to stats/hidserv- + stats, causing tor to abort while trying to write stats. This was + previously masked by bug 19556. Fixes bug 19557; bugfix + on 0.2.6.1-alpha. o Minor bugfixes (user interface): - Remove a warning message "Service [scrubbed] not found after - descriptor upload". This message appears when one uses HSPOST control - command to upload a service descriptor. Since there is only a descriptor - and no service, showing this message is pointless and confusing. - Fixes bug 19464; bugfix on 0.2.7.2-alpha. + descriptor upload". This message appears when one uses HSPOST + control command to upload a service descriptor. Since there is + only a descriptor and no service, showing this message is + pointless and confusing. Fixes bug 19464; bugfix on 0.2.7.2-alpha. + + o Fallback directory list: + - Add a comment to the generated list that explains how to comment- + out unsuitable fallbacks in a way that's compatible with the stem + fallback parser. + - Update fallback whitelist and blacklist based on relay operator + emails. Blacklist unsuitable fallbacks. Resolves ticket 19071. + Patch by teor. + - Update hard-coded fallback list to remove unsuitable fallbacks. + Resolves ticket 19071. Patch by teor. Changes in version 0.2.8.4-rc - 2016-06-15

1 0

[tor/release-0.2.8] Repair unit test that assumed we have 9 dirauths.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit e99cc8740f793ba3796408c6f23bf35f12572193 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:52:19 2016 -0400 Repair unit test that assumed we have 9 dirauths. --- src/test/test_config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/test_config.c b/src/test/test_config.c index 6d9b491..90ea4da 100644 --- a/src/test/test_config.c +++ b/src/test/test_config.c @@ -1630,10 +1630,10 @@ test_config_adding_default_trusted_dir_servers(void *arg) tt_assert(get_n_authorities(BRIDGE_DIRINFO) == 1); tt_assert(smartlist_len(router_get_fallback_dir_servers()) == 1); - /* Assume we have nine V3 authorities */ + /* Assume we have eight V3 authorities */ add_default_trusted_dir_authorities(V3_DIRINFO); - tt_assert(get_n_authorities(V3_DIRINFO) == 9); - tt_assert(smartlist_len(router_get_fallback_dir_servers()) == 10); + tt_int_op(get_n_authorities(V3_DIRINFO), OP_EQ, 8); + tt_int_op(smartlist_len(router_get_fallback_dir_servers()), OP_EQ, 9); done: clear_dir_servers();

1 0

[tor/release-0.2.8] Merge branch 'maint-0.2.8' into release-0.2.8
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit 6220cd13c517f18c8a1cb1c5bc350f3e2a7eafac Merge: e512e6c e99cc87 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:52:24 2016 -0400 Merge branch 'maint-0.2.8' into release-0.2.8 src/test/test_config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

1 0

[tor/master] Repair unit test that assumed we have 9 dirauths.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit e99cc8740f793ba3796408c6f23bf35f12572193 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:52:19 2016 -0400 Repair unit test that assumed we have 9 dirauths. --- src/test/test_config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/test_config.c b/src/test/test_config.c index 6d9b491..90ea4da 100644 --- a/src/test/test_config.c +++ b/src/test/test_config.c @@ -1630,10 +1630,10 @@ test_config_adding_default_trusted_dir_servers(void *arg) tt_assert(get_n_authorities(BRIDGE_DIRINFO) == 1); tt_assert(smartlist_len(router_get_fallback_dir_servers()) == 1); - /* Assume we have nine V3 authorities */ + /* Assume we have eight V3 authorities */ add_default_trusted_dir_authorities(V3_DIRINFO); - tt_assert(get_n_authorities(V3_DIRINFO) == 9); - tt_assert(smartlist_len(router_get_fallback_dir_servers()) == 10); + tt_int_op(get_n_authorities(V3_DIRINFO), OP_EQ, 8); + tt_int_op(smartlist_len(router_get_fallback_dir_servers()), OP_EQ, 9); done: clear_dir_servers();

1 0

[tor/master] Merge branch 'maint-0.2.8'
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit 5c97b42cac83edfbe979f6a5399ed43c2cdad153 Merge: 8cae4ab e99cc87 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:52:30 2016 -0400 Merge branch 'maint-0.2.8' src/test/test_config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

1 0

[tor/maint-0.2.8] Repair unit test that assumed we have 9 dirauths.
by nickm＠torproject.org 05 Jul '16

05 Jul '16

commit e99cc8740f793ba3796408c6f23bf35f12572193 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 12:52:19 2016 -0400 Repair unit test that assumed we have 9 dirauths. --- src/test/test_config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/test_config.c b/src/test/test_config.c index 6d9b491..90ea4da 100644 --- a/src/test/test_config.c +++ b/src/test/test_config.c @@ -1630,10 +1630,10 @@ test_config_adding_default_trusted_dir_servers(void *arg) tt_assert(get_n_authorities(BRIDGE_DIRINFO) == 1); tt_assert(smartlist_len(router_get_fallback_dir_servers()) == 1); - /* Assume we have nine V3 authorities */ + /* Assume we have eight V3 authorities */ add_default_trusted_dir_authorities(V3_DIRINFO); - tt_assert(get_n_authorities(V3_DIRINFO) == 9); - tt_assert(smartlist_len(router_get_fallback_dir_servers()) == 10); + tt_int_op(get_n_authorities(V3_DIRINFO), OP_EQ, 8); + tt_int_op(smartlist_len(router_get_fallback_dir_servers()), OP_EQ, 9); done: clear_dir_servers();

1 0