May 2016 - tor-commits - lists.torproject.org

[tor/maint-0.2.8] Comment-only change to clarify routerstatus_t IPv4 byte order
by nickm＠torproject.org 05 May '16

05 May '16

commit 225448ad34a75b6eea9ab17e306e67578ce86760 Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Fri Apr 29 11:03:59 2016 +1000 Comment-only change to clarify routerstatus_t IPv4 byte order --- src/or/or.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/or.h b/src/or/or.h index 592f295..6694bb4 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -2215,7 +2215,7 @@ typedef struct routerstatus_t { /** Digest of the router's most recent descriptor or microdescriptor. * If it's a descriptor, we only use the first DIGEST_LEN bytes. */ char descriptor_digest[DIGEST256_LEN]; - uint32_t addr; /**< IPv4 address for this router. */ + uint32_t addr; /**< IPv4 address for this router, in host order. */ uint16_t or_port; /**< OR port for this router. */ uint16_t dir_port; /**< Directory port for this router. */ tor_addr_t ipv6_addr; /**< IPv6 address for this router. */

1 0

[tor/maint-0.2.8] Refactor router_pick_directory_server_impl to use node functions
by nickm＠torproject.org 05 May '16

05 May '16

commit 03fc4cf04caf240fa4e285c3b483c60587456e9b Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Sat Apr 30 11:00:50 2016 +1000 Refactor router_pick_directory_server_impl to use node functions No behavioural change This makes the use of the node explicit in the function, rather than hiding the node lookup in fascist_firewall_allows_rs. --- src/or/routerlist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 13739a7..1c275a6 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -1740,13 +1740,13 @@ router_pick_directory_server_impl(dirinfo_type_t type, int flags, * we try routers that only have one address both times.) */ if (!fascistfirewall || skip_or_fw || - fascist_firewall_allows_rs(status, FIREWALL_OR_CONNECTION, - try_ip_pref)) + fascist_firewall_allows_node(node, FIREWALL_OR_CONNECTION, + try_ip_pref)) smartlist_add(is_trusted ? trusted_tunnel : is_overloaded ? overloaded_tunnel : tunnel, (void*)node); else if (!must_have_or && (skip_dir_fw || - fascist_firewall_allows_rs(status, FIREWALL_DIR_CONNECTION, - try_ip_pref))) + fascist_firewall_allows_node(node, FIREWALL_DIR_CONNECTION, + try_ip_pref))) smartlist_add(is_trusted ? trusted_direct : is_overloaded ? overloaded_direct : direct, (void*)node); } SMARTLIST_FOREACH_END(node);

1 0

[tor/master] Make directory node selection more reliable
by nickm＠torproject.org 05 May '16

05 May '16

commit 2e5b35db81e867e782086e3d714fcc7882c9c171 Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Thu May 5 11:51:37 2016 +1000 Make directory node selection more reliable Delete an unnecessary check for non-preferred IP versions. Allows clients which can't reach any directories of their preferred IP address version to get directory documents. Patch on #17840 in 0.2.8.1-alpha. --- changes/bug18929 | 5 +++++ src/or/routerlist.c | 12 +++--------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/changes/bug18929 b/changes/bug18929 new file mode 100644 index 0000000..f79baca --- /dev/null +++ b/changes/bug18929 @@ -0,0 +1,5 @@ + o Minor bugfixes (IPv6): + - Make directory node selection more reliable, mainly for + IPv6-only clients and clients with few reachable addresses. + Resolves #18929, bugfix on #17840 in 0.2.8.1-alpha. + Patch by "teor". diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 3c9023e..2167ae2 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -1597,11 +1597,10 @@ router_picked_poor_directory_log(const routerstatus_t *rs) STMT_BEGIN \ if (result == NULL && try_ip_pref && options->ClientUseIPv4 \ && fascist_firewall_use_ipv6(options) && !server_mode(options) \ - && n_not_preferred && !n_busy) { \ + && !n_busy) { \ n_excluded = 0; \ n_busy = 0; \ try_ip_pref = 0; \ - n_not_preferred = 0; \ goto retry_label; \ } \ STMT_END \ @@ -1620,7 +1619,6 @@ router_picked_poor_directory_log(const routerstatus_t *rs) n_excluded = 0; \ n_busy = 0; \ try_ip_pref = 1; \ - n_not_preferred = 0; \ goto retry_label; \ } \ STMT_END @@ -1673,7 +1671,7 @@ router_pick_directory_server_impl(dirinfo_type_t type, int flags, const int no_microdesc_fetching = (flags & PDS_NO_EXISTING_MICRODESC_FETCH); const int for_guard = (flags & PDS_FOR_GUARD); int try_excluding = 1, n_excluded = 0, n_busy = 0; - int try_ip_pref = 1, n_not_preferred = 0; + int try_ip_pref = 1; if (!consensus) return NULL; @@ -1750,8 +1748,6 @@ router_pick_directory_server_impl(dirinfo_type_t type, int flags, try_ip_pref)) smartlist_add(is_trusted ? trusted_direct : is_overloaded ? overloaded_direct : direct, (void*)node); - else if (!tor_addr_is_null(&status->ipv6_addr)) - ++n_not_preferred; } SMARTLIST_FOREACH_END(node); if (smartlist_len(tunnel)) { @@ -1839,7 +1835,7 @@ router_pick_trusteddirserver_impl(const smartlist_t *sourcelist, smartlist_t *pick_from; int n_busy = 0; int try_excluding = 1, n_excluded = 0; - int try_ip_pref = 1, n_not_preferred = 0; + int try_ip_pref = 1; if (!sourcelist) return NULL; @@ -1896,8 +1892,6 @@ router_pick_trusteddirserver_impl(const smartlist_t *sourcelist, fascist_firewall_allows_dir_server(d, FIREWALL_DIR_CONNECTION, try_ip_pref)) smartlist_add(is_overloaded ? overloaded_direct : direct, (void*)d); - else if (!tor_addr_is_null(&d->ipv6_addr)) - ++n_not_preferred; } SMARTLIST_FOREACH_END(d);

1 0

[tor/master] Make clients always use begindir for directory requests
by nickm＠torproject.org 05 May '16

05 May '16

commit 833b5f71a72394c02ef633ba0f78d7011fef6181 Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Thu Apr 28 15:37:59 2016 +1000 Make clients always use begindir for directory requests This improves client anonymity and avoids directory header tampering. The extra load on the authorities should be offset by the fallback directories feature. This also simplifies the fixes to #18809. --- changes/feature18483 | 4 ++++ src/or/directory.c | 61 +++++++++++++++++++++++++++++++++++++++++++++------- src/or/directory.h | 6 ++++-- 3 files changed, 61 insertions(+), 10 deletions(-) diff --git a/changes/feature18483 b/changes/feature18483 new file mode 100644 index 0000000..b3c42e6 --- /dev/null +++ b/changes/feature18483 @@ -0,0 +1,4 @@ + o Minor features (clients): + - Make clients, onion services, and bridge relays always + use an encrypted begindir connection for directory requests. + Resolves #18483. Patch by "teor". diff --git a/src/or/directory.c b/src/or/directory.c index ca3b3e3..a03283e 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -964,6 +964,16 @@ connection_dir_download_cert_failed(dir_connection_t *conn, int status) update_certificate_downloads(time(NULL)); } +/* Should this tor instance only use begindir for all its directory requests? + */ +int +directory_must_use_begindir(const or_options_t *options) +{ + /* Clients, onion services, and bridges must use begindir, + * relays and authorities do not have to */ + return !public_server_mode(options); +} + /** Evaluate the situation and decide if we should use an encrypted * "begindir-style" connection for this directory request. * 1) If or_port is 0, or it's a direct conn and or_port is firewalled @@ -971,23 +981,48 @@ connection_dir_download_cert_failed(dir_connection_t *conn, int status) * 2) If we prefer to avoid begindir conns, and we're not fetching or * publishing a bridge relay descriptor, no. * 3) Else yes. + * If returning 0, return in *reason why we can't use begindir. + * reason must not be NULL. */ static int directory_command_should_use_begindir(const or_options_t *options, const tor_addr_t *addr, int or_port, uint8_t router_purpose, - dir_indirection_t indirection) + dir_indirection_t indirection, + const char **reason) { (void) router_purpose; - if (!or_port) + tor_assert(reason); + *reason = NULL; + + /* Reasons why we can't possibly use begindir */ + if (!or_port) { + *reason = "directory with unknown ORPort"; return 0; /* We don't know an ORPort -- no chance. */ - if (indirection == DIRIND_DIRECT_CONN || indirection == DIRIND_ANON_DIRPORT) + } + if (indirection == DIRIND_DIRECT_CONN || + indirection == DIRIND_ANON_DIRPORT) { + *reason = "DirPort connection"; return 0; - if (indirection == DIRIND_ONEHOP) + } + if (indirection == DIRIND_ONEHOP) { + /* We're firewalled and want a direct OR connection */ if (!fascist_firewall_allows_address_addr(addr, or_port, - FIREWALL_OR_CONNECTION, 0, 0) || - directory_fetches_from_authorities(options)) - return 0; /* We're firewalled or are acting like a relay -- also no. */ + FIREWALL_OR_CONNECTION, 0, 0)) { + *reason = "ORPort not reachable"; + return 0; + } + } + /* Reasons why we want to avoid using begindir */ + if (indirection == DIRIND_ONEHOP) { + if (!directory_must_use_begindir(options)) { + *reason = "in relay mode"; + return 0; + } + } + /* DIRIND_ONEHOP on a client, or DIRIND_ANONYMOUS + */ + *reason = "(using begindir)"; return 1; } @@ -1070,11 +1105,13 @@ directory_initiate_command_rend(const tor_addr_port_t *or_addr_port, dir_connection_t *conn; const or_options_t *options = get_options(); int socket_error = 0; + const char *begindir_reason = NULL; /* Should the connection be to a relay's OR port (and inside that we will * send our directory request)? */ const int use_begindir = directory_command_should_use_begindir(options, &or_addr_port->addr, or_addr_port->port, - router_purpose, indirection); + router_purpose, indirection, + &begindir_reason); /* Will the connection go via a three-hop Tor circuit? Note that this * is separate from whether it will use_begindir. */ const int anonymized_connection = dirind_is_anon(indirection); @@ -1100,6 +1137,14 @@ directory_initiate_command_rend(const tor_addr_port_t *or_addr_port, (void)is_sensitive_dir_purpose; #endif + /* use encrypted begindir connections for everything except relays + * this provides better protection for directory fetches */ + if (!use_begindir && directory_must_use_begindir(options)) { + log_warn(LD_BUG, "Client could not use begindir connection: %s", + begindir_reason ? begindir_reason : "(NULL)"); + return; + } + /* ensure that we don't make direct connections when a SOCKS server is * configured. */ if (!anonymized_connection && !use_begindir && !options->HTTPProxy && diff --git a/src/or/directory.h b/src/or/directory.h index 03c04c1..c4edbb5 100644 --- a/src/or/directory.h +++ b/src/or/directory.h @@ -28,8 +28,8 @@ void directory_get_from_all_authorities(uint8_t dir_purpose, /** Enumeration of ways to connect to a directory server */ typedef enum { - /** Default: connect over a one-hop Tor circuit but fall back to direct - * connection */ + /** Default: connect over a one-hop Tor circuit. Relays fall back to direct + * DirPort connections, clients, onion services, and bridges do not */ DIRIND_ONEHOP=0, /** Connect over a multi-hop anonymizing Tor circuit */ DIRIND_ANONYMOUS=1, @@ -39,6 +39,8 @@ typedef enum { DIRIND_ANON_DIRPORT, } dir_indirection_t; +int directory_must_use_begindir(const or_options_t *options); + MOCK_DECL(void, directory_initiate_command_routerstatus, (const routerstatus_t *status, uint8_t dir_purpose,

1 0

[translation/tor-launcher-properties_completed] Update translations for tor-launcher-properties_completed
by translation＠torproject.org 05 May '16

05 May '16

commit 57d3bb6aed1a744a2b90be8cbb24408459009379 Author: Translation commit bot <translation(a)torproject.org> Date: Thu May 5 12:15:39 2016 +0000 Update translations for tor-launcher-properties_completed --- sv/torlauncher.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/sv/torlauncher.properties b/sv/torlauncher.properties index cb7b8f5..3345deb 100644 --- a/sv/torlauncher.properties +++ b/sv/torlauncher.properties @@ -36,6 +36,7 @@ torlauncher.quit_win=Stäng torlauncher.done=Klar torlauncher.forAssistance=För assistans, kontakta %S +torlauncher.forAssistance2=För hjälp, besök %S torlauncher.copiedNLogMessages=Kopieringen är färdig. %S meddelanden från Tor-loggen som du kan klistra in i en textredigerare eller ett e-postmeddelande.

1 0

[translation/tor-launcher-properties] Update translations for tor-launcher-properties
by translation＠torproject.org 05 May '16

05 May '16

commit 708921ad026b603b067c826dcd0dad5a08c88c01 Author: Translation commit bot <translation(a)torproject.org> Date: Thu May 5 12:15:35 2016 +0000 Update translations for tor-launcher-properties --- sv/torlauncher.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sv/torlauncher.properties b/sv/torlauncher.properties index a49b83f..3345deb 100644 --- a/sv/torlauncher.properties +++ b/sv/torlauncher.properties @@ -36,7 +36,7 @@ torlauncher.quit_win=Stäng torlauncher.done=Klar torlauncher.forAssistance=För assistans, kontakta %S -torlauncher.forAssistance2=For assistance, visit %S +torlauncher.forAssistance2=För hjälp, besök %S torlauncher.copiedNLogMessages=Kopieringen är färdig. %S meddelanden från Tor-loggen som du kan klistra in i en textredigerare eller ett e-postmeddelande.

1 0

[translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties
by translation＠torproject.org 05 May '16

05 May '16

commit d6170785c4dfc4ac3a72129c96fa1c6e62167e48 Author: Translation commit bot <translation(a)torproject.org> Date: Thu May 5 09:45:53 2016 +0000 Update translations for torbutton-torbuttonproperties --- lo/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lo/torbutton.properties b/lo/torbutton.properties index 48b154b..1a443ff 100644 --- a/lo/torbutton.properties +++ b/lo/torbutton.properties @@ -76,4 +76,4 @@ profileProblemTitle=ລາຍລະອຽດບັນຫາ %S profileReadOnly=ທ່ານບໍ່ສາມາດແລ່ນ %S ຈາກລະບົບຟາຍລ໌ອ່ານໄດ້ຢ່າງດຽວ. ກະລຸນາ ກ່າຍເອົາ %S ໄປໃສ່ບ່ອນອື່ນກ່ອນ ກ່ອນຈະພະຍາຍາມໃຊ້ມັນ. profileReadOnlyMac=ທ່ານບໍ່ສາມາດແລ່ນ %S ຈາກລະບົບຟາຍລ໌ອ່ານໄດ້ຢ່າງດຽວ. ກະລຸນາ ກ່າຍເອົາ %S ໄປໃສ່ ໜ້າຈໍຂອງທ່ານກ່ອນ ຫຼື ໃສ່ຕູ້ແອັບພຼີເຄຊັນ ກ່ອນຈະພະຍາຍາມໃຊ້ມັນ. profileAccessDenied=%S ບໍ່ມີອະນຸຍາດໃຫ້ເຂົ້າເຖິງລາຍລະອຽດນີ້ໄດ້. ກະລຸນາ ປັບ ລະດັບອະນຸຍາດ ຟາຍລ໌ ລະບົບກ່ອນ ແລ້ວຈຶ່ງ ລອງໃໝ່ອີກ. -profileMigrationFailed=Migration of your existing %S profile failed.\nNew settings will be used. +profileMigrationFailed=ການເຄື່ອນຍ້າຍລາຍລະອຽດ %S ຂອງ ທ່ານ ທີ່ມີຢູ່ ຖືກລົ້ມເຫຼວ.\nການຄັ້ງຄ່າໃໝ່ຈະຖຶກນໍາໃຊ້ແທນ.

1 0

[user-manual/master] Clarify headings
by colin＠torproject.org 04 May '16

04 May '16

commit 9170f3f45d2e0c1d862be5902537c27bb86c5048 Author: Colin Childs <colin(a)torproject.org> Date: Wed May 4 18:38:31 2016 -0500 Clarify headings --- C/plugins.page | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C/plugins.page b/C/plugins.page index 889b0b3..8ea8222 100644 --- a/C/plugins.page +++ b/C/plugins.page @@ -3,11 +3,11 @@ id="plugins"> <info> - <desc>How Tor Browser handles browser plugins and add-ons</desc> + <desc>How Tor Browser handles add-ons, plugins and JavasScript</desc> <link type="guide" xref="index" group="#last" /> </info> -<title>Flash, JavaScript, and other add-ons</title> +<title>Plugins, add-ons and JavasSript</title> <section id="flash"> <title>Flash Player</title>

1 0

[user-manual/master] Clarify that YouTube should work in the Tor Browser, and does not
by colin＠torproject.org 04 May '16

04 May '16

commit 5864a6c4f2464c77807f1cb5c5e976d22c376ebb Author: Colin Childs <colin(a)torproject.org> Date: Wed May 4 18:21:31 2016 -0500 Clarify that YouTube should work in the Tor Browser, and does not require flash --- C/plugins.page | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/C/plugins.page b/C/plugins.page index 94e9ed3..889b0b3 100644 --- a/C/plugins.page +++ b/C/plugins.page @@ -12,17 +12,18 @@ <section id="flash"> <title>Flash Player</title> <p> - Video websites, such as YouTube and Vimeo, make use of the - Flash Player plugin to display video content. Unfortunately, this - software operates independently of Tor Browser and cannot easily be - made to obey Tor Browser’s proxy settings. It can therefore reveal your - real location and IP address to the website operators, or to an outside - observer. For this reason, Flash is disabled by default in Tor Browser, - and enabling it is not recommended. + Video websites, such as Vimeo make use of the Flash Player plugin + to display video content. Unfortunately, this software operates + independently of Tor Browser and cannot easily be made to obey Tor + Browser’s proxy settings. It can therefore reveal your real location + and IP address to the website operators, or to an outside observer. + For this reason, Flash is disabled by default in Tor Browser, and + enabling it is not recommended. </p> <p> - Some video websites offer alternative video delivery methods that do - not use Flash. These methods may be compatible with Tor Browser. + Some video websites (such as YouTube) offer alternative video delivery + methods that do not use Flash. These methods may be compatible with + Tor Browser. </p> </section> @@ -34,7 +35,7 @@ interactive elements such as video, animation, audio, and status timelines. Unfortunately, JavaScript can also enable attacks on the security of the browser, which might lead to deanonymization. </p> - + <p> Tor Browser includes an add-on called NoScript, accessed through the “S” icon at the top-left of the window, which allows you to control the @@ -59,7 +60,7 @@ setting is to allow all websites to run scripts. Tor Browser is based on Firefox, and any browser add-ons or themes that are compatible with Firefox can also be installed in Tor Browser. </p> - + <p> However, the only add-ons that have been tested for use with Tor Browser are those included by default. Installing any other browser

1 0

[translation/tor-launcher-properties_completed] Update translations for tor-launcher-properties_completed
by translation＠torproject.org 04 May '16

04 May '16

commit fed967da87af987dc2d763fc2824e38d90c29017 Author: Translation commit bot <translation(a)torproject.org> Date: Wed May 4 23:15:39 2016 +0000 Update translations for tor-launcher-properties_completed --- hu/torlauncher.properties | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hu/torlauncher.properties b/hu/torlauncher.properties index 82ef206..61b2012 100644 --- a/hu/torlauncher.properties +++ b/hu/torlauncher.properties @@ -3,7 +3,7 @@ torlauncher.error_title=Tor Indító -torlauncher.tor_exited=A Tor váratlanul kilépet. Ez bekövetkezhet a Tor-ban található hibából, egy a rendszeren található másik programból, vagy hibás hardverből. Amíg nem indítja újra a tor-t addig a Tor Browser nem ér el semmilyen oldalt. Ha a hiba folyamatosan fennáll, kérjük küldje le a Tor Log-ot a támogatási csoportnak. +torlauncher.tor_exited=A Tor váratlanul kilépett. Ez bekövetkezhet a Tor-ban található hibából, egy a rendszeren található másik programból, vagy hibás hardverből. Amíg nem indítja újra a tor-t addig a Tor Browser nem ér el semmilyen oldalt. Ha a hiba folyamatosan fennáll, kérjük küldje le a Tor Log-ot a támogatási csoportnak. torlauncher.tor_exited2=A Tor újraindítása nem fogja bezárni a böngésző füleket. torlauncher.tor_controlconn_failed=Nem lehetséges csatlakozni a Tor vezérlő portjára torlauncher.tor_failed_to_start=Nem sikerült elindulnia a Tor-nak. @@ -36,8 +36,9 @@ torlauncher.quit_win=Kilépés torlauncher.done=Kész torlauncher.forAssistance=Segítségér kérjük írjon ide: %S +torlauncher.forAssistance2=Segítségért látogassa meg: %S -torlauncher.copiedNLogMessages=Másolás kész. %S Tor log üzenet vár arra, hogy beillesszék egy szövegszerkesztővbe vagy egy emailbe. +torlauncher.copiedNLogMessages=Másolás kész. %S Tor naplóüzenet áll készen a beillesztésre egy szövegszerkesztőbe vagy egy email üzenetbe. torlauncher.bootstrapStatus.conn_dir=Csatlakozás egy Elosztó címtárhoz torlauncher.bootstrapStatus.handshake_dir=Titkosított címtárkapcsolat létrehozása

1 0