November 2016 - tor-commits - lists.torproject.org

[tor/master] Fix warnings from lintChanges.py
by nickm＠torproject.org 06 Nov '16

06 Nov '16

commit add164aa41724ba6d66c961f37bd798e268062d2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Nov 6 16:39:46 2016 -0500 Fix warnings from lintChanges.py --- changes/bug19969 | 4 ++-- changes/bug20472 | 3 ++- changes/bug20551 | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/changes/bug19969 b/changes/bug19969 index 0bdd880..c760c6d 100644 --- a/changes/bug19969 +++ b/changes/bug19969 @@ -1,9 +1,9 @@ - o Major bugfixes (client performance); + o Major bugfixes (client performance): - Clients now respond to new application stream requests when they arrive, rather than waiting up to one second before starting to handle them. Fixes part of bug 19969; bugfix on 0.2.8.1-alpha. - o Major bugfixes (clients on flaky network connections); + o Major bugfixes (clients on flaky network connections): - When Tor leaves standby because of a new application request, open circuits as needed to serve that request. Previously, we would potentially wait a very long time. Fixes part of bug 19969; bugfix diff --git a/changes/bug20472 b/changes/bug20472 index b035037..4d90c39 100644 --- a/changes/bug20472 +++ b/changes/bug20472 @@ -1,4 +1,5 @@ o Minor bugfixes (circuits): - Remove a BUG warning in circuit_pick_extend_handshake. Instead, assume all nodes support EXTEND2. Use ntor whenever a key is available. - Bugfix on commit 10aa913 from 19163 in 0.2.9.3-alpha. Fixes bug 20472. + Fixes bug 20472; bugfix on 0.2.9.3-alpha. + diff --git a/changes/bug20551 b/changes/bug20551 index 1e0746b..b7ec4ca 100644 --- a/changes/bug20551 +++ b/changes/bug20551 @@ -1,3 +1,3 @@ - o Minor bugfixes (compilation); + o Minor bugfixes (compilation): - Fix implicit conversion warnings under OpenSSL 1.1. Fixes bug 20551; bugfix on 0.2.1.1-alpha.

1 0

[tor/release-0.2.9] Fix warnings from lintChanges.py
by nickm＠torproject.org 06 Nov '16

06 Nov '16

commit add164aa41724ba6d66c961f37bd798e268062d2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Nov 6 16:39:46 2016 -0500 Fix warnings from lintChanges.py --- changes/bug19969 | 4 ++-- changes/bug20472 | 3 ++- changes/bug20551 | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/changes/bug19969 b/changes/bug19969 index 0bdd880..c760c6d 100644 --- a/changes/bug19969 +++ b/changes/bug19969 @@ -1,9 +1,9 @@ - o Major bugfixes (client performance); + o Major bugfixes (client performance): - Clients now respond to new application stream requests when they arrive, rather than waiting up to one second before starting to handle them. Fixes part of bug 19969; bugfix on 0.2.8.1-alpha. - o Major bugfixes (clients on flaky network connections); + o Major bugfixes (clients on flaky network connections): - When Tor leaves standby because of a new application request, open circuits as needed to serve that request. Previously, we would potentially wait a very long time. Fixes part of bug 19969; bugfix diff --git a/changes/bug20472 b/changes/bug20472 index b035037..4d90c39 100644 --- a/changes/bug20472 +++ b/changes/bug20472 @@ -1,4 +1,5 @@ o Minor bugfixes (circuits): - Remove a BUG warning in circuit_pick_extend_handshake. Instead, assume all nodes support EXTEND2. Use ntor whenever a key is available. - Bugfix on commit 10aa913 from 19163 in 0.2.9.3-alpha. Fixes bug 20472. + Fixes bug 20472; bugfix on 0.2.9.3-alpha. + diff --git a/changes/bug20551 b/changes/bug20551 index 1e0746b..b7ec4ca 100644 --- a/changes/bug20551 +++ b/changes/bug20551 @@ -1,3 +1,3 @@ - o Minor bugfixes (compilation); + o Minor bugfixes (compilation): - Fix implicit conversion warnings under OpenSSL 1.1. Fixes bug 20551; bugfix on 0.2.1.1-alpha.

1 0

[stem/master] Suppress pyflakes issues by prefix or suffix
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit 058fb76c9ba57676df3c209dfed6996ffb565257 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Nov 6 11:47:14 2016 -0800 Suppress pyflakes issues by prefix or suffix On #17306 neel's test output has quite a few pyflakes issues I don't get... https://trac.torproject.org/projects/tor/attachment/ticket/17306/integ_test… These would be a hassle to suppress one by one so allowing our config to suppress by prefix or suffix. --- docs/change_log.rst | 1 + run_tests.py | 2 +- stem/util/test_tools.py | 21 ++++++++++++++++++--- test/settings.cfg | 5 +++++ 4 files changed, 25 insertions(+), 4 deletions(-) diff --git a/docs/change_log.rst b/docs/change_log.rst index 0d8dcf2..ba496a7 100644 --- a/docs/change_log.rst +++ b/docs/change_log.rst @@ -91,6 +91,7 @@ The following are only available within Stem's `git repository * The 'ss' connection resolver didn't work on Gentoo (:trac:`18079`) * Recognize IPv4-mapped IPv6 addresses in our utils (:trac:`18079`) * Allow :func:`stem.util.conf.Config.set` to remove values when provided with a **None** value + * Support prefix and suffix issue strings in :func:`~stem.util.test_tools.pyflakes_issues` * Additional information when :func:`~stem.util.system.call` fails through a :class:`~stem.util.system.CallError` * Added **stem.util.system.SYSTEM_CALL_TIME** with the total time spent on system calls * Added an **is_ipv6** value to :class:`~stem.util.connection.Connection` instances diff --git a/run_tests.py b/run_tests.py index abe77e4..db34e5b 100755 --- a/run_tests.py +++ b/run_tests.py @@ -125,7 +125,7 @@ def main(): if not stem.prereq.is_mock_available(): try: try: - import unittest.mock + import unittest.mock as mock except ImportError: import mock diff --git a/stem/util/test_tools.py b/stem/util/test_tools.py index a09f735..406ebd7 100644 --- a/stem/util/test_tools.py +++ b/stem/util/test_tools.py @@ -273,7 +273,8 @@ def pyflakes_issues(paths): pyflakes.ignore stem/util/test_tools.py => 'pycodestyle' imported but unused If a 'exclude_paths' was set in our test config then we exclude any absolute - paths matching those regexes. + paths matching those regexes. Issue strings can start or end with an asterisk + to match just against the prefix or suffix. .. versionchanged:: 1.3.0 Renamed from get_pyflakes_issues() to pyflakes_issues(). The old name @@ -283,6 +284,9 @@ def pyflakes_issues(paths): Changing tuples in return value to be namedtuple instances, and adding the line that had the issue. + .. versionchanged:: 1.5.0 + Support matching against prefix or suffix issue strings. + :param list paths: paths to search for problems :returns: dict of paths list of :class:`stem.util.test_tools.Issue` instances @@ -316,8 +320,19 @@ def pyflakes_issues(paths): # path ends with any of them. for ignored_path, ignored_issues in self._ignored_issues.items(): - if path.endswith(ignored_path) and issue in ignored_issues: - return True + if path.endswith(ignored_path): + is_match = issue in ignored_issues + + for prefix in [i[:1] for i in ignored_issues if i.endswith('*')]: + if issue.startswith(prefix): + is_match = True + + for suffix in [i[1:] for i in ignored_issues if i.startswith('*')]: + if issue.endswith(suffix): + is_match = True + + if is_match: + return True return False diff --git a/test/settings.cfg b/test/settings.cfg index 9504da3..4913202 100644 --- a/test/settings.cfg +++ b/test/settings.cfg @@ -144,9 +144,13 @@ pyflakes.ignore stem/__init__.py => undefined name 'long' pyflakes.ignore stem/__init__.py => undefined name 'unicode' pyflakes.ignore stem/control.py => undefined name 'controller' pyflakes.ignore stem/manual.py => undefined name 'unichr' +pyflakes.ignore stem/prereq.py => 'Crypto.PublicKey.RSA' imported but unused +pyflakes.ignore stem/prereq.py => 'Crypto.Util.asn1' imported but unused +pyflakes.ignore stem/prereq.py => 'Crypto.Util.number.long_to_bytes' imported but unused pyflakes.ignore stem/prereq.py => 'RSA' imported but unused pyflakes.ignore stem/prereq.py => 'asn1' imported but unused pyflakes.ignore stem/prereq.py => 'unittest' imported but unused +pyflakes.ignore stem/prereq.py => 'unittest.mock' imported but unused pyflakes.ignore stem/prereq.py => 'long_to_bytes' imported but unused pyflakes.ignore stem/interpreter/__init__.py => undefined name 'raw_input' pyflakes.ignore stem/util/conf.py => undefined name 'unicode' @@ -154,6 +158,7 @@ pyflakes.ignore stem/util/test_tools.py => 'pyflakes' imported but unused pyflakes.ignore stem/util/test_tools.py => 'pycodestyle' imported but unused pyflakes.ignore test/mocking.py => undefined name 'test' pyflakes.ignore test/unit/response/events.py => 'from stem import *' used; unable to detect undefined names +pyflakes.ignore test/unit/response/events.py => *may be undefined, or defined from star imports: stem # Test modules we want to run. Modules are roughly ordered by the dependencies # so the lowest level tests come first. This is because a problem in say,

1 0

[stem/master] Fill in missing manual summaries
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit 859bf025b0a9a2e0793f64ed3404db06051d15ae Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Nov 4 16:36:54 2016 -0700 Fill in missing manual summaries As tor adds new config options we want short, particularly human-readable summaries. Filling in the new additons. We have a test that checks for this but it required the ONLINE integ target so really never gets run in practice. Replacing this with a unit test since honestly we don't need the downloaded information for this one. --- stem/settings.cfg | 11 ++++++----- test/integ/manual.py | 22 ---------------------- test/unit/manual.py | 19 +++++++++++++++++++ 3 files changed, 25 insertions(+), 27 deletions(-) diff --git a/stem/settings.cfg b/stem/settings.cfg index b561f73..c57d823 100644 --- a/stem/settings.cfg +++ b/stem/settings.cfg @@ -117,9 +117,6 @@ manual.summary.AccelName OpenSSL engine name for crypto acceleration manual.summary.AccelDir Crypto acceleration library path manual.summary.AvoidDiskWrites Toggles if tor avoids frequently writing to disk manual.summary.CircuitPriorityHalflife Overwrite method for prioritizing traffic among relayed connections -manual.summary.DisableIOCP Disables use of the Windows IOCP networking API -manual.summary.UserspaceIOCPBuffers Disable kernel-space IOCP TCP buffers -manual.summary.UseFilteringSSLBufferevents Use SSL for a chain of bufferevents manual.summary.CountPrivateBandwidth Applies rate limiting to private IP addresses # Client Config Options @@ -196,7 +193,6 @@ manual.summary.OptimisticData Use exits without confirmation that prior connecti manual.summary.Tor2webMode Establish non-anonymous hidden service connections manual.summary.Tor2webRendezvousPoints Rendezvous points to use for hidden services when in Tor2webMode manual.summary.UseMicrodescriptors Retrieve microdescriptors rather than server descriptors -manual.summary.UseNTorHandshake Use ntor for establishing circuits with relays manual.summary.PathBiasCircThreshold Number of circuits through a guard before applying bias checks manual.summary.PathBiasNoticeRate Fraction of circuits that must succeed before logging a notice manual.summary.PathBiasWarnRate Fraction of circuits that must succeed before logging a warning @@ -228,7 +224,8 @@ manual.summary.BridgeRelay Act as a bridge manual.summary.ContactInfo Contact information for this relay manual.summary.ExitRelay Allow relaying of exit traffic manual.summary.ExitPolicy Traffic destinations that can exit from this relay -manual.summary.ExitPolicyRejectPrivate Prevent exiting connection on the local network +manual.summary.ExitPolicyRejectPrivate Prevent exiting on the local network +manual.summary.ExitPolicyRejectLocalInterfaces More extensive prevention of exiting on the local network manual.summary.IPv6Exit Allow clients to use us for IPv6 traffic manual.summary.MaxOnionQueueDelay Duration to reject new onionskins if we have more than we can process manual.summary.MyFamily Other relays this operator administers @@ -266,6 +263,7 @@ manual.summary.HiddenServiceStatistics Toggles storing hidden service stats to d manual.summary.ExtraInfoStatistics Publishes statistic data in the extra-info documents manual.summary.ExtendAllowPrivateAddresses Allow circuits to be extended to the local network manual.summary.MaxMemInQueues Threshold at which tor will terminate circuits to avoid running out of memory +manual.summary.DisableOOSCheck Don't close connections when running out of sockets manual.summary.SigningKeyLifetime Duration the Ed25519 signing key is valid for manual.summary.OfflineMasterKey Don't generate the master secret key @@ -302,6 +300,7 @@ manual.summary.AuthDirMaxServersPerAuthAddr Limit on the number of relays accept manual.summary.AuthDirFastGuarantee Advertised rate at which the Fast flag is granted manual.summary.AuthDirGuardBWGuarantee Advertised rate necessary to be a guard manual.summary.AuthDirPinKeys Don't accept descriptors with conflicting identity keypairs +manual.summary.AuthDirSharedRandomness Participates in shared randomness voting manual.summary.BridgePassword Password for requesting bridge information manual.summary.V3AuthVotingInterval Consensus voting interval manual.summary.V3AuthVoteDelay Wait time to collect votes of other authorities @@ -326,6 +325,8 @@ manual.summary.HiddenServiceMaxStreamsCloseCircuit Closes rendezvous circuits th manual.summary.RendPostPeriod Period at which the rendezvous service descriptors are refreshed manual.summary.HiddenServiceDirGroupReadable Group read permissions for the hidden service directory manual.summary.HiddenServiceNumIntroductionPoints Number of introduction points the hidden service will have +manual.summary.HiddenServiceSingleHopMode Allow non-anonymous single hop hidden services +manual.summary.HiddenServiceNonAnonymousMode Enables HiddenServiceSingleHopMode to be set # Testing Network Options diff --git a/test/integ/manual.py b/test/integ/manual.py index dbef86a..62222f5 100644 --- a/test/integ/manual.py +++ b/test/integ/manual.py @@ -246,28 +246,6 @@ class TestManual(unittest.TestCase): self.assertEqual(['tor - The second-generation onion router'], categories['NAME']) self.assertEqual(['tor [OPTION value]...'], categories['SYNOPSIS']) - def test_has_all_summaries(self): - """ - Check that we have brief, human readable summaries for all of tor's - configuration options. If you add a new config entry then please take a sec - to write a little summary. They're located in 'stem/settings.cfg'. - """ - - if self.requires_downloaded_manual(): - return - - manual = stem.manual.Manual.from_man(self.man_path) - present = set(manual.config_options.keys()) - expected = set([key[15:] for key in stem.manual._config(lowercase = False) if key.startswith('manual.summary.')]) - - missing_options = present.difference(expected) - extra_options = expected.difference(present) - - if missing_options: - self.fail("Changed tor's man page? Please update Stem's settings.cfg with summaries of the following config options: %s" % ', '.join(missing_options)) - elif extra_options: - self.fail("Changed tor's man page? Please remove the following summaries from Stem's settings.cfg: %s" % ', '.join(extra_options)) - def test_has_all_tor_config_options(self): """ Check that all the configuration options tor supports are in the man page. diff --git a/test/unit/manual.py b/test/unit/manual.py index 9cbd6ad..65957c8 100644 --- a/test/unit/manual.py +++ b/test/unit/manual.py @@ -105,6 +105,25 @@ EXPECTED_CONFIG_OPTIONS['MaxAdvertisedBandwidth'] = stem.manual.ConfigOption( class TestManual(unittest.TestCase): + def test_has_all_summaries(self): + """ + Check that we have brief, human readable summaries for all of tor's + configuration options. If you add a new config entry then please take a sec + to write a little summary. They're located in 'stem/settings.cfg'. + """ + + manual = stem.manual.Manual.from_cache() + present = set(manual.config_options.keys()) + expected = set([key[15:] for key in stem.manual._config(lowercase = False) if key.startswith('manual.summary.')]) + + missing_options = present.difference(expected) + extra_options = expected.difference(present) + + if missing_options: + self.fail("Ran cache_manual.py? Please update Stem's settings.cfg with summaries of the following config options: %s" % ', '.join(missing_options)) + elif extra_options: + self.fail("Ran cache_manual.py? Please remove the following summaries from Stem's settings.cfg: %s" % ', '.join(extra_options)) + def test_is_important(self): self.assertTrue(stem.manual.is_important('ExitPolicy')) self.assertTrue(stem.manual.is_important('exitpolicy'))

1 0

[stem/master] Use the range function instead of xrange
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit 5dcf225538e1e54e3365ad78e694595eb9526c76 Author: cypherpunks <cypherpunks(a)torproject.org> Date: Fri Nov 4 10:51:49 2016 +0000 Use the range function instead of xrange The xrange function no longer exists in Python 3 [0]. [0] https://docs.python.org/3.0/whatsnew/3.0.html#views-and-iterators-instead-o… --- docs/_static/example/event_listening.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/_static/example/event_listening.py b/docs/_static/example/event_listening.py index 2e6f026..ff8c146 100644 --- a/docs/_static/example/event_listening.py +++ b/docs/_static/example/event_listening.py @@ -93,15 +93,15 @@ def _render_graph(window, bandwidth_rates): # draw the graph - for col in xrange(GRAPH_WIDTH): + for col in range(GRAPH_WIDTH): col_height = GRAPH_HEIGHT * download_rates[col] / max(max_download_rate, 1) - for row in xrange(col_height): + for row in range(col_height): window.addstr(GRAPH_HEIGHT - row, col + 6, " ", DOWNLOAD_COLOR, curses.A_STANDOUT) col_height = GRAPH_HEIGHT * upload_rates[col] / max(max_upload_rate, 1) - for row in xrange(col_height): + for row in range(col_height): window.addstr(GRAPH_HEIGHT - row, col + GRAPH_WIDTH + 12, " ", UPLOAD_COLOR, curses.A_STANDOUT) window.refresh()

1 0

[stem/master] Use the new style of catching exceptions
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit 05162a899d527c041173bff18f22afcd2b07d502 Author: cypherpunks <cypherpunks(a)torproject.org> Date: Fri Nov 4 10:42:02 2016 +0000 Use the new style of catching exceptions --- docs/_static/example/reading_twitter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/_static/example/reading_twitter.py b/docs/_static/example/reading_twitter.py index 28f840d..7f9094b 100644 --- a/docs/_static/example/reading_twitter.py +++ b/docs/_static/example/reading_twitter.py @@ -81,7 +81,7 @@ try: print("%i. %s" % (index + 1, tweet["created_at"])) print(tweet["text"]) print("") -except IOError, exc: +except IOError as exc: print(exc) finally: tor_process.kill() # stops tor

1 0

[stem/master] Initialize the missing SOCKS_PORT variable
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit e5863bbc073103cfe8803c8fe990a2eec08b7355 Author: cypherpunks <cypherpunks(a)torproject.org> Date: Sun Nov 6 13:37:49 2016 +0000 Initialize the missing SOCKS_PORT variable --- docs/_static/example/client_usage_using_socksipy.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/_static/example/client_usage_using_socksipy.py b/docs/_static/example/client_usage_using_socksipy.py index c480682..6f532d5 100644 --- a/docs/_static/example/client_usage_using_socksipy.py +++ b/docs/_static/example/client_usage_using_socksipy.py @@ -2,6 +2,8 @@ import socks # SocksiPy module import socket import urllib +SOCKS_PORT = 7000 + # Set socks proxy and wrap the urllib module socks.setdefaultproxy(socks.PROXY_TYPE_SOCKS5, '127.0.0.1', SOCKS_PORT)

1 0

[stem/master] test_installs_all_data_files fails with vim swap files
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit 5fa09317c4ef3dd746537acbf2d316f3d6704d1b Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Nov 4 16:41:52 2016 -0700 test_installs_all_data_files fails with vim swap files Simple error with our new test... ====================================================================== FAIL: test_installs_all_data_files ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/atagar/Desktop/stem/test/unit/installation.py", line 82, in test_installs_all_data_files self.fail("setup.py doesn't install %s" % path) AssertionError: setup.py doesn't install /home/atagar/Desktop/stem/stem/.settings.cfg.swp ---------------------------------------------------------------------- Ran 2 tests in 0.018s FAILED (failures=1) --- test/unit/installation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/installation.py b/test/unit/installation.py index 12a1e2e..7e13ab1 100644 --- a/test/unit/installation.py +++ b/test/unit/installation.py @@ -76,7 +76,7 @@ class TestInstallation(unittest.TestCase): for filename in entry[2]: path = os.path.join(directory, filename) - if path.endswith('.orig') or path.endswith('.py') or path.endswith('.pyc'): + if path.endswith('.py') or path.endswith('.pyc') or path.endswith('.swp') or path.endswith('orig'): continue elif path not in data_files: self.fail("setup.py doesn't install %s" % path)

1 0

[stem/master] Minor doc corrections
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit b4926784b92426aeb9a3d0d1c573720ba9308d73 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Nov 6 09:18:11 2016 -0800 Minor doc corrections Vidalia link no longer worked and trac components are now nested. --- docs/faq.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/faq.rst b/docs/faq.rst index 2e022e6..1b39a9b 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -326,7 +326,7 @@ An important thing to note is that a new circuit does not necessarily mean a new Tor does not have a method for cycling your IP address. This is on purpose, and done for a couple reasons. The first is that this capability is usually requested for not-so-nice reasons such as ban evasion or SEO. Second, repeated circuit creation puts a very high load on the Tor network, so please don't! -With all that out of the way, how do you create a new circuit? You can customize the rate at which Tor cycles circuits with the **MaxCircuitDirtiness** option in your `torrc <https://www.torproject.org/docs/faq.html.en#torrc>`_. `Vidalia <https://www.torproject.org/getinvolved/volunteer.html.en#project-vidalia>`_ and `arm <https://www.atagar.com/arm/>`_ both provide a method to request a new identity, and you can do so programmatically by sending Tor a NEWNYM signal. +With all that out of the way, how do you create a new circuit? You can customize the rate at which Tor cycles circuits with the **MaxCircuitDirtiness** option in your `torrc <https://www.torproject.org/docs/faq.html.en#torrc>`_. `Vidalia <https://en.wikipedia.org/wiki/Vidalia_%28software%29>`_ and `arm <https://www.atagar.com/arm/>`_ both provide a method to request a new identity, and you can do so programmatically by sending Tor a NEWNYM signal. To do this with telnet... @@ -463,7 +463,7 @@ To start hacking on Stem please do the following and don't hesitate to let me know if you get stuck or would like to discuss anything! #. Clone our `git <http://git-scm.com/>`_ repository: **git clone https://git.torproject.org/stem.git** -#. Get our test depdendencies: **sudo pip install mock pycodestyle pyflakes**. +#. Get our test dependencies: **sudo pip install mock pycodestyle pyflakes**. #. Find a `bug or feature <https://trac.torproject.org/projects/tor/wiki/doc/stem/bugs>`_ that sounds interesting. #. When you have something that you would like to contribute back do the following... @@ -474,7 +474,7 @@ know if you get stuck or would like to discuss anything! * Description: longer description and a link to your repository with either the git commits or branch that has your change * Type: 'defect' if this is a bug fix and 'enhancement' otherwise * Priority: rough guess at the priority of your change - * Component: Stem + * Component: Core Tor / Stem * I'll review the change and give suggestions. When we're both happy with it I'll push your change to the official repository.

1 0

[stem/master] Remove one mention of a hidden service directory
by atagar＠torproject.org 06 Nov '16

06 Nov '16

commit 58f638c0c2c70e17fdc7f3ecfce5d54d5ac2c4f3 Author: cypherpunks <cypherpunks(a)torproject.org> Date: Sun Nov 6 13:38:24 2016 +0000 Remove one mention of a hidden service directory Ephemeral hidden services do not touch disk so there is no hidden service directory to display. --- docs/_static/example/ephemeral_hidden_services.py | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/_static/example/ephemeral_hidden_services.py b/docs/_static/example/ephemeral_hidden_services.py index 85d36fa..8ca3ab6 100644 --- a/docs/_static/example/ephemeral_hidden_services.py +++ b/docs/_static/example/ephemeral_hidden_services.py @@ -17,7 +17,6 @@ with Controller.from_port() as controller: # Create a hidden service where visitors of port 80 get redirected to local # port 5000 (this is where Flask runs by default). - print(" * Creating our hidden service in %s" % hidden_service_dir) response = controller.create_ephemeral_hidden_service({80: 5000}, await_publication = True) print(" * Our service is available at %s.onion, press ctrl+c to quit" % response.service_id)

1 0