April 2015 - tor-commits - lists.torproject.org

[tor/master] Refactor router_rebuild_descriptor
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit 8feaf3846d67d80d6a1bae9867cdf55bafdc437e Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Sat Feb 7 13:29:26 2015 +0100 Refactor router_rebuild_descriptor Allow building a router descriptor without storing it to global state. This is in preparation of a patch to export the created descriptors via the control port. --- src/or/router.c | 59 +++++++++++++++++++++++++++++++++++++++++-------------- src/or/router.h | 1 + 2 files changed, 45 … [View More]insertions(+), 15 deletions(-) diff --git a/src/or/router.c b/src/or/router.c index 2ddaa89..b8bfd3c 100644 --- a/src/or/router.c +++ b/src/or/router.c @@ -1802,12 +1802,15 @@ router_pick_published_address(const or_options_t *options, uint32_t *addr) return 0; } -/** If force is true, or our descriptor is out-of-date, rebuild a fresh - * routerinfo, signed server descriptor, and extra-info document for this OR. - * Return 0 on success, -1 on temporary error. +/** Build a fresh routerinfo, signed server descriptor, and extra-info document + * for this OR. Set r to the generated routerinfo, e to the generated + * extra-info document. Return 0 on success, -1 on temporary error. Failure to + * generate an extra-info document is not an error and is indicated by setting + * e to NULL. Caller is responsible for freeing generated documents if 0 is + * returned. */ int -router_rebuild_descriptor(int force) +router_build_fresh_descriptor(routerinfo_t **r, extrainfo_t **e) { routerinfo_t *ri; extrainfo_t *ei; @@ -1816,20 +1819,11 @@ router_rebuild_descriptor(int force) int hibernating = we_are_hibernating(); const or_options_t *options = get_options(); - if (desc_clean_since && !force) - return 0; - - if (router_pick_published_address(options, &addr) < 0 || - router_get_advertised_or_port(options) == 0) { - /* Stop trying to rebuild our descriptor every second. We'll - * learn that it's time to try again when ip_address_changed() - * marks it dirty. */ - desc_clean_since = time(NULL); + if (router_pick_published_address(options, &addr) < 0) { + log_warn(LD_CONFIG, "Don't know my address while generating descriptor"); return -1; } - log_info(LD_OR, "Rebuilding relay descriptor%s", force ? " (forced)" : ""); - ri = tor_malloc_zero(sizeof(routerinfo_t)); ri->cache_info.routerlist_index = -1; ri->nickname = tor_strdup(options->Nickname); @@ -2024,6 +2018,41 @@ router_rebuild_descriptor(int force) tor_assert(! routerinfo_incompatible_with_extrainfo(ri, ei, NULL, NULL)); } + *r = ri; + *e = ei; + return 0; +} + +/** If force is true, or our descriptor is out-of-date, rebuild a fresh + * routerinfo, signed server descriptor, and extra-info document for this OR. + * Return 0 on success, -1 on temporary error. + */ +int +router_rebuild_descriptor(int force) +{ + routerinfo_t *ri; + extrainfo_t *ei; + uint32_t addr; + const or_options_t *options = get_options(); + + if (desc_clean_since && !force) + return 0; + + if (router_pick_published_address(options, &addr) < 0 || + router_get_advertised_or_port(options) == 0) { + /* Stop trying to rebuild our descriptor every second. We'll + * learn that it's time to try again when ip_address_changed() + * marks it dirty. */ + desc_clean_since = time(NULL); + return -1; + } + + log_info(LD_OR, "Rebuilding relay descriptor%s", force ? " (forced)" : ""); + + if (router_build_fresh_descriptor(&ri, &ei) < 0) { + return -1; + } + routerinfo_free(desc_routerinfo); desc_routerinfo = ri; extrainfo_free(desc_extrainfo); diff --git a/src/or/router.h b/src/or/router.h index 8108ffb..73b43bc 100644 --- a/src/or/router.h +++ b/src/or/router.h @@ -89,6 +89,7 @@ const uint8_t *router_get_my_id_digest(void); int router_extrainfo_digest_is_me(const char *digest); int router_is_me(const routerinfo_t *router); int router_pick_published_address(const or_options_t *options, uint32_t *addr); +int router_build_fresh_descriptor(routerinfo_t **r, extrainfo_t **e); int router_rebuild_descriptor(int force); char *router_dump_router_to_string(routerinfo_t *router, crypto_pk_t *ident_key); [View Less]

1 0

[tor/master] Implement status/fresh-relay-descs command
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit 0c11d8b2d218b48ede19601bb7400639e3883a9c Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Sun Feb 15 12:33:33 2015 +0100 Implement status/fresh-relay-descs command The idea here is that a controller should be able to make Tor produce a new relay descriptor on demand, without that descriptor actually being uploaded to the dirauths (they would likely reject it anyway due to freshness concerns). Implements #14784. --- changes/bug14784 | … [View More] 4 ++++ src/or/control.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/changes/bug14784 b/changes/bug14784 new file mode 100644 index 0000000..1f50142 --- /dev/null +++ b/changes/bug14784 @@ -0,0 +1,4 @@ + o Minor features: + - Implement a new controller command "status/fresh-relay-descs" to + fetch a descriptor/extrainfo pair that was generated on demand + just for the controller's use. Implements ticket 14784. diff --git a/src/or/control.c b/src/or/control.c index 064b745..2977b8b 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -2100,6 +2100,47 @@ getinfo_helper_events(control_connection_t *control_conn, return -1; } *answer = bridge_stats; + } else if (!strcmp(question, "status/fresh-relay-descs")) { + if (!server_mode(get_options())) { + *errmsg = "Only relays have descriptors"; + return -1; + } + routerinfo_t *r; + extrainfo_t *e; + if (router_build_fresh_descriptor(&r, &e) < 0) { + *errmsg = "Error generating descriptor"; + return -1; + } + size_t size = r->cache_info.signed_descriptor_len + 1; + if (e) { + size += e->cache_info.signed_descriptor_len + 1; + } + tor_assert(r->cache_info.signed_descriptor_len); + char *descs = tor_malloc(size); + char *cp = descs; + memcpy(cp, signed_descriptor_get_body(&r->cache_info), + r->cache_info.signed_descriptor_len); + cp += r->cache_info.signed_descriptor_len - 1; + if (e) { + if (cp[0] == '\0') { + cp[0] = '\n'; + } else if (cp[0] != '\n') { + cp[1] = '\n'; + cp++; + } + memcpy(cp, signed_descriptor_get_body(&e->cache_info), + e->cache_info.signed_descriptor_len); + cp += e->cache_info.signed_descriptor_len - 1; + } + if (cp[0] == '\n') { + cp[0] = '\0'; + } else if (cp[0] != '\0') { + cp[1] = '\0'; + } + log_warn(LD_CONFIG, "%s", descs); + *answer = descs; + routerinfo_free(r); + extrainfo_free(e); } else { return 0; } @@ -2210,6 +2251,8 @@ static const getinfo_item_t getinfo_items[] = { "The last bootstrap phase status event that Tor sent."), DOC("status/clients-seen", "Breakdown of client countries seen by a bridge."), + DOC("status/fresh-relay-descs", + "A fresh relay/ei descriptor pair for Tor's current state. Not stored."), DOC("status/version/recommended", "List of currently recommended versions."), DOC("status/version/current", "Status of the current version."), DOC("status/version/num-versioning", "Number of versioning authorities."), [View Less]

1 0

[tor/master] Remove spurious warn
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit 1a7dea9191585853fe9b3e591a98620c994111cf Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 15 11:04:17 2015 -0400 Remove spurious warn --- src/or/control.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/or/control.c b/src/or/control.c index a34eb0d..fde3990 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -2137,7 +2137,6 @@ getinfo_helper_events(control_connection_t *control_conn, } else if (cp[0] != '\0') { cp[1] = '\0'; … [View More]

1 0

[tor/master] Merge remote-tracking branch 'sebastian/bug14784'
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit b98cc79477e5eb70284bb70dc80d778d5d082cc1 Merge: c3e8b7f 0c11d8b Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 15 11:10:37 2015 -0400 Merge remote-tracking branch 'sebastian/bug14784' changes/bug14784 | 4 ++++ src/or/control.c | 43 +++++++++++++++++++++++++++++++++++++++ src/or/router.c | 59 ++++++++++++++++++++++++++++++++++++++++-------------- src/or/router.h | 1 + 4 files changed, 92 insertions(+), 15 deletions(-)

1 0

[tor/master] Fix indentation on a block
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit cc10f13408e25eaf04f849d0f761680f383fa61d Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 15 11:05:09 2015 -0400 Fix indentation on a block --- src/or/control.c | 76 +++++++++++++++++++++++++++--------------------------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/src/or/control.c b/src/or/control.c index fde3990..d4216d2 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -2101,45 +2101,45 @@ getinfo_helper_events(… [View More]control_connection_t *control_conn, } *answer = bridge_stats; } else if (!strcmp(question, "status/fresh-relay-descs")) { - if (!server_mode(get_options())) { - *errmsg = "Only relays have descriptors"; - return -1; - } - routerinfo_t *r; - extrainfo_t *e; - if (router_build_fresh_descriptor(&r, &e) < 0) { - *errmsg = "Error generating descriptor"; - return -1; - } - size_t size = r->cache_info.signed_descriptor_len + 1; - if (e) { - size += e->cache_info.signed_descriptor_len + 1; - } - tor_assert(r->cache_info.signed_descriptor_len); - char *descs = tor_malloc(size); - char *cp = descs; - memcpy(cp, signed_descriptor_get_body(&r->cache_info), - r->cache_info.signed_descriptor_len); - cp += r->cache_info.signed_descriptor_len - 1; - if (e) { - if (cp[0] == '\0') { - cp[0] = '\n'; - } else if (cp[0] != '\n') { - cp[1] = '\n'; - cp++; - } - memcpy(cp, signed_descriptor_get_body(&e->cache_info), - e->cache_info.signed_descriptor_len); - cp += e->cache_info.signed_descriptor_len - 1; - } - if (cp[0] == '\n') { - cp[0] = '\0'; - } else if (cp[0] != '\0') { - cp[1] = '\0'; + if (!server_mode(get_options())) { + *errmsg = "Only relays have descriptors"; + return -1; + } + routerinfo_t *r; + extrainfo_t *e; + if (router_build_fresh_descriptor(&r, &e) < 0) { + *errmsg = "Error generating descriptor"; + return -1; + } + size_t size = r->cache_info.signed_descriptor_len + 1; + if (e) { + size += e->cache_info.signed_descriptor_len + 1; + } + tor_assert(r->cache_info.signed_descriptor_len); + char *descs = tor_malloc(size); + char *cp = descs; + memcpy(cp, signed_descriptor_get_body(&r->cache_info), + r->cache_info.signed_descriptor_len); + cp += r->cache_info.signed_descriptor_len - 1; + if (e) { + if (cp[0] == '\0') { + cp[0] = '\n'; + } else if (cp[0] != '\n') { + cp[1] = '\n'; + cp++; } - *answer = descs; - routerinfo_free(r); - extrainfo_free(e); + memcpy(cp, signed_descriptor_get_body(&e->cache_info), + e->cache_info.signed_descriptor_len); + cp += e->cache_info.signed_descriptor_len - 1; + } + if (cp[0] == '\n') { + cp[0] = '\0'; + } else if (cp[0] != '\0') { + cp[1] = '\0'; + } + *answer = descs; + routerinfo_free(r); + extrainfo_free(e); } else { return 0; } [View Less]

1 0

[torspec/master] Remove note about wildcard transport; see #15612
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit a95724915096956ceff80856a4176f081660ca9c Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 15 10:53:31 2015 -0400 Remove note about wildcard transport; see #15612 --- pt-spec.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/pt-spec.txt b/pt-spec.txt index aea7fd5..43ae73f 100644 --- a/pt-spec.txt +++ b/pt-spec.txt @@ -103,7 +103,6 @@ connection | +-----------+ ^ +------------+ | whichever one is listed first. TODO: Document … [View More]

1 0

[tor/master] Merge remote-tracking branch 'teor/fix-spaces-20150415'
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit eec58c35482d4425fccf38d632035319b56f795e Merge: 7e1fa9d af2b6bd Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 15 10:37:55 2015 -0400 Merge remote-tracking branch 'teor/fix-spaces-20150415' src/common/crypto.h | 1 + src/test/test-memwipe.c | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/master] Fix another space issue
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit c3e8b7f2da7f5c7fc4d341b533b7031eab90a665 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 15 10:38:12 2015 -0400 Fix another space issue --- src/or/rendcommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c index 775d2b9..3fea07f 100644 --- a/src/or/rendcommon.c +++ b/src/or/rendcommon.c @@ -963,7 +963,7 @@ rend_cache_lookup_entry(const char *query, int version, rend_cache_entry_t **e) *e = … [View More]

1 0

[tor/master] Fix spaces in crypto.h and test-memwipe.c
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit af2b6bdaba85d617f9eb93c67457f8b89b088b2d Author: teor <teor2345(a)gmail.com> Date: Wed Apr 15 19:42:41 2015 +1000 Fix spaces in crypto.h and test-memwipe.c --- src/common/crypto.h | 1 + src/test/test-memwipe.c | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/common/crypto.h b/src/common/crypto.h index 440ff23..b9c26a4 100644 --- a/src/common/crypto.h +++ b/src/common/crypto.h @@ -296,3 +296,4 @@ struct dh_st *crypto_dh_get_dh_(… [View More]

1 0

[tor/master] Refactor rend_cache_lookup_entry() and how it's used
by nickm＠torproject.org 15 Apr '15

15 Apr '15

commit 91009dce971655f6b18b5eba5f0c0b48dbd8a737 Author: David Goulet <dgoulet(a)ev0ke.net> Date: Mon Jan 26 17:42:42 2015 -0500 Refactor rend_cache_lookup_entry() and how it's used Here is why: 1) v0 descriptors are deprecated since 0.2.2.1 and not suppose to be alive in the network anymore. This function should only serve v2 version for now as the default. 2) It should return different error code depending on what's the actual error is. Right … [View More]now, there is no distinction between a cache entry not found and an invalid query. 3) This function should NOT test if the intro points are usable or not. This adds some load on a function that should be "O(1)" and do one job. Furthermore, multiple callsites actually already test that doing twice the job... 4) While adding control event, it would be useful to be able to lookup a cache entry without having it checking the intro points. There are also places in the code that do want to lookup the cache entry without doing that. Fixes #14391 Signed-off-by: David Goulet <dgoulet(a)ev0ke.net> --- src/or/connection_edge.c | 59 +++++++++++++++++++++++++----------------- src/or/rendclient.c | 56 ++++++++++++++++++++++++++-------------- src/or/rendcommon.c | 64 +++++++++++++++++++++++++++++----------------- 3 files changed, 113 insertions(+), 66 deletions(-) diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index f541249..3833d16 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -1502,23 +1502,45 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, log_info(LD_REND,"Got a hidden service request for ID '%s'", safe_str_client(rend_data->onion_address)); - /* see if we already have a hidden service descriptor cached for this - * address. */ + /* Lookup the given onion address. If invalid, stop right now else we + * might have it in the cache or not, it will be tested later on. */ + unsigned int refetch_desc = 0; rend_cache_entry_t *entry = NULL; const int rend_cache_lookup_result = rend_cache_lookup_entry(rend_data->onion_address, -1, &entry); if (rend_cache_lookup_result < 0) { - /* We should already have rejected this address! */ - log_warn(LD_BUG,"Invalid service name '%s'", - safe_str_client(rend_data->onion_address)); - connection_mark_unattached_ap(conn, END_STREAM_REASON_TORPROTOCOL); - return -1; + switch (-rend_cache_lookup_result) { + case EINVAL: + /* We should already have rejected this address! */ + log_warn(LD_BUG,"Invalid service name '%s'", + safe_str_client(rend_data->onion_address)); + connection_mark_unattached_ap(conn, END_STREAM_REASON_TORPROTOCOL); + return -1; + case ENOENT: + refetch_desc = 1; + break; + default: + log_warn(LD_BUG, "Unknown cache lookup error %d", + rend_cache_lookup_result); + return -1; + } } /* Help predict this next time. We're not sure if it will need * a stable circuit yet, but we know we'll need *something*. */ rep_hist_note_used_internal(now, 0, 1); + /* Now we have a descriptor but is it usable or not? If not, refetch. + * Also, a fetch could have been requested if the onion address was not + * found in the cache previously. */ + if (refetch_desc || !rend_client_any_intro_points_usable(entry)) { + base_conn->state = AP_CONN_STATE_RENDDESC_WAIT; + log_info(LD_REND, "Unknown descriptor %s. Fetching.", + safe_str_client(rend_data->onion_address)); + rend_client_refetch_v2_renddesc(rend_data); + return 0; + } + /* Look up if we have client authorization configured for this hidden * service. If we do, associate it with the rend_data. */ rend_service_authorization_t *client_auth = @@ -1532,22 +1554,13 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, rend_data->auth_type = client_auth->auth_type; } - /* Now, we either launch an attempt to connect to the hidden service, - * or we launch an attempt to look up its descriptor, depending on - * whether we had the descriptor. */ - if (rend_cache_lookup_result == 0) { - base_conn->state = AP_CONN_STATE_RENDDESC_WAIT; - log_info(LD_REND, "Unknown descriptor %s. Fetching.", - safe_str_client(rend_data->onion_address)); - rend_client_refetch_v2_renddesc(rend_data); - } else { /* rend_cache_lookup_result > 0 */ - base_conn->state = AP_CONN_STATE_CIRCUIT_WAIT; - log_info(LD_REND, "Descriptor is here. Great."); - if (connection_ap_handshake_attach_circuit(conn) < 0) { - if (!base_conn->marked_for_close) - connection_mark_unattached_ap(conn, END_STREAM_REASON_CANT_ATTACH); - return -1; - } + /* We have the descriptor so launch a connection to the HS. */ + base_conn->state = AP_CONN_STATE_CIRCUIT_WAIT; + log_info(LD_REND, "Descriptor is here. Great."); + if (connection_ap_handshake_attach_circuit(conn) < 0) { + if (!base_conn->marked_for_close) + connection_mark_unattached_ap(conn, END_STREAM_REASON_CANT_ATTACH); + return -1; } return 0; } diff --git a/src/or/rendclient.c b/src/or/rendclient.c index 0c02243..350cd2e 100644 --- a/src/or/rendclient.c +++ b/src/or/rendclient.c @@ -141,7 +141,7 @@ rend_client_send_introduction(origin_circuit_t *introcirc, int r, v3_shift = 0; char payload[RELAY_PAYLOAD_SIZE]; char tmp[RELAY_PAYLOAD_SIZE]; - rend_cache_entry_t *entry; + rend_cache_entry_t *entry = NULL; crypt_path_t *cpath; off_t dh_offset; crypto_pk_t *intro_key = NULL; @@ -158,8 +158,13 @@ rend_client_send_introduction(origin_circuit_t *introcirc, tor_assert(!(rendcirc->build_state->onehop_tunnel)); #endif - if (rend_cache_lookup_entry(introcirc->rend_data->onion_address, -1, - &entry) < 1) { + r = rend_cache_lookup_entry(introcirc->rend_data->onion_address, -1, + &entry); + /* An invalid onion address is not possible else we have a big issue. */ + tor_assert(r != -EINVAL); + if (r < 0 || !rend_client_any_intro_points_usable(entry)) { + /* If the descriptor is not found or the intro points are not usable + * anymore, trigger a fetch. */ log_info(LD_REND, "query %s didn't have valid rend desc in cache. " "Refetching descriptor.", @@ -734,7 +739,7 @@ rend_client_refetch_v2_renddesc(const rend_data_t *rend_query) return; } /* Before fetching, check if we already have a usable descriptor here. */ - if (rend_cache_lookup_entry(rend_query->onion_address, -1, &e) > 0 && + if (rend_cache_lookup_entry(rend_query->onion_address, -1, &e) == 0 && rend_client_any_intro_points_usable(e)) { log_info(LD_REND, "We would fetch a v2 rendezvous descriptor, but we " "already have a usable descriptor here. Not fetching."); @@ -848,17 +853,26 @@ rend_client_report_intro_point_failure(extend_info_t *failed_intro, connection_t *conn; r = rend_cache_lookup_entry(rend_query->onion_address, -1, &ent); - if (r<0) { - log_warn(LD_BUG, "Malformed service ID %s.", - escaped_safe_str_client(rend_query->onion_address)); - return -1; - } - if (r==0) { - log_info(LD_REND, "Unknown service %s. Re-fetching descriptor.", - escaped_safe_str_client(rend_query->onion_address)); - rend_client_refetch_v2_renddesc(rend_query); - return 0; + if (r < 0) { + /* Either invalid onion address or cache entry not found. */ + switch (-r) { + case EINVAL: + log_warn(LD_BUG, "Malformed service ID %s.", + escaped_safe_str_client(rend_query->onion_address)); + return -1; + case ENOENT: + log_info(LD_REND, "Unknown service %s. Re-fetching descriptor.", + escaped_safe_str_client(rend_query->onion_address)); + rend_client_refetch_v2_renddesc(rend_query); + return 0; + default: + log_warn(LD_BUG, "Unknown cache lookup returned code: %d", r); + return -1; + } } + /* The intro points are not checked here if they are usable or not because + * this is called when an intro point circuit is closed thus there must be + * at least one intro point that is usable and is about to be flagged. */ for (i = 0; i < smartlist_len(ent->parsed->intro_nodes); i++) { rend_intro_point_t *intro = smartlist_get(ent->parsed->intro_nodes, i); @@ -1057,7 +1071,7 @@ rend_client_desc_trynow(const char *query) continue; assert_connection_ok(base_conn, now); if (rend_cache_lookup_entry(rend_data->onion_address, -1, - &entry) == 1 && + &entry) == 0 && rend_client_any_intro_points_usable(entry)) { /* either this fetch worked, or it failed but there was a * valid entry from before which we should reuse */ @@ -1121,13 +1135,17 @@ rend_client_note_connection_attempt_ended(const char *onion_address) extend_info_t * rend_client_get_random_intro(const rend_data_t *rend_query) { + int ret; extend_info_t *result; rend_cache_entry_t *entry; - if (rend_cache_lookup_entry(rend_query->onion_address, -1, &entry) < 1) { - log_warn(LD_REND, - "Query '%s' didn't have valid rend desc in cache. Failing.", - safe_str_client(rend_query->onion_address)); + ret = rend_cache_lookup_entry(rend_query->onion_address, -1, &entry); + if (ret < 0 || !rend_client_any_intro_points_usable(entry)) { + log_warn(LD_REND, + "Query '%s' didn't have valid rend desc in cache. Failing.", + safe_str_client(rend_query->onion_address)); + /* XXX: Should we refetch the descriptor here if the IPs are not usable + * anymore ?. */ return NULL; } diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c index 866f4fb..0317455 100644 --- a/src/or/rendcommon.c +++ b/src/or/rendcommon.c @@ -920,36 +920,52 @@ rend_valid_service_id(const char *query) return 1; } -/** If we have a cached rend_cache_entry_t for the service ID query - * with version, set *e to that entry and return 1. - * Else return 0. If version is nonnegative, only return an entry - * in that descriptor format version. Otherwise (if version is - * negative), return the most recent format we have. - */ +/** Lookup in the client cache the given service ID query for + * version. + * + * Return 0 if found and if e is non NULL, set it with the entry + * found. Else, a negative value is returned and e is untouched. + * -EINVAL means that query is not a valid service id. + * -ENOENT means that no entry in the cache was found. */ int rend_cache_lookup_entry(const char *query, int version, rend_cache_entry_t **e) { - char key[REND_SERVICE_ID_LEN_BASE32+2]; /* <version><query>\0 */ + int ret = 0; + char key[REND_SERVICE_ID_LEN_BASE32 + 2]; /* <version><query>\0 */ + rend_cache_entry_t *entry = NULL; + static const int default_version = 2; + tor_assert(rend_cache); - if (!rend_valid_service_id(query)) - return -1; - *e = NULL; - if (version != 0) { - tor_snprintf(key, sizeof(key), "2%s", query); - *e = strmap_get_lc(rend_cache, key); + tor_assert(query); + + if (!rend_valid_service_id(query)) { + ret = -EINVAL; + goto end; } - if (!*e && version != 2) { - tor_snprintf(key, sizeof(key), "0%s", query); - *e = strmap_get_lc(rend_cache, key); + + switch (version) { + case 0: + log_warn(LD_REND, "Cache lookup of a v0 renddesc is deprecated."); + break; + case 2: + /* Default is version 2. */ + default: + tor_snprintf(key, sizeof(key), "%d%s", default_version, query); + entry = strmap_get_lc(rend_cache, key); + break; } - if (!*e) - return 0; - tor_assert((*e)->parsed && (*e)->parsed->intro_nodes); - /* XXX023 hack for now, to return "not found" if there are no intro - * points remaining. See bug 997. */ - if (! rend_client_any_intro_points_usable(*e)) - return 0; - return 1; + if (!entry) { + ret = -ENOENT; + goto end; + } + tor_assert(entry->parsed && entry->parsed->intro_nodes); + + if (e) { + *e = entry; + } + +end: + return ret; } /** Lookup the v2 service descriptor with base32-encoded desc_id and [View Less]

1 0