April 2015 - tor-commits - lists.torproject.org

[tor-browser/tor-browser-31.6.0esr-4.5-1] Bug 10761: Fix shutdown crashes on Windows
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit c9944b9ca97a238304b61e822d7509ec4ac85a12 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Apr 6 07:47:41 2015 +0000 Bug 10761: Fix shutdown crashes on Windows Jacek Caban gave us this patch which should fix the shutdown crashes on Windows (#10761 and #14454) as newer GCC/Binutils versions do not need the workaround anymore that got implemented back then in https://bugzilla.mozilla.org/show_bug.cgi?id=337887. --- security/nss/coreconf/WIN32.mk | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/security/nss/coreconf/WIN32.mk b/security/nss/coreconf/WIN32.mk index afece49..5c6cae0 100644 --- a/security/nss/coreconf/WIN32.mk +++ b/security/nss/coreconf/WIN32.mk @@ -94,10 +94,7 @@ endif DLL_SUFFIX = dll ifdef NS_USE_GCC - # The -mnop-fun-dllimport flag allows us to avoid a drawback of - # the dllimport attribute that a pointer to a function marked as - # dllimport cannot be used as as a constant address. - OS_CFLAGS += -mwindows -mms-bitfields -mnop-fun-dllimport + OS_CFLAGS += -mwindows -mms-bitfields _GEN_IMPORT_LIB=-Wl,--out-implib,$(IMPORT_LIBRARY) DLLFLAGS += -mwindows -o $@ -shared -Wl,--export-all-symbols $(if $(IMPORT_LIBRARY),$(_GEN_IMPORT_LIB)) ifdef BUILD_OPT

1 0

[tor-browser/tor-browser-31.6.0esr-4.5-1] Merge remote-tracking branch 'gk/bug_10761_v2' into tor-browser-31.6.0esr-4.5-1
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit e1a8bafb44367592bc982c2a65752ec439b515a6 Merge: 5ad57a0 c9944b9c Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Apr 15 22:16:33 2015 -0700 Merge remote-tracking branch 'gk/bug_10761_v2' into tor-browser-31.6.0esr-4.5-1 security/nss/coreconf/WIN32.mk | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)

1 0

[tor-browser/tor-browser-31.6.0esr-4.5-1] Revert "TB1: Add a string-based cacheKey."
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit 5ad57a0b24c85d19427eddebc2f647296063acfd Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Apr 15 22:07:27 2015 -0700 Revert "TB1: Add a string-based cacheKey." This reverts commit 53f8f2506cb21bf1847a4261ef383db9be55a93c. This used to be used by Torbutton/SafeCache, but we moved the cache isolation to direct C++ patches instead. --- netwerk/base/public/nsICachingChannel.idl | 7 ------- netwerk/protocol/http/nsHttpChannel.cpp | 23 ----------------------- netwerk/protocol/http/nsHttpChannel.h | 1 - 3 files changed, 31 deletions(-) diff --git a/netwerk/base/public/nsICachingChannel.idl b/netwerk/base/public/nsICachingChannel.idl index 09b1f75..9c1b0a6 100644 --- a/netwerk/base/public/nsICachingChannel.idl +++ b/netwerk/base/public/nsICachingChannel.idl @@ -64,13 +64,6 @@ interface nsICachingChannel : nsICacheInfoChannel */ attribute nsISupports cacheKey; - /** - * Set/get the cache domain... uniquely identifies the data in the cache - * for this channel. Holding a reference to this key does NOT prevent - * the cached data from being removed. - */ - attribute AUTF8String cacheDomain; - /************************************************************************** * Caching channel specific load flags: */ diff --git a/netwerk/protocol/http/nsHttpChannel.cpp b/netwerk/protocol/http/nsHttpChannel.cpp index 59ba71b..bba507e 100644 --- a/netwerk/protocol/http/nsHttpChannel.cpp +++ b/netwerk/protocol/http/nsHttpChannel.cpp @@ -3271,12 +3271,6 @@ nsHttpChannel::AssembleCacheKey(const char *spec, uint32_t postID, cacheKey.Append(buf); } - if (strlen(mCacheDomain.get()) > 0) { - cacheKey.AppendLiteral("domain="); - cacheKey.Append(mCacheDomain.get()); - cacheKey.AppendLiteral("&"); - } - if (!cacheKey.IsEmpty()) { cacheKey.AppendLiteral("uri="); } @@ -5563,23 +5557,6 @@ nsHttpChannel::SetCacheTokenCachedCharset(const nsACString &aCharset) PromiseFlatCString(aCharset).get()); } - -NS_IMETHODIMP -nsHttpChannel::GetCacheDomain(nsACString &value) -{ - value = mCacheDomain; - - return NS_OK; -} - -NS_IMETHODIMP -nsHttpChannel::SetCacheDomain(const nsACString &value) -{ - mCacheDomain = value; - - return NS_OK; -} - //----------------------------------------------------------------------------- // nsHttpChannel::nsICachingChannel //----------------------------------------------------------------------------- diff --git a/netwerk/protocol/http/nsHttpChannel.h b/netwerk/protocol/http/nsHttpChannel.h index a76ed8e..ef59c0b 100644 --- a/netwerk/protocol/http/nsHttpChannel.h +++ b/netwerk/protocol/http/nsHttpChannel.h @@ -354,7 +354,6 @@ private: nsCOMPtr<nsICacheEntry> mOfflineCacheEntry; uint32_t mOfflineCacheLastModifiedTime; nsCOMPtr<nsIApplicationCache> mApplicationCacheForWrite; - nsCString mCacheDomain; // auth specific data nsCOMPtr<nsIHttpChannelAuthProvider> mAuthProvider;

1 0

[translation/tor_animation_completed] Update translations for tor_animation_completed
by translation＠torproject.org 16 Apr '15

16 Apr '15

commit 2a7e96790608928174e4be5fe7e573f6e961bf32 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Apr 16 03:16:02 2015 +0000 Update translations for tor_animation_completed --- id.srt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/id.srt b/id.srt index 28d02b0..1961f01 100644 --- a/id.srt +++ b/id.srt @@ -160,5 +160,5 @@ seperti aktivists, journalists dan blogger. 35 00:02:04,000 --> 00:02:09,000 -Unduh dan gunakan Tor! Atau gunakan relay! +Unduh dan gunakan Tor! Atau gunakan relaynya!

1 0

[translation/tor_animation] Update translations for tor_animation
by translation＠torproject.org 16 Apr '15

16 Apr '15

commit 2b6c7de715abd4bdbea9607cd6fafc9f514a10d2 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Apr 16 03:15:54 2015 +0000 Update translations for tor_animation --- id.srt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/id.srt b/id.srt index 28d02b0..1961f01 100644 --- a/id.srt +++ b/id.srt @@ -160,5 +160,5 @@ seperti aktivists, journalists dan blogger. 35 00:02:04,000 --> 00:02:09,000 -Unduh dan gunakan Tor! Atau gunakan relay! +Unduh dan gunakan Tor! Atau gunakan relaynya!

1 0

[tor-browser/tor-browser-31.6.0esr-4.5-1] fixup! Bug #5856: Do not expose physical screen info via window & window.screen.
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit a5648c8d80f396caf294d761cc4a9a76c0b33a9d Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Apr 8 22:55:41 2015 -0700 fixup! Bug #5856: Do not expose physical screen info via window & window.screen. --- dom/base/nsGlobalWindow.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/dom/base/nsGlobalWindow.cpp b/dom/base/nsGlobalWindow.cpp index 9fc9c31..2f85d60 100644 --- a/dom/base/nsGlobalWindow.cpp +++ b/dom/base/nsGlobalWindow.cpp @@ -4867,9 +4867,9 @@ nsGlobalWindow::GetOuterSize(ErrorResult& aError) MOZ_ASSERT(IsOuterWindow()); if (!IsChrome()) { - CSSIntSize size; - aError = GetInnerSize(size); - return nsIntSize(size.width, size.height); + CSSIntSize size; + aError = GetInnerSize(size); + return nsIntSize(size.width, size.height); } nsCOMPtr<nsIBaseWindow> treeOwnerAsWin = GetTreeOwnerWindow(); @@ -5114,6 +5114,11 @@ nsGlobalWindow::GetDevicePixelRatio(ErrorResult& aError) { FORWARD_TO_OUTER_OR_THROW(GetDevicePixelRatio, (aError), aError, 0.0); + // For non-chrome callers, always return 1.0 to prevent fingerprinting. + if (!IsChrome()) { + return 1.0; + } + if (!mDocShell) { return 1.0; }

1 0

[tor-browser/tor-browser-31.6.0esr-4.5-1] Merge remote-tracking branch 'arthur/13875' into tor-browser-31.6.0esr-4.5-1
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit 4c5a59914a15fa0795575f1f0b9ebe957bc52c65 Merge: 1a6eb58 a5648c8 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Apr 15 18:41:42 2015 -0700 Merge remote-tracking branch 'arthur/13875' into tor-browser-31.6.0esr-4.5-1 dom/base/nsGlobalWindow.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)

1 0

[tor-browser/tor-browser-31.6.0esr-4.5-1] fixup! Bug #3455.2. Allow RFC1929 authentication (username/password) to SOCKS servers.
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit 44cd9b47cb74544aa6eac4b1b0f3d4474457c3dc Author: Georg Koppen <gk(a)torproject.org> Date: Tue Apr 14 10:27:02 2015 +0000 fixup! Bug #3455.2. Allow RFC1929 authentication (username/password) to SOCKS servers. --- netwerk/protocol/http/nsHttpConnectionInfo.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/netwerk/protocol/http/nsHttpConnectionInfo.cpp b/netwerk/protocol/http/nsHttpConnectionInfo.cpp index 2ef09b6..c602902 100644 --- a/netwerk/protocol/http/nsHttpConnectionInfo.cpp +++ b/netwerk/protocol/http/nsHttpConnectionInfo.cpp @@ -98,6 +98,11 @@ nsHttpConnectionInfo::SetOriginServer(const nsACString &host, int32_t port) // information so that a change in proxy config will mean this connection // is not reused + // NOTE: Adding the username and the password provides a means to isolate + // keep-alive to the URL bar domain as well: If the username is the URL bar + // domain, keep-alive connections are not reused by resources bound to + // different URL bar domains as the respective hash keys are not matching. + if ((!mUsingHttpProxy && ProxyHost()) || (mUsingHttpProxy && mUsingConnect)) { mHashKey.AppendLiteral(" (");

1 0

[tor-browser/tor-browser-31.6.0esr-4.5-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by mikeperry＠torproject.org 16 Apr '15

16 Apr '15

commit 1a6eb58a1d3cab67e371ac861d04ba526d4e6751 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Apr 14 10:31:39 2015 +0000 fixup! TB4: Tor Browser's Firefox preference overrides. We remove the keep-alive restriction now that we have isolation to the URL bar domain which is governing this as well (see: bug 4100). --- browser/app/profile/000-tor-browser.js | 1 - 1 file changed, 1 deletion(-) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 13bcf8e..192159b 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -132,7 +132,6 @@ pref("network.http.pipelining.maxrequests", 12); pref("network.http.pipelining.ssl", true); pref("network.http.proxy.pipelining", true); pref("security.ssl.enable_false_start", true); -pref("network.http.keep-alive.timeout", 20); pref("network.http.connection-retry-timeout", 0); pref("network.http.max-persistent-connections-per-proxy", 256); pref("network.http.pipelining.reschedule-timeout", 15000);

1 0

[translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties
by translation＠torproject.org 16 Apr '15

16 Apr '15

commit 737e0db0b6501c2249b640a2b513ac0dfdd17ca0 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Apr 16 00:46:00 2015 +0000 Update translations for torbutton-torbuttonproperties --- ro/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ro/torbutton.properties b/ro/torbutton.properties index cace1c7..d52df33 100644 --- a/ro/torbutton.properties +++ b/ro/torbutton.properties @@ -56,7 +56,7 @@ torbutton.popup.never_ask_again = Nu mai intreba din nou torbutton.popup.confirm_newnym = Tor Browser will close all windows and tabs. All website sessions will be lost.\n\nRestart Tor Browser now to reset your identity?\n\n torbutton.slider_notification = The green onion menu now has a security slider which lets you adjust your security level. Check it out! -torbutton.slider_notification_button = Open security settings +torbutton.slider_notification_button = Deschide setările de securitate torbutton.maximize_warning = Maximizing Tor Browser can allow websites to determine your monitor size, which can be used to track you. We recommend that you leave Tor Browser windows in their original default size.

1 0