February 2015 - tor-commits - lists.torproject.org

[bridgedb/master] Add unittests for the bridgedb.parse.options module.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit a235f2c5a81829720803cb8545f9f611e9bf547d Author: Isis Lovecruft <isis(a)torproject.org> Date: Thu Aug 21 04:25:06 2014 +0000 Add unittests for the bridgedb.parse.options module. --- lib/bridgedb/parse/options.py | 9 +-- lib/bridgedb/test/test_parse_options.py | 102 +++++++++++++++++++++++++++++++ 2 files changed, 107 insertions(+), 4 deletions(-) diff --git a/lib/bridgedb/parse/options.py b/lib/bridgedb/parse/options.py index 5664460..2ed93d0 100644 --- a/lib/bridgedb/parse/options.py +++ b/lib/bridgedb/parse/options.py @@ -121,7 +121,7 @@ def parseOptions(): print(uerr.message) print(options.getUsage()) sys.exit(1) - except Exception as error: + except Exception as error: # pragma: no cover exc, value, tb = sys.exc_info() print("Unhandled Error: %s" % error.message) print(traceback.format_exc(tb)) @@ -204,7 +204,7 @@ class BaseOptions(usage.Options): gRundir = os.getcwdu() setRundir(gRundir) - if not os.path.isdir(gRundir): + if not os.path.isdir(gRundir): # pragma: no cover raise usage.UsageError( "Could not change to runtime directory: `%s'" % gRundir) @@ -214,14 +214,15 @@ class BaseOptions(usage.Options): gConfig = config if not os.path.isabs(gConfig): - if gConfig.startswith('.'): # also covers '..' + # startswith('.') will handle other relative paths, i.e. '..' + if gConfig.startswith('.'): # pragma: no cover gConfig = os.path.abspath(os.path.expanduser(gConfig)) else: gConfig = os.path.join(gRundir, gConfig) setConfig(gConfig) gConfig = getConfig() - if not os.path.isfile(gConfig): + if not os.path.isfile(gConfig): # pragma: no cover raise usage.UsageError( "Specified config file `%s' doesn't exist!" % gConfig) diff --git a/lib/bridgedb/test/test_parse_options.py b/lib/bridgedb/test/test_parse_options.py new file mode 100644 index 0000000..fc76904 --- /dev/null +++ b/lib/bridgedb/test/test_parse_options.py @@ -0,0 +1,102 @@ +# -*- coding: utf-8 -*- +#_____________________________________________________________________________ +# +# This file is part of BridgeDB, a Tor bridge distribution system. +# +# :authors: Isis Lovecruft 0xA3ADB67A2CDB8B35 <isis(a)torproject.org> +# please also see AUTHORS file +# :copyright: (c) 2014, The Tor Project, Inc. +# (c) 2014, Isis Lovecruft +# :license: see LICENSE for licensing information +#_____________________________________________________________________________ + +"""Unittests for :mod:`bridgedb.parse.options`.""" + + +from __future__ import print_function + +import os +import sys + +from twisted.python.usage import UsageError +from twisted.trial import unittest + +from bridgedb.parse import options + + +class ParseOptionsTests(unittest.TestCase): + """Unittests for :mod:`bridgedb.parse.options`.""" + + def setUp(self): + """Replace the current sys.argv's for the run of this test, and + redirect sys.stdout to os.devnull to prevent the options parser from + printing the --help a bunch of times. + """ + # Make sure a config file is in the current directory, or else the + # argument parser will get angry and throw another SystemExit + # exception. + with open(os.path.join(os.getcwd(), 'bridgedb.conf'), 'a+') as fh: + fh.write('\n') + + self.oldSysArgv = sys.argv + self.oldStdout = sys.stdout + sys.stdout = open(os.devnull, 'w') + + def tearDown(self): + """Put the original sys.argv's back.""" + sys.stdout.close() # Actually closes the FD we opened for /dev/null + sys.argv = self.oldSysArgv + sys.stdout = self.oldStdout + self.oldSysArgv = None + self.oldStdout = None + + def test_parse_options_parseOptions_with_invalid_options(self): + """:func:`options.parseOptions` should raise SystemExit because + the args 'somearg anotherarg' are invalid commands. + """ + fakeSysArgv = ['somearg', 'anotherarg'] + sys.argv = fakeSysArgv + self.assertRaises(SystemExit, options.parseOptions) + + def test_parse_options_parseOptions_with_valid_options(self): + """:func:`options.parseOptions` should return a + :class:`options.MainOptions` when given valid commandline arguments. + """ + fakeSysArgv = ['bridgedb', 'mock', '-n', '-1'] + sys.argv = fakeSysArgv + opts = options.parseOptions() + self.assertIsInstance(opts, options.MainOptions) + + def test_parse_options_parseOptions_verbosity_quiet_quiet(self): + """If we use `-q` twice on the commandline, ``opts['verbosity']`` + should equal ``10``. + """ + fakeSysArgv = ['bridgedb', '-q', '-q', 'mock', '-n', '-1'] + sys.argv = fakeSysArgv + opts = options.parseOptions() + self.assertEqual(opts['verbosity'], 10) + + def test_parse_options_parseOptions_verbosity_verbose(self): + """If we use `-v` once on the commandline, ``opts['verbosity']`` + should equal ``50``. + """ + fakeSysArgv = ['bridgedb', '-v', '-v', 'mock', '-n', '-1'] + sys.argv = fakeSysArgv + opts = options.parseOptions() + self.assertEqual(opts['verbosity'], 50) + + def test_parse_options_parseOptions_rundir(self): + """The automatic rundir should be our current directory.""" + fakeSysArgv = ['bridgedb', 'mock', '-n', '-1'] + sys.argv = fakeSysArgv + opts = options.parseOptions() + self.assertEqual(opts['rundir'], os.getcwd()) + + def test_parse_options_parseOptions_version(self): + """:func:`options.parseOptions` when given a `--version` argument on + the commandline, should raise SystemExit (after printing some stuff, + but we don't care what it prints). + """ + fakeSysArgv = ['bridgedb', '--version'] + sys.argv = fakeSysArgv + self.assertRaises(SystemExit, options.parseOptions)

1 0

[bridgedb/master] Only run test_https.py tests if a BridgeDB process is already running.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit 1bfb9c5fce4b47bc7990a2565cbb153c991cfeb1 Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 05:42:56 2014 +0000 Only run test_https.py tests if a BridgeDB process is already running. --- lib/bridgedb/test/test_https.py | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/lib/bridgedb/test/test_https.py b/lib/bridgedb/test/test_https.py index 7b1c8c8..176b769 100644 --- a/lib/bridgedb/test/test_https.py +++ b/lib/bridgedb/test/test_https.py @@ -26,6 +26,10 @@ from __future__ import print_function from twisted.trial import unittest from BeautifulSoup import BeautifulSoup import mechanize +import os + +from bridgedb.test.util import processExists +from bridgedb.test.util import getBridgeDBPID HTTPS_ROOT = 'https://127.0.0.1:6789' CAPTCHA_RESPONSE = 'Tvx74Pmy' @@ -33,6 +37,11 @@ CAPTCHA_RESPONSE = 'Tvx74Pmy' class HTTPTests(unittest.TestCase): def setUp(self): + here = os.getcwd() + topdir = here.rstrip('_trial_temp') + self.rundir = os.path.join(topdir, 'run') + self.pidfile = os.path.join(self.rundir, 'bridgedb.pid') + self.pid = getBridgeDBPID(self.pidfile) self.br = None def tearDown(self): @@ -132,6 +141,9 @@ class HTTPTests(unittest.TestCase): return bridges def test_get_obfs2_ipv4(self): + if not self.pid or not processExists(self.pid): + raise SkipTest("Can't run test: no BridgeDB process running.") + self.openBrowser() self.goToOptionsPage() @@ -144,6 +156,9 @@ class HTTPTests(unittest.TestCase): self.assertEquals(PT, pt) def test_get_obfs3_ipv4(self): + if not self.pid or not processExists(self.pid): + raise SkipTest("Can't run test: no BridgeDB process running.") + self.openBrowser() self.goToOptionsPage() @@ -156,6 +171,9 @@ class HTTPTests(unittest.TestCase): self.assertEquals(PT, pt) def test_get_vanilla_ipv4(self): + if not self.pid or not processExists(self.pid): + raise SkipTest("Can't run test: no BridgeDB process running.") + self.openBrowser() self.goToOptionsPage() @@ -168,6 +186,9 @@ class HTTPTests(unittest.TestCase): self.assertTrue(bridge != None) def test_get_scramblesuit_ipv4(self): + if not self.pid or not processExists(self.pid): + raise SkipTest("Can't run test: no BridgeDB process running.") + self.openBrowser() self.goToOptionsPage()

1 0

[bridgedb/master] Fix yet another type error in test_Bucket.py.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit 7c6f68326a920ca6ee9f3089acc493690af303a2 Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 20 07:23:01 2014 +0000 Fix yet another type error in test_Bucket.py. --- lib/bridgedb/test/test_Bucket.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bridgedb/test/test_Bucket.py b/lib/bridgedb/test/test_Bucket.py index 5e39260..fa3bb7e 100644 --- a/lib/bridgedb/test/test_Bucket.py +++ b/lib/bridgedb/test/test_Bucket.py @@ -35,7 +35,7 @@ class BucketDataTest(unittest.TestCase): distname = "test-distributor" bucket = Bucket.BucketData(distname, needed) this(bucket.name).should.be.equal(distname) - this(bucket.needed).should.be.equal(Bucket.BUCKET_MAX_BRIDGES) + this(bucket.needed).should.be.equal(needed) def test_alloc_all_the_bridges(self): """Set the needed number of bridges to the default"""

1 0

[bridgedb/master] Bump Leekspin requirement to version 0.2.1.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit 41410f917297a8e667bfabf899477c300254c20f Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 03:22:40 2014 +0000 Bump Leekspin requirement to version 0.2.1. --- .test.requirements.txt | 2 +- .travis.requirements.txt | 2 +- setup.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.test.requirements.txt b/.test.requirements.txt index 12dfb7b..f1f85ab 100644 --- a/.test.requirements.txt +++ b/.test.requirements.txt @@ -6,7 +6,7 @@ # $ make coverage # coverage==3.7.1 -leekspin==0.2.0 +leekspin==0.2.1 mechanize==0.2.5 pep8==1.5.7 # pylint must be pinned until pylint bug #203 is fixed. See diff --git a/.travis.requirements.txt b/.travis.requirements.txt index 37b7bfe..b84396b 100644 --- a/.travis.requirements.txt +++ b/.travis.requirements.txt @@ -15,7 +15,7 @@ #------------------------------------------------------------------------------ coverage==3.7.1 coveralls==0.4.2 -leekspin==0.2.0 +leekspin==0.2.1 mechanize==0.2.5 pep8==1.5.7 # pylint must be pinned until pylint bug #203 is fixed. See diff --git a/setup.py b/setup.py index cc2bd32..e3463c9 100644 --- a/setup.py +++ b/setup.py @@ -285,7 +285,7 @@ setuptools.setup( scripts=['scripts/bridgedb'], extras_require={'test': ["sure==1.2.2", "coverage==3.7.1", - "leekspin==0.2.0"]}, + "leekspin==0.2.1"]}, zip_safe=False, cmdclass=get_cmdclass(), include_package_data=True,

1 0

[bridgedb/master] Add missing SkipTest import in test_https.py.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit 4deffa3ebdd6214714ad106ed6e342fecb53b087 Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 05:58:25 2014 +0000 Add missing SkipTest import in test_https.py. --- lib/bridgedb/test/test_https.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/bridgedb/test/test_https.py b/lib/bridgedb/test/test_https.py index 95c2be8..b8034d8 100644 --- a/lib/bridgedb/test/test_https.py +++ b/lib/bridgedb/test/test_https.py @@ -28,7 +28,9 @@ import mechanize import os from BeautifulSoup import BeautifulSoup + from twisted.trial import unittest +from twisted.trial.unittest import SkipTest from bridgedb.test.util import processExists from bridgedb.test.util import getBridgeDBPID

1 0

[bridgedb/master] Merge branch 'fix/9874-https' into develop
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit a580c4ba0d30f55546d3d181d7ea878e6a13133c Merge: 9729bd1 4deffa3 Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 05:59:17 2014 +0000 Merge branch 'fix/9874-https' into develop lib/bridgedb/test/test_https.py | 2 ++ 1 file changed, 2 insertions(+)

1 0

[bridgedb/master] Document parameter in bridgedb.test.util.processExists().
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit f5360f503b280b56c58488c8ecb215f0952f2927 Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 05:33:50 2014 +0000 Document parameter in bridgedb.test.util.processExists(). --- lib/bridgedb/test/util.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bridgedb/test/util.py b/lib/bridgedb/test/util.py index 8627281..4c6f795 100644 --- a/lib/bridgedb/test/util.py +++ b/lib/bridgedb/test/util.py @@ -66,8 +66,9 @@ def fileCheckDecorator(func): return wrapper def processExists(pid): - """Test if **pid** exists. + """Test if the process with **pid** exists. + :param int pid: An integer specifying the process ID. :raises: OSError, if ``OSError.errno`` wasn't an expected errno (according to the "ERRORS" section from ``man 2 kill``). :rtype: bool

1 0

[bridgedb/master] Rename pidExists() to processExists() in bridgedb.test.util.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit e4a406b9533e8e1e9295a9369ebb796e7655691e Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 05:31:39 2014 +0000 Rename pidExists() to processExists() in bridgedb.test.util. --- lib/bridgedb/test/test_bridgedb.py | 2 +- lib/bridgedb/test/util.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/bridgedb/test/test_bridgedb.py b/lib/bridgedb/test/test_bridgedb.py index 8627aed..750ddd4 100644 --- a/lib/bridgedb/test/test_bridgedb.py +++ b/lib/bridgedb/test/test_bridgedb.py @@ -20,7 +20,7 @@ import time from twisted.trial import unittest from twisted.trial.unittest import SkipTest -from bridgedb.test.util import pidExists +from bridgedb.test.util import processExists from bridgedb.test.util import getBridgeDBPID diff --git a/lib/bridgedb/test/util.py b/lib/bridgedb/test/util.py index 287fa26..8627281 100644 --- a/lib/bridgedb/test/util.py +++ b/lib/bridgedb/test/util.py @@ -65,7 +65,7 @@ def fileCheckDecorator(func): % (str(description), dst, src)) return wrapper -def pidExists(pid): +def processExists(pid): """Test if **pid** exists. :raises: OSError, if ``OSError.errno`` wasn't an expected errno (according

1 0

[bridgedb/master] Merge branch 'fix/9874-https' into develop
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit 9566aa05021f68523a974eb1d7f5ddd57cb3e4cf Merge: 9729bd1 4deffa3 Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Aug 27 05:59:17 2014 +0000 Merge branch 'fix/9874-https' into develop lib/bridgedb/test/test_https.py | 2 ++ 1 file changed, 2 insertions(+)

1 0

[bridgedb/master] Add unittests for bridgedb.bridgerequest.
by isis＠torproject.org 03 Feb '15

03 Feb '15

commit 1e7e8324ddb113920348990172e194440f322f55 Author: Isis Lovecruft <isis(a)torproject.org> Date: Thu Aug 21 02:42:14 2014 +0000 Add unittests for bridgedb.bridgerequest. --- lib/bridgedb/test/test_bridgerequest.py | 44 +++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/lib/bridgedb/test/test_bridgerequest.py b/lib/bridgedb/test/test_bridgerequest.py new file mode 100644 index 0000000..1db8814 --- /dev/null +++ b/lib/bridgedb/test/test_bridgerequest.py @@ -0,0 +1,44 @@ +# -*- coding: utf-8 -*- +#_____________________________________________________________________________ +# +# This file is part of BridgeDB, a Tor bridge distribution system. +# +# :authors: Isis Lovecruft 0xA3ADB67A2CDB8B35 <isis(a)torproject.org> +# please also see AUTHORS file +# :copyright: (c) 2007-2014, The Tor Project, Inc. +# (c) 2014, Isis Lovecruft +# :license: see LICENSE for licensing information +#_____________________________________________________________________________ + + +from twisted.trial import unittest + +from bridgedb import bridgerequest +from bridgedb.bridgerequest import IBridgeRequest +from bridgedb.bridgerequest import BridgeRequestBase + + +class BridgeRequestBaseTests(unittest.TestCase): + """Unittests for :class:`bridgedb.bridgerequest.BridgeRequestBase`.""" + + def setUp(self): + """Setup test run.""" + self.request = BridgeRequestBase() + + def test_BridgeRequestBase_implements_IRequestBridges(self): + """BridgeRequestBase should implement IRequestBridges interface.""" + self.assertTrue(IBridgeRequest.implementedBy(BridgeRequestBase)) + + def test_BridgeRequestBase_withoutBlockInCountry(self): + """BridgeRequestBase.withoutBlockInCountry() should add the country CC + to the ``notBlockedIn`` attribute. + """ + self.request.withoutBlockInCountry('US') + self.assertIn('US', self.request.notBlockedIn) + + def test_BridgeRequestBase_withPluggableTransportType(self): + """BridgeRequestBase.withPluggableTransportType() should add the + pluggable transport type to the ``transport`` attribute. + """ + self.request.withPluggableTransportType('huggable-transport') + self.assertIn('huggable-transport', self.request.transports)

1 0