November 2015 - tor-commits - lists.torproject.org

[depictor/master] Download from authorities in serial
by tom＠torproject.org 05 Nov '15

05 Nov '15

commit 53739518034d04b271fc810fd7d5f862e909f0b4 Author: Tom Ritter <tom(a)ritter.vg> Date: Thu Nov 5 16:25:41 2015 -0600 Download from authorities in serial This mirrors doctor's patch here: https://gitweb.torproject.org/doctor.git/commit/?id=b2772926bbf9b5f1565b07b… Downloading from authorities in parallell is throwing off the download times. It will take a week to get correct times into the page though... --- write_website.py | 15 +++++++-------- 1 file changed, … [View More]

1 0

[tor/master] Fix SipHash-2-4 performance for non multiple of 8 buffers.
by nickm＠torproject.org 05 Nov '15

05 Nov '15

commit b71f6d6a47af96f5fab5d139e585739b078ea54a Author: Yawning Angel <yawning(a)schwanenlied.me> Date: Thu Nov 5 18:21:43 2015 +0000 Fix SipHash-2-4 performance for non multiple of 8 buffers. Code cribbed from Andrew Moon's Public Domain SipHash-2-4 implementation (which IMO is also cleaner). Fixes bug 17544. --- changes/bug17544 | 4 ++++ src/ext/csiphash.c | 57 ++++++++++++++++++---------------------------------- 2 files changed, 24 insertions(+), … [View More]37 deletions(-) diff --git a/changes/bug17544 b/changes/bug17544 new file mode 100644 index 0000000..4316d07 --- /dev/null +++ b/changes/bug17544 @@ -0,0 +1,4 @@ + o Minor bugfix (SipHash-2-4 performance): + - Improve performance when hashing non-multiple of 8 sized buffers, + based on Andrew Moon's Public Domain SipHash-2-4 implementation. + Fixes bug 17544; bugfix on 0.2.5.3-alpha. diff --git a/src/ext/csiphash.c b/src/ext/csiphash.c index 27c5358..b60f73a 100644 --- a/src/ext/csiphash.c +++ b/src/ext/csiphash.c @@ -97,65 +97,48 @@ #endif uint64_t siphash24(const void *src, unsigned long src_sz, const struct sipkey *key) { + const uint8_t *m = src; uint64_t k0 = key->k0; uint64_t k1 = key->k1; - uint64_t b = (uint64_t)src_sz << 56; -#ifdef UNALIGNED_OK - const uint64_t *in = (uint64_t*)src; -#else - /* On platforms where alignment matters, if 'in' is a pointer to a - * datatype that must be aligned, the compiler is allowed to - * generate code that assumes that it is aligned as such. - */ - const uint8_t *in = (uint8_t *)src; -#endif - - uint64_t t; - uint8_t *pt, *m; + uint64_t last7 = (uint64_t)(src_sz & 0xff) << 56; + size_t i, blocks; uint64_t v0 = k0 ^ 0x736f6d6570736575ULL; uint64_t v1 = k1 ^ 0x646f72616e646f6dULL; uint64_t v2 = k0 ^ 0x6c7967656e657261ULL; uint64_t v3 = k1 ^ 0x7465646279746573ULL; - while (src_sz >= 8) { + for (i = 0, blocks = (src_sz & ~7); i < blocks; i+= 8) { #ifdef UNALIGNED_OK - uint64_t mi = _le64toh(*in); - in += 1; + uint64_t mi = _le64toh(*(m + i)); #else uint64_t mi; - memcpy(&mi, in, 8); + memcpy(&mi, m + i, 8); mi = _le64toh(mi); - in += 8; #endif - src_sz -= 8; v3 ^= mi; DOUBLE_ROUND(v0,v1,v2,v3); v0 ^= mi; } - t = 0; pt = (uint8_t*)&t; m = (uint8_t*)in; - switch (src_sz) { - case 7: pt[6] = m[6]; - case 6: pt[5] = m[5]; - case 5: pt[4] = m[4]; -#ifdef UNALIGNED_OK - case 4: *((uint32_t*)&pt[0]) = *((uint32_t*)&m[0]); break; -#else - case 4: pt[3] = m[3]; -#endif - case 3: pt[2] = m[2]; - case 2: pt[1] = m[1]; - case 1: pt[0] = m[0]; + switch (src_sz - blocks) { + case 7: last7 |= (uint64_t)m[i + 6] << 48; + case 6: last7 |= (uint64_t)m[i + 5] << 40; + case 5: last7 |= (uint64_t)m[i + 4] << 32; + case 4: last7 |= (uint64_t)m[i + 3] << 24; + case 3: last7 |= (uint64_t)m[i + 2] << 16; + case 2: last7 |= (uint64_t)m[i + 1] << 8; + case 1: last7 |= (uint64_t)m[i + 0] ; + case 0: + default:; } - b |= _le64toh(t); - - v3 ^= b; + v3 ^= last7; DOUBLE_ROUND(v0,v1,v2,v3); - v0 ^= b; v2 ^= 0xff; + v0 ^= last7; + v2 ^= 0xff; DOUBLE_ROUND(v0,v1,v2,v3); DOUBLE_ROUND(v0,v1,v2,v3); - return (v0 ^ v1) ^ (v2 ^ v3); + return v0 ^ v1 ^ v2 ^ v3; } [View Less]

1 0

[translation/tor-messenger-ircproperties] Update translations for tor-messenger-ircproperties
by translation＠torproject.org 05 Nov '15

05 Nov '15

commit 79243d70d8746635821b3041870b17cd8d8dd52c Author: Translation commit bot <translation(a)torproject.org> Date: Thu Nov 5 22:16:32 2015 +0000 Update translations for tor-messenger-ircproperties --- lt/irc.properties | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lt/irc.properties b/lt/irc.properties index d881f2a..539d445 100644 --- a/lt/irc.properties +++ b/lt/irc.properties @@ -14,12 +14,12 @@ irc.usernameHint=nick connection.error.lost=… [View More]

1 0

[translation/tails-persistence-setup] Update translations for tails-persistence-setup
by translation＠torproject.org 05 Nov '15

05 Nov '15

commit 245d2db9066108361cc976585680931ec848fd73 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Nov 5 22:15:21 2015 +0000 Update translations for tails-persistence-setup --- lt/lt.po | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lt/lt.po b/lt/lt.po index 63a5ee7..adbb267 100644 --- a/lt/lt.po +++ b/lt/lt.po @@ -9,8 +9,8 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)… [View More]

1 0

[translation/torbutton-aboutdialogdtd] Update translations for torbutton-aboutdialogdtd
by translation＠torproject.org 05 Nov '15

05 Nov '15

commit 4d29e6d9913e9c4b491f007628766f18d0baf010 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Nov 5 21:46:16 2015 +0000 Update translations for torbutton-aboutdialogdtd --- lt/aboutdialog.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lt/aboutdialog.dtd b/lt/aboutdialog.dtd index abda747..a96bcaa 100644 --- a/lt/aboutdialog.dtd +++ b/lt/aboutdialog.dtd @@ -3,7 +3,7 @@ <!ENTITY project.tpoLink "the &… [View More]

1 0

[translation/abouttor-homepage] Update translations for abouttor-homepage
by translation＠torproject.org 05 Nov '15

05 Nov '15

commit f563ed0f9cb4f583a13a93252d9699b98e0958e5 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Nov 5 21:45:51 2015 +0000 Update translations for abouttor-homepage --- lt/aboutTor.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lt/aboutTor.dtd b/lt/aboutTor.dtd index ea685a9..5f20b58 100644 --- a/lt/aboutTor.dtd +++ b/lt/aboutTor.dtd @@ -15,7 +15,7 @@ <!ENTITY aboutTor.success.label "Congratulations!"> <!ENTITY aboutTor.… [View More]

1 0

[translation/tails-greeter_completed] Update translations for tails-greeter_completed
by translation＠torproject.org 05 Nov '15

05 Nov '15

commit 604c31e6957fe74e847ab11f6160debc15b65382 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Nov 5 21:45:31 2015 +0000 Update translations for tails-greeter_completed --- lt/lt.po | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lt/lt.po b/lt/lt.po index 7be4920..71b86f8 100644 --- a/lt/lt.po +++ b/lt/lt.po @@ -13,9 +13,9 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" -"POT-… [View More]

1 0

[translation/tails-greeter] Update translations for tails-greeter
by translation＠torproject.org 05 Nov '15

05 Nov '15

commit 69193c3b3778bf0a7f0d6032cd0ec724cb58cf1b Author: Translation commit bot <translation(a)torproject.org> Date: Thu Nov 5 21:45:24 2015 +0000 Update translations for tails-greeter --- lt/lt.po | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lt/lt.po b/lt/lt.po index 4f69f0b..71b86f8 100644 --- a/lt/lt.po +++ b/lt/lt.po @@ -13,9 +13,9 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: … [View More]

1 0

[webwml/master] Adding hardened builds to the website
by gk＠torproject.org 05 Nov '15

05 Nov '15

commit 4e93dae28b6706fefa32b1cc133795782367b675 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 5 20:40:47 2015 +0000 Adding hardened builds to the website --- projects/en/torbrowser.wml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/projects/en/torbrowser.wml b/projects/en/torbrowser.wml index 0f8d694..e567eac 100644 --- a/projects/en/torbrowser.wml +++ b/projects/en/torbrowser.wml @@ -525,6 +525,30 @@ </table> </… [View More]

1 0

[webwml/master] Adding hardened release to recommended versions
by gk＠torproject.org 05 Nov '15

05 Nov '15

commit a95b5fc6ee77a984af1d392f9c620d617a4c8309 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 5 20:10:21 2015 +0000 Adding hardened release to recommended versions --- projects/torbrowser/RecommendedTBBVersions | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/projects/torbrowser/RecommendedTBBVersions b/projects/torbrowser/RecommendedTBBVersions index 87731c3..3beaf87 100644 --- a/projects/torbrowser/RecommendedTBBVersions +++ b/projects/… [View More]

1 0