September 2014 - tor-commits - lists.torproject.org

[tor/master] Rename socks5 error code setting function again
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit fcebc8da95af5ccb28d715a6897566ea1c190a03 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 29 09:17:20 2014 -0400 Rename socks5 error code setting function again I'd prefer not to use the name "send" for any function that doesn't really send things. --- src/or/buffers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/or/buffers.c b/src/or/buffers.c index edb64ec..d174f81 100644 --- a/src/or/buffers.c +++ b/src/or/buffers.c @@ -55,7 +55,7 @@ * forever. */ -static void send_socks5_error(socks_request_t *req, +static void socks_request_set_socks5_error(socks_request_t *req, socks5_reply_status_t reason); static int parse_socks(const char *data, size_t datalen, socks_request_t *req, @@ -1838,7 +1838,7 @@ fetch_ext_or_command_from_evbuffer(struct evbuffer *buf, ext_or_cmd_t **out) * have Tor send it as error response to <b>req</b>. */ static void -send_socks5_error(socks_request_t *req, +socks_request_set_socks5_error(socks_request_t *req, socks5_reply_status_t reason) { req->replylen = 10; @@ -1984,7 +1984,7 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req, req->command != SOCKS_COMMAND_RESOLVE && req->command != SOCKS_COMMAND_RESOLVE_PTR) { /* not a connect or resolve or a resolve_ptr? we don't support it. */ - send_socks5_error(req,SOCKS5_COMMAND_NOT_SUPPORTED); + socks_request_set_socks5_error(req,SOCKS5_COMMAND_NOT_SUPPORTED); log_warn(LD_APP,"socks5: command %d not recognized. Rejecting.", req->command);

1 0

[tor/master] Merge branch 'bug12971_take2_squashed'
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit 11ebbf5e88a55c15bdec0d16f0f60b24ee747fc9 Merge: 5e8cc76 fcebc8d Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 29 09:18:03 2014 -0400 Merge branch 'bug12971_take2_squashed' changes/bug12971 | 5 +++++ src/or/buffers.c | 20 ++++++++++++++++++++ src/test/test_socks.c | 18 ++++++++++++++---- 3 files changed, 39 insertions(+), 4 deletions(-)

1 0

[tor/master] Do not launch pluggable transport plugins when DisableNetwork is set.
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit fa60a64088ace76aa2a3c1a8347ee32d4bd3ee21 Author: Yawning Angel <yawning(a)schwanenlied.me> Date: Wed Sep 24 09:39:15 2014 +0000 Do not launch pluggable transport plugins when DisableNetwork is set. When DisableNetwork is set, do not launch pluggable transport plugins, and if any are running already, terminate the existing instances. Resolves ticket 13213. --- changes/bug13213 | 4 ++++ src/or/config.c | 32 +++++++++++++++++--------------- 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/changes/bug13213 b/changes/bug13213 new file mode 100644 index 0000000..6dae8b0 --- /dev/null +++ b/changes/bug13213 @@ -0,0 +1,4 @@ + o Minor bugfixes (Bridges): + - When DisableNetwork is set, do not launch pluggable transport + plugins, and if any are running already, terminate the existing + instances. Resolves ticket 13213. diff --git a/src/or/config.c b/src/or/config.c index 16acec7..8f4fc39 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -1399,24 +1399,26 @@ options_act(const or_options_t *old_options) mark_transport_list(); pt_prepare_proxy_list_for_config_read(); - if (options->ClientTransportPlugin) { - for (cl = options->ClientTransportPlugin; cl; cl = cl->next) { - if (parse_client_transport_line(options, cl->value, 0)<0) { - log_warn(LD_BUG, - "Previously validated ClientTransportPlugin line " - "could not be added!"); - return -1; + if (!options->DisableNetwork) { + if (options->ClientTransportPlugin) { + for (cl = options->ClientTransportPlugin; cl; cl = cl->next) { + if (parse_client_transport_line(options, cl->value, 0)<0) { + log_warn(LD_BUG, + "Previously validated ClientTransportPlugin line " + "could not be added!"); + return -1; + } } } - } - if (options->ServerTransportPlugin && server_mode(options)) { - for (cl = options->ServerTransportPlugin; cl; cl = cl->next) { - if (parse_server_transport_line(options, cl->value, 0)<0) { - log_warn(LD_BUG, - "Previously validated ServerTransportPlugin line " - "could not be added!"); - return -1; + if (options->ServerTransportPlugin && server_mode(options)) { + for (cl = options->ServerTransportPlugin; cl; cl = cl->next) { + if (parse_server_transport_line(options, cl->value, 0)<0) { + log_warn(LD_BUG, + "Previously validated ServerTransportPlugin line " + "could not be added!"); + return -1; + } } } }

1 0

[tor/master] Merge remote-tracking branch 'yawning/bug13213'
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit dc019b06548e49ce4ea2a1501715985b648f2606 Merge: 56f92ca fa60a64 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 29 08:57:19 2014 -0400 Merge remote-tracking branch 'yawning/bug13213' changes/bug13213 | 4 ++++ src/or/config.c | 32 +++++++++++++++++--------------- 2 files changed, 21 insertions(+), 15 deletions(-)

1 0

[tor/master] Improving error message.
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit f20c72f45647cf869f02a60addc9e079760ee763 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sun Sep 28 18:09:25 2014 +0300 Improving error message. --- changes/bug13228 | 5 +++++ configure.ac | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/changes/bug13228 b/changes/bug13228 new file mode 100644 index 0000000..0de013c --- /dev/null +++ b/changes/bug13228 @@ -0,0 +1,5 @@ + o Build fixes: + - Improve configure script error message to make it clear + that compilation has failed and that user has to either + add --disable-asciidoc argument or install asciidoc. + Resolves ticket 13228. diff --git a/configure.ac b/configure.ac index bd46a7c..73499c2 100644 --- a/configure.ac +++ b/configure.ac @@ -1599,7 +1599,9 @@ if test x$asciidoc = xtrue && test "$ASCIIDOC" = "none" ; then if ! [[ -f "$srcdir/$file.1.in" ]] || ! [[ -f "$srcdir/$file.html.in" ]] ; then echo "=================================="; echo; - echo "You need asciidoc installed to be able to build the manpage."; + echo "Building Tor has failed since manpages cannot be built."; + echo; + echo "You need asciidoc installed to be able to build the manpages."; echo "To build without manpages, use the --disable-asciidoc argument"; echo "when calling configure."; echo;

1 0

[tor/master] Merge remote-tracking branch 'rl1987/bug13228'
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit 56f92ca02d2fb972bc476f235a545b3dc764f58d Merge: b45bfba f20c72f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 29 08:55:17 2014 -0400 Merge remote-tracking branch 'rl1987/bug13228' changes/bug13228 | 5 +++++ configure.ac | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-)

1 0

[tor/master] Whitespace fixes
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit b45bfba2ce3754aa8107717e638b325dd30f05ed Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Sep 29 08:48:22 2014 -0400 Whitespace fixes --- src/or/config.c | 1 - src/test/test_crypto.c | 13 ++++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/or/config.c b/src/or/config.c index 16acec7..3d9e1d2 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -1676,7 +1676,6 @@ options_act(const or_options_t *old_options) connection_or_update_token_buckets(get_connection_array(), options); } - /* Only collect directory-request statistics on relays and bridges. */ options->DirReqStatistics = options->DirReqStatistics_option && server_mode(options); diff --git a/src/test/test_crypto.c b/src/test/test_crypto.c index 32ea2f6..795c603 100644 --- a/src/test/test_crypto.c +++ b/src/test/test_crypto.c @@ -1051,7 +1051,8 @@ test_crypto_pwbox(void *arg) (void)arg; for (i = 0; i < ARRAY_LENGTH(flags); ++i) { - tt_int_op(0, ==, crypto_pwbox(&boxed, &len, (const uint8_t*)msg, strlen(msg), + tt_int_op(0, ==, crypto_pwbox(&boxed, &len, + (const uint8_t*)msg, strlen(msg), pw, strlen(pw), flags[i])); tt_assert(boxed); tt_assert(len > 128+32); @@ -1065,13 +1066,16 @@ test_crypto_pwbox(void *arg) tor_free(decoded); - tt_int_op(UNPWBOX_BAD_SECRET, ==, crypto_unpwbox(&decoded, &dlen, boxed, len, + tt_int_op(UNPWBOX_BAD_SECRET, ==, crypto_unpwbox(&decoded, &dlen, + boxed, len, pw, strlen(pw)-1)); boxed[len-1] ^= 1; - tt_int_op(UNPWBOX_BAD_SECRET, ==, crypto_unpwbox(&decoded, &dlen, boxed, len, + tt_int_op(UNPWBOX_BAD_SECRET, ==, crypto_unpwbox(&decoded, &dlen, + boxed, len, pw, strlen(pw))); boxed[0] = 255; - tt_int_op(UNPWBOX_CORRUPTED, ==, crypto_unpwbox(&decoded, &dlen, boxed, len, + tt_int_op(UNPWBOX_CORRUPTED, ==, crypto_unpwbox(&decoded, &dlen, + boxed, len, pw, strlen(pw))); tor_free(boxed); @@ -1080,7 +1084,6 @@ test_crypto_pwbox(void *arg) done: tor_free(boxed); tor_free(decoded); - } /** Test AES-CTR encryption and decryption with IV. */

1 0

[metrics-db/master] Fix link to directory key certificates.
by karsten＠torproject.org 29 Sep '14

29 Sep '14

commit 2d40d1b77fd4bd858751fa37cf3649df3afbe405 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Mon Sep 29 09:11:08 2014 +0200 Fix link to directory key certificates. Spotted by cypherpunks, resolves #13265. --- web/formats.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/formats.html b/web/formats.html index 9b8ba5c..b5d56da 100644 --- a/web/formats.html +++ b/web/formats.html @@ -126,7 +126,7 @@ Vote documents are by far the largest documents provided here. </p> <h3>Directory key certificates -(<a href="archive/relay-descriptors/certs.xz">archive</a>) +(<a href="archive/relay-descriptors/certs.tar.xz">archive</a>) <span class="type-annotation"><tt>@type dir-key-certificate-3 1.0</tt></span> </h3> @@ -136,7 +136,7 @@ The directory authorities sign their votes and the consensus with their key that they publish in a key certificate. These key certificates change once every few months, so they are only available in the -<a href="archive/relay-descriptors/certs.xz">archive</a>. +<a href="archive/relay-descriptors/certs.tar.xz">archive</a>. </p> <h3>Microdescriptor consensuses

1 0

[tor/master] Stop test & bench build failures with --disable-curve25519
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit ffd92e8ef885f4a63fd09892d508674c9b4a1daf Author: teor <teor2345(a)gmail.com> Date: Mon Sep 29 12:06:15 2014 +1000 Stop test & bench build failures with --disable-curve25519 Ensure test & bench code that references curve25519 is disabled by the appropriate macros. tor now builds with and without --disable-curve25519. --- changes/bug13285-disable-curve25519-build-errors | 3 +++ src/test/bench.c | 4 ++-- src/test/test_crypto.c | 5 ++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/changes/bug13285-disable-curve25519-build-errors b/changes/bug13285-disable-curve25519-build-errors new file mode 100644 index 0000000..285b642 --- /dev/null +++ b/changes/bug13285-disable-curve25519-build-errors @@ -0,0 +1,3 @@ + o Minor bugfixes: + - Stop test & bench build failures with --disable-curve25519. + Fixes bug 13285. diff --git a/src/test/bench.c b/src/test/bench.c index 98e45d2..1204854 100644 --- a/src/test/bench.c +++ b/src/test/bench.c @@ -236,7 +236,6 @@ bench_onion_ntor(void) ntor_handshake_state_free(state); dimap_free(keymap, NULL); } -#endif static void bench_ed25519(void) @@ -294,6 +293,7 @@ bench_ed25519(void) printf("Blind a public key: %.2f usec\n", MICROCOUNT(start, end, iters)); } +#endif static void bench_cell_aes(void) @@ -575,8 +575,8 @@ static struct benchmark_t benchmarks[] = { ENT(onion_TAP), #ifdef CURVE25519_ENABLED ENT(onion_ntor), -#endif ENT(ed25519), +#endif ENT(cell_aes), ENT(cell_ops), ENT(dh), diff --git a/src/test/test_crypto.c b/src/test/test_crypto.c index 0c87c88..32ea2f6 100644 --- a/src/test/test_crypto.c +++ b/src/test/test_crypto.c @@ -13,9 +13,9 @@ #include "siphash.h" #ifdef CURVE25519_ENABLED #include "crypto_curve25519.h" +#endif #include "crypto_ed25519.h" #include "ed25519_vectors.inc" -#endif #include "crypto_s2k.h" #include "crypto_pwbox.h" @@ -1697,8 +1697,6 @@ test_crypto_ed25519_test_vectors(void *arg) tor_free(mem_op_hex_tmp); } -#endif - static void test_crypto_ed25519_encode(void *arg) { @@ -1875,6 +1873,7 @@ test_crypto_ed25519_testvectors(void *arg) done: tor_free(mem_op_hex_tmp); } +#endif /* CURVE25519_ENABLED */ static void test_crypto_siphash(void *arg)

1 0

[tor/master] Stop signed left shifts overflowing in ed25519: Macros
by nickm＠torproject.org 29 Sep '14

29 Sep '14

commit 6b155dc1a6c7c7bd345514a31288c260e4588216 Author: teor <teor2345(a)gmail.com> Date: Sun Sep 28 20:34:21 2014 -0400 Stop signed left shifts overflowing in ed25519: Macros The macros let us use unsigned types for potentially overflowing left shifts. Create SHL32() and SHL64() and SHL8() macros for convenience. --- src/ext/ed25519/ref10/crypto_int32.h | 22 ++++++++++++++++++++++ src/ext/ed25519/ref10/crypto_int64.h | 20 ++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/src/ext/ed25519/ref10/crypto_int32.h b/src/ext/ed25519/ref10/crypto_int32.h index cd5c7c2..dd13c91 100644 --- a/src/ext/ed25519/ref10/crypto_int32.h +++ b/src/ext/ed25519/ref10/crypto_int32.h @@ -1,3 +1,25 @@ /* Added for Tor. */ + +#ifndef CRYPTO_INT32_H +#define CRYPTO_INT32_H + #include "torint.h" #define crypto_int32 int32_t +#define crypto_uint32 uint32_t + +/* + Stop signed left shifts overflowing + by using unsigned types for bitwise operations + */ + +#ifndef OVERFLOW_SAFE_SIGNED_LSHIFT +#define OVERFLOW_SAFE_SIGNED_LSHIFT(s, lshift, utype, stype) \ + ((stype)((utype)(s) << (utype)(lshift))) +#endif + +#define SHL32(s, lshift) \ + OVERFLOW_SAFE_SIGNED_LSHIFT(s, lshift, crypto_uint32, crypto_int32) +#define SHL8(s, lshift) \ + OVERFLOW_SAFE_SIGNED_LSHIFT(s, lshift, unsigned char, signed char) + +#endif /* CRYPTO_INT32_H */ diff --git a/src/ext/ed25519/ref10/crypto_int64.h b/src/ext/ed25519/ref10/crypto_int64.h index de0b602..46e8852 100644 --- a/src/ext/ed25519/ref10/crypto_int64.h +++ b/src/ext/ed25519/ref10/crypto_int64.h @@ -1,3 +1,23 @@ /* Added for Tor. */ + +#ifndef CRYPTO_INT64_H +#define CRYPTO_INT64_H + #include "torint.h" #define crypto_int64 int64_t +#define crypto_uint64 uint64_t + +/* + Stop signed left shifts overflowing + by using unsigned types for bitwise operations + */ + +#ifndef OVERFLOW_SAFE_SIGNED_LSHIFT +#define OVERFLOW_SAFE_SIGNED_LSHIFT(s, lshift, utype, stype) \ + ((stype)((utype)(s) << (utype)(lshift))) +#endif + +#define SHL64(s, lshift) \ + OVERFLOW_SAFE_SIGNED_LSHIFT(s, lshift, crypto_uint64, crypto_int64) + +#endif /* CRYPTO_INT64_H */

1 0