May 2012 - tor-commits - lists.torproject.org

[torbutton/master] Release script + doc updates.
by mikeperry＠torproject.org 31 May '12

31 May '12

commit 03b74562a4b2137769582816c1dc83b3d792bd77 Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Thu May 31 15:17:37 2012 -0700 Release script + doc updates. --- README.RELEASE | 14 ++++++++++++-- trans_tools/validate.py | 2 +- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/README.RELEASE b/README.RELEASE index f386760..aa6e9ca 100644 --- a/README.RELEASE +++ b/README.RELEASE @@ -5,7 +5,7 @@ #. Decide the version number. - export … [View More]

1 0

[torbutton/master] New strings from transifex.
by mikeperry＠torproject.org 31 May '12

31 May '12

commit 8354d3a5aa096effec63df4544d4e4da382817fe Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Thu May 31 15:17:13 2012 -0700 New strings from transifex. --- src/chrome/locale/af/torbutton.dtd | 2 +- src/chrome/locale/af/torbutton.properties | 3 + src/chrome/locale/ak/torbutton.dtd | 2 +- src/chrome/locale/ak/torbutton.properties | 3 + src/chrome/locale/am/torbutton.dtd | 2 +- src/chrome/locale/am/torbutton.properties … [View More]

1 0

r25663: {translation} New torbutton strings. (in translation/trunk/projects/torbutton/po: ar ca cs cy da de el eo es et eu fa fi fr gu he hi hr hu id it ja my nb nl pl pt pt_BR ro ru sk sl sr sv th tr uk vi zh_CN zh_TW)
by Mike Perry 31 May '12

31 May '12

Author: mikeperry Date: 2012-05-31 21:16:22 +0000 (Thu, 31 May 2012) New Revision: 25663 Modified: translation/trunk/projects/torbutton/po/ar/torbutton.dtd.po translation/trunk/projects/torbutton/po/ar/torbutton.properties.po translation/trunk/projects/torbutton/po/ca/torbutton.dtd.po translation/trunk/projects/torbutton/po/ca/torbutton.properties.po translation/trunk/projects/torbutton/po/cs/torbutton.dtd.po translation/trunk/projects/torbutton/po/cs/torbutton.properties.po … [View More]

1 0

[tor/master] Make all begindir or one-hop circuits internal
by nickm＠torproject.org 31 May '12

31 May '12

commit 834654f145cc1205e20cf5f07a37bef2e11252ce Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 15 09:41:45 2012 -0400 Make all begindir or one-hop circuits internal This solves bug 5283, where client traffic could get sent over the same circuit as an anonymized connection to a directory, even if that circuit used an exit node unsuitable for clients. By marking the directory connection as needs_internal, we ensure that the (non-internal!) … [View More]

1 0

[tor/master] add changes file for bug 5283
by nickm＠torproject.org 31 May '12

31 May '12

commit b7e863c07305941d0c12b46da503fca694148abf Author: Roger Dingledine <arma(a)torproject.org> Date: Tue May 15 20:50:29 2012 -0400 add changes file for bug 5283 I called it a bugfix on 0.2.0.10-alpha, since git commit e5885deab is where we introduced anonymized begin_dir connections. --- changes/bug5283 | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/changes/bug5283 b/changes/bug5283 new file mode 100644 index 0000000..f0325cf --- /dev/… [View More]

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 31 May '12

31 May '12

commit 0cbe3ff313deb6ef7807b07f922a567e8e1274bd Merge: dff73d2 b7e863c Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 31 17:00:37 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.2' changes/bug5283 | 6 ++++++ src/or/circuituse.c | 8 +++++++- 2 files changed, 13 insertions(+), 1 deletions(-)

1 0

[tor/maint-0.2.2] Make all begindir or one-hop circuits internal
by nickm＠torproject.org 31 May '12

31 May '12

commit 834654f145cc1205e20cf5f07a37bef2e11252ce Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 15 09:41:45 2012 -0400 Make all begindir or one-hop circuits internal This solves bug 5283, where client traffic could get sent over the same circuit as an anonymized connection to a directory, even if that circuit used an exit node unsuitable for clients. By marking the directory connection as needs_internal, we ensure that the (non-internal!) … [View More]

1 0

[tor/maint-0.2.2] add changes file for bug 5283
by nickm＠torproject.org 31 May '12

31 May '12

commit b7e863c07305941d0c12b46da503fca694148abf Author: Roger Dingledine <arma(a)torproject.org> Date: Tue May 15 20:50:29 2012 -0400 add changes file for bug 5283 I called it a bugfix on 0.2.0.10-alpha, since git commit e5885deab is where we introduced anonymized begin_dir connections. --- changes/bug5283 | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/changes/bug5283 b/changes/bug5283 new file mode 100644 index 0000000..f0325cf --- /dev/… [View More]

1 0

[tor/master] Have get_parent_directory() handle "/foo" and "/" correctly.
by nickm＠torproject.org 31 May '12

31 May '12

commit 254504fc1494b1ca4eea14eb71bd5b4b5d0d2765 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 24 12:56:31 2012 -0400 Have get_parent_directory() handle "/foo" and "/" correctly. The parent of "/foo" is "/"; and "/" is its own parent. This would cause Tor to fail if you tried to have a PF_UNIX control socket in the root directory. That would be a stupid thing to do for other reasons, but there's no reason to fail like _this_. Bug … [View More]found by Esteban Manchado Velázquez. Fix for bug 5089; bugfix on Tor 0.2.2.26-beta. Unit test included. --- changes/bug5089 | 5 +++++ src/common/compat.c | 13 +++++++++++-- src/test/test_util.c | 5 +++-- 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/changes/bug5089 b/changes/bug5089 new file mode 100644 index 0000000..2062885 --- /dev/null +++ b/changes/bug5089 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Correctly handle checking the permissions on the parent + directory of a control socket in the root directory. Bug found + by Esteban Manchado Velázquez. Fix for bug 5089; bugfix on Tor + 0.2.2.26-beta. diff --git a/src/common/compat.c b/src/common/compat.c index a4e5074..ffd9724 100644 --- a/src/common/compat.c +++ b/src/common/compat.c @@ -1481,7 +1481,11 @@ get_user_homedir(const char *username) } #endif -/** Modify <b>fname</b> to contain the name of the directory */ +/** Modify <b>fname</b> to contain the name of its parent directory. Doesn't + * actually examine the filesystem; does a purely syntactic modification. + * + * The parent of the root director is considered to be iteself. + * */ int get_parent_directory(char *fname) { @@ -1503,13 +1507,18 @@ get_parent_directory(char *fname) */ cp = fname + strlen(fname); at_end = 1; - while (--cp > fname) { + while (--cp >= fname) { int is_sep = (*cp == '/' #ifdef MS_WINDOWS || *cp == '\\' #endif ); if (is_sep) { + if (cp == fname) { + /* This is the first separator in the file name; don't remove it! */ + cp[1] = '\0'; + return 0; + } *cp = '\0'; if (! at_end) return 0; diff --git a/src/test/test_util.c b/src/test/test_util.c index f9a83a3..1c7c2fe 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -1299,11 +1299,12 @@ test_util_parent_dir(void *ptr) T("/home/wombat/knish", 0, "/home/wombat"); T("/home/wombat/knish/", 0, "/home/wombat"); + T("/home", 0, "/"); T("./home/wombat/knish/", 0, "./home/wombat"); T("./wombat", 0, "."); T("", -1, ""); - T("/", -1, ""); - T("////", -1, ""); + T("/", 0, "/"); + T("////", 0, "/"); done: tor_free(cp); [View Less]

1 0

[tor/master] A few more get_parent_directory tests.
by nickm＠torproject.org 31 May '12

31 May '12

commit b86c562d76c7b0cce25a3a9f46d5d66e2eef30ff Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 31 15:12:45 2012 -0400 A few more get_parent_directory tests. --- src/test/test_util.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/test/test_util.c b/src/test/test_util.c index 1c7c2fe..a393079 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -1302,6 +1302,9 @@ test_util_parent_dir(void *ptr) T("/home", 0, "/"); T("./… [View More]

1 0