tor-commits September 2011

tor-commits@lists.torproject.org

19 participants
865 discussions

[arm/release] Minor fix for time units.
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit 4df31a62dbee86919d8834f84b958507e7112e46 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sun Jul 31 01:07:03 2011 +0500 Minor fix for time units. --- src/util/gtkTools.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/gtkTools.py b/src/util/gtkTools.py index 56a5718..8e8b985 100644 --- a/src/util/gtkTools.py +++ b/src/util/gtkTools.py @@ -189,7 +189,7 @@ def input_time(prompt, default=None): hBox.pack_end(comboBox, False, … [View More]

1 0

[arm/release] Deduplicating common startup message
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit 5ca794e25271a09054adb0c63b86d1398c52089c Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Aug 8 07:46:15 2011 -0700 Deduplicating common startup message Deduplication entry for the "Loading relay descriptors" notice messages. --- src/settings.cfg | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/settings.cfg b/src/settings.cfg index 9154ed5..0e8f9dd 100644 --- a/src/settings.cfg +++ b/src/settings.cfg @@ -279,6 +279,7 @@ config.… [View More]

1 0

[arm/release] fix: GUARD event support
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit ce2ff76cc352309ac4450d6dc9f94e1db7da4983 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Aug 3 09:01:48 2011 -0700 fix: GUARD event support The log panel wasn't receiving GUARD events, causing them to be silently dropped. Also doing better parsing for timestamp entries. --- src/cli/logPanel.py | 17 ++++++++++++++++- 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/src/cli/logPanel.py b/src/cli/logPanel.py index bb47517..f39617d … [View More]

1 0

[arm/release] Show all options for testing.
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit 546ca73259d7863e3efe5e11e09c023c2790a2f6 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Mon Aug 1 05:11:21 2011 +0500 Show all options for testing. --- src/gui/configPanel.py | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/gui/configPanel.py b/src/gui/configPanel.py index adcdcec..e66f670 100644 --- a/src/gui/configPanel.py +++ b/src/gui/configPanel.py @@ -86,23 +86,23 @@ class ConfigPanel(object, … [View More]

1 0

[arm/release] fix: dropping nonexistent ORCONN attributes
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit eb4d0007a65a7cd10d50545dee90c56f6e998c31 Author: Damian Johnson <atagar(a)torproject.org> Date: Tue Aug 2 07:39:03 2011 -0700 fix: dropping nonexistent ORCONN attributes The AGE, READ, and WRITTEN attributes of ORCONN don't exist so dropping them from the log panel. --- src/cli/logPanel.py | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/cli/logPanel.py b/src/cli/logPanel.py index 0b4ab9c..bb47517 100644 --- a/src/cli/logPanel.py ++… [View More]

1 0

[arm/release] fix: detecting for /var/lib/tor-arm
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit 4f88292730be74ede753b2bdc9c1fdcbb9437106 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Aug 6 16:14:07 2011 -0700 fix: detecting for /var/lib/tor-arm The '/var/lib/tor-arm' directory lack read permissions for the user we're running as, so checking for '/var/lib/tor-arm/torrc' always fails. This is just meant to determine if we're run the 'override.py --init' prep so detecting for the directory is fine. --- src/cli/wizard.py | 2 +- 1 … [View More]

1 0

[arm/release] fix: misparsing sudo version string
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit d1c16ba280d925b7b0724e8c47dca959a46c19d5 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Aug 6 16:24:46 2011 -0700 fix: misparsing sudo version string --- src/cli/wizard.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index ff4e5cf..f0c14a8 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -417,7 +417,7 @@ def showWizard(): sudoVersionResult = sysTools.call("sudo -V") … [View More]

1 0

[arm/release] Periodically refreshing display
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit 3f93c66d2536ae85a0880b98425fedb507ad8503 Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Aug 8 08:30:48 2011 -0700 Periodically refreshing display On some platforms the terminal gets into a screwed up state, displaying scrambled content (I haven't reproduced this on my system, but seen it on an Ubuntu netbook). Redrawing the display, reguardless of if the content has changed every five seconds so this glitches will correct themselves. … [View More]Arm had previously done this but I took it out when the display code had stabilized (to cut down on load). However, this doesn't have a noticeable cpu cost so might as well put it back. This also simplifies some of the redrawing logic, centralizing it in the controller. --- armrc.sample | 5 ++ src/cli/controller.py | 75 +++++++++++++++++++----------------- src/cli/graphing/bandwidthStats.py | 2 +- src/cli/graphing/graphPanel.py | 2 +- src/cli/headerPanel.py | 2 +- src/cli/menu/item.py | 2 +- src/cli/menu/menu.py | 2 +- src/cli/wizard.py | 6 +- 8 files changed, 53 insertions(+), 43 deletions(-) diff --git a/armrc.sample b/armrc.sample index 1edd024..d547b6c 100644 --- a/armrc.sample +++ b/armrc.sample @@ -57,6 +57,11 @@ features.showFdUsage false # Seconds to wait on user input before refreshing content features.redrawRate 5 +# Rate (seconds) to periodically redraw the screen, disabled if zero. This +# shouldn't be necessary, but can correct issues if the terminal gets into a +# funky state. +features.refreshRate 5 + # Confirms promt to confirm when quiting if true features.confirmQuit true diff --git a/src/cli/controller.py b/src/cli/controller.py index 1554949..d2c9d73 100644 --- a/src/cli/controller.py +++ b/src/cli/controller.py @@ -37,6 +37,7 @@ CONFIG = {"startup.events": "N3", "features.panels.show.config": True, "features.panels.show.torrc": True, "features.redrawRate": 5, + "features.refreshRate": 5, "features.confirmQuit": True, "features.graph.type": 1, "features.graph.bw.prepopulate": True, @@ -171,6 +172,7 @@ class Controller: self._forceRedraw = False self._isDone = False self._torManager = TorManager(self) + self._lastDrawn = 0 self.setMsg() # initializes our control message def getScreen(self): @@ -310,39 +312,49 @@ class Controller: return allPanels - def requestRedraw(self, immediate = False): + def redraw(self, force = True): """ - Requests that all content is redrawn when the interface is next rendered. + Redraws the displayed panel content. Arguments: - immediate - redraws now if true, otherwise waits for when next normally - drawn + force - redraws reguardless of if it's needed if true, otherwise ignores + the request when there arne't changes to be displayed """ - if immediate: - displayPanels = self.getDisplayPanels() - - occupiedContent = 0 - for panelImpl in displayPanels: - panelImpl.setTop(occupiedContent) - occupiedContent += panelImpl.getHeight() - - for panelImpl in displayPanels: - panelImpl.redraw(True) - else: - self._forceRedraw = True + force |= self._forceRedraw + self._forceRedraw = False + + currentTime = time.time() + if CONFIG["features.refreshRate"] != 0: + if self._lastDrawn + CONFIG["features.refreshRate"] <= currentTime: + force = True + + displayPanels = self.getDisplayPanels() + + occupiedContent = 0 + for panelImpl in displayPanels: + panelImpl.setTop(occupiedContent) + occupiedContent += panelImpl.getHeight() + + for panelImpl in displayPanels: + panelImpl.redraw(force) + + if force: self._lastDrawn = currentTime - def isRedrawRequested(self, clearFlag = False): + def requestRedraw(self): + """ + Requests that all content is redrawn when the interface is next rendered. """ - True if a full redraw has been requested, false otherwise. - Arguments: - clearFlag - request clears the flag if true + self._forceRedraw = True + + def getLastRedrawTime(self): + """ + Provides the time when the content was last redrawn, zero if the content + has never been drawn. """ - returnValue = self._forceRedraw - if clearFlag: self._forceRedraw = False - return returnValue + return self._lastDrawn def setMsg(self, msg = None, attr = None, redraw = False): """ @@ -612,7 +624,9 @@ def startTorMonitor(startTime): # initializes interface configs config = conf.getConfig("arm") - config.update(CONFIG) + config.update(CONFIG, { + "features.redrawRate": 1, + "features.refreshRate": 0}) cli.graphing.graphPanel.loadConfig(config) cli.connections.connEntry.loadConfig(config) @@ -710,17 +724,8 @@ def drawTorMonitor(stdscr, startTime): for panelImpl in control.getAllPanels(): panelImpl.setVisible(panelImpl in displayPanels) - # panel placement - occupiedContent = 0 - for panelImpl in displayPanels: - panelImpl.setTop(occupiedContent) - occupiedContent += panelImpl.getHeight() - - # redraws visible content - forceRedraw = control.isRedrawRequested(True) - for panelImpl in displayPanels: - panelImpl.redraw(forceRedraw) - + # redraws the interface if it's needed + control.redraw(False) stdscr.refresh() # wait for user keyboard input until timeout, unless an override was set diff --git a/src/cli/graphing/bandwidthStats.py b/src/cli/graphing/bandwidthStats.py index 654443c..9782d9f 100644 --- a/src/cli/graphing/bandwidthStats.py +++ b/src/cli/graphing/bandwidthStats.py @@ -100,7 +100,7 @@ class BandwidthStats(graphPanel.GraphStats): self.isAccounting = isAccountingEnabled # redraws the whole screen since our height changed - cli.controller.getController().requestRedraw(True) + cli.controller.getController().redraw() # redraws to reflect changes (this especially noticeable when we have # accounting and shut down since it then gives notice of the shutdown) diff --git a/src/cli/graphing/graphPanel.py b/src/cli/graphing/graphPanel.py index b080871..76221ff 100644 --- a/src/cli/graphing/graphPanel.py +++ b/src/cli/graphing/graphPanel.py @@ -324,7 +324,7 @@ class GraphPanel(panel.Panel): self.setGraphHeight(self.graphHeight - 1) elif uiTools.isSelectionKey(key): break - control.requestRedraw(True) + control.redraw() finally: control.setMsg() panel.CURSES_LOCK.release() diff --git a/src/cli/headerPanel.py b/src/cli/headerPanel.py index e64a6de..4e78f6c 100644 --- a/src/cli/headerPanel.py +++ b/src/cli/headerPanel.py @@ -427,7 +427,7 @@ class HeaderPanel(panel.Panel, threading.Thread): # We're toggling between being a relay and client, causing the height # of this panel to change. Redraw all content so we don't get # overlapping content. - cli.controller.getController().requestRedraw(True) + cli.controller.getController().redraw() else: # just need to redraw ourselves self.redraw(True) diff --git a/src/cli/menu/item.py b/src/cli/menu/item.py index f46cdbb..1ed3f1f 100644 --- a/src/cli/menu/item.py +++ b/src/cli/menu/item.py @@ -58,7 +58,7 @@ class MenuItem(): if self._callback: control = cli.controller.getController() control.setMsg() - control.requestRedraw(True) + control.redraw() self._callback() return True diff --git a/src/cli/menu/menu.py b/src/cli/menu/menu.py index 8302551..a93a1e0 100644 --- a/src/cli/menu/menu.py +++ b/src/cli/menu/menu.py @@ -114,7 +114,7 @@ def showMenu(): cursor.handleKey(key) # redraws the rest of the interface if we're rendering on it again - if not cursor.isDone(): control.requestRedraw(True) + if not cursor.isDone(): control.redraw() finally: control.setMsg() cli.popups.finalize() diff --git a/src/cli/wizard.py b/src/cli/wizard.py index f0c14a8..82b2825 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -342,7 +342,7 @@ def showWizard(): generatedTorrc = getTorrc(relayType, config, disabledOpt) torrcLocation = manager.getTorrcPath() - controller.requestRedraw(True) + controller.redraw() confirmationSelection = showConfirmationDialog(generatedTorrc, torrcLocation) if confirmationSelection == NEXT: @@ -463,7 +463,7 @@ def showWizard(): elif confirmationSelection == CANCEL: break # redraws screen to clear away the dialog we just showed - cli.controller.getController().requestRedraw(True) + cli.controller.getController().redraw() def promptRelayType(initialSelection): """ @@ -621,7 +621,7 @@ def promptConfigOptions(relayType, config, disabledOpt): try: options[selection].setValue(newValue.strip()) except ValueError, exc: cli.popups.showMsg(str(exc), 3) - cli.controller.getController().requestRedraw(True) + cli.controller.getController().redraw() elif key == 27: selection, key = -1, curses.KEY_ENTER # esc - cancel finally: cli.popups.finalize() [View Less]

1 0

[arm/release] fix: avoiding setresuid/gid if unavailable
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit 4a1604958c6da5862c344f4d7ba6f0e0560daa23 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Aug 6 15:35:00 2011 -0700 fix: avoiding setresuid/gid if unavailable The os.setresuid and os.setresgid functions are only available in Python 2.7 and later. Arm aims for 2.5 compatability so using os.setreuid/gid if running a prior version. This, unfortunately, means that the saved uid is not reduced which might be a vulnerability - hopefully Jake will … [View More]know of an alternative if this is a concern. --- src/resources/torrcOverride/override.py | 26 +++++++++++++++++++++++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/src/resources/torrcOverride/override.py b/src/resources/torrcOverride/override.py index b99ae95..8261eab 100755 --- a/src/resources/torrcOverride/override.py +++ b/src/resources/torrcOverride/override.py @@ -145,6 +145,13 @@ def remove(): print " unsuccessful: %s" % exc def replaceTorrc(): + # TODO: The setresgid and setresuid functions are only available in + # python 2.7 (arm aims for 2.5 compatability). I'm not spotting a method + # for setting the saved user id without it, though. :/ + + majorVersion, minorVersion = sys.version_info[:2] + canSetSavedUid = majorVersion >= 3 or (majorVersion == 2 and minorVersion >= 7) + orig_uid = os.getuid() orig_euid = os.geteuid() @@ -168,7 +175,13 @@ def replaceTorrc(): # drop to the unprivileged group, and lose the rest of the groups os.setgid(dropped_gid) os.setegid(dropped_egid) - os.setresgid(dropped_gid, dropped_egid, dropped_gid) + + if canSetSavedUid: + # only usable in python 2.7 or later + os.setresgid(dropped_gid, dropped_egid, dropped_gid) + else: + os.setregid(dropped_gid, dropped_egid) + os.setgroups([dropped_gid]) # make a tempfile and write out the contents @@ -192,8 +205,15 @@ def replaceTorrc(): # I believe this drops os.setfsuid os.setfsgid stuff # Clear all other supplemental groups for dropped_uid os.setgroups([dropped_gid]) - os.setresgid(dropped_gid, dropped_egid, dropped_gid) - os.setresuid(dropped_uid, dropped_euid, dropped_uid) + + if canSetSavedUid: + # only usable in python 2.7 or later + os.setresgid(dropped_gid, dropped_egid, dropped_gid) + os.setresuid(dropped_uid, dropped_euid, dropped_uid) + else: + os.setregid(dropped_gid, dropped_egid) + os.setreuid(dropped_uid, dropped_euid) + os.setgid(dropped_gid) os.setegid(dropped_egid) os.setuid(dropped_uid) [View Less]

1 0

[arm/release] Use CSVs for RouterList values.
by atagar＠torproject.org 25 Sep '11

25 Sep '11

commit eccb84e2494dc2b31aeea8ee33053368d0763d71 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sun Jul 31 15:47:30 2011 +0500 Use CSVs for RouterList values. --- src/gui/configPanel.py | 8 +++++--- src/util/gtkTools.py | 9 +++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gui/configPanel.py b/src/gui/configPanel.py index 1b57341..adcdcec 100644 --- a/src/gui/configPanel.py +++ b/src/gui/configPanel.py @@ -34,9 +34,9 @@ def … [View More]input_conf_value_int(option, oldValue): prompt = "Enter value for %s" % option return gtkTools.input_int(prompt, oldValue) -def input_conf_value_list(option, oldValue): +def input_conf_value_list(option, oldValue, csv=False): prompt = "Enter value for %s" % option - return gtkTools.input_list(prompt, oldValue) + return gtkTools.input_list(prompt, oldValue, csv) def input_conf_value_string(option, oldValue): prompt = "Enter value for %s" % option @@ -138,7 +138,9 @@ class ConfigPanel(object, CliConfigPanel): elif configType == 'String': newValue = input_conf_value_string(configOption, oldValue) elif configType == 'LineList': - newValue = input_conf_value_list(configOption, oldValue) + newValue = input_conf_value_list(configOption, oldValue, csv=False) + elif configType == 'RouterList': + newValue = input_conf_value_list(configOption, oldValue, csv=True) elif configType == 'Boolean': newValue = input_conf_value_bool(configOption, oldValue) elif configType == 'Filename': diff --git a/src/util/gtkTools.py b/src/util/gtkTools.py index 8e8b985..2960188 100644 --- a/src/util/gtkTools.py +++ b/src/util/gtkTools.py @@ -214,7 +214,7 @@ def input_time(prompt, default=None): return "%d %s" % (value, units) if response == gtk.RESPONSE_OK else None -def input_int(prompt, default=None): +def input_int(prompt, default=None, csvResponse=False): dialog = gtk.MessageDialog(None, gtk.DIALOG_MODAL | gtk.DIALOG_DESTROY_WITH_PARENT, gtk.MESSAGE_QUESTION, @@ -268,7 +268,7 @@ def input_string(prompt, default=None): return text if response == gtk.RESPONSE_OK else None -def input_list(prompt, default): +def input_list(prompt, default, csv=False): def on_add_button_clicked(widget, listStore): newValue = input_string("Enter new value:") @@ -321,8 +321,9 @@ def input_list(prompt, default): addButton.connect('clicked', on_add_button_clicked, listStore) deleteButton.connect('clicked', on_delete_button_clicked, treeView) + separator = "," if csv else " " if default: - for value in default.split(): + for value in default.split(separator): row = (value,) listStore.append(row) @@ -334,7 +335,7 @@ def input_list(prompt, default): if not response == gtk.RESPONSE_OK: return - return None if len(listStore) == 0 else " ".join([row[0] for row in listStore]) + return None if len(listStore) == 0 else separator.join([row[0] for row in listStore]) def input_bool(prompt, default=None): dialog = gtk.MessageDialog(None, [View Less]

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits September 2011