July 2011 - tor-commits - lists.torproject.org

[metrics-web/master] Mention how to identify stable Tor versions.
by karsten＠torproject.org 06 Jul '11

06 Jul '11

commit 4a241c7cab1af41385ea568f55d572bb2e1f18ee Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Jul 6 13:05:38 2011 +0200 Mention how to identify stable Tor versions. --- web/WEB-INF/network.jsp | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/web/WEB-INF/network.jsp b/web/WEB-INF/network.jsp index 7906789..1789cb7 100644 --- a/web/WEB-INF/network.jsp +++ b/web/WEB-INF/network.jsp @@ -129,8 +129,12 @@ average number of relays with these flags assigned. <h3>Relays by version</h3> Relays report the Tor version that they are running to the directory -authorities. The following graph shows the number of relays by -version. +authorities. See the +<a href="https://www.torproject.org/download/download.html.en">download +page</a> and +<a href="https://gitweb.torproject.org/tor.git/blob/HEAD:/ChangeLog">ChangeLog file</a> +to find out which Tor versions are stable and unstable. +The following graph shows the number of relays by version. <a name="versions"></a> <img src="versions.png${versions_url}" width="576" height="360" alt="Relay versions graph">

1 0

[metrics-web/master] Add relay stability tech report to metrics website.
by karsten＠torproject.org 06 Jul '11

06 Jul '11

commit c1e85a21cee3185fbcae506d26aa690e1859e46b Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Jul 6 13:05:16 2011 +0200 Add relay stability tech report to metrics website. --- web/WEB-INF/index.jsp | 4 ++++ web/WEB-INF/papers.jsp | 6 ++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/web/WEB-INF/index.jsp b/web/WEB-INF/index.jsp index 0da160b..23845a6 100644 --- a/web/WEB-INF/index.jsp +++ b/web/WEB-INF/index.jsp @@ -32,6 +32,10 @@ <h3>News</h3> <ul> + <li>July 4, 2011: Technical report + <a href="papers/relay-stability-2011-06-30.pdf">An Analysis of + Tor Relay Stability</a> is available for download on the + <a href="papers.html">Papers</a> page.</li> <li>March 14, 2011: <a href="data.html#bridgeassignments">Sanitized bridge pool assignments</a> containing lists of running bridges with diff --git a/web/WEB-INF/papers.jsp b/web/WEB-INF/papers.jsp index 50f8bda..6011a20 100644 --- a/web/WEB-INF/papers.jsp +++ b/web/WEB-INF/papers.jsp @@ -45,6 +45,12 @@ been included in the <a href="#papers">papers</a> above or in the daily updated <a href="graphs.html">graphs</a>. <ul> + <li>An Analysis of Tor Relay Stability (<a + href="papers/relay-stability-2011-06-30.pdf">PDF</a>, 1.3M from + June 30, 2011, + <a href="https://gitweb.torproject.org/metrics-tasks.git/tree/HEAD:/task-2911">code</a>, + <a href="data/running-relays-reverse.csv.bz2">data</a>, + 322M).</li> <li>Overview of Statistical Data in the Tor Network (<a href="papers/data-2011-03-14.pdf">PDF</a>, 166K from March 14, 2011).</li>

1 0

[tor/master] appease check-spaces
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 4f749791730a9ac8e4e815546e0411e34dc222a9 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:22 2011 -0400 appease check-spaces --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 1140f33..a63e89b 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1501,7 +1501,7 @@ get_unique_circ_id_by_conn(or_connection_t *conn) } /** If verbose is false, allocate and return a comma-separated list of - * the currently built elements of circ. If verbose is true, also + * the currently built elements of circ. If verbose is true, also * list information about link status in a more verbose format using spaces. * If verbose_names is false, give nicknames for Named routers and hex * digests for others; if verbose_names is true, use $DIGEST=Name style

1 0

[tor/master] Merge branch 'maint-0.2.2'
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit ab8c0d4c9e23b1c4e2d9e56d87b1b61505a2a8db Merge: 7295ad1 4f74979 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:49:11 2011 -0400 Merge branch 'maint-0.2.2' src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

1 0

[tor/release-0.2.2] Merge branch 'maint-0.2.2' into release-0.2.2
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 1eec073f1bd1203935afdaa10a3818b73a668fdc Merge: f348c1c 4f74979 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:45 2011 -0400 Merge branch 'maint-0.2.2' into release-0.2.2 src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

1 0

[tor/release-0.2.2] appease check-spaces
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 4f749791730a9ac8e4e815546e0411e34dc222a9 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:22 2011 -0400 appease check-spaces --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 1140f33..a63e89b 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1501,7 +1501,7 @@ get_unique_circ_id_by_conn(or_connection_t *conn) } /** If verbose is false, allocate and return a comma-separated list of - * the currently built elements of circ. If verbose is true, also + * the currently built elements of circ. If verbose is true, also * list information about link status in a more verbose format using spaces. * If verbose_names is false, give nicknames for Named routers and hex * digests for others; if verbose_names is true, use $DIGEST=Name style

1 0

[tor/maint-0.2.2] appease check-spaces
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 4f749791730a9ac8e4e815546e0411e34dc222a9 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:22 2011 -0400 appease check-spaces --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 1140f33..a63e89b 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1501,7 +1501,7 @@ get_unique_circ_id_by_conn(or_connection_t *conn) } /** If verbose is false, allocate and return a comma-separated list of - * the currently built elements of circ. If verbose is true, also + * the currently built elements of circ. If verbose is true, also * list information about link status in a more verbose format using spaces. * If verbose_names is false, give nicknames for Named routers and hex * digests for others; if verbose_names is true, use $DIGEST=Name style

1 0

[tor/release-0.2.2] prepare for tomorrow's release candidate
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit f348c1c6baa56008bc826c3a16856c42777b5a65 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:45:24 2011 -0400 prepare for tomorrow's release candidate --- ChangeLog | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 108ac61..c77177b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,21 @@ +Changes in version 0.2.2.30-rc - 2011-07-06 + o Minor bugfixes: + - Always NUL-terminate the sun_path field of a sockaddr_un before + passing it to the kernel. (Not a security issue: kernels are + smart enough to reject bad sockaddr_uns.) Found by Coverity; + CID #428. Bugfix on Tor 0.2.0.3-alpha. + - Don't stack-allocate the list of supplementary GIDs when we're + about to log them. Stack-allocating NGROUPS_MAX gid_t elements + could take up to 256K, which is way too much stack. Found by + Coverity; CID #450. Bugfix on 0.2.1.7-alpha. + - Add BUILDTIMEOUT_SET to the list returned by the 'GETINFO + events/names' control-port command. Bugfix on 0.2.2.9-alpha; + fixes part of bug 3465. + - Fix a memory leak when receiving a descriptor for a hidden + service we didn't ask for. Found by Coverity; CID #30. Bugfix + on 0.2.2.26-beta. + + Changes in version 0.2.2.29-beta - 2011-06-20 Tor 0.2.2.29-beta reverts an accidental behavior change for users who have bridge lines in their torrc but don't want to use them; gets

1 0

[tor/release-0.2.2] Fix a rare memory leak in rend_cache_store
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 46297bc7bd86826fa79195f36059ce408ef45b6c Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jul 1 11:52:39 2011 -0400 Fix a rare memory leak in rend_cache_store When we rejected a descriptor for not being the one we wanted, we were letting the parsed descriptor go out of scope. Found by Coverity; CID # 30. Bugfix on 0.2.1.26. (No changes file yet, since this is not in any 0.2.1.x release.) --- src/or/rendcommon.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c index 8727a70..e0c101e 100644 --- a/src/or/rendcommon.c +++ b/src/or/rendcommon.c @@ -1077,6 +1077,7 @@ rend_cache_store(const char *desc, size_t desc_len, int published, log_warn(LD_REND, "Received service descriptor for service ID %s; " "expected descriptor for service ID %s.", query, safe_str(service_id)); + rend_service_descriptor_free(parsed); return -2; } now = time(NULL);

1 0

[tor/release-0.2.2] Use strlcpy in create_unix_sockaddr()
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 959da6b7f2b5ed63426fd12a9046ac06033f6db1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jul 1 12:06:54 2011 -0400 Use strlcpy in create_unix_sockaddr() Using strncpy meant that if listenaddress were ever >= sizeof(sockaddr_un.sun_path), we would fail to nul-terminate sun_path. This isn't a big deal: we never read sun_path, and the kernel is smart enough to reject the sockaddr_un if it isn't nul-terminated. Nonetheless, it's a dumb failure mode. Instead, we should reject addresses that don't fit in sockaddr_un.sun_path. Coverity found this; it's CID 428. Bugfix on 0.2.0.3-alpha. --- changes/cid_428 | 5 +++++ src/or/connection.c | 8 +++++++- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/changes/cid_428 b/changes/cid_428 new file mode 100644 index 0000000..cb0fc8c --- /dev/null +++ b/changes/cid_428 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Always NUL-terminate the sun_path field of a sockaddr_un before + passing it to the kernel. (Not a security issue: kernels are + smart enough to reject bad sockaddr_uns.) Found by Coverity; CID + # 428. Bugfix on Tor 0.2.0.3-alpha. diff --git a/src/or/connection.c b/src/or/connection.c index 4869a24..2897fe1 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -804,7 +804,13 @@ create_unix_sockaddr(const char *listenaddress, char **readable_address, sockaddr = tor_malloc_zero(sizeof(struct sockaddr_un)); sockaddr->sun_family = AF_UNIX; - strncpy(sockaddr->sun_path, listenaddress, sizeof(sockaddr->sun_path)); + if (strlcpy(sockaddr->sun_path, listenaddress, sizeof(sockaddr->sun_path)) + >= sizeof(sockaddr->sun_path)) { + log_warn(LD_CONFIG, "Unix socket path '%s' is too long to fit.", + escaped(listenaddress)); + tor_free(sockaddr); + return NULL; + } if (readable_address) *readable_address = tor_strdup(listenaddress);

1 0