July 2011 - tor-commits - lists.torproject.org

[metrics-web/master] Add relay stability tech report to metrics website.
by karsten＠torproject.org 06 Jul '11

06 Jul '11

commit c1e85a21cee3185fbcae506d26aa690e1859e46b Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Jul 6 13:05:16 2011 +0200 Add relay stability tech report to metrics website. --- web/WEB-INF/index.jsp | 4 ++++ web/WEB-INF/papers.jsp | 6 ++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/web/WEB-INF/index.jsp b/web/WEB-INF/index.jsp index 0da160b..23845a6 100644 --- a/web/WEB-INF/index.jsp +++ b/web/WEB-INF/index.jsp @@ -32,6 +32,10 @@ <h3>News</h3> <ul> + <li>July 4, 2011: Technical report + <a href="papers/relay-stability-2011-06-30.pdf">An Analysis of + Tor Relay Stability</a> is available for download on the + <a href="papers.html">Papers</a> page.</li> <li>March 14, 2011: <a href="data.html#bridgeassignments">Sanitized bridge pool assignments</a> containing lists of running bridges with diff --git a/web/WEB-INF/papers.jsp b/web/WEB-INF/papers.jsp index 50f8bda..6011a20 100644 --- a/web/WEB-INF/papers.jsp +++ b/web/WEB-INF/papers.jsp @@ -45,6 +45,12 @@ been included in the <a href="#papers">papers</a> above or in the daily updated <a href="graphs.html">graphs</a>. <ul> + <li>An Analysis of Tor Relay Stability (<a + href="papers/relay-stability-2011-06-30.pdf">PDF</a>, 1.3M from + June 30, 2011, + <a href="https://gitweb.torproject.org/metrics-tasks.git/tree/HEAD:/task-2911">code</a>, + <a href="data/running-relays-reverse.csv.bz2">data</a>, + 322M).</li> <li>Overview of Statistical Data in the Tor Network (<a href="papers/data-2011-03-14.pdf">PDF</a>, 166K from March 14, 2011).</li>

1 0

[metrics-web/master] Mention how to identify stable Tor versions.
by karsten＠torproject.org 06 Jul '11

06 Jul '11

commit 4a241c7cab1af41385ea568f55d572bb2e1f18ee Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Jul 6 13:05:38 2011 +0200 Mention how to identify stable Tor versions. --- web/WEB-INF/network.jsp | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/web/WEB-INF/network.jsp b/web/WEB-INF/network.jsp index 7906789..1789cb7 100644 --- a/web/WEB-INF/network.jsp +++ b/web/WEB-INF/network.jsp @@ -129,8 +129,12 @@ average number of relays with these flags assigned. <h3>Relays by version</h3> Relays report the Tor version that they are running to the directory -authorities. The following graph shows the number of relays by -version. +authorities. See the +<a href="https://www.torproject.org/download/download.html.en">download +page</a> and +<a href="https://gitweb.torproject.org/tor.git/blob/HEAD:/ChangeLog">ChangeLog file</a> +to find out which Tor versions are stable and unstable. +The following graph shows the number of relays by version. <a name="versions"></a> <img src="versions.png${versions_url}" width="576" height="360" alt="Relay versions graph">

1 0

[tor/master] Merge branch 'maint-0.2.2'
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit ab8c0d4c9e23b1c4e2d9e56d87b1b61505a2a8db Merge: 7295ad1 4f74979 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:49:11 2011 -0400 Merge branch 'maint-0.2.2' src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

1 0

[tor/master] appease check-spaces
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 4f749791730a9ac8e4e815546e0411e34dc222a9 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:22 2011 -0400 appease check-spaces --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 1140f33..a63e89b 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1501,7 +1501,7 @@ get_unique_circ_id_by_conn(or_connection_t *conn) } /** If verbose is false, allocate and return a comma-separated list of - * the currently built elements of circ. If verbose is true, also + * the currently built elements of circ. If verbose is true, also * list information about link status in a more verbose format using spaces. * If verbose_names is false, give nicknames for Named routers and hex * digests for others; if verbose_names is true, use $DIGEST=Name style

1 0

[tor/release-0.2.2] Merge branch 'maint-0.2.2' into release-0.2.2
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 1eec073f1bd1203935afdaa10a3818b73a668fdc Merge: f348c1c 4f74979 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:45 2011 -0400 Merge branch 'maint-0.2.2' into release-0.2.2 src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

1 0

[tor/release-0.2.2] appease check-spaces
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 4f749791730a9ac8e4e815546e0411e34dc222a9 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:22 2011 -0400 appease check-spaces --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 1140f33..a63e89b 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1501,7 +1501,7 @@ get_unique_circ_id_by_conn(or_connection_t *conn) } /** If verbose is false, allocate and return a comma-separated list of - * the currently built elements of circ. If verbose is true, also + * the currently built elements of circ. If verbose is true, also * list information about link status in a more verbose format using spaces. * If verbose_names is false, give nicknames for Named routers and hex * digests for others; if verbose_names is true, use $DIGEST=Name style

1 0

[tor/maint-0.2.2] appease check-spaces
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 4f749791730a9ac8e4e815546e0411e34dc222a9 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:48:22 2011 -0400 appease check-spaces --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 1140f33..a63e89b 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1501,7 +1501,7 @@ get_unique_circ_id_by_conn(or_connection_t *conn) } /** If verbose is false, allocate and return a comma-separated list of - * the currently built elements of circ. If verbose is true, also + * the currently built elements of circ. If verbose is true, also * list information about link status in a more verbose format using spaces. * If verbose_names is false, give nicknames for Named routers and hex * digests for others; if verbose_names is true, use $DIGEST=Name style

1 0

[tor/release-0.2.2] prepare for tomorrow's release candidate
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit f348c1c6baa56008bc826c3a16856c42777b5a65 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jul 6 00:45:24 2011 -0400 prepare for tomorrow's release candidate --- ChangeLog | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 108ac61..c77177b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,21 @@ +Changes in version 0.2.2.30-rc - 2011-07-06 + o Minor bugfixes: + - Always NUL-terminate the sun_path field of a sockaddr_un before + passing it to the kernel. (Not a security issue: kernels are + smart enough to reject bad sockaddr_uns.) Found by Coverity; + CID #428. Bugfix on Tor 0.2.0.3-alpha. + - Don't stack-allocate the list of supplementary GIDs when we're + about to log them. Stack-allocating NGROUPS_MAX gid_t elements + could take up to 256K, which is way too much stack. Found by + Coverity; CID #450. Bugfix on 0.2.1.7-alpha. + - Add BUILDTIMEOUT_SET to the list returned by the 'GETINFO + events/names' control-port command. Bugfix on 0.2.2.9-alpha; + fixes part of bug 3465. + - Fix a memory leak when receiving a descriptor for a hidden + service we didn't ask for. Found by Coverity; CID #30. Bugfix + on 0.2.2.26-beta. + + Changes in version 0.2.2.29-beta - 2011-06-20 Tor 0.2.2.29-beta reverts an accidental behavior change for users who have bridge lines in their torrc but don't want to use them; gets

1 0

[tor/release-0.2.2] Fix insanely large stack_allocation in log_credential_status
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit d25feadebbf05d6fce55cfee1e3c8f928903f543 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jul 1 12:36:33 2011 -0400 Fix insanely large stack_allocation in log_credential_status I'm not one to insist on C's miserly stack limits, but allocating a 256K array on the stack is too much even for me. Bugfix on 0.2.1.7-alpha. Found by coverity. Fixes CID # 450. --- changes/cid_450 | 5 +++++ src/common/compat.c | 16 ++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/changes/cid_450 b/changes/cid_450 new file mode 100644 index 0000000..2045fca --- /dev/null +++ b/changes/cid_450 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Don't stack-allocate the list of supplementary GIDs when we're + about to log them. Stack-allocating NGROUPS_MAX gid_t elements + could take up to 256K, which is way too much stack. Found by + Coverity; CID #450. Bugfix on 0.2.1.7-alpha. diff --git a/src/common/compat.c b/src/common/compat.c index 3965108..9533c11 100644 --- a/src/common/compat.c +++ b/src/common/compat.c @@ -1080,7 +1080,8 @@ log_credential_status(void) /* Read, effective and saved GIDs */ gid_t rgid, egid, sgid; /* Supplementary groups */ - gid_t sup_gids[NGROUPS_MAX + 1]; + gid_t *sup_gids = NULL; + int sup_gids_size; /* Number of supplementary groups */ int ngids; @@ -1126,9 +1127,19 @@ log_credential_status(void) #endif /* log supplementary groups */ - if ((ngids = getgroups(NGROUPS_MAX + 1, sup_gids)) < 0) { + sup_gids_size = 64; + sup_gids = tor_malloc(sizeof(gid_t) * 64); + while ((ngids = getgroups(sup_gids_size, sup_gids)) < 0 && + errno == EINVAL && + sup_gids_size < NGROUPS_MAX) { + sup_gids_size *= 2; + sup_gids = tor_realloc(sup_gids, sizeof(gid_t) * sup_gids_size); + } + + if (ngids < 0) { log_warn(LD_GENERAL, "Error getting supplementary GIDs: %s", strerror(errno)); + tor_free(sup_gids); return -1; } else { int i, retval = 0; @@ -1158,6 +1169,7 @@ log_credential_status(void) tor_free(cp); }); smartlist_free(elts); + tor_free(sup_gids); return retval; }

1 0

[tor/release-0.2.2] Add BUILDTIMEOUT_SET to the result of GETINFO events/names
by arma＠torproject.org 06 Jul '11

06 Jul '11

commit 93d52f6739d3bb184575aa53eab1562d2c80ee57 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Sat Jun 25 15:02:11 2011 -0700 Add BUILDTIMEOUT_SET to the result of GETINFO events/names --- changes/bug3465-022 | 6 ++++++ src/or/control.c | 3 ++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/changes/bug3465-022 b/changes/bug3465-022 new file mode 100644 index 0000000..2d22616 --- /dev/null +++ b/changes/bug3465-022 @@ -0,0 +1,6 @@ + o Minor bugfixes: + + - Add BUILDTIMEOUT_SET to the list returned by the 'GETINFO + events/names' control-port command. Bugfix on 0.2.2.9-alpha; + fixes part of bug 3465. + diff --git a/src/or/control.c b/src/or/control.c index 82017bd..da0a95d 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -1380,7 +1380,8 @@ getinfo_helper_misc(control_connection_t *conn, const char *question, *answer = tor_strdup("CIRC STREAM ORCONN BW DEBUG INFO NOTICE WARN ERR " "NEWDESC ADDRMAP AUTHDIR_NEWDESCS DESCCHANGED " "NS STATUS_GENERAL STATUS_CLIENT STATUS_SERVER " - "GUARD STREAM_BW CLIENTS_SEEN NEWCONSENSUS"); + "GUARD STREAM_BW CLIENTS_SEEN NEWCONSENSUS " + "BUILDTIMEOUT_SET"); } else if (!strcmp(question, "features/names")) { *answer = tor_strdup("VERBOSE_NAMES EXTENDED_EVENTS"); } else if (!strcmp(question, "address")) {

1 0