tor-commits July 2011

tor-commits@lists.torproject.org

16 participants
868 discussions

[arm/release] Remove repetitive cell packing inside cols.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 76ef47882a19484c498e60954f6f5310d140416d Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sun Jun 5 21:53:23 2011 +0500 Remove repetitive cell packing inside cols. --- src/gui/controller.py | 75 ++++++++++++++---------------------------------- 1 files changed, 22 insertions(+), 53 deletions(-) diff --git a/src/gui/controller.py b/src/gui/controller.py index 2f54933..a4f34a0 100644 --- a/src/gui/controller.py +++ b/src/gui/controller.py @@ -8,63 +8,11 @@ class GuiController: self.builder = gtk.Builder() self.builder.add_from_file(filename) self.builder.connect_signals(self) + self._pack_formatted_cells_into_cols() def run(self): window = self.builder.get_object('window_main') - col = self.builder.get_object('treeview_sticky').get_column(0) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'text', 0) - - col = self.builder.get_object('treeview_sticky').get_column(1) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 1) - col.add_attribute(cell, 'foreground', 2) - - col = self.builder.get_object('treeview_conn').get_column(0) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 0) - col.add_attribute(cell, 'foreground', 4) - - col = self.builder.get_object('treeview_conn').get_column(1) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 1) - col.add_attribute(cell, 'foreground', 4) - - col = self.builder.get_object('treeview_conn').get_column(2) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 2) - col.add_attribute(cell, 'foreground', 4) - - col = self.builder.get_object('treeview_conn').get_column(3) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 3) - col.add_attribute(cell, 'foreground', 4) - - col = self.builder.get_object('treeview_config').get_column(0) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 0) - col.add_attribute(cell, 'foreground', 3) - - col = self.builder.get_object('treeview_config').get_column(1) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 1) - col.add_attribute(cell, 'foreground', 3) - - col = self.builder.get_object('treeview_config').get_column(2) - cell = gtk.CellRendererText() - col.pack_start(cell) - col.add_attribute(cell, 'markup', 2) - col.add_attribute(cell, 'foreground', 3) - textview = self.builder.get_object('textview_log') textbuffer = self.builder.get_object('textbuffer_log') textview.set_buffer(textbuffer) @@ -79,6 +27,27 @@ class GuiController: def on_window_main_delete_event(self, widget, data=None): gtk.main_quit() + def _pack_formatted_cells_into_cols(self): + self._pack_formatted_cell_into_col(treeview='treeview_sticky', col=0, markup=0) + self._pack_formatted_cell_into_col(treeview='treeview_sticky', col=1, markup=1, foreground=2) + self._pack_formatted_cell_into_col(treeview='treeview_conn', col=0, markup=0, foreground=4) + self._pack_formatted_cell_into_col(treeview='treeview_conn', col=1, markup=1, foreground=4) + self._pack_formatted_cell_into_col(treeview='treeview_conn', col=2, markup=2, foreground=4) + self._pack_formatted_cell_into_col(treeview='treeview_conn', col=3, markup=3, foreground=4) + self._pack_formatted_cell_into_col(treeview='treeview_config', col=0, markup=0, foreground=3) + self._pack_formatted_cell_into_col(treeview='treeview_config', col=1, markup=1, foreground=3) + self._pack_formatted_cell_into_col(treeview='treeview_config', col=2, markup=2, foreground=3) + + def _pack_formatted_cell_into_col(self, treeview, col, markup, foreground=-1, background=-1): + col = self.builder.get_object(treeview).get_column(col) + cell = gtk.CellRendererText() + col.pack_start(cell) + col.add_attribute(cell, 'markup', markup) + if foreground != -1: + col.add_attribute(cell, 'foreground', foreground) + if background != -1: + col.add_attribute(cell, 'background', background) + def startGui(): controller = GuiController() controller.run()

1 0

[arm/release] Fixed comments referring to cagraph.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 681b169abf18334fc0aeb4ecea2f9bd50f43da2e Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Wed Jun 8 20:43:42 2011 +0500 Fixed comments referring to cagraph. --- src/prereq.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/prereq.py b/src/prereq.py index 2e26161..506a4b0 100644 --- a/src/prereq.py +++ b/src/prereq.py @@ -68,7 +68,7 @@ def promptCagraphInstall(): # if user says no then terminate if not userInput.lower() in ("y", "yes"): return False - # attempt to install TorCtl, printing the issue if unsuccessful + # attempt to install cagraph, printing the issue if unsuccessful try: installCagraph() @@ -122,10 +122,10 @@ def installCagraph(): exitStatus = os.system("wget -P %s %s" % (tmpDir, CAGRAPH_TARBALL_URL)) if exitStatus: raise IOError("Unable to fetch cagraph from %s. Is wget installed?" % CAGRAPH_TARBALL_URL) - # the destination for TorCtl will be our directory + # the destination for cagraph will be our directory ourDir = os.path.dirname(os.path.realpath(__file__)) - # exports TorCtl to our location + # exports cagraph to our location exitStatus = os.system("(cd %s && tar --strip-components=1 -xzf %s %s/cagraph)" % (ourDir, tmpFilename, CAGRAPH_TARBALL_ROOT)) if exitStatus: raise IOError("Unable to extract cagraph to %s" % ourDir)

1 0

[arm/release] Adding source flag to disable gui while in beta
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 155c58fe5ddb1734b4b5a46b0a7906cbf01677d5 Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jun 10 08:36:54 2011 -0700 Adding source flag to disable gui while in beta Source flag disables the --gui argument (and by extention prevents the gui from being run). This isn't perfect in that the gui prereqs are checked despite this flag when we have the gui arg, but this is both a temporary hack and not a terribly big concern. --- src/starter.py | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/starter.py b/src/starter.py index edb8bb2..d2ac910 100644 --- a/src/starter.py +++ b/src/starter.py @@ -30,6 +30,7 @@ import util.uiTools import TorCtl.TorCtl import TorCtl.TorUtil +INCLUDE_GUI = False LOG_DUMP_PATH = os.path.expanduser("~/.arm/log") DEFAULT_CONFIG = os.path.expanduser("~/.arm/armrc") CONFIG = {"startup.controlPassword": None, @@ -50,8 +51,13 @@ CONFIG = {"startup.controlPassword": None, "log.configDescriptions.persistance.saveFailed": util.log.NOTICE, "log.savingDebugLog": util.log.NOTICE} -OPT = "gi:c:dbe:vh" -OPT_EXPANDED = ["gui", "interface=", "config=", "debug", "blind", "event=", "version", "help"] +if INCLUDE_GUI: + OPT = "gi:c:dbe:vh" + OPT_EXPANDED = ["gui", "interface=", "config=", "debug", "blind", "event=", "version", "help"] +else: + OPT = "i:c:dbe:vh" + OPT_EXPANDED = ["interface=", "config=", "debug", "blind", "event=", "version", "help"] + HELP_MSG = """Usage arm [OPTION] Terminal status monitor for Tor relays. @@ -71,6 +77,11 @@ arm -b -i 1643 hide connection data, attaching to control port 1643 arm -e we -c /tmp/cfg use this configuration file with 'WARN'/'ERR' events """ % (CONFIG["startup.interface.ipAddress"], CONFIG["startup.interface.port"], DEFAULT_CONFIG, LOG_DUMP_PATH, CONFIG["startup.events"], cli.logPanel.EVENT_LISTING) +# icky and temporary hack to remove the gui help option if it's unavailbe +if not INCLUDE_GUI: + helpComp = HELP_MSG.split("\n") + HELP_MSG = "\n".join(helpComp[:3] + helpComp[4:]) + # filename used for cached tor config descriptions CONFIG_DESC_FILENAME = "torConfigDesc.txt" @@ -239,7 +250,7 @@ if __name__ == '__main__': param["startup.interface.ipAddress"] = controlAddr param["startup.interface.port"] = controlPort - elif opt in ("-g", "--gui"): launchGui = True + elif opt in ("-g", "--gui") and INCLUDE_GUI: launchGui = True elif opt in ("-c", "--config"): configPath = arg # sets path of user's config elif opt in ("-d", "--debug"): isDebugMode = True # dumps all logs elif opt in ("-b", "--blind"):

1 0

[arm/release] Added gui as expanded option.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 9e59ed0df5168c801a72bf25c5986de9256a5b85 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Wed Jun 8 20:44:52 2011 +0500 Added gui as expanded option. --- src/starter.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/starter.py b/src/starter.py index a94020f..edb8bb2 100644 --- a/src/starter.py +++ b/src/starter.py @@ -51,7 +51,7 @@ CONFIG = {"startup.controlPassword": None, "log.savingDebugLog": util.log.NOTICE} OPT = "gi:c:dbe:vh" -OPT_EXPANDED = ["gtk", "interface=", "config=", "debug", "blind", "event=", "version", "help"] +OPT_EXPANDED = ["gui", "interface=", "config=", "debug", "blind", "event=", "version", "help"] HELP_MSG = """Usage arm [OPTION] Terminal status monitor for Tor relays.

1 0

[arm/release] fix: checking cli or gui prereqs based on args
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 0c6fcdfaca98fede097d970fa42a3406e63bb334 Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jun 10 08:34:28 2011 -0700 fix: checking cli or gui prereqs based on args This only checks for curses dependencies if running the cli and gtk dependencies when running the gui. This isn't quite an ideal solution since it duplicates the gui args in prereq.py but not the end of the world. --- arm | 2 +- src/prereq.py | 39 ++++++++++++++++++++++++++++++++++----- 2 files changed, 35 insertions(+), 6 deletions(-) diff --git a/arm b/arm index de0b248..a6dba93 100755 --- a/arm +++ b/arm @@ -5,7 +5,7 @@ else arm_base=$( dirname "$0" )/src/ fi -python "${arm_base}prereq.py" +python "${arm_base}prereq.py" $* if [ $? = 0 ]; then exec python -W ignore::DeprecationWarning "${arm_base}starter.py" $* diff --git a/src/prereq.py b/src/prereq.py index 506a4b0..93d9de3 100644 --- a/src/prereq.py +++ b/src/prereq.py @@ -133,7 +133,11 @@ def installCagraph(): # of errors. shutil.rmtree(tmpDir, ignore_errors=True) -if __name__ == '__main__': +def allPrereq(): + """ + Requrements for both the cli and gui versions of arm. + """ + majorVersion = sys.version_info[0] minorVersion = sys.version_info[1] @@ -144,17 +148,42 @@ if __name__ == '__main__': print("arm requires python version 2.5 or greater\n") sys.exit(1) + if not isTorCtlAvailable(): + isInstalled = promptTorCtlInstall() + if not isInstalled: sys.exit(1) + +def cliPrereq(): + """ + Requirements for the cli arm interface. + """ + + allPrereq() + try: import curses except ImportError: print("arm requires curses - try installing the python-curses package\n") sys.exit(1) - - if not isTorCtlAvailable(): - isInstalled = promptTorCtlInstall() - if not isInstalled: sys.exit(1) +def guiPrereq(): + """ + Requirements for the gui arm interface. + """ + + allPrereq() + + try: + import gtk + except ImportError: + print("arm requires gtk - try installing the python-gtk2 package\n") + sys.exit(1) + if not isCagraphAvailable(): isInstalled = promptCagraphInstall() if not isInstalled: sys.exit(1) +if __name__ == '__main__': + isGui = "-g" in sys.argv or "--gui" in sys.argv + if isGui: guiPrereq() + else: cliPrereq() +

1 0

[arm/release] Fetching / validating lib dependencies via mirror
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 1419b8997ec348092b2bd98fa3d596f491321c3a Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jun 10 18:39:24 2011 -0700 Fetching / validating lib dependencies via mirror When needed we fetch torctl and cagraph (small library dependencies of arm) from a mirror on my site and verify their sha256 signatures against hardcoded values. Issue caught by Sebastian and rransom. --- src/prereq.py | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++---- 1 files changed, 53 insertions(+), 5 deletions(-) diff --git a/src/prereq.py b/src/prereq.py index 93d9de3..ba1e988 100644 --- a/src/prereq.py +++ b/src/prereq.py @@ -5,8 +5,19 @@ Provides a warning and error code if python version isn't compatible. import os import sys import shutil +import urllib +import hashlib +import tarfile import tempfile +# Library dependencies can be fetched on request. By default this is via +# the following mirrors with their sha256 signatures checked. +TORCTL_ARCHIVE = "http://www.atagar.com/arm/resources/deps/11-6-10/torctl.tar.gz" +TORCTL_SIG = "be583e53b2bccf09a7126c5271f9af5682447903b6ac92cf1cf78ca5b35273ed" +CAGRAPH_ARCHIVE = "http://www.atagar.com/arm/resources/deps/11-6-10/cagraph.tar.gz" +CAGRAPH_SIG = "1439acd40ce016f4329deb216d86f36a749e4b8bf73a313a757396af6f95310d" + +# optionally we can do an unverified fetch from the library's sources TORCTL_REPO = "git://git.torproject.org/pytorctl.git" CAGRAPH_TARBALL_URL = "http://cagraph.googlecode.com/files/cagraph-1.2.tar.gz" CAGRAPH_TARBALL_NAME = "cagraph-1.2.tar.gz" @@ -46,7 +57,7 @@ def promptTorCtlInstall(): # attempt to install TorCtl, printing the issue if unsuccessful try: - installTorCtl() + fetchLibrary(TORCTL_ARCHIVE, TORCTL_SIG) if not isTorCtlAvailable(): raise IOError("Unable to install TorCtl, sorry") @@ -70,7 +81,7 @@ def promptCagraphInstall(): # attempt to install cagraph, printing the issue if unsuccessful try: - installCagraph() + fetchLibrary(CAGRAPH_ARCHIVE, CAGRAPH_SIG) if not isCagraphAvailable(): raise IOError("Unable to install cagraph, sorry") @@ -81,6 +92,43 @@ def promptCagraphInstall(): print exc return False +def fetchLibrary(url, sig): + """ + Downloads the given archive, verifies its signature, then installs the + library. This raises an IOError if any of these steps fail. + + Arguments: + url - url from which to fetch the gzipped tarball + sig - sha256 signature for the archive + """ + + tmpDir = tempfile.mkdtemp() + destination = tmpDir + "/" + url.split("/")[-1] + urllib.urlretrieve(url, destination) + + # checks the signature, reading the archive in 256-byte chunks + m = hashlib.sha256() + fd = open(destination, "rb") + + while True: + data = fd.read(256) + if not data: break + m.update(data) + + fd.close() + actualSig = m.hexdigest() + + if sig != actualSig: + raise IOError("Signature of the library is incorrect (got '%s' rather than '%s')" % (actualSig, sig)) + + # extracts the tarball + tarFd = tarfile.open(destination, 'r:gz') + tarFd.extractall("src/") + tarFd.close() + + # clean up the temporary contents (fails quietly if unsuccessful) + shutil.rmtree(destination, ignore_errors=True) + def installTorCtl(): """ Checks out the current git head release for TorCtl and bundles it with arm. @@ -110,8 +158,8 @@ def installTorCtl(): def installCagraph(): """ - Downloads and extracts the cagraph tarball. - This raises an IOError if unsuccessful. + Downloads and extracts the cagraph tarball. This raises an IOError if + unsuccessful. """ if isCagraphAvailable(): return @@ -119,7 +167,7 @@ def installCagraph(): tmpDir = tempfile.mkdtemp() tmpFilename = os.path.join(tmpDir, CAGRAPH_TARBALL_NAME) - exitStatus = os.system("wget -P %s %s" % (tmpDir, CAGRAPH_TARBALL_URL)) + exitStatus = os.system("wget --quiet -P %s %s" % (tmpDir, CAGRAPH_TARBALL_URL)) if exitStatus: raise IOError("Unable to fetch cagraph from %s. Is wget installed?" % CAGRAPH_TARBALL_URL) # the destination for cagraph will be our directory

1 0

[arm/release] fix: removing dreprcated hearder comment
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 25157e75d3480dbe61ec99d6298de091a8b71446 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Jun 11 12:37:56 2011 -0700 fix: removing dreprcated hearder comment The connect functionality of torTools was long ago sent upstream to TorCtl. --- src/util/torTools.py | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/src/util/torTools.py b/src/util/torTools.py index d7ffa4d..f17ed0b 100644 --- a/src/util/torTools.py +++ b/src/util/torTools.py @@ -1,12 +1,6 @@ """ Helper for working with an active tor process. This both provides a wrapper for -accessing TorCtl and notifications of state changes to subscribers. To quickly -fetch a TorCtl instance to experiment with use the following: - ->>> import util.torTools ->>> conn = util.torTools.connect() ->>> conn.get_info("version")["version"] -'0.2.1.24' +accessing TorCtl and notifications of state changes to subscribers. """ import os

1 0

[arm/release] fix: Reverting one of the map changes
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 3ec4ad0a4be48b6674b7107fbc30ca8894b45d13 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Jun 4 21:37:57 2011 -0700 fix: Reverting one of the map changes Mistakenly thought map could call object methods (oops). This caused a crash with most popups. --- src/cli/popups.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/cli/popups.py b/src/cli/popups.py index 4bb519d..8061c8f 100644 --- a/src/cli/popups.py +++ b/src/cli/popups.py @@ -26,7 +26,7 @@ def init(height = -1, width = -1, top = 0, left = 0, belowStatic = True): control = cli.controller.getController() if belowStatic: - stickyHeight = sum(map(getHeight, control.getStickyPanels())) + stickyHeight = sum([stickyPanel.getHeight() for stickyPanel in control.getStickyPanels()]) else: stickyHeight = 0 popup = panel.Panel(control.getScreen(), "popup", top + stickyHeight, left, height, width)

1 0

[arm/release] Fixed file mode.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit d4a7db902d187810b3ce2b3ba247dbd2760eeeef Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sun Jun 5 21:13:49 2011 +0500 Fixed file mode. --- 0 files changed, 0 insertions(+), 0 deletions(-) diff --git a/src/gui/controller.py b/src/gui/controller.py old mode 100755 new mode 100644

1 0

[arm/release] Adding cagraph to gitignore
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit b69b57080cebf0f313f3971c06489bb182d890da Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jun 10 18:38:22 2011 -0700 Adding cagraph to gitignore --- .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 6377435..d72262b 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,5 @@ *.pyc src/TorCtl/ +src/cagraph/ *.swp

1 0

← Newer
1
...
27
28
29
30
31
32
33
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits July 2011