April 2011 - tor-commits - lists.torproject.org

[arm/master] Backporting fix for parsing multi-line exit policies to current release.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit d50aefb997137c360b4cd51d31faf83d93d9417d Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Aug 7 22:00:08 2010 +0000 Backporting fix for parsing multi-line exit policies to current release. svn:r22820 --- interface/connPanel.py | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/interface/connPanel.py b/interface/connPanel.py index d78c3ed..2fb1d72 100644 --- a/interface/connPanel.py +++ b/interface/connPanel.py @@ -8,7 +8,7 @@ import curses from threading import RLock from TorCtl import TorCtl -from util import log, connections, hostnames, panel, uiTools +from util import log, connections, hostnames, panel, torTools, uiTools # Scrubs private data from any connection that might belong to client or exit # traffic. This is a little overly conservative, hiding anything that isn't @@ -192,7 +192,10 @@ class ConnPanel(TorCtl.PostEventListener, panel.Panel): else: self.family = [] self.isBridge = self.conn.get_option("BridgeRelay")[0][1] == "1" - self.exitPolicy = self.conn.get_option("ExitPolicy")[0][1] + + policyEntries = torTools.getConn().getOption("ExitPolicy", multiple=True) + self.exitPolicy = ",".join(policyEntries) + self.exitPolicy = self.exitPolicy.replace("\\t", " ").replace("\"", "") if self.exitPolicy: self.exitPolicy += "," + self.conn.get_info("exit-policy/default")["exit-policy/default"] else: self.exitPolicy = self.conn.get_info("exit-policy/default")["exit-policy/default"]

1 0

[arm/master] Rewrite of the first third of the interface, providing vastly improved performance, maintainability, and a few very nice features.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit c4e034f4789fe2ef65b6d3bed78d59ed308087cb Merge: e3b7f0e 426c879 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Jul 7 16:48:51 2010 +0000 Rewrite of the first third of the interface, providing vastly improved performance, maintainability, and a few very nice features. added: settings are fetched from an optional armrc (update rates, controller password, caching, runlevels, etc) added: system tools util providing simplified usage, suppression of leaks to stdout, logging, and optional caching added: wrapper for accessing TorCtl providing: - client side caching for commonly fetched relay information (fingerprint, descriptor, etc) - singleton accessor and convenience functions, simplifying interface code - wrapper allowing reattachment to new controllers (ie, arm still works if tor's stopped then restarted - still in the works) change: full rewrite of the header panel, providing: - notice for when tor's disconnected (with time-stamp) - lightweight redrawing (smarter caching and moved updating into a daemon thread) - more graceful handling of tiny displays change: rewrite of graph panel and related stats, providing: - prepopulation of bandwidth information from the state file if possible - observed and measured bandwidth stats (requested by arma) - graph can be configured to display any numeric ps stat - third option for graphing bounds (restricting to both local minima and maxima) - substantially reduced redraw rate and making use of cached ps parameters (reducing call volume) fix: preventing 'command unavailable' error messages from going to stdout, which disrupts the display (caught by sid77) fix: removed -p option due to being a gaping security problem (caught by ioerror and nickm) fix: crashing issue if TorCtl reports TorCtlClosed before the first refresh (caught by Tas) fix: preventing the connection panel from initiating or resetting while in blind mode (caught by micah) fix: ss resolution wasn't specifying the use of numeric ports (caught by data) fix: parsing error when ExitPolicy is undefined (caught by Paul Menzel) fix: revised sleep pattern used for threads, greatly reducing the time it takes to quit fix: bug in defaulting the connection resolver to something predetermined to be available fix: stopping connection resolution (and related failover message) when tor's stopped fix: crashing issue when trying to resolve addresses without network connectivity fix: forgot to join on connection resolver when quitting fix: revised calculation for effective bandwidth rate to take MaxAdvertisedBandwidth into account svn:r22617 ChangeLog | 32 ++ README | 30 +- TODO | 301 +++++++----- armrc.sample | 82 ++++ init/project113.py | 192 ++++++++ init/starter.py | 188 ++++---- interface/__init__.py | 2 +- interface/bandwidthMonitor.py | 185 ------- interface/confPanel.py | 4 +- interface/connCountMonitor.py | 57 --- interface/connPanel.py | 11 +- interface/controller.py | 377 +++++++-------- interface/cpuMemMonitor.py | 54 -- interface/fileDescriptorPopup.py | 21 +- interface/graphPanel.py | 279 ----------- interface/graphing/__init__.py | 6 + interface/graphing/bandwidthStats.py | 348 ++++++++++++++ interface/graphing/connStats.py | 51 ++ interface/graphing/graphPanel.py | 363 ++++++++++++++ interface/graphing/psStats.py | 129 +++++ interface/headerPanel.py | 485 +++++++++++-------- interface/logPanel.py | 30 +- util/__init__.py | 2 +- util/conf.py | 246 ++++++++++ util/connections.py | 142 ++++-- util/hostnames.py | 75 ++- util/log.py | 59 ++- util/panel.py | 62 ++- util/sysTools.py | 172 +++++++ util/torTools.py | 877 ++++++++++++++++++++++++++++++++++ util/uiTools.py | 78 +++- 31 files changed, 3593 insertions(+), 1347 deletions(-) diff --cc init/starter.py index d95672e,a58b687..8ce8315 --- a/init/starter.py +++ b/init/starter.py @@@ -14,18 -13,30 +13,30 @@@ import getop # includes parent directory rather than init in path (so sibling modules are included) sys.path[0] = sys.path[0][:-5] - from TorCtl import TorCtl, TorUtil - from interface import controller, logPanel + import interface.controller + import interface.logPanel + import util.conf + import util.connections + import util.hostnames + import util.log + import util.panel + import util.sysTools + import util.torTools + import util.uiTools + import TorCtl.TorUtil - VERSION = "1.3.5" - LAST_MODIFIED = "Apr 8, 2010" -VERSION = "1.3.6_dev" ++VERSION = "1.3.6" + LAST_MODIFIED = "July 7, 2010" - DEFAULT_CONTROL_ADDR = "127.0.0.1" - DEFAULT_CONTROL_PORT = 9051 - DEFAULT_LOGGED_EVENTS = "N3" # tor and arm NOTICE, WARN, and ERR events + DEFAULT_CONFIG = os.path.expanduser("~/.armrc") + DEFAULTS = {"startup.controlPassword": None, + "startup.interface.ipAddress": "127.0.0.1", + "startup.interface.port": 9051, + "startup.blindModeEnabled": False, + "startup.events": "N3"} - OPT = "i:p:be:vh" - OPT_EXPANDED = ["interface=", "password=", "blind", "event=", "version", "help"] + OPT = "i:c:be:vh" + OPT_EXPANDED = ["interface=", "config=", "blind", "event=", "version", "help"] HELP_MSG = """Usage arm [OPTION] Terminal status monitor for Tor relays.

1 0

[arm/master] Revisions for the deb release build.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit 9da2275af16d586dcfc30582765dcfc6b1d898d0 Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Oct 7 06:08:47 2010 +0000 Revisions for the deb release build. svn:r23441 --- debian/changelog | 10 ++++++++-- debian/control | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/debian/changelog b/debian/changelog index 5464df0..9dd15fa 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,11 @@ -tor-arm (0.3.6) unstable; urgency=low +tor-arm (1.3.7) unstable; urgency=low + + * see http://www.atagar.com/arm/log.php + + -- Damian Johnson (www.atagar.com) <atagar1(a)gmail.com> Wed, 6 Oct 2010 22:30:43 -0700 + +tor-arm (1.3.6) unstable; urgency=low * Initial release. - -- Damian Johnson <atagar(a)torproject.org> Mon, 30 Aug 2010 08:13:43 -0700 + -- Damian Johnson (www.atagar.com) <atagar1(a)gmail.com> Mon, 30 Aug 2010 08:13:43 -0700 diff --git a/debian/control b/debian/control index 9d019cc..7bd04fa 100644 --- a/debian/control +++ b/debian/control @@ -1,9 +1,9 @@ Source: tor-arm Section: comm Priority: extra -Maintainer: Damian Johnson <atagar1(a)gmail.com> +Maintainer: Damian Johnson (www.atagar.com) <atagar1(a)gmail.com> Build-Depends: debhelper (>= 5), python-support (>= 0.6), cdbs (>= 0.4.49), python -Standards-Version: 3.8.3 +Standards-Version: 3.8.0 Homepage: http://www.atagar.com/arm Package: tor-arm

1 0

[arm/master] Reverting change to the license (looks like that isn't allowed) and removing copyright section from the man page.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit a40075d0258738b4620f95c541ca8fd20a2d2bfc Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Dec 12 01:02:54 2010 +0000 Reverting change to the license (looks like that isn't allowed) and removing copyright section from the man page. svn:r23927 --- LICENSE | 2 +- arm.1 | 3 --- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/LICENSE b/LICENSE index 1528791..94a9ed0 100644 --- a/LICENSE +++ b/LICENSE @@ -1,7 +1,7 @@ GNU GENERAL PUBLIC LICENSE Version 3, 29 June 2007 - Copyright (C) 2009-2010 Damian Johnson <atagar1(a)gmail.com> + Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/> Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. diff --git a/arm.1 b/arm.1 index 32ab749..58cc3ce 100644 --- a/arm.1 +++ b/arm.1 @@ -68,6 +68,3 @@ Sample armrc configuration file that documents all options .SH AUTHOR Written by Damian Johnson (atagar1(a)gmail.com) -.SH COPYRIGHT -GNU GPL version 3, \fIhttp://gnu.org/licenses/gpl.html\fR -

1 0

[arm/master] Bumping the version for the hotfix.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit cfa0fd24792e7d5c95303d5de10727f04fec99d0 Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Oct 8 16:42:15 2010 +0000 Bumping the version for the hotfix. svn:r23465 --- src/version.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/version.py b/src/version.py index dc41d36..08989e3 100644 --- a/src/version.py +++ b/src/version.py @@ -2,6 +2,6 @@ Provides arm's version and release date. """ -VERSION = '1.3.7' -LAST_MODIFIED = "October 6, 2010" +VERSION = '1.3.7-1' +LAST_MODIFIED = "October 7, 2010"

1 0

[arm/master] Bumping version in debian changelog for hotfix release.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit 76dcdd263dc172c97e46516cecabca321257b5ce Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Oct 8 17:00:14 2010 +0000 Bumping version in debian changelog for hotfix release. svn:r23466 --- debian/changelog | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/debian/changelog b/debian/changelog index 9dd15fa..c3664d8 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +tor-arm (1.3.7-1) unstable; urgency=low + + * hotfix for crashing issue with the graph panel (caught by tomb) + + -- Damian Johnson (www.atagar.com) <atagar1(a)gmail.com> Wed, 7 Oct 2010 09:50:43 -0700 + tor-arm (1.3.7) unstable; urgency=low * see http://www.atagar.com/arm/log.php

1 0

[arm/master] Merging to release for version 1.4.0
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit f403cccb5119e4290c5dce370249f2cade3b7617 Merge: 76dcdd2 c43410c Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Nov 28 10:58:57 2010 +0000 Merging to release for version 1.4.0 svn:r23873 ChangeLog | 46 ++- README | 19 +- TODO | 103 +++--- arm | 4 +- arm.1 | 73 ++++ armrc.sample | 228 ++++++++++- debian/MANIFEST | 40 -- debian/arm.1.gz | Bin 1115 -> 0 bytes debian/changelog | 17 - debian/compat | 1 - debian/control | 28 -- debian/copyright | 27 -- debian/make-deb | 21 - debian/make-rpm | 21 - debian/manpages | 1 - debian/pycompat | 1 - debian/rules | 23 - debian/setup.cfg | 3 - debian/source/format | 1 - install | 4 +- setup.py | 60 +++- src/armrc.defaults | 229 ----------- src/interface/__init__.py | 2 +- src/interface/confPanel.py | 292 ------------- src/interface/configPanel.py | 312 ++++++++++++++ src/interface/connPanel.py | 3 +- src/interface/controller.py | 657 +++++++++++++++++++++++------- src/interface/graphing/bandwidthStats.py | 3 +- src/interface/graphing/graphPanel.py | 10 +- src/interface/graphing/psStats.py | 2 +- src/interface/headerPanel.py | 3 +- src/interface/logPanel.py | 126 ++++-- src/interface/torrcPanel.py | 221 ++++++++++ src/settings.cfg | 130 ++++++ src/starter.py | 162 ++++++-- src/uninstall | 2 +- src/util/__init__.py | 2 +- src/util/conf.py | 222 +++++++---- src/util/connections.py | 2 +- src/util/hostnames.py | 10 +- src/util/log.py | 8 +- src/util/panel.py | 96 ++++- src/util/sysTools.py | 20 + src/util/torConfig.py | 659 ++++++++++++++++++++++++++++++ src/util/torTools.py | 170 +++++++- src/util/uiTools.py | 181 ++++++++- src/version.py | 4 +- 47 files changed, 3091 insertions(+), 1158 deletions(-) diff --cc TODO index 6b0fe37,c5fe109..fa9d6ad --- a/TODO +++ b/TODO @@@ -35,17 -28,26 +28,35 @@@ TOD - pick apart applications like iftop and pktstat to see how they get per-connection bandwidth usage. Forum thread discussing it: https://bbs.archlinux.org/viewtopic.php?pid=715906 - - give usage stats for exit port usage (popup?) - - country data for client connections (requested by ioerror) + [ ] control port interpreter (interactive prompt) + Panel and startup option (-t maybe?) for providing raw control port + access along with usability improvements (piggybacking on the arm + connection): + - irc like help (ex "/help GETINFO" could provide a summary of + getinfo commands, partly using the results from + "GETINFO info/names") + - tab completion and up/down for previous commands + - warn and get confirmation if command would disrupt arm (for + instance 'SETEVENTS') + - 'safe' option that restricts to read-only access (start with this) + - issue sighup reset + [ ] low hanging fruit from the "client mode use cases" below + * release prep + * pylint --indent-string=" " --disable=C,R interface/foo.py | less + * double check __init__.py and README for changes + + - Roadmap for version 1.4.2 + [ ] refactor panels + [ ] controller and popup panels + [ ] attempt to clear controller password from memory + - http://www.codexon.com/posts/clearing-passwords-in-memory-with-python + * release prep + * pylint --indent-string=" " --disable=C,R interface/foo.py | less + * double check __init__.py and README for changes + +- Roadmap for version 1.3.9 + [ ] refactor panels + [ ] controller and popup panels - allow arm to resume after restarting tor This requires a full move to the torTools controller. - provide measurements for startup time, and try to improve bottlenecks diff --cc src/version.py index 08989e3,0b32fbf..a35c4ee --- a/src/version.py +++ b/src/version.py @@@ -2,6 -2,6 +2,6 @@@ Provides arm's version and release date. """ - VERSION = '1.3.7-1' - LAST_MODIFIED = "October 7, 2010" -VERSION = '1.4.0_dev' ++VERSION = '1.4.0' + LAST_MODIFIED = "November 27, 2010"

1 0

[arm/master] Changing arm's versioning scheme to differentiate it from debian.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit 8dac24227ae6a8eb61da31ea6cb64c0eb3ebc6a2 Author: Damian Johnson <atagar(a)torproject.org> Date: Tue Dec 7 17:42:11 2010 +0000 Changing arm's versioning scheme to differentiate it from debian. svn:r23899 --- src/version.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/version.py b/src/version.py index fc30f0b..4a0b625 100644 --- a/src/version.py +++ b/src/version.py @@ -2,6 +2,6 @@ Provides arm's version and release date. """ -VERSION = '1.4.0-2' +VERSION = '1.4.0.2' LAST_MODIFIED = "November 30, 2010"

1 0

[arm/master] More fixes for issues caught by weasel
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit c43535aee0c9038fefa7867ffc511dea4e258568 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Dec 12 00:21:28 2010 +0000 More fixes for issues caught by weasel change: noting myself in the license file fix: startup script wasn't hanlding unusual paths, such as with spaces and dashes fix: startup script was forking the final process instad of calling exec fix: initially built diff differed from rebuilt version since it was missing the pycompat svn:r23926 --- LICENSE | 2 +- arm | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/LICENSE b/LICENSE index 94a9ed0..1528791 100644 --- a/LICENSE +++ b/LICENSE @@ -1,7 +1,7 @@ GNU GENERAL PUBLIC LICENSE Version 3, 29 June 2007 - Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/> + Copyright (C) 2009-2010 Damian Johnson <atagar1(a)gmail.com> Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. diff --git a/arm b/arm index a6d336a..de0b248 100755 --- a/arm +++ b/arm @@ -1,13 +1,13 @@ #!/bin/sh -if [ $0 = /usr/bin/arm ]; then +if [ "$0" = /usr/bin/arm ]; then arm_base=/usr/share/arm/ else - arm_base=$( dirname $0 )/src/ + arm_base=$( dirname "$0" )/src/ fi -python ${arm_base}prereq.py +python "${arm_base}prereq.py" if [ $? = 0 ]; then - python -W ignore::DeprecationWarning ${arm_base}starter.py $* + exec python -W ignore::DeprecationWarning "${arm_base}starter.py" $* fi

1 0

[arm/master] Removing dependency on python 2.6 for installation and building.
by sebastian＠torproject.org 24 Apr '11

24 Apr '11

commit 66b3c94952d819341fc374326ff3cc7178cbb447 Author: Damian Johnson <atagar(a)torproject.org> Date: Tue Dec 7 17:46:03 2010 +0000 Removing dependency on python 2.6 for installation and building. This was using the gzip name attribute unnecessarily which isn't available in older python versions (caught by weasel). svn:r23900 --- setup.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/setup.py b/setup.py index d11080f..edae307 100644 --- a/setup.py +++ b/setup.py @@ -51,7 +51,7 @@ if "install" in sys.argv: # places in tmp rather than a relative path to avoid having this copy appear # in the deb and rpm builds - manFilename = manOutputFile.name + manFilename = tmpFilename except IOError, exc: print "Unable to compress man page: %s" % exc

1 0