tor-commits October 2011

tor-commits@lists.torproject.org

18 participants
1256 discussions

[tor/master] Merge branch 'cov_run224_squashed'
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit 6df3869f3b3448d041ece19498d062104c32fa45 Merge: e0a053b ce6a2c2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 26 13:22:51 2011 -0400 Merge branch 'cov_run224_squashed' changes/cov_485,486,487 | 5 +++++ src/or/config.c | 7 +++++-- src/or/connection.c | 4 ++-- 3 files changed, 12 insertions(+), 4 deletions(-)

1 0

[tor/master] Changelog for recent coverity issues
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit ce6a2c2f140a3c1af9d6544f90d5fff1e06ffc42 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Oct 6 14:08:07 2011 -0400 Changelog for recent coverity issues --- changes/cov_485,486,487 | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/changes/cov_485,486,487 b/changes/cov_485,486,487 new file mode 100644 index 0000000..648b010 --- /dev/null +++ b/changes/cov_485,486,487 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Fix memory leaks in the failing cases of the new SocksPort and + ControlPort code. Found by Coverity Scan. Bugfix on + 0.2.3.3-alpha; fixes coverity CID 485, 486, and 487. +

1 0

[tor/master] Do not tread vpadding cell as versions cell. Not in any released version.
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit e0a053be01211133e68ec5e75d49aaddea5d4072 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 26 11:50:50 2011 -0400 Do not tread vpadding cell as versions cell. Not in any released version. --- src/or/command.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/command.c b/src/or/command.c index c4cc3a9..c85b057 100644 --- a/src/or/command.c +++ b/src/or/command.c @@ -285,7 +285,7 @@ command_process_var_cell(var_cell_t *cell, or_connection_t *conn) break; case CELL_VPADDING: ++stats_n_vpadding_cells_processed; - PROCESS_CELL(versions, cell, conn); + /* Do nothing */ break; case CELL_CERT: ++stats_n_cert_cells_processed;

1 0

[tor/master] Fix a NULL pointer dereference in parse_server_transport_line().
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit 9d53c0091169e9b68d91c023124e1fed31909ffa Author: George Kadianakis <desnacked(a)gmail.com> Date: Wed Oct 26 17:13:56 2011 +0200 Fix a NULL pointer dereference in parse_server_transport_line(). --- src/or/config.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/or/config.c b/src/or/config.c index ec9d84b..3080da0 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -4985,8 +4985,10 @@ parse_server_transport_line(const char *line, int validate_only) done: SMARTLIST_FOREACH(items, char*, s, tor_free(s)); smartlist_free(items); - SMARTLIST_FOREACH(transport_list, char*, s, tor_free(s)); - smartlist_free(transport_list); + if (transport_list) { + SMARTLIST_FOREACH(transport_list, char*, s, tor_free(s)); + smartlist_free(transport_list); + } return r; }

1 0

[tor/master] Check return of init_keys() ip_address_changed: fix Coverity CID 484
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit 2412e0e4024325608b551f74140e449d2016916f Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Oct 6 12:59:25 2011 -0400 Check return of init_keys() ip_address_changed: fix Coverity CID 484 --- changes/cov484 | 4 ++++ src/or/main.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/changes/cov484 b/changes/cov484 new file mode 100644 index 0000000..33adbda --- /dev/null +++ b/changes/cov484 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - Report any failure in init_keys() calls done because our IP address + has changed. Spotted by Coverity Scan. Bugfix on 0.1.1.4-alpha; + fixes CID 484. diff --git a/src/or/main.c b/src/or/main.c index 289d805..c011c9b 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -1378,7 +1378,8 @@ ip_address_changed(int at_interface) if (at_interface) { if (! server) { /* Okay, change our keys. */ - init_keys(); + if (init_keys()<0) + log_warn(LD_GENERAL, "Unable to rotate keys after IP change!"); } } else { if (server) {

1 0

[tor/master] Make internal error check for unrecognized digest algorithm more robust
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit 246afc1b1ba8c81557307bfffa5291c91cc2c782 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Oct 6 13:02:50 2011 -0400 Make internal error check for unrecognized digest algorithm more robust Fixes Coverity CID 479. --- changes/cov479 | 5 +++++ src/common/crypto.c | 4 ++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/changes/cov479 b/changes/cov479 new file mode 100644 index 0000000..afbaffc --- /dev/null +++ b/changes/cov479 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Fix internal bug-checking logic that was supposed to catch + failures in digest generation so that it will fail more robustly + if we ask for a nonexistent algorithm. Found by Coverity Scan. + Bugfix on 0.2.2.1-alpha; fixes Coverity CID 479. diff --git a/src/common/crypto.c b/src/common/crypto.c index 851f11b..235bd88 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -1663,6 +1663,10 @@ crypto_digest_get_digest(crypto_digest_env_t *digest, SHA256_Final(r, &tmpenv.d.sha2); break; default: + log_warn(LD_BUG, "Called with unknown algorithm %d", digest->algorithm); + /* If fragile_assert is not enabled, then we should at least not + * leak anything. */ + memset(r, 0xff, sizeof(r)); tor_fragile_assert(); break; }

1 0

[tor/master] Merge remote-tracking branch 'public/cov_run224_022' into maint-0.2.2
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit 4a1a89be0cd1abbd2aa4746038f52cd0dcffa65a Merge: 9af3a3c 246afc1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 26 11:07:28 2011 -0400 Merge remote-tracking branch 'public/cov_run224_022' into maint-0.2.2 changes/cov479 | 5 +++++ changes/cov484 | 4 ++++ src/common/crypto.c | 4 ++++ src/or/main.c | 3 ++- 4 files changed, 15 insertions(+), 1 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 26 Oct '11

26 Oct '11

commit beb9097beda7cc82eec744878a2efd2810351158 Merge: 34f1243 4a1a89b Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 26 11:08:19 2011 -0400 Merge remote-tracking branch 'origin/maint-0.2.2' changes/cov479 | 5 +++++ changes/cov484 | 4 ++++ src/common/crypto.c | 4 ++++ src/or/main.c | 3 ++- 4 files changed, 15 insertions(+), 1 deletions(-)

1 0

[tor/maint-0.2.2] Check return of init_keys() ip_address_changed: fix Coverity CID 484
by nickm＠torproject.org 26 Oct '11

26 Oct '11

1 0

[tor/maint-0.2.2] Merge remote-tracking branch 'public/cov_run224_022' into maint-0.2.2
by nickm＠torproject.org 26 Oct '11

26 Oct '11

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits October 2011