- tor-commits - lists.torproject.org

r4521: Get one last patch in for ticket #2186 before The Great Git (vidalia/trunk/src/vidalia/config)
by vidalia-svn＠svn.torproject.org 24 Feb '11

24 Feb '11

Author: edmanm Date: 2011-02-24 14:49:11 +0000 (Thu, 24 Feb 2011) New Revision: 4521 Modified: vidalia/trunk/src/vidalia/config/ServerPage.cpp Log: Get one last patch in for ticket #2186 before The Great Git Migration. ;) Modified: vidalia/trunk/src/vidalia/config/ServerPage.cpp =================================================================== --- vidalia/trunk/src/vidalia/config/ServerPage.cpp 2011-02-23 12:20:10 UTC (rev 4520) +++ vidalia/trunk/src/vidalia/config/ServerPage.cpp 2011-02-24 14:49:11 UTC (rev 4521) @@ -562,15 +562,11 @@ ServerPage::displayBridgeUsage() { QString info; + QMessageBox dlg(this); info = Vidalia::torControl()->getInfo("status/clients-seen").toString(); if (info.isEmpty()) { - QMessageBox dlg(QMessageBox::Information, tr("No Recent Usage"), - tr("No clients have used your relay recently."), - QMessageBox::Ok, this); - dlg.setInformativeText(tr("Leave your relay running so clients have " - "a better chance of finding and using it.")); - dlg.exec(); + goto none; } else { QDateTime timeStarted; QHash<QString,int> countrySummary; @@ -588,29 +584,47 @@ if (!timeStarted.isValid()) goto err; - foreach (QString pair, keyvals.value("CountrySummary").split(",")) { - QStringList parts = pair.split("="); - if (parts.size() != 2) - goto err; + QStringList summary = keyvals.value("CountrySummary") + .split(",", QString::SkipEmptyParts); + if (summary.isEmpty()) { + goto none; + } else { + foreach (QString pair, summary) { + QStringList parts = pair.split("="); + if (parts.size() != 2) + goto err; - countrySummary.insert(parts.at(0).toUpper(), parts.at(1).toInt(&ok)); - if (!ok) - goto err; + countrySummary.insert(parts.at(0).toUpper(), parts.at(1).toInt(&ok)); + if (!ok) + goto err; + } + + dlg.update(timeStarted, countrySummary); + dlg.exec(); } - - dlg.update(timeStarted, countrySummary); - dlg.exec(); } return; +none: + dlg.setIcon(QMessageBox::Information); + dlg.setWindowTitle(tr("No Recent Usage")); + dlg.setText(tr("No clients have used your relay recently.")); + dlg.setInformativeText(tr("Leave your relay running so clients have " + "a better chance of finding and using it.")); + dlg.setStandardButtons(QMessageBox::Ok); + dlg.exec(); + return; + err: - QMessageBox dlg(QMessageBox::Warning, tr("Bridge History"), - tr("Vidalia was unable to retrieve your bridge's usage " - "history."), QMessageBox::Ok, this); + dlg.setIcon(QMessageBox::Warning); + dlg.setWindowTitle(tr("Bridge History")); + dlg.setText(tr("Vidalia was unable to retrieve your bridge's usage " + "history.")); dlg.setInformativeText(tr("Tor returned an improperly formatted " "response when Vidalia requested your " "bridge's usage history.")); dlg.setDetailedText(tr("The returned response was: %1").arg(info)); + dlg.setStandardButtons(QMessageBox::Ok); dlg.exec(); }

1 0

[tor/master] Fix memory leak in md-download logic
by nickm＠torproject.org 24 Feb '11

24 Feb '11

commit 0a6beb936866447742d1117eefcfeef2e62326fc Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 24 09:47:33 2011 -0500 Fix memory leak in md-download logic Also fix some microdesc comments Fix for bug 2623 --- src/or/directory.c | 1 + src/or/microdesc.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/or/directory.c b/src/or/directory.c index 7137fe1..e4752b8 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -1957,6 +1957,7 @@ connection_dir_client_reached_eof(dir_connection_t *conn) } SMARTLIST_FOREACH(which, char *, cp, tor_free(cp)); smartlist_free(which); + smartlist_free(mds); } } diff --git a/src/or/microdesc.c b/src/or/microdesc.c index 2480b8e..469c2fc 100644 --- a/src/or/microdesc.c +++ b/src/or/microdesc.c @@ -133,7 +133,7 @@ get_microdesc_cache(void) * to allow, so we should reject any non-requested microdesc with a different * digest, and alter the list to contain only the digests of those microdescs * we didn't find. - * Return a list of the added microdescriptors. */ + * Return a newly allocated list of the added microdescriptors, or NULL */ smartlist_t * microdescs_add_to_cache(microdesc_cache_t *cache, const char *s, const char *eos, saved_location_t where, @@ -181,7 +181,7 @@ microdescs_add_to_cache(microdesc_cache_t *cache, } /* As microdescs_add_to_cache, but takes a list of micrdescriptors instead of - * a string to encode. Frees any members of <b>descriptors</b> that it does + * a string to decode. Frees any members of <b>descriptors</b> that it does * not add. */ smartlist_t * microdescs_add_list_to_cache(microdesc_cache_t *cache,

1 0

[tor/master] Fix a couple of compile warnings on OS X 10.6
by nickm＠torproject.org 24 Feb '11

24 Feb '11

commit 303c04109b9044715c2f0b7e8cd9f18027ee7d5f Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Thu Feb 24 07:19:09 2011 +0100 Fix a couple of compile warnings on OS X 10.6 --- src/or/status.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/or/status.c b/src/or/status.c index 36b3f7b..054567f 100644 --- a/src/or/status.c +++ b/src/or/status.c @@ -33,8 +33,8 @@ static char * secs_to_uptime(long secs) { long int days = secs / 86400; - int hours = (secs - (days * 86400)) / 3600; - int minutes = (secs - (days * 86400) - (hours * 3600)) / 60; + int hours = (int)((secs - (days * 86400)) / 3600); + int minutes = (int)((secs - (days * 86400) - (hours * 3600)) / 60); char *uptime_string = NULL; switch (days) {

1 0

[tor/master] Merge remote branch 'sebastian/osx_compile'
by nickm＠torproject.org 24 Feb '11

24 Feb '11

commit feaa0120d0d08591d3c9e720438d8f2fc34ed736 Merge: 9265164 303c041 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 24 09:27:04 2011 -0500 Merge remote branch 'sebastian/osx_compile' src/or/status.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

1 0

[torperf/master] Fix extra_stats.py to output more useful data.
by karsten＠torproject.org 24 Feb '11

24 Feb '11

commit 71069e738bc69647f57987db5c5584473d219baf Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Wed Feb 23 00:23:43 2011 -0800 Fix extra_stats.py to output more useful data. Documentation follows in next commit. Also requires a TorCtl update to latest origin/master. --- extra_stats.py | 140 ++++++++++++++++++++++++++++++++++++++++++++++++-------- 1 files changed, 120 insertions(+), 20 deletions(-) diff --git a/extra_stats.py b/extra_stats.py old mode 100644 new mode 100755 index eac037b..fb8d38a --- a/extra_stats.py +++ b/extra_stats.py @@ -1,45 +1,144 @@ -import sys, time, math +#!/usr/bin/python + +import sys, time +import TorCtl.TorUtil as TorUtil import TorCtl.TorCtl as TorCtl HOST = "127.0.0.1" +class Circuit: + def __init__(self, launch_time, circ_id): + self.circ_id = circ_id + self.launch_time = launch_time + self.close_time = launch_time + self.stream_end_time = 0 + self.path = [] + self.build_times = [] + self.failed = False + self.fail_reason = None + self.used = False + self.strm_id = 0 + self.stream_failed = False + self.stream_fail_reason = None + class WriteStats(TorCtl.PostEventListener): def __init__(self, port, filename): TorCtl.PostEventListener.__init__(self) self._port = int(port) self._filename = filename self._conn = None + self.all_circs = {} + self.ignore_streams = {} + self.current_timeout = None + self.current_quantile = None def connect(self): self._conn = TorCtl.connect(HOST, self._port) + self._conn.debug(file("control.log", "w")) if not self._conn: sys.exit(2) def setup_listener(self): - self._conn.set_events(["Stream"]) + try: + # buildtimeout_set will not be available in 0.2.1 + self._conn.set_events(["STREAM", "CIRC", "BUILDTIMEOUT_SET"], + extended=True) + except: + self._conn.set_events(["STREAM", "CIRC"], extended=True) self._conn.add_event_listener(self) + def buildtimeout_set_event(self, b): + self.current_timeout = b.timeout_ms + self.current_quantile = b.cutoff_quantile + result = b.event_name + " " +b.body + self.write_result(result) + + def circ_status_event(self, c): + if c.status == "LAUNCHED": + self.all_circs[c.circ_id] = Circuit(c.arrived_at, c.circ_id) + elif c.circ_id not in self.all_circs: + return + + circ = self.all_circs[c.circ_id] + if c.status == "EXTENDED": + circ.build_times.append(c.arrived_at-circ.launch_time) + elif c.status == "BUILT": + circ.path = c.path + elif c.status == "FAILED": + circ.fail_reason = c.reason + if c.remote_reason: circ.fail_reason += ":"+c.remote_reason + circ.path = c.path + circ.close_time = c.arrived_at + circ.failed = True + self.write_circ(circ) + del self.all_circs[c.circ_id] + elif c.status == "CLOSED": + circ.close_time = c.arrived_at + self.write_circ(circ) + del self.all_circs[c.circ_id] + + def write_circ(self, circ): + result = "CIRC_ID=%d LAUNCH=%s PATH=%s BUILDTIMES=%s " \ + % (circ.circ_id, str(circ.launch_time), ",".join(circ.path), + ",".join(map(str, circ.build_times))) + if circ.failed: + result += "FAIL_REASONS=%s " % circ.fail_reason + if circ.stream_failed: + result += "STREAM_FAIL_REASONS=%s " % circ.stream_fail_reason + elif circ.used: + result += "USED_AT=%s USED_BY=%d " % \ + (str(circ.stream_end_time), circ.strm_id) + + if self.current_timeout: + result += "TIMEOUT=%d QUANTILE=%f " % \ + (self.current_timeout, self.current_quantile) + + self.write_result(result) + def stream_status_event(self, event): - if event.source == 'EXIT' or \ - event.status == 'DETACHED': - for circs in self._conn.get_info("circuit-status").itervalues(): - for circ in circs.split("\n"): - entry = circ.split(" ") - if entry[0] == str(event.circ_id): - if event.source == 'EXIT': - self.write_result(True, event.arrived_at, entry[2].split(",")) - else: - self.write_result(False, event.arrived_at, entry[2].split(",")) - - def write_result(self, successful, now, relays): - success = "" - if successful: - success = "ok" - else: - success = "error" + if event.status == "NEW": + if event.purpose != "USER": + self.ignore_streams[event.strm_id] = True + return + if event.strm_id in self.ignore_streams: + if event.status == "CLOSED": + del self.ignore_streams[event.strm_id] + return + if event.circ_id not in self.all_circs: + if event.circ_id: + TorUtil.plog("WARN", + "Unknown circuit id %d has a stream event %d %s" % \ + (event.circ_id, event.strm_id, event.status)) + return + circ = self.all_circs[event.circ_id] + if event.status == 'DETACHED' or event.status == 'FAILED': + # Detached usually means there was some failure + assert not circ.strm_id + circ.used = True + circ.strm_id = event.strm_id + circ.stream_failed = True + circ.stream_end_time = event.arrived_at + if event.reason: + circ.stream_fail_reason = event.reason + if event.remote_reason: + circ.stream_fail_reason += " "+event.remote_reason + self.write_circ(circ) + # We have no explicit assurance here that tor will not + # try to reuse this circuit later... But we should + # print out a warn above if that happens. + del self.all_circs[event.circ_id] + if event.status == 'CLOSED': + assert not circ.strm_id or circ.stream_failed + circ.used = True + circ.strm_id = event.strm_id + circ.stream_end_time = event.arrived_at + self.write_circ(circ) + del self.all_circs[event.circ_id] + def write_result(self, result): + # XXX: hrmm. seems wasteful to keep opening+closing.. statsfile = open(self._filename, 'a') - statsfile.write("%s %d %s\n" % (success, math.floor(now), " ".join(relays))) + statsfile.write(result+"\n") statsfile.close() def main(): @@ -54,6 +153,7 @@ def main(): stats.connect() stats.setup_listener() try: + # XXX: join instead while True: time.sleep(500) except:

1 0

[torperf/master] Update measurements doc for new extra_stats.py.
by karsten＠torproject.org 24 Feb '11

24 Feb '11

commit e02ad69c67f858c551fb307bb43c6405dd6b4b1d Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Wed Feb 23 00:27:55 2011 -0800 Update measurements doc for new extra_stats.py. --- measurements-HOWTO | 37 ++++++++++++++++++++++--------------- 1 files changed, 22 insertions(+), 15 deletions(-) diff --git a/measurements-HOWTO b/measurements-HOWTO index 9c78992..c91894a 100644 --- a/measurements-HOWTO +++ b/measurements-HOWTO @@ -163,26 +163,33 @@ startsec startusec writebytes readbytes The 50kb.extradata, 1mb.extradata, and 5mb.extradata files should -accumulate lines like this (linebreaks for formatting reasons): +accumulate lines with KEY=value pairs describing the following properties: -ok 1284059486 $ED16C4DD8E9BCACDE829E6B6571B58095383897A=PPrivCom030 - $80818E35A46DEED6889818ADC596404AB94E392A=Pandora14 - $4C23C8C30C66C87E1C875A949B4841E4305FFC57~Amunet11 +CIRC_ID: The circuit id from the control port +LAUNCH: The launch time +PATH: The identity fingerprints of the members of the path +BUILDTIMES: Cumulative timer of how long before each hop was completed +USED_AT: Closing time for the Torperf stream +USED_BY: Control port stream id for this Torperf stream +TIMEOUT: The current CircuitBuildTimeout (in ms, pre-rounding) +QUANTILE: The current CircuitBuildTimeout quantile cutoff -with column headers: +In the event of error, the following fields may be present in lieu of +completion data: -ok|error timestamp firsthop secondhop thirdhop [fourthhop ...] +FAIL_REASONS: Reasons for circuit failure +STREAM_FAIL_REASONS: Reasons for stream failure -The first column indicates if this circuit was actually used to fetch -the data or if Tor chose a different circuit because this one was -problematic. For every error entry there should be a following ok -entry, unless the network of the torperf instance is totally dead or -the resource it wants to fetch is unavailable. +The files will also contain direct copies of the control port event +BUILDTIMEOUT_SET. See control-spec.txt for details of this. -The timestamp will NOT necessarily match the timestamps in the .data file -exactly, because additional processing is necessary. You should allow -for up to a minute of slack when matching the two files up. See the -consolidate_stats.py script that fulfills this job. +The USED_AT timestamp will NOT necessarily match the timestamps in the .data +file exactly, because additional processing is necessary. The timestamp from +the .data files that is closest to USED_AT is "datacompletesec +datacompleteusec". If the times are more than a second apart, something is +really wrong. + +XXX: consolidate-stats needs update, and no longer works. Call it like this:

1 0

[torperf/master] Fix annoying formatting in example start script.
by karsten＠torproject.org 24 Feb '11

24 Feb '11

commit add8b1f470562ab958294789c62987f6f4ae6698 Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Wed Feb 23 00:28:12 2011 -0800 Fix annoying formatting in example start script. Bonus commit! ;) --- example_start-tors_fastslow.txt | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/example_start-tors_fastslow.txt b/example_start-tors_fastslow.txt index 2226cb0..4887868 100755 --- a/example_start-tors_fastslow.txt +++ b/example_start-tors_fastslow.txt @@ -8,14 +8,14 @@ mkdir -p regular50kb regular1mb regular5mb BASEPORT=9000 SIZENUM=0 for SIZE in 50kb 1mb 5mb; do -SPEEDNUM=0 -let SIZENUM=10+$SIZENUM -for SPEED in slow slowratio regular fast fastratio; do -let SPEEDNUM=1+$SPEEDNUM -let PORT=$BASEPORT+$SIZENUM+$SPEEDNUM -let CONTROLPORT=1000+$PORT -cd ~/torperf/$SPEED$SIZE -cat <<EOF >torrc + SPEEDNUM=0 + let SIZENUM=10+$SIZENUM + for SPEED in slow slowratio regular fast fastratio; do + let SPEEDNUM=1+$SPEEDNUM + let PORT=$BASEPORT+$SIZENUM+$SPEEDNUM + let CONTROLPORT=1000+$PORT + cd ~/torperf/$SPEED$SIZE + cat <<EOF >torrc DataDirectory . SocksPort $PORT MaxCircuitDirtiness 1 minute @@ -24,7 +24,7 @@ Log notice file log ControlPort $CONTROLPORT CookieAuthentication 1 EOF -done + done done cd ~/torperf/slow50kb && tor -f ~/torperf/slow50kb/torrc

1 0

[torperf/master] Clarify some fields of extradata.
by karsten＠torproject.org 24 Feb '11

24 Feb '11

commit b240ae1ad416b42eeba37d0442471b9858ad2821 Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Wed Feb 23 13:28:05 2011 -0800 Clarify some fields of extradata. --- measurements-HOWTO | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/measurements-HOWTO b/measurements-HOWTO index c91894a..e72969e 100644 --- a/measurements-HOWTO +++ b/measurements-HOWTO @@ -166,10 +166,10 @@ The 50kb.extradata, 1mb.extradata, and 5mb.extradata files should accumulate lines with KEY=value pairs describing the following properties: CIRC_ID: The circuit id from the control port -LAUNCH: The launch time +LAUNCH: The launch time of the circuit PATH: The identity fingerprints of the members of the path BUILDTIMES: Cumulative timer of how long before each hop was completed -USED_AT: Closing time for the Torperf stream +USED_AT: Closing time for the Torperf stream (should match datacomplete*sec) USED_BY: Control port stream id for this Torperf stream TIMEOUT: The current CircuitBuildTimeout (in ms, pre-rounding) QUANTILE: The current CircuitBuildTimeout quantile cutoff

1 0

[torperf/master] Fix a spurious WARN in extra_data.py
by karsten＠torproject.org 24 Feb '11

24 Feb '11

commit 34362200e773ad22c893079a933df558e330d49a Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Wed Feb 23 13:27:49 2011 -0800 Fix a spurious WARN in extra_data.py --- extra_stats.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/extra_stats.py b/extra_stats.py index fb8d38a..1ae0142 100755 --- a/extra_stats.py +++ b/extra_stats.py @@ -127,6 +127,9 @@ class WriteStats(TorCtl.PostEventListener): # try to reuse this circuit later... But we should # print out a warn above if that happens. del self.all_circs[event.circ_id] + # Some STREAM FAILED events are paired with a CLOSED, some are not :( + if event.status == "FAILED": + self.ignore_streams[event.strm_id] = True if event.status == 'CLOSED': assert not circ.strm_id or circ.stream_failed circ.used = True

1 0

[pytorctl/master] Fix a python 2.5 traceback in recent 'body' commit.
by mikeperry＠torproject.org 24 Feb '11

24 Feb '11

commit 96133c805d3e5402f6444e71a4555c6b410986e7 Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Thu Feb 24 03:49:05 2011 -0800 Fix a python 2.5 traceback in recent 'body' commit. --- TorCtl.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/TorCtl.py b/TorCtl.py index 4319242..5403a95 100755 --- a/TorCtl.py +++ b/TorCtl.py @@ -266,8 +266,8 @@ class ORConnEvent(Event): self.ncircs = ncircs class StreamBwEvent(Event): - def __init__(self, event_name, strm_id, written, read, body): - Event.__init__(self, event_name, body) + def __init__(self, event_name, saved_body, strm_id, written, read): + Event.__init__(self, event_name, saved_body) self.strm_id = int(strm_id) self.bytes_read = int(read) self.bytes_written = int(written) @@ -1431,7 +1431,7 @@ class EventHandler(EventSink): m = re.match(r"(\d+)\s+(\d+)\s+(\d+)", body) if not m: raise ProtocolError("STREAM_BW event misformatted.") - event = StreamBwEvent(evtype, *m.groups(), body=body) + event = StreamBwEvent(evtype, body, *m.groups()) elif evtype == "BW": m = re.match(r"(\d+)\s+(\d+)", body) if not m:

1 0