-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2/1/19 9:27 AM, Nicolas Vigier wrote:
On Tue, 29 Jan 2019, Mark Smith wrote:
3.1 Source Code Integration
Prior to building the browser, the Tor Launcher code will be placed under browser/extensions/tor-launcher/. To avoid the problems associated with git submodules, this will be done using a nested git repository. Specifically, we want to facilitate nightly and developer builds that require that the Tor Launcher code be referred to by a branch or symbolic name rather than a git hash. We will need to make TO-BE-DETERMINED changes to the firefox project within tor-browser-build to put the Tor Launcher code in the correct place within the tor-browser source tree, and to keep it up to date. The tor-launcher RBM project will be removed from tor-browser-build.
This sounds good. However, I think we should not remove completly the tor-launcher project from tor-browser-build but do something like this: - modify the tor-launcher project to create a tar from the sources, instead of an xpi file - remove the tor-launcher dependency from projects/tor-browser and add it to projects/firefox. - in projects/firefox/build extract the tor-launcher tarball under browser/extensions/tor-launcher/.
Thanks! That sounds like a good plan, and so I added it to the proposal. An updated draft is attached. The only changes compared to the 29-Jan-2019 version are in section 3.1. Kathy and will start implementing this next week. - -- Mark Smith Pearl Crescent, LLC http://pearlcrescent.com/ -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJgKw3Q6yOMzgNxlqDjYST46ZD24FAlxcV7AACgkQDjYST46Z D25XvQgAtV4fc+tn1s5a7oEbiqh0E0yo8acYAf6cjopQ2qFusvKR6x/F3VGbKuPl eCF2yUzCqfQ0gqCKSi42XlukQAlXHCgEPsy/5IzVmLhJ9EWMAS24XQnmYYXL+FBg BF+zyld5OXV5XvChilHhqGJfLByMoW8iltcfOqPrliu7SjhUQ9M59I6tc/qm6BkK TZrR6p5LRDRAKjRkLSrnIMtQI8RWVT3aUwa9KjEIEDBLtjIxtUTlSjb4xBRCpmYM 54vLLCmId6LHvXOYLQEgPLoaoNX0c3vZhHFwpQeMH4ilTsgwX16+QCygBKCFkrGQ y+QhhN1kvCw2YFDI1lOX+P6a1GVBKQ== =xTLQ -----END PGP SIGNATURE-----