clairehurst pushed to branch tor-browser-149.0a1-16.0-2 at The Tor Project / Applications / Tor Browser Commits: 2bd95221 by clairehurst at 2026-03-25T15:43:07-06:00 TB 44694 [android]: Remove new Tab bar feature - - - - - 3 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt - mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt ===================================== @@ -63,7 +63,6 @@ class CustomizationFragment : PreferenceFragmentCompat() { setupRadioGroups() val tabletAndTabStripEnabled = Settings(requireContext()).isTabStripEnabled updateToolbarCategoryBasedOnTabStrip(tabletAndTabStripEnabled) - setupTabStripCategory() updateToolbarShortcut() // if tab strip is enabled, swipe toolbar to switch tabs should not be enabled so the @@ -206,20 +205,6 @@ class CustomizationFragment : PreferenceFragmentCompat() { addToRadioGroup(topPreference, bottomPreference) } - private fun setupTabStripCategory() { - val tabStripSwitch = requirePreference<SwitchPreference>(R.string.pref_key_tab_strip_show) - val context = requireContext() - - tabStripSwitch.isChecked = Settings(requireContext()).isTabStripEnabled - - tabStripSwitch.setOnPreferenceChangeListener { _, newValue -> - val enabled = newValue as Boolean - context.settings().isTabStripEnabled = enabled - updateToolbarCategoryBasedOnTabStrip(enabled) - true - } - } - private fun setupGesturesCategory(isSwipeToolbarToSwitchTabsVisible: Boolean) { requirePreference<SwitchPreference>(R.string.pref_key_website_pull_to_refresh).apply { isVisible = FeatureFlags.PULL_TO_REFRESH_ENABLED ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt ===================================== @@ -2038,11 +2038,7 @@ class Settings( default = { FxNimbus.features.searchOptimizationOption.value().showStocksCard }, ) - var isTabStripEnabled by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_tab_strip_show), - default = FxNimbus.features.tabStrip.value().enabled && - (isTabStripEligible(appContext) || FxNimbus.features.tabStrip.value().allowOnAllDevices), - ) + val isTabStripEnabled = false var isDynamicToolbarEnabled = false ===================================== mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml ===================================== @@ -60,15 +60,6 @@ android:selectable="false" /> </androidx.preference.PreferenceCategory> - <androidx.preference.PreferenceCategory - android:layout="@layout/preference_cat_style" - android:title="@string/preferences_tab_strip" - app:iconSpaceReserved="false"> - <androidx.preference.SwitchPreference - android:key="@string/pref_key_tab_strip_show" - android:title="@string/preference_tab_strip_show" /> - </androidx.preference.PreferenceCategory> - <!-- Toolbar shortcut picker --> <androidx.preference.PreferenceCategory android:key="@string/pref_key_customization_category_toolbar_shortcut" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2bd95221... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2bd95221... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help
participants (1)
-
clairehurst (@clairehurst)