Pier Angelo Vendrame pushed to branch base-browser-115.5.0esr-13.0-1 at The Tor Project / Applications / Tor Browser

Commits: f8c8f156 by Eitan Isaacson at 2023-11-15T16:17:23+00:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie

Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - 9f5d76b6 by Pier Angelo Vendrame at 2023-11-15T16:17:23+00:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized

Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows.

Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 87b8ae77 by Pier Angelo Vendrame at 2023-11-15T16:17:24+00:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8

Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 195c4314 by Emilio Cobos Álvarez at 2023-11-15T16:17:24+00:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster

Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - d902a3fb by Pier Angelo Vendrame at 2023-11-15T16:17:25+00:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll

Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - 5155642d by Eden Chuang at 2023-11-15T18:35:20+00:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth

Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - 01dcc0cf by edgul at 2023-11-15T18:35:21+00:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D182373

- - - - - 1674ff16 by Kelsey Gilbert at 2023-11-15T18:35:21+00:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond

We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch.

Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 99661088 by Mark Banner at 2023-11-15T18:35:22+00:00 Bug 1845752. r=ckerschb

Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 8aef0316 by Bob Owen at 2023-11-15T18:35:22+00:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel

This also specializes ElementStreamFormat for bool.

Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - fa1092b5 by Malte Juergens at 2023-11-15T18:35:23+00:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb

Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - da366933 by Andreas Pehrson at 2023-11-15T18:35:23+00:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt

Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex.

Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - 94700fc8 by Henry Wilkes at 2023-11-15T18:35:23+00:00 Bug 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

- - - - - dc81a84d by hackademix at 2023-11-15T18:35:24+00:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.

- - - - - e5cf5f1d by Henry Wilkes at 2023-11-15T18:35:24+00:00 Bug 41483: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla bug 1790187

- - - - - 5adb5eeb by Pier Angelo Vendrame at 2023-11-15T18:35:25+00:00 Bug 41116: Normalize system fonts.

System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.

- - - - - b3b31bf7 by Marco Simonelli at 2023-11-15T18:35:25+00:00 Bug 41459: WebRTC fails to build under mingw (Part 1)

- properly define NOMINMAX for just MSVC builds

- - - - - 0dd20e74 by Marco Simonelli at 2023-11-15T18:35:26+00:00 Bug 41459: WebRTC fails to build under mingw (Part 2)

- fixes required to build third_party/libwebrtc

- - - - - ebb405b6 by Marco Simonelli at 2023-11-15T18:35:26+00:00 Bug 41459: WebRTC fails to build under mingw (Part 3)

- fixes required to build third_party/sipcc

- - - - - d1095640 by Marco Simonelli at 2023-11-15T18:35:27+00:00 Bug 41459: WebRTC fails to build under mingw (Part 4)

- fixes requried to build netwerk/sctp

- - - - - 023ccfc8 by Marco Simonelli at 2023-11-15T18:35:27+00:00 Bug 41459: WebRTC fails to build under mingw (Part 5)

- fixes required to build dom/media/webrtc

- - - - - 0afa7e4d by Marco Simonelli at 2023-11-15T18:35:28+00:00 Bug 41459: WebRTC fails to build under mingw (Part 6)

- fixes required to build dom/media/systemservices

- - - - - 64d5f040 by hackademix at 2023-11-15T18:35:28+00:00 Bug 41854: Allow overriding download spam protection.

- - - - - a10ba79e by Gaba at 2023-11-15T18:35:29+00:00 Adding issue and merge request templates

- - - - - 4d25db4e by Pier Angelo Vendrame at 2023-11-15T18:35:29+00:00 Base Browser's .mozconfigs.

Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.

Bug 21849: Don't allow SSL key logging.

Bug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android.

Bug 29859: Disable HLS support for now

Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug 33734: Set MOZ_NORMANDY to False

Bug 33851: Omit Parental Controls.

Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

Bug 41584: Move some configuration options to base-browser level

- - - - - 9f3a9750 by Pier Angelo Vendrame at 2023-11-15T18:35:30+00:00 Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

- - - - - 69f07a1c by Pier Angelo Vendrame at 2023-11-15T18:35:30+00:00 Bug 41108: Remove privileged macOS installation from 102

- - - - - 756afd33 by Dan Ballard at 2023-11-15T18:35:31+00:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies

- - - - - 71d242e6 by Matthew Finkel at 2023-11-15T18:35:31+00:00 Bug 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

- - - - - de0b072c by Matthew Finkel at 2023-11-15T18:35:31+00:00 Bug 28125: Prevent non-Necko network connections

- - - - - 43376f9b by Mike Perry at 2023-11-15T18:35:32+00:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

- - - - - 62cadc2f by Alex Catarineu at 2023-11-15T18:35:32+00:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

- - - - - fde9b85d by Georg Koppen at 2023-11-15T18:35:33+00:00 Bug 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

- - - - - 3cb2c009 by Kathy Brade at 2023-11-15T18:35:33+00:00 Bug 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

- - - - - 372664f5 by Kathy Brade at 2023-11-15T18:35:34+00:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

- - - - - 5b4869c7 by Alex Catarineu at 2023-11-15T18:35:34+00:00 Bug 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

- - - - - d027d81e by Kathy Brade at 2023-11-15T18:35:34+00:00 Bug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

Bug 41662: Disable about:sync-logs

Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.

- - - - - de2ebf0b by Arthur Edelstein at 2023-11-15T18:35:35+00:00 Bug 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.

- - - - - 7f0d5dc7 by Alex Catarineu at 2023-11-15T18:35:35+00:00 Bug 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

- - - - - 6ae28d5b by cypherpunks1 at 2023-11-15T18:35:36+00:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping

- - - - - 8d6fcc75 by Pier Angelo Vendrame at 2023-11-15T18:35:36+00:00 Bug 41635: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

- - - - - a4295da1 by Georg Koppen at 2023-11-15T18:35:37+00:00 Bug 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

- - - - - cdebe5e1 by Alex Catarineu at 2023-11-15T18:35:37+00:00 Bug 28369: Stop shipping pingsender executable

- - - - - 8a37662f by cypherpunks1 at 2023-11-15T18:35:38+00:00 Bug 41568: Disable LaterRun

- - - - - 8f3ff102 by cypherpunks1 at 2023-11-15T18:35:38+00:00 Bug 40717: Hide Windows SSO in settings

- - - - - d29e6920 by Pier Angelo Vendrame at 2023-11-15T18:35:38+00:00 Bug 41599: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

- - - - - bfefa11e by cypherpunks1 at 2023-11-15T18:35:39+00:00 Bug 40175: Add origin attributes to about:reader top-level requests

- - - - - 5098992a by Richard Pospesel at 2023-11-15T18:35:39+00:00 Bug 41327: Disable UrlbarProviderInterventions

- - - - - 86258972 by Richard Pospesel at 2023-11-15T18:35:40+00:00 Bug 42037: Disable about:firefoxview page

- - - - - 8f39bf4e by Mike Perry at 2023-11-15T18:35:40+00:00 Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Bug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

Bug 18297: Use separate Noto JP,KR,SC,TC fonts

Bug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug 23745: Set dom.indexedDB.enabled = true

Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

Bug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

Bug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197.

Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

Bug 29916: Make sure enterprise policies are disabled

Bug 2874: Block Components.interfaces from content

Bug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

Bug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996.

Bug 30845: Make sure default themes and other internal extensions are enabled

Bug 28896: Enable extensions in private browsing by default

Bug 31065: Explicitly allow proxying localhost

Bug 31598: Enable letterboxing

Disable Presentation API everywhere

Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.

Bug 32321: Disable Mozilla's MitM pings

Bug 19890: Disable installation of system addons

By setting the URL to "" we make sure that already installed system addons get deleted as well.

Bug 22548: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".

Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs

Bug 16441: Suppress "Reset Tor Browser" prompt.

Bug 29120: Use the in-memory media cache and increase its maximum size.

Bug 33697: use old search config based on list.json

Bug 33855: Ensure that site-specific browser mode is disabled.

Bug 30682: Disable Intermediate CA Preloading.

Bug 40061: Omit the Windows default browser agent from the build

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40408: Disallow SVG Context Paint in all web content

Bug 40308: Disable network partitioning until we evaluate dFPI

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40383: Disable dom.enable_event_timing

Bug 40423: Disable http/3

Bug 40177: Update prefs for Fx91esr

Bug 40700: Disable addons and features recommendations

Bug 40682: Disable network.proxy.allow_bypass

Bug 40736: Disable third-party cookies in PBM

Bug 19850: Enabled HTTPS-Only by default

Bug 40912: Hide the screenshot menu

Bug 41292: Disable moreFromMozilla in preferences page

Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector

Bug 24686: Set network.http.tailing.enabled to true

Bug 40183: Disable TLS ciphersuites using SHA-1

Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.

- - - - - bd57a518 by Richard Pospesel at 2023-11-15T18:35:41+00:00 Bug 41659: Add canonical color definitions to base-browser

- - - - - 988497ad by Pier Angelo Vendrame at 2023-11-15T18:35:41+00:00 Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

- - - - - 98d23173 by Alex Catarineu at 2023-11-15T18:35:41+00:00 Bug 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

- - - - - f69630df by Alex Catarineu at 2023-11-15T18:35:42+00:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView

- - - - - f63bd0f6 by Alex Catarineu at 2023-11-15T18:35:42+00:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware

- - - - - 8d8251dd by Alex Catarineu at 2023-11-15T18:35:43+00:00 Bug 26345: Hide tracking protection UI

- - - - - 638b432d by Pier Angelo Vendrame at 2023-11-15T18:35:43+00:00 Bug 9173: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.

On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.

This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).

- - - - - 0fd970c6 by Alex Catarineu at 2023-11-15T18:35:44+00:00 Bug 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

- - - - - c774a794 by Mike Perry at 2023-11-15T18:35:44+00:00 Bug 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

- - - - - d1ceb955 by Igor Oliveira at 2023-11-15T18:35:44+00:00 Bug 23104: Add a default line height compensation

Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height.

- - - - - a45a5f1f by Pier Angelo Vendrame at 2023-11-15T18:35:45+00:00 Bug 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled.

- - - - - 1f9c4499 by Matthew Finkel at 2023-11-15T18:35:45+00:00 Bug 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

- - - - - cae23fa4 by cypherpunks1 at 2023-11-15T18:35:46+00:00 Bug 33955: When copying an image only copy the image contents to the clipboard

- - - - - 9522da4f by cypherpunks1 at 2023-11-15T18:35:46+00:00 Bug 41791: Omit the source URL when copying page contents to the clipboard

- - - - - e753ea45 by Pier Angelo Vendrame at 2023-11-15T18:35:47+00:00 Base Browser strings

This commit adds all the strings needed by following Base Browser patches.

- - - - - e61c537b by hackademix at 2023-11-15T18:35:47+00:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.

- - - - - 0c19127a by hackademix at 2023-11-15T18:35:47+00:00 Bug 41434: Letterboxing, improve logging.

- - - - - 7dac3334 by hackademix at 2023-11-15T18:35:48+00:00 Bug 31064: Letterboxing, exempt browser extensions.

- - - - - 387cb9b8 by hackademix at 2023-11-15T18:35:48+00:00 Bug 32411: Letterboxing, exempt view-source: URIs.

- - - - - 80827e51 by hackademix at 2023-11-15T18:35:49+00:00 Bug 32308: use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping

- - - - - 2f37bb96 by hackademix at 2023-11-15T18:35:49+00:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

- - - - - 61948b8a by Pier Angelo Vendrame at 2023-11-15T18:35:50+00:00 Bug 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

- - - - - 1268e4f0 by p13dz at 2023-11-15T18:35:50+00:00 Bug 40283: Workaround for the file upload bug

- - - - - 669a2805 by Arthur Edelstein at 2023-11-15T18:35:51+00:00 Bug 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

- - - - - 096b7836 by cypherpunks1 at 2023-11-15T18:35:51+00:00 Bug 41740: Change the RFP value of devicePixelRatio to 2

- - - - - 2682d966 by Pier Angelo Vendrame at 2023-11-15T18:35:51+00:00 Bug 41739: Remove "Website appearance" from about:preferences.

It is ignored because of RFP and it is confusing for users.

- - - - - 30def173 by cypherpunks1 at 2023-11-15T18:35:52+00:00 Bug 41881: Don't persist custom network requests on private windows

- - - - - 55ae62fa by hackademix at 2023-11-15T18:35:52+00:00 Bug 42019: Empty browser's clipboard on browser shutdown

- - - - - 2c19cfaa by hackademix at 2023-11-15T18:35:53+00:00 fixup! Bug 42019: Empty browser's clipboard on browser shutdown

Bug 42154: empty clipboard content from private windows on exit.

- - - - - 38a40aa2 by hackademix at 2023-11-15T18:35:53+00:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order.

- - - - - d40fb9e5 by Pier Angelo Vendrame at 2023-11-15T18:35:54+00:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

- - - - - 5bfc5244 by Henry Wilkes at 2023-11-15T18:35:54+00:00 Bug 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need.

Bug 41624: Disable about:pocket-* pages.

Bug 40144: Redirect about:privatebrowsing to the user's home

- - - - - bd654cf2 by Kathy Brade at 2023-11-15T18:35:54+00:00 Bug 4234: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.

As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

- - - - - 81f90bd1 by Pier Angelo Vendrame at 2023-11-15T18:35:55+00:00 Bug 42061: Create an alpha update channel.

- - - - - 2df91255 by Nicolas Vigier at 2023-11-15T18:35:55+00:00 Bug 41682: Add base-browser nightly mar signing key

- - - - - 329e58c5 by hackademix at 2023-11-15T18:35:56+00:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module

- - - - - dfe59359 by Pier Angelo Vendrame at 2023-11-15T18:35:56+00:00 Bug 41698: Reword the recommendation badges in about:addons

Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.

We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

- - - - - acd0e50e by Alex Catarineu at 2023-11-15T18:35:57+00:00 Bug 40069: Add helpers for message passing with extensions

- - - - - cc159b6c by Matthew Finkel at 2023-11-15T18:35:57+00:00 Bug 41598: Prevent NoScript from being removed/disabled.

Bug 40253: Explicitly allow NoScript in Private Browsing mode.

- - - - - 1e9b3d00 by Henry Wilkes at 2023-11-15T18:35:57+00:00 Bug 41736: Hide NoScript extension's toolbar button by default.

This hides it from both the toolbar and the unified extensions panel.

We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it).

- - - - - 03b8d19d by hackademix at 2023-11-15T18:35:58+00:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons

- - - - - cd158a54 by Pier Angelo Vendrame at 2023-11-15T18:35:58+00:00 Bug 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

- - - - - ec4d55d5 by Pier Angelo Vendrame at 2023-11-15T18:35:59+00:00 Bug 40926: Implemented the New Identity feature

- - - - - df02c466 by hackademix at 2023-11-15T18:35:59+00:00 fixup! Bug 40926: Implemented the New Identity feature

Bug 42182: avoid reloading any search engine extension.

- - - - - a15e1303 by Henry Wilkes at 2023-11-15T18:36:00+00:00 Bug 41736: Customize toolbar for base-browser.

- - - - - b6735f73 by Pier Angelo Vendrame at 2023-11-15T18:36:00+00:00 Bug 42027: Base Browser migration procedures.

This commit implmenents the the Base Browser's version of _migrateUI.

- - - - -

30 changed files:

- .eslintignore - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-addons.js - browser/base/content/browser-context.inc - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.css - browser/base/content/browser.js - browser/base/content/browser.xhtml

The diff was not included because it is too large.

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7eab6c4...