Dan Ballard pushed to branch tor-browser-149.0a1-16.0-2 at The Tor Project / Applications / Tor Browser Commits: d8aa4961 by clairehurst at 2026-03-25T19:03:24-06:00 TB 44653 [android]: Disable 'Allow search suggestions in private sessions' prompt presented in RR 148 android - - - - - 3 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/FenixSearchMiddleware.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarComposable.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/FenixSearchMiddleware.kt ===================================== @@ -237,12 +237,7 @@ class FenixSearchMiddleware( store.dispatch(SearchSuggestionsVisibilityUpdated(shouldShowSuggestions)) - val showPrivatePrompt = with(store.state) { - !settings.showSearchSuggestionsInPrivateOnboardingFinished && - appStore.state.mode.isPrivate && - !isSearchSuggestionsFeatureEnabled() && !showSearchShortcuts && - query.isNotBlank() && url != query - } + val showPrivatePrompt = false store.dispatch( SearchFragmentAction.AllowSearchSuggestionsInPrivateModePrompt( ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarComposable.kt ===================================== @@ -156,7 +156,7 @@ class AwesomeBarComposable( } if (isSearchActive) { - if (state.showSearchSuggestionsHint) { + if (false) { PrivateSuggestionsCard( onSearchSuggestionsInPrivateModeAllowed = { activity.settings().shouldShowSearchSuggestionsInPrivate = true ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt ===================================== @@ -1613,10 +1613,7 @@ class Settings( default = false, ) - var showSearchSuggestionsInPrivateOnboardingFinished by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_show_search_suggestions_in_private_onboarding), - default = false, - ) + var showSearchSuggestionsInPrivateOnboardingFinished = false fun incrementVisitedInstallableCount() = pwaInstallableVisitCount.increment() View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d8aa4961... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d8aa4961... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help
participants (1)
-
Dan Ballard (@dan)