Dan Ballard pushed to branch tor-browser-153.2.0esr-16.0-1 at The Tor Project / Applications / Tor Browser Commits: 946ec210 by clairehurst at 2026-09-08T09:02:07-07:00 fixup! [android] Disable features and functionality TB 44548: Remove "Passwords" UI from Android - - - - - 4 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt - mobile/android/fenix/app/src/main/res/xml/preferences.xml - mobile/android/fenix/app/src/main/res/xml/save_logins_preferences.xml Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt ===================================== @@ -399,11 +399,6 @@ class SettingsFragment : PreferenceFragmentCompat(), SystemInsetsPaddedFragment, SettingsFragmentDirections.actionSettingsFragmentToCustomizationFragment() } - resources.getString(R.string.pref_key_passwords) -> { - SettingsMetrics.passwords.record() - SettingsFragmentDirections.actionSettingsFragmentToSavedLoginsAuthFragment() - } - resources.getString(R.string.pref_key_email_masks) -> { SettingsFragmentDirections.actionSettingsFragmentToEmailMasksSettingsFragment() } ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt ===================================== @@ -1899,15 +1899,9 @@ class Settings( default = true, ) - var shouldPromptToSaveLogins by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_save_logins), - default = true, - ) + var shouldPromptToSaveLogins = false - var shouldAutofillLogins by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_autofill_logins), - default = true, - ) + var shouldAutofillLogins = false /** * In Bug 1853113, we changed the type of [searchWidgetInstalled] from int to boolean without ===================================== mobile/android/fenix/app/src/main/res/xml/preferences.xml ===================================== @@ -58,11 +58,6 @@ app:iconSpaceReserved="false" android:title="@string/preferences_customize" /> - <androidx.preference.Preference - android:key="@string/pref_key_passwords" - app:iconSpaceReserved="false" - android:title="@string/preferences_passwords_logins_and_passwords_2" /> - <androidx.preference.Preference android:key="@string/pref_key_email_masks" android:title="@string/preferences_email_masks" ===================================== mobile/android/fenix/app/src/main/res/xml/save_logins_preferences.xml ===================================== @@ -4,11 +4,11 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"> <org.mozilla.fenix.settings.RadioButtonPreference - android:defaultValue="true" + android:defaultValue="false" android:key="@string/pref_key_save_logins" android:title="@string/preferences_passwords_save_logins_ask_to_save" /> <org.mozilla.fenix.settings.RadioButtonPreference - android:defaultValue="false" + android:defaultValue="true" android:key="@string/pref_key_never_save_logins" android:title="@string/preferences_passwords_save_logins_never_save" /> </PreferenceScreen> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/946ec210... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/946ec210... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help