brizental pushed to branch main at The Tor Project / Applications / tor-browser-bundle-testsuite Commits: dc363581 by Beatriz Rizental at 2026-05-11T09:57:26-03:00 Bug 40104: Always assume SETUP_ANDROID_SDK env var is set We were checking if this variable existed in the environment as a truthy value, but that was causing false positives. Now we actually check the specific value of the variable. Hopefully that fixes it. - - - - - 1 changed file: - .gitlab/scripts/before_script.py Changes: ===================================== .gitlab/scripts/before_script.py ===================================== @@ -155,7 +155,7 @@ def before_script( minidump_stackwalk_url: str, minidump_stackwalk_sha256: str, moz_fetches_dir: str, - sha256sums_url: str = "", + sha256sums_url: str, setup_android: bool = False, ) -> None: check_sha256sums_url(sha256sums_url) @@ -170,10 +170,10 @@ def before_script( if __name__ == "__main__": before_script( - mozharness_url=os.environ["MOZHARNESS_URL"], - minidump_stackwalk_url=os.environ["MINIDUMP_STACKWALK_URL"], + mozharness_url=os.environ.get("MOZHARNESS_URL", ""), + minidump_stackwalk_url=os.environ.get("MINIDUMP_STACKWALK_URL", ""), minidump_stackwalk_sha256=os.environ.get("MINIDUMP_STACKWALK_SHA256", ""), - moz_fetches_dir=os.environ["MOZ_FETCHES_DIR"], + moz_fetches_dir=os.environ.get("MOZ_FETCHES_DIR", ""), sha256sums_url=os.environ.get("SHA256SUMS_URL", ""), - setup_android="SETUP_ANDROID_SDK" in os.environ, + setup_android=os.environ.get("SETUP_ANDROID_SDK", "") == "1", ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite/... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite/... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help