Matthew Finkel pushed to branch tor-browser-82.0.0b4-10.0-1 at The Tor Project / Applications / fenix Commits: d0ee6fe3 by Alex Catarineu at 2020-10-22T13:25:22+02:00 Bug 40095: Hide "Sign in to sync" in bookmarks - - - - - 8c969c0c by Matthew Finkel at 2020-10-22T22:18:33+00:00 Merge remote-tracking branch 'acatgl/40095' into tor-browser-82.0.0b4-10.0-1 - - - - - 1 changed file: - app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt Changes: ===================================== app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt ===================================== @@ -48,7 +48,6 @@ import org.mozilla.fenix.ext.bookmarkStorage import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.minus import org.mozilla.fenix.ext.nav -import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.ext.toShortUrl import org.mozilla.fenix.library.LibraryPageFragment import org.mozilla.fenix.utils.allowUndo @@ -129,16 +128,9 @@ class BookmarkFragment : LibraryPageFragment<BookmarkNode>(), UserInteractionHan @ExperimentalCoroutinesApi override fun onViewCreated(view: View, savedInstanceState: Bundle?) { super.onViewCreated(view, savedInstanceState) - val accountManager = requireComponents.backgroundServices.accountManager consumeFrom(bookmarkStore) { bookmarkView.update(it) - - // Only display the sign-in prompt if we're inside of the virtual "Desktop Bookmarks" node. - // Don't want to pester user too much with it, and if there are lots of bookmarks present, - // it'll just get visually lost. Inside of the "Desktop Bookmarks" node, it'll nicely stand-out, - // since there are always only three other items in there. It's also the right place contextually. - bookmarkView.view.bookmark_folders_sign_in.isVisible = - it.tree?.guid == BookmarkRoot.Root.id && accountManager.authenticatedAccount() == null + bookmarkView.view.bookmark_folders_sign_in.isVisible = false } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/03b642acdc42e... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/03b642acdc42e... You're receiving this email because of your account on gitlab.torproject.org.