commit 13052ed2adcf0236392afae3eacc502701d7de8d Author: Alex Catarineu acat@torproject.org Date: Thu Jul 23 19:02:42 2020 +0200

fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#tor --- browser/components/torpreferences/content/torPane.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/browser/components/torpreferences/content/torPane.js b/browser/components/torpreferences/content/torPane.js index 18d27ec4a50b..49054b5dac6a 100644 --- a/browser/components/torpreferences/content/torPane.js +++ b/browser/components/torpreferences/content/torPane.js @@ -196,14 +196,16 @@ const gTorPane = (function() { TorStrings.settings.useBridge ); this._useBridgeCheckbox.addEventListener("command", e => { - gTorPane.onToggleBridge(e.target.checked).onUpdateBridgeSettings(); + const checked = this._useBridgeCheckbox.checked; + gTorPane.onToggleBridge(checked).onUpdateBridgeSettings(); }); this._bridgeSelectionRadiogroup = prefpane.querySelector( selectors.bridges.bridgeSelectionRadiogroup ); this._bridgeSelectionRadiogroup.value = TorBridgeSource.BUILTIN; this._bridgeSelectionRadiogroup.addEventListener("command", e => { - gTorPane.onSelectBridgeOption(e.target.value).onUpdateBridgeSettings(); + const value = this._bridgeSelectionRadiogroup.value; + gTorPane.onSelectBridgeOption(value).onUpdateBridgeSettings(); });

// Builtin bridges @@ -294,7 +296,8 @@ const gTorPane = (function() { TorStrings.settings.useLocalProxy ); this._useProxyCheckbox.addEventListener("command", e => { - gTorPane.onToggleProxy(e.target.checked).onUpdateProxySettings(); + const checked = this._useProxyCheckbox.checked; + gTorPane.onToggleProxy(checked).onUpdateProxySettings(); }); this._proxyTypeLabel = prefpane.querySelector( selectors.advanced.proxyTypeLabel @@ -316,7 +319,8 @@ const gTorPane = (function() { selectors.advanced.proxyTypeList ); this._proxyTypeMenulist.addEventListener("command", e => { - gTorPane.onSelectProxyType(e.target.value).onUpdateProxySettings(); + const value = this._proxyTypeMenulist.value; + gTorPane.onSelectProxyType(value).onUpdateProxySettings(); }); for (let currentProxy of mockProxies) { let menuEntry = document.createXULElement("menuitem"); @@ -398,7 +402,8 @@ const gTorPane = (function() { TorStrings.settings.useFirewall ); this._useFirewallCheckbox.addEventListener("command", e => { - gTorPane.onToggleFirewall(e.target.checked).onUpdateFirewallSettings(); + const checked = this._useFirewallCheckbox.checked; + gTorPane.onToggleFirewall(checked).onUpdateFirewallSettings(); }); this._allowedPortsLabel = prefpane.querySelector( selectors.advanced.firewallAllowedPortsLabel