Pier Angelo Vendrame pushed to branch tor-browser-147.0a1-16.0-2 at The Tor Project / Applications / Tor Browser Commits: c7449fd1 by Dan Ballard at 2026-01-21T12:23:14-08:00 TB 44507: [android] Drop Sentry as a dependancy - - - - - 4 changed files: - gradle/libs.versions.toml - mobile/android/android-components/.buildconfig.yml - mobile/android/fenix/app/build.gradle - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Analytics.kt Changes: ===================================== gradle/libs.versions.toml ===================================== @@ -101,7 +101,6 @@ disklrucache = "2.0.2" jna = "5.18.1" okhttp = "4.12.0" okio = "3.15.0" -sentry = "8.27.1" zxing = "3.5.4" [libraries] @@ -272,7 +271,6 @@ mockwebserver = { group = "com.squareup.okhttp3", name = "mockwebserver", versio okhttp = { group = "com.squareup.okhttp3", name = "okhttp", version.ref = "okhttp" } okhttp-urlconnection = { group = "com.squareup.okhttp3", name = "okhttp-urlconnection", version.ref = "okhttp" } okio = { group = "com.squareup.okio", name = "okio", version.ref = "okio" } -sentry = { group = "io.sentry", name = "sentry-android", version.ref = "sentry" } zxing = { group = "com.google.zxing", name = "core", version.ref = "zxing" } [plugins] ===================================== mobile/android/android-components/.buildconfig.yml ===================================== @@ -1645,20 +1645,6 @@ projects: - components:support-test - components:support-utils - components:tooling-lint - components:lib-crash-sentry: - description: A crash reporter for Sentry.io that that uses lib-crash. - path: components/lib/crash-sentry - publish: true - upstream_dependencies: - - components:concept-base - - components:concept-fetch - - components:lib-crash - - components:lib-publicsuffixlist - - components:support-base - - components:support-ktx - - components:support-test - - components:support-utils - - components:tooling-lint components:lib-dataprotect: description: A component using AndroidKeyStore to protect user data. path: components/lib/dataprotect ===================================== mobile/android/fenix/app/build.gradle ===================================== @@ -666,7 +666,6 @@ dependencies { implementation project(':components:ui-tabcounter') implementation project(':components:ui-widgets') implementation project(':components:lib-crash') - implementation project(':components:lib-crash-sentry') implementation project(':components:lib-dataprotect') implementation project(':components:lib-push-firebase') implementation project(':components:lib-state') @@ -727,7 +726,6 @@ dependencies { implementation libs.play.review implementation libs.play.review.ktx implementation libs.protobuf.javalite - implementation libs.sentry debugImplementation libs.androidx.compose.ui.tooling debugImplementation libs.leakcanary ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Analytics.kt ===================================== @@ -14,8 +14,6 @@ import mozilla.components.lib.crash.runtimetagproviders.BuildRuntimeTagProvider import mozilla.components.lib.crash.runtimetagproviders.EnvironmentRuntimeProvider import mozilla.components.lib.crash.runtimetagproviders.ExperimentDataRuntimeTagProvider import mozilla.components.lib.crash.runtimetagproviders.VersionInfoProvider -import mozilla.components.lib.crash.sentry.SentryService -import mozilla.components.lib.crash.sentry.eventprocessors.CrashMetadataEventProcessor import mozilla.components.lib.crash.service.CrashReporterService import mozilla.components.lib.crash.service.GleanCrashReporterService import mozilla.components.lib.crash.service.socorro.MozillaSocorroService @@ -60,37 +58,9 @@ class Analytics( val services = mutableListOf<CrashReporterService>() val distributionId = "Mozilla" - if (isSentryEnabled()) { - // We treat caught exceptions similar to debug logging. - // On the release channel volume of these is too high for our Sentry instances, and - // we get most value out of nightly/beta logging anyway. - val shouldSendCaughtExceptions = when (Config.channel) { - ReleaseChannel.Release -> false - else -> true - } - val sentryService = SentryService( - context, - BuildConfig.SENTRY_TOKEN, - tags = mapOf( - "geckoview" to "$MOZ_APP_VERSION-$MOZ_APP_BUILDID", - "fenix.git" to BuildConfig.VCS_HASH, - ), - environment = BuildConfig.BUILD_TYPE, - sendEventForNativeCrashes = false, // Do not send native crashes to Sentry - sendCaughtExceptions = shouldSendCaughtExceptions, - sentryProjectUrl = getSentryProjectUrl(), - crashMetadataEventProcessor = CrashMetadataEventProcessor(), - ) - - // We only want to initialize Sentry on startup on the main process. - if (context.isMainProcess()) { - runWhenReadyQueue.runIfReadyOrQueue { - sentryService.initIfNeeded() - } - } - - services.add(sentryService) - } + // Bug 44507: Drop Sentry as a dependency + // Since we've removed sentry and it's library (for defence in depth as well as spave saving) + // We can't keep any code that calls a now non existent library // The name "Fenix" here matches the product name on Socorro and is unrelated to the actual app name: // https://bugzilla.mozilla.org/show_bug.cgi?id=1523284 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c7449fd1... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c7449fd1... You're receiving this email because of your account on gitlab.torproject.org.
participants (1)
-
Pier Angelo Vendrame (@pierov)