clairehurst pushed to branch tor-browser-148.0a1-16.0-2 at The Tor Project / Applications / Tor Browser Commits: f35a834a by clairehurst at 2026-02-26T19:58:28-07:00 TB 31951: [Android] Disable Scroll to hide toolbar - - - - - 4 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt - mobile/android/fenix/app/src/main/res/values/preference_keys.xml - mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt ===================================== @@ -256,10 +256,6 @@ class CustomizationFragment : PreferenceFragmentCompat() { isChecked = context.settings().isPullToRefreshEnabledInBrowser onPreferenceChangeListener = SharedPreferenceUpdater() } - requirePreference<SwitchPreference>(R.string.pref_key_dynamic_toolbar).apply { - isChecked = context.settings().isDynamicToolbarEnabled - onPreferenceChangeListener = SharedPreferenceUpdater() - } requirePreference<SwitchPreference>(R.string.pref_key_swipe_toolbar_switch_tabs).apply { isChecked = context.settings().isSwipeToolbarToSwitchTabsEnabled isVisible = isSwipeToolbarToSwitchTabsVisible @@ -278,9 +274,6 @@ class CustomizationFragment : PreferenceFragmentCompat() { resources.getString(R.string.pref_key_website_pull_to_refresh) -> { PullToRefreshInBrowser.enabled.set(requireContext().settings().isPullToRefreshEnabledInBrowser) } - resources.getString(R.string.pref_key_dynamic_toolbar) -> { - CustomizationSettings.dynamicToolbar.set(requireContext().settings().isDynamicToolbarEnabled) - } } return super.onPreferenceTreeClick(preference) } ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt ===================================== @@ -2033,10 +2033,7 @@ class Settings( (isTabStripEligible(appContext) || FxNimbus.features.tabStrip.value().allowOnAllDevices), ) - var isDynamicToolbarEnabled by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_dynamic_toolbar), - default = true, - ) + var isDynamicToolbarEnabled = false var useNewDynamicToolbarBehaviour by booleanPreference( appContext.getPreferenceKey(R.string.pref_key_use_scroll_data_for_dynamic_toolbar), ===================================== mobile/android/fenix/app/src/main/res/values/preference_keys.xml ===================================== @@ -203,7 +203,6 @@ <string name="pref_key_website_pull_to_refresh" translatable="false">pref_key_website_pull_to_refresh</string> <string name="pref_key_tab_strip_show" translatable="false">pref_key_tab_strip_show</string> <string name="pref_key_tab_strip_message" translatable="false">pref_key_tab_strip_message</string> - <string name="pref_key_dynamic_toolbar" translatable="false">pref_key_dynamic_toolbar</string> <string name="pref_key_use_scroll_data_for_dynamic_toolbar" translatable="false">pref_key_use_scroll_data_for_dynamic_toolbar</string> <string name="pref_key_swipe_toolbar_switch_tabs" translatable="false">pref_key_swipe_toolbar_switch_tabs</string> <string name="pref_key_swipe_toolbar_show_tabs" translatable="false">pref_key_swipe_toolbar_show_tabs</string> ===================================== mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml ===================================== @@ -98,9 +98,6 @@ android:key="@string/pref_key_website_pull_to_refresh" android:title="@string/preference_gestures_website_pull_to_refresh" app:isPreferenceVisible="false" /> - <androidx.preference.SwitchPreference - android:key="@string/pref_key_dynamic_toolbar" - android:title="@string/preference_gestures_dynamic_toolbar" /> <androidx.preference.SwitchPreference android:key="@string/pref_key_swipe_toolbar_switch_tabs" android:title="@string/preference_gestures_swipe_toolbar_switch_tabs_2" /> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f35a834a... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f35a834a... You're receiving this email because of your account on gitlab.torproject.org.