clairehurst pushed to branch tor-browser-140.4.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: af86b6bf by clairehurst at 2025-10-16T17:13:16-06:00 fixup! TB 34378: [android] Port external helper app prompting - - - - - 2 changed files: - mobile/android/android-components/components/feature/app-links/build.gradle - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt Changes: ===================================== mobile/android/android-components/components/feature/app-links/build.gradle ===================================== @@ -36,7 +36,6 @@ dependencies { implementation project(':ui-widgets') implementation libs.kotlin.coroutines - implementation project(path: ':support-utils') testImplementation project(':support-test') testImplementation project(':support-test-libstate') ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -870,17 +870,12 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorAn if (existingDialog != null) { return existingDialog } - - // TODO: This is a temporary solution to keep RR rebases in motion. - // We need to figure out a proper fix here and then apply it as a fixup to - // "TB 34378: [android] Port external helper app prompting" SimpleRedirectDialogFragment.newInstance( - dialogTitleString = "???", - dialogMessageString = "???" - ).also { - dialog = it - return it - } + getString(R.string.mozac_feature_applinks_normal_confirm_dialog_title), + ).also { + dialog = it + return it + } } private fun isAlreadyADialogCreated(): Boolean { return findPreviousDialogFragment() != null View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/af86b6bf... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/af86b6bf... You're receiving this email because of your account on gitlab.torproject.org.