Pier Angelo Vendrame pushed to branch tor-browser-129.0a1-15.0-1 at The Tor Project / Applications / Tor Browser
Commits: ccaf390b by Pier Angelo Vendrame at 2025-02-10T17:23:56+01:00 fixup! Firefox preference overrides.
BB 43236: Disable vsync on Wayland.
Vsync leaks the monitor refresh rate, therefore it is already disabled on other platforms, including Linux/X11 and Windows.
- - - - - 67100207 by Pier Angelo Vendrame at 2025-02-10T17:23:56+01:00 BB 43386: Use Firefox in the UA in RFP-exempt request.
XHR requests initiated by extensions are exempt from RFP. Therefore, they report the actual app name, instead of Firefox, and the actual Firefox minor version.
This happens whenever the app name has been customized and does not match a hardcoded "Firefox".
- - - - - ba58f4de by clairehurst at 2025-02-10T17:23:57+01:00 [android] Bug_43351: Add function to disable forcing ALL CAPS for the fenix snackbar action button text
This is needed because the default snackbar will force all caps, which can cause problems in some languages. See tor-browser#43351 and bugzilla bug 1935387.
TODO: Remove once the forced all caps is removed by mozilla.
- - - - - 6f91b386 by Beatriz Rizental at 2025-02-10T17:23:57+01:00 fixup! Add CI for Tor Browser
- - - - - 329323a6 by Pier Angelo Vendrame at 2025-02-10T17:23:57+01:00 fixup! Firefox preference overrides.
BB 41065: Hardcode the limit of storage quota.
Currently, we return min(10GB, 0.2 * available space in the fs). This is bad for systems that have less than 50GB free, especially live systems, such as Tails. Set a pref to replace the available space with a hardcoded limit (5GiB).
- - - - - 4adb5447 by Pier Angelo Vendrame at 2025-02-10T17:23:57+01:00 fixup! Firefox preference overrides.
BB 43402: set browser.startup.blankWindow false.
- - - - - 3058bb98 by Henry Wilkes at 2025-02-10T17:23:58+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Return only the bridge settings from Moat.
Rather than return { bridges: enabled: true, ... } from MoatRPC API, we just return the relevant parts. This should make it clearer that Moat can *only* change TorSettings.bridges, and nothing else.
- - - - - 77611c5d by Henry Wilkes at 2025-02-10T17:23:58+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Have Moat bridges pass through TorSettings rather than using TorProvider directly.
TorSettings should be the only caller to TorProvider.writeSettings, so we can establish more control over which bridges are in use at any given moment in one place.
Also add some sanitation to the Moat response.
- - - - - 74814eb6 by Henry Wilkes at 2025-02-10T17:23:58+01:00 fixup! TB 40933: Add tor-launcher functionality
TB 41921: Use temporary bridges for TorProvider initialisation.
It is unlikely that temporary bridges would be present when TorProvider is initialised, but it should be using whatever TorSettings.applySettings uses.
- - - - - 8acf85a0 by Henry Wilkes at 2025-02-10T17:23:58+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Only use TorSettings.changeSettings to change the Tor settings and apply them in one method.
The granular methods have been made private.
- - - - - 86a0463e by Henry Wilkes at 2025-02-10T17:23:59+01:00 fixup! TB 42247: Android helpers for the TorProvider
TB 41921: Only use TorSettings.changeSettings to change the Tor settings and apply them in one method.
We drop redundant arguments and unused methods from android integration.
- - - - - 7da76500 by Henry Wilkes at 2025-02-10T17:23:59+01:00 fixup! TB 41878: [android] Add standalone Tor Bootstrap
TB 41921: Drop redundant arguments to getTorIntegration().setSettings.
All calls to this method passed true for the last two arguments.
- - - - - b1de0b1f by Henry Wilkes at 2025-02-10T17:23:59+01:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
TB 41921: Only use TorSettings.changeSettings to change the Tor settings and apply them in one method.
- - - - - e399886a by Henry Wilkes at 2025-02-10T17:23:59+01:00 fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser
TB 41921: Only use TorSettings.changeSettings to change the Tor settings and apply them in one method.
- - - - - 5f8a8997 by Henry Wilkes at 2025-02-10T17:23:59+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Make the TorSettings properties read-only outside of the TorSettings modules.
Within TorSettings we make all post initialisation changes in changeSettings. This means we can simplify the class and move all the setter logic into one place.
- - - - - b928574f by Henry Wilkes at 2025-02-10T17:24:00+01:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
TB 41921: Pass in the BridgeDB bridge_strings as an Array to TorSettings.
- - - - - d7354d74 by Henry Wilkes at 2025-02-10T17:24:00+01:00 fixup! TB 40933: Add tor-launcher functionality
TB 41921: Move prompt_at_startup preference from TorProvider to TorConnect only.
- - - - - d2db4edd by Henry Wilkes at 2025-02-10T17:24:00+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Move prompt_at_startup pref from TorProvider to TorConnect only.
This simplifies the logic, where we set the preference any time we have a bootstrap error and clear it when we are bootstrapped.
- - - - - 0df84c25 by Henry Wilkes at 2025-02-10T17:24:00+01:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
TB 41921: Move flushSettings call to TorSettings.
The call in connectionPane will not necessarily run when the preference tab is closed, nor will it trigger for bridges added through auto-bootstrapping.
- - - - - 50ecf95b by Henry Wilkes at 2025-02-10T17:24:01+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Flush TorSettings settings every time they are saved.
- - - - - 4af07293 by Henry Wilkes at 2025-02-10T17:24:01+01:00 fixup! TB 40933: Add tor-launcher functionality
TB 41921: Add a NOTE for future development ensuring that writeSettings is not subject to any races between sequential calls.
- - - - - ee562d86 by Henry Wilkes at 2025-02-10T17:24:01+01:00 fixup! TB 40933: Add tor-launcher functionality
TB 41921: Ensure shouldStartAndOwnTor is constant per-session.
TorConnect and TorSettings `enabled` properties depend on this value, and shouldn't change per session.
- - - - - bf84f466 by Henry Wilkes at 2025-02-10T17:24:01+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Tighten up TorSettings.
We ensure TorSettings is enabled before certain operations.
Also tidy up uninit to account for early calls (before init completes) or repeat calls.
Also stop using "torbrowser.settings.enabled" preference, and read from the preferences for the first run.
Also make TorSettings.initailizedPromise read-only.
- - - - - ee5ae62a by Henry Wilkes at 2025-02-10T17:24:02+01:00 fixup! TB 40562: Added Tor Browser preferences to 000-tor-browser.js
TB 41921: Set default TorSetting setting values in 000-tor-browser.js.
- - - - - bfef38c6 by Henry Wilkes at 2025-02-10T17:24:02+01:00 fixup! TB 41435: Add a Tor Browser migration function
TB 41921: Clear out unused "torbrowser.settings.enabled" preference.
- - - - - c3711b8e by Henry Wilkes at 2025-02-10T17:24:02+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Move quickstart setting from TorSettings to TorConnect.
- - - - - d4ae2cd6 by Henry Wilkes at 2025-02-10T17:24:02+01:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
TB 41921: Move quickstart setting from TorSettings to TorConnect.
- - - - - d88bb531 by Henry Wilkes at 2025-02-10T17:24:03+01:00 fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser
TB 41921: Move quickstart setting from TorSettings to TorConnect.
This also means we no longer need to listen for TorSettingsTopics.Ready for the initial value.
Also fix typo in signal name: "quickstart-changed" to "quickstart-change".
- - - - - 9db9034d by Henry Wilkes at 2025-02-10T17:24:03+01:00 fixup! TB 42247: Android helpers for the TorProvider
TB 41921: Move quickstart setting from TorSettings to TorConnect.
- - - - - e4ee80ae by Henry Wilkes at 2025-02-10T17:24:03+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Do not wait for TorSettings to initialise before allowing a bootstrap.
Instead, we wait for TorSettings as required: for preparing AutoBootstrap attempts, and TorBootstrapRequest should already wait for TorSettings before attempting to connect.
- - - - - 51af454c by Henry Wilkes at 2025-02-10T17:24:03+01:00 fixup! TB 40933: Add tor-launcher functionality
TB 41921: Ensure TorProviderBuilder.build can be called immediately after TorProviderBuilder.init returns (without await).
We make sure that the `#provider` instance is created before any break in execution caused by an `await`.
- - - - - bb3cff4d by Henry Wilkes at 2025-02-10T17:24:03+01:00 fixup! TB 42247: Android helpers for the TorProvider
TB 41921: Do not wait for TorProviderBuilder.init since it is no longer async.
- - - - - 2ee51acd by Henry Wilkes at 2025-02-10T17:24:04+01:00 fixup! TB 40933: Add tor-launcher functionality
TB 41921: Add a note to TorBootstrapRequest explaining the expectation that the TorProvider has already read from TorSettings before it connects.
- - - - - 306fc85a by clairehurst at 2025-02-10T17:24:04+01:00 fixup! [android] Implement Android-native Connection Assist UI
Bug 43359: Improper handling of TorBootstrapChangeListener with respect to system onDestroy() calls for HomeActivity
- - - - - 2290e9b4 by clairehurst at 2025-02-10T17:24:04+01:00 fixup! [android] Add standalone Tor Bootstrap
Bug 43360: Replace custom variable isBeingRecreated with built-in isFinishing function
- - - - - 0b867753 by clairehurst at 2025-02-10T17:24:04+01:00 fixup! [android] Add standalone Tor Bootstrap
Bug 43368: Add @Suppress for linting error "Overriding method should call super. onNewIntent"
- - - - - 9ef85012 by Henry Wilkes at 2025-02-10T17:24:05+01:00 fixup! TB 40597: Implement TorSettings module
TB 41921: Reset bootstrap stage when bridge settings change.
In particular, this will cancel an autobootstrap when the user manually changes the bridge settings. However we apply this to all bootstrap attempts for consistency.
By resetting to the Start stage, we also ensure that about:torconnect UI no longer shows the "Try bridges" pages when the user manually changes their bridges themselves.
- - - - - 2c1ab622 by Henry Wilkes at 2025-02-10T17:24:05+01:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
TB 41921: Also show the "Connect" button for bridge dialogs when we have an ongoing bootstrap attempt.
With the new behaviour, changing the settings while not bootstrapped will cancel any ongoing bootstrap. Therefore, we can start a new bootstrap using the new settings.
- - - - - 86caa2b2 by Henry Wilkes at 2025-02-10T17:24:05+01:00 fixup! Add CI for Tor Browser
MB 324: Revert tor-browser changes that add update-translations CI.
- - - - - fe9c62cc by Henry Wilkes at 2025-02-10T17:24:05+01:00 Revert "TB 42305: Add script to combine translation files across versions."
This reverts commit 3247633d3f6bf60be7feaf2e3515d9b7c2b1dad0.
- - - - - d6fa9624 by Henry Wilkes at 2025-02-10T17:24:06+01:00 fixup! Add CI for Base Browser
MB 324: Move update-translations CI to base-browser.
- - - - - ddaea819 by Henry Wilkes at 2025-02-10T17:24:06+01:00 BB 42305: Add script to combine translation files across versions.
- - - - - 0ef82fcf by Henry Wilkes at 2025-02-10T17:24:06+01:00 fixup! Add CI for Tor Browser
MB 324: Re-introduce tor-browser changes to update-translations
- - - - - 882b73b6 by Pier Angelo Vendrame at 2025-02-10T17:24:06+01:00 fixup! TB 42247: Android helpers for the TorProvider
Add a missing return to #getAllSettings().
- - - - - dbce6a68 by Pier Angelo Vendrame at 2025-02-10T17:24:07+01:00 fixup! TB 2176: Rebrand Firefox to TorBrowser
TB 43323: Add an asset for sanity tests.
- - - - - bd5cbca8 by Henry Wilkes at 2025-02-10T17:24:07+01:00 fixup! Add CI for Tor Browser
MB 324: Move update-translations from tor-browser to base-browser.
Should be dropped at the next rebase.
- - - - - 5178f2d9 by Henry Wilkes at 2025-02-10T17:24:07+01:00 fixup! Add CI for Base Browser
MB 324: Move update-translations from tor-browser to base-browser.
- - - - - a602ba5c by Pier Angelo Vendrame at 2025-02-10T17:24:07+01:00 fixup! Adding issue and merge request templates
Remove "Emergency" from security updates as per today's meeting.
Our policy usually is to backport (almost) all emergency fixes, sooner or later. The actual emergency can be inferred from the timeline.
- - - - - 281658b7 by Morgan at 2025-02-10T17:24:08+01:00 fixup! TB 41649: Create rebase and security backport gitlab issue templates
- TB 43298: add rebase template for nightly-based Tor Browser Alpha and Bugzilla Triage Issue generation - TB 43341: Create Firefox Nightly Rebase Issue Template
- - - - - 144d6abb by Henry Wilkes at 2025-02-10T17:24:08+01:00 fixup! BB 42305: Add script to combine translation files across versions.
MB 324: Make the added comments also work for Mullvad Browser.
- - - - - e3a0e855 by clairehurst at 2025-02-10T17:24:08+01:00 fixup! TB 40933: Add tor-launcher functionality
Bug 43222: Fix tor logs timestamps
- - - - - 398c6cce by clairehurst at 2025-02-10T17:24:08+01:00 fixup! TB 42247: Android helpers for the TorProvider
Bug 43222: Fix tor logs timestamps
- - - - - e3488ef5 by clairehurst at 2025-02-10T17:24:08+01:00 fixup! TB 41878: [android] Add standalone Tor Bootstrap
Bug 43222: Fix tor logs timestamps
- - - - - 4c2cb7e6 by clairehurst at 2025-02-10T17:24:09+01:00 fixup! TB 40041 [android]: Implement Tor Network Settings
Bug 43222: Fix tor logs timestamps
- - - - - 04fe9107 by Beatriz Rizental at 2025-02-10T17:24:09+01:00 fixup! Add CI for Base Browser
Attempt to download MR branch in case fetching fails due to the pipeline running in the parent project context.
- - - - - 94fa5417 by Pier Angelo Vendrame at 2025-02-10T17:24:09+01:00 Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref"
This reverts commit 57c94a79410783c564187a9496d7a5403accf15e.
- - - - - c92cc90c by Pier Angelo Vendrame at 2025-02-10T17:33:17+01:00 Bug 1840385 - Do not spoof the OS in HTTP User Agent. r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D234835
- - - - - 18d26d7f by Henry Wilkes at 2025-02-10T17:33:20+01:00 fixup! TB 40458: Implement .tor.onion aliases
TB 41831: Add additional effective TLD for abc.au.securedrop.tor.onion exception.
- - - - - 52881321 by Beatriz Rizental at 2025-02-10T17:33:20+01:00 fixup! Add CI for Tor Browser
Revert changes that will not be part of the Base Browser commit
- - - - - a1146389 by Beatriz Rizental at 2025-02-10T17:33:20+01:00 fixup! Add CI for Base Browser
- - - - - db182914 by Beatriz Rizental at 2025-02-10T17:33:20+01:00 fixup! Add CI for Base Browser
- - - - - 45830b74 by Beatriz Rizental at 2025-02-10T17:33:21+01:00 fixup! Add CI for Base Browser
Fetch specific branch when prepopulating history from local repository.
- - - - - d182dd51 by Beatriz Rizental at 2025-02-10T17:33:21+01:00 TB 43243: [android] Implement Android launch test
Also remove exit call from terminate function. It causes all espresso tests to crash on exit and otherwise doesn't do anything.
- - - - - abe3f667 by Beatriz Rizental at 2025-02-10T17:33:21+01:00 fixup! Add CI for Tor Browser
Implement Nightly startup tests for Android
- - - - - 41a14ffe by Henry Wilkes at 2025-02-10T17:33:21+01:00 fixup! TB 40597: Implement TorSettings module
TB 43254: Allow some DomainFrontedRequests to be cancelled.
This is used by some of the Moat calls to stop abandoned requests running in the background:
1. Cancelled AutoBootstraps. 2. Cancelled CAPTCHA request/submissions.
- - - - - d290912a by Henry Wilkes at 2025-02-10T17:33:22+01:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
TB 43254: Cancel Moat requests when the CAPTHCA dialog is closed.
- - - - - 115ea410 by Beatriz Rizental at 2025-02-10T17:56:43+01:00 fixup! Add CI for Base Browser
- - - - -
55 changed files:
- + .gitlab/ci/jobs/startup-test/startup-test-android.py - .gitlab/ci/jobs/startup-test/startup-test.yml - .gitlab/ci/jobs/update-translations.yml - .gitlab/ci/mixins.yml - + .gitlab/issue_templates/Bugzilla Triage.md - + .gitlab/issue_templates/Rebase Browser - Rapid.md - .gitlab/merge_request_templates/default.md - browser/app/profile/000-tor-browser.js - browser/app/profile/001-base-profile.js - browser/components/BrowserGlue.sys.mjs - browser/components/resistfingerprinting/test/browser/browser_navigator.js - browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js - browser/components/torpreferences/content/builtinBridgeDialog.js - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionSettingsDialog.js - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/requestBridgeDialog.js - dom/base/Navigator.cpp - + mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AppStartupTest.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/FenixSnackbar.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt - + mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorLog.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorLogsComposeFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorLogsViewModel.kt - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorIntegrationAndroid.java - netwerk/dns/effective_tld_names.dat - netwerk/protocol/http/nsHttpHandler.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp - toolkit/components/resistfingerprinting/nsRFPService.h - toolkit/components/tor-launcher/TorBootstrapRequest.sys.mjs - toolkit/components/tor-launcher/TorControlPort.sys.mjs - toolkit/components/tor-launcher/TorLauncherUtil.sys.mjs - toolkit/components/tor-launcher/TorProvider.sys.mjs - toolkit/components/tor-launcher/TorProviderBuilder.sys.mjs - toolkit/components/torconnect/TorConnectParent.sys.mjs - toolkit/modules/BridgeDB.sys.mjs - toolkit/modules/DomainFrontedRequests.sys.mjs - toolkit/modules/Moat.sys.mjs - toolkit/modules/TorAndroidIntegration.sys.mjs - toolkit/modules/TorConnect.sys.mjs - toolkit/modules/TorSettings.sys.mjs - + toolkit/themes/shared/icons/torbrowser.png - toolkit/themes/shared/minimal-toolkit.jar.inc.mn - tools/torbrowser/l10n/combine-translation-versions.py → tools/base-browser/l10n/combine-translation-versions.py - tools/torbrowser/l10n/combine/__init__.py → tools/base-browser/l10n/combine/__init__.py - tools/torbrowser/l10n/combine/combine.py → tools/base-browser/l10n/combine/combine.py - tools/torbrowser/l10n/combine/tests/README → tools/base-browser/l10n/combine/tests/README - tools/torbrowser/l10n/combine/tests/__init__.py → tools/base-browser/l10n/combine/tests/__init__.py - tools/torbrowser/l10n/combine/tests/test_android.py → tools/base-browser/l10n/combine/tests/test_android.py - tools/torbrowser/l10n/combine/tests/test_dtd.py → tools/base-browser/l10n/combine/tests/test_dtd.py - tools/torbrowser/l10n/combine/tests/test_fluent.py → tools/base-browser/l10n/combine/tests/test_fluent.py - tools/torbrowser/l10n/combine/tests/test_properties.py → tools/base-browser/l10n/combine/tests/test_properties.py
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b66b828...